Fix checkstyle

[openflowplugin.git] / openflowjava / openflow-protocol-impl / src / main / java / org / opendaylight / openflowjava / protocol / impl / deserialization / factories / RoleRequestInputMessageFactory.java

diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/RoleRequestInputMessageFactory.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/RoleRequestInputMessageFactory.java
index 1627f2b589fb936a1a48f2453c3b7550d1e274f8..2c7d0f3eb0e40888db1d69044d7d48661fb8c390 100644 (file)
--- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/RoleRequestInputMessageFactory.java
+++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/RoleRequestInputMessageFactory.java
@@ -7,8 +7,10 @@
  */
 package org.opendaylight.openflowjava.protocol.impl.deserialization.factories;
 
+import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint32;
+import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint64;
+
 import io.netty.buffer.ByteBuf;
-import java.math.BigInteger;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFDeserializer;
 import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.ControllerRole;
@@ -16,8 +18,9 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.RoleRequestInputBuilder;
 
 /**
- * @author giuseppex.petralia@intel.com
+ * Translates RoleRequestInput messages.
  *
+ * @author giuseppex.petralia@intel.com
  */
 public class RoleRequestInputMessageFactory implements OFDeserializer<RoleRequestInput> {
 
@@ -25,14 +28,12 @@ public class RoleRequestInputMessageFactory implements OFDeserializer<RoleReques
 
     @Override
     public RoleRequestInput deserialize(ByteBuf rawMessage) {
-        RoleRequestInputBuilder builder = new RoleRequestInputBuilder();
-        builder.setVersion((short) EncodeConstants.OF13_VERSION_ID);
-        builder.setXid((rawMessage.readUnsignedInt()));
-        builder.setRole(ControllerRole.forValue(rawMessage.readInt()));
+        RoleRequestInputBuilder builder = new RoleRequestInputBuilder()
+                .setVersion(EncodeConstants.OF_VERSION_1_3)
+                .setXid(readUint32(rawMessage))
+                .setRole(ControllerRole.forValue(rawMessage.readInt()));
         rawMessage.skipBytes(PADDING);
-        byte[] generationId = new byte[EncodeConstants.SIZE_OF_LONG_IN_BYTES];
-        rawMessage.readBytes(generationId);
-        builder.setGenerationId(new BigInteger(1, generationId));
+        builder.setGenerationId(readUint64(rawMessage));
         return builder.build();
     }
 }