Update MRI upstreams for Phosphorus

[openflowplugin.git] / openflowjava / openflow-protocol-impl / src / main / java / org / opendaylight / openflowjava / protocol / impl / serialization / SerializerRegistryImpl.java

diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImpl.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImpl.java
index 4875898ebbdf61859c0a7ff7967984d3e6ac2de1..e59340a60f117c76d8216e4cc1af1f45e3ce63c8 100644 (file)
--- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImpl.java
+++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImpl.java
@@ -5,7 +5,6 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowjava.protocol.impl.serialization;
 
 import java.util.HashMap;
@@ -23,7 +22,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * Stores and handles serializers<br>
+ * Stores and handles serializers. <br>
  * K - {@link MessageTypeKey} type<br>
  * S - returned serializer type
  *
@@ -35,10 +34,8 @@ import org.slf4j.LoggerFactory;
 public class SerializerRegistryImpl implements SerializerRegistry {
 
     private static final Logger LOG = LoggerFactory.getLogger(SerializerRegistryImpl.class);
-    private static final short OF10 = EncodeConstants.OF10_VERSION_ID;
-    private static final short OF13 = EncodeConstants.OF13_VERSION_ID;
-    private Map<MessageTypeKey<?>, OFGeneralSerializer> registry;
 
+    private Map<MessageTypeKey<?>, OFGeneralSerializer> registry;
     private boolean isGroupAddModEnabled = false;
 
     @Override
@@ -51,8 +48,10 @@ public class SerializerRegistryImpl implements SerializerRegistry {
         AdditionalMessageFactoryInitializer.registerMessageSerializers(this);
 
         // match structure serializers
-        registerSerializer(new MessageTypeKey<>(OF10, MatchV10.class), new OF10MatchSerializer());
-        registerSerializer(new MessageTypeKey<>(OF13, Match.class), new OF13MatchSerializer());
+        registerSerializer(new MessageTypeKey<>(EncodeConstants.OF_VERSION_1_0, MatchV10.class),
+            new OF10MatchSerializer());
+        registerSerializer(new MessageTypeKey<>(EncodeConstants.OF_VERSION_1_3, Match.class),
+            new OF13MatchSerializer());
 
         // match entry serializers
         MatchEntriesInitializer.registerMatchEntrySerializers(this);
@@ -62,8 +61,9 @@ public class SerializerRegistryImpl implements SerializerRegistry {
         InstructionsInitializer.registerInstructionSerializers(this);
     }
 
-    public void setGroupAddModConfig(boolean isGroupAddModEnabled) {
-        this.isGroupAddModEnabled = isGroupAddModEnabled;
+    @Override
+    public void setGroupAddModConfig(final boolean value) {
+        this.isGroupAddModEnabled = value;
     }
 
     @Override
@@ -72,12 +72,14 @@ public class SerializerRegistryImpl implements SerializerRegistry {
     }
 
     /**
-     * @param msgTypeKey
+     * Gets the encoder for the given message type key.
+     *
+     * @param msgTypeKey the message type key
      * @return encoder for current type of message (msgTypeKey)
      */
     @Override
     @SuppressWarnings("unchecked")
-    public <K, S extends OFGeneralSerializer> S getSerializer(MessageTypeKey<K> msgTypeKey) {
+    public <K, S extends OFGeneralSerializer> S getSerializer(final MessageTypeKey<K> msgTypeKey) {
         OFGeneralSerializer serializer = registry.get(msgTypeKey);
         if (serializer == null) {
             throw new IllegalStateException("Serializer for key: " + msgTypeKey
@@ -88,8 +90,8 @@ public class SerializerRegistryImpl implements SerializerRegistry {
     }
 
     @Override
-    public <K> void registerSerializer(MessageTypeKey<K> msgTypeKey, OFGeneralSerializer serializer) {
-        if ((msgTypeKey == null) || (serializer == null)) {
+    public <K> void registerSerializer(final MessageTypeKey<K> msgTypeKey, final OFGeneralSerializer serializer) {
+        if (msgTypeKey == null || serializer == null) {
             throw new IllegalArgumentException("MessageTypeKey or Serializer is null");
         }
         OFGeneralSerializer serInRegistry = registry.put(msgTypeKey, serializer);
@@ -103,7 +105,7 @@ public class SerializerRegistryImpl implements SerializerRegistry {
     }
 
     @Override
-    public <K> boolean unregisterSerializer(MessageTypeKey<K> msgTypeKey) {
+    public <K> boolean unregisterSerializer(final MessageTypeKey<K> msgTypeKey) {
         if (msgTypeKey == null) {
             throw new IllegalArgumentException("MessageTypeKey is null");
         }