package org.opendaylight.openflowjava.protocol.impl.core.connection;
-import static org.mockito.Matchers.any;
+import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
+
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.RemovalListener;
-import com.google.common.cache.RemovalNotification;
import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelPipeline;
import io.netty.channel.socket.SocketChannel;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+import org.junit.runner.RunWith;
import org.mockito.Mock;
-import org.mockito.MockitoAnnotations;
+import org.mockito.junit.MockitoJUnitRunner;
+import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter.MessageListener;
+import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter.SystemListener;
import org.opendaylight.openflowjava.protocol.api.connection.ConnectionReadyListener;
import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.BarrierInput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.MultipartReplyMessage;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.MultipartReplyMessageBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OfHeader;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OpenflowProtocolListener;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PacketInMessage;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PacketInMessageBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PortStatusMessage;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.system.rev130927.DisconnectEventBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.system.rev130927.SwitchIdleEvent;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.system.rev130927.SwitchIdleEventBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.system.rev130927.SystemNotificationsListener;
import org.opendaylight.yangtools.yang.binding.DataObject;
+import org.opendaylight.yangtools.yang.common.Uint32;
/**
+ * Unit test for ConnectionAdapterImpl.
+ *
* @author michal.polkorab
* @author madamjak
- *
*/
+@RunWith(MockitoJUnitRunner.class)
public class ConnectionAdapterImplTest {
private static final int RPC_RESPONSE_EXPIRATION = 1;
+ private static final int CHANNEL_OUTBOUND_QUEUE_SIZE = 1024;
private static final RemovalListener<RpcResponseKey, ResponseExpectedRpcListener<?>> REMOVAL_LISTENER =
- new RemovalListener<RpcResponseKey, ResponseExpectedRpcListener<?>>() {
- @Override
- public void onRemoval(
- final RemovalNotification<RpcResponseKey, ResponseExpectedRpcListener<?>> notification) {
- notification.getValue().discard();
- }
- };
+ notification -> notification.getValue().discard();
- @Mock SocketChannel channel;
- @Mock ChannelPipeline pipeline;
- @Mock OpenflowProtocolListener messageListener;
- @Mock SystemNotificationsListener systemListener;
- @Mock ConnectionReadyListener readyListener;
- @Mock Cache<RpcResponseKey, ResponseExpectedRpcListener<?>> mockCache;
- @Mock ChannelFuture channelFuture;
+ @Mock
+ private SocketChannel channel;
+ @Mock
+ ChannelPipeline pipeline;
+ @Mock
+ private MessageListener messageListener;
+ @Mock
+ private SystemListener systemListener;
+ @Mock
+ private ConnectionReadyListener readyListener;
+ @Mock
+ private Cache<RpcResponseKey, ResponseExpectedRpcListener<?>> mockCache;
+ @Mock
+ private ChannelFuture channelFuture;
private ConnectionAdapterImpl adapter;
private Cache<RpcResponseKey, ResponseExpectedRpcListener<?>> cache;
/**
- * Initializes ConnectionAdapter
+ * Initializes ConnectionAdapter.
*/
@Before
public void setUp() {
- MockitoAnnotations.initMocks(this);
when(channel.pipeline()).thenReturn(pipeline);
- adapter = new ConnectionAdapterImpl(channel, InetSocketAddress.createUnresolved("10.0.0.1", 6653), true);
+ adapter = new ConnectionAdapterImpl(channel, InetSocketAddress.createUnresolved("10.0.0.1", 6653), true,
+ CHANNEL_OUTBOUND_QUEUE_SIZE);
adapter.setMessageListener(messageListener);
adapter.setSystemListener(systemListener);
adapter.setConnectionReadyListener(readyListener);
- cache = CacheBuilder.newBuilder().concurrencyLevel(1).expireAfterWrite(RPC_RESPONSE_EXPIRATION, TimeUnit.MINUTES)
- .removalListener(REMOVAL_LISTENER).build();
+ cache = CacheBuilder.newBuilder().concurrencyLevel(1)
+ .expireAfterWrite(RPC_RESPONSE_EXPIRATION, TimeUnit.MINUTES).removalListener(REMOVAL_LISTENER).build();
adapter.setResponseCache(cache);
when(channel.disconnect()).thenReturn(channelFuture);
}
/**
- * Tests {@link ConnectionAdapterImpl#consume(DataObject)} with notifications
+ * Tests {@link ConnectionAdapterImpl#consume(DataObject)} with notifications.
*/
@Test
public void testConsume() {
DataObject message = new EchoRequestMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onEchoRequestMessage((EchoRequestMessage) message);
+ verify(messageListener, times(1)).onEchoRequest((EchoRequestMessage) message);
message = new ErrorMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onErrorMessage((ErrorMessage) message);
+ verify(messageListener, times(1)).onError((ErrorMessage) message);
message = new ExperimenterMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onExperimenterMessage((ExperimenterMessage) message);
+ verify(messageListener, times(1)).onExperimenter((ExperimenterMessage) message);
message = new FlowRemovedMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onFlowRemovedMessage((FlowRemovedMessage) message);
+ verify(messageListener, times(1)).onFlowRemoved((FlowRemovedMessage) message);
message = new HelloMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onHelloMessage((HelloMessage) message);
+ verify(messageListener, times(1)).onHello((HelloMessage) message);
message = new MultipartReplyMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onMultipartReplyMessage((MultipartReplyMessage) message);
+ verify(messageListener, times(1)).onMultipartReply((MultipartReplyMessage) message);
message = new PacketInMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onPacketInMessage((PacketInMessage) message);
+ verify(messageListener, times(1)).onPacketIn((PacketInMessage) message);
message = new PortStatusMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onPortStatusMessage((PortStatusMessage) message);
+ verify(messageListener, times(1)).onPortStatus((PortStatusMessage) message);
message = new SwitchIdleEventBuilder().build();
adapter.consume(message);
- verify(systemListener, times(1)).onSwitchIdleEvent((SwitchIdleEvent) message);
+ verify(systemListener, times(1)).onSwitchIdle((SwitchIdleEvent) message);
message = new DisconnectEventBuilder().build();
adapter.consume(message);
- verify(systemListener, times(1)).onDisconnectEvent((DisconnectEvent) message);
+ verify(systemListener, times(1)).onDisconnect((DisconnectEvent) message);
message = new EchoRequestMessageBuilder().build();
adapter.consume(message);
- verify(messageListener, times(1)).onEchoRequestMessage((EchoRequestMessage) message);
+ verify(messageListener, times(1)).onEchoRequest((EchoRequestMessage) message);
}
/**
- * Tests {@link ConnectionAdapterImpl#consume(DataObject)} with unexpected rpc
+ * Tests {@link ConnectionAdapterImpl#consume(DataObject)} with unexpected rpc.
*/
@Test
public void testConsume2() {
adapter.setResponseCache(mockCache);
- final BarrierOutputBuilder barrierBuilder = new BarrierOutputBuilder();
- barrierBuilder.setXid(42L);
- final BarrierOutput barrier = barrierBuilder.build();
- adapter.consume(barrier);
+ adapter.consume(new BarrierOutputBuilder().setXid(Uint32.valueOf(42)).build());
verify(mockCache, times(1)).getIfPresent(any(RpcResponseKey.class));
}
/**
- * Tests {@link ConnectionAdapterImpl#consume(DataObject)} with expected rpc
+ * Tests {@link ConnectionAdapterImpl#consume(DataObject)} with expected rpc.
*/
@Test
public void testConsume3() {
final BarrierInputBuilder inputBuilder = new BarrierInputBuilder();
- inputBuilder.setVersion((short) EncodeConstants.OF13_VERSION_ID);
- inputBuilder.setXid(42L);
+ inputBuilder.setVersion(EncodeConstants.OF_VERSION_1_3);
+ inputBuilder.setXid(Uint32.valueOf(42));
final BarrierInput barrierInput = inputBuilder.build();
- final RpcResponseKey key = new RpcResponseKey(42L, "org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.BarrierOutput");
+ final RpcResponseKey key = new RpcResponseKey(42L,
+ "org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.BarrierOutput");
final ResponseExpectedRpcListener<OfHeader> listener = new ResponseExpectedRpcListener<>(barrierInput,
"failure", mockCache, key);
cache.put(key, listener);
final BarrierOutputBuilder barrierBuilder = new BarrierOutputBuilder();
- barrierBuilder.setXid(42L);
+ barrierBuilder.setXid(Uint32.valueOf(42));
final BarrierOutput barrierOutput = barrierBuilder.build();
adapter.consume(barrierOutput);
final ResponseExpectedRpcListener<?> ifPresent = cache.getIfPresent(key);
Assert.assertNull("Listener was not discarded", ifPresent);
}
+
/**
- * Test IsAlive method
+ * Test IsAlive method.
*/
@Test
- public void testIsAlive(){
+ public void testIsAlive() {
final int port = 9876;
- final String host ="localhost";
+ final String host = "localhost";
final InetSocketAddress inetSockAddr = InetSocketAddress.createUnresolved(host, port);
- final ConnectionAdapterImpl connAddapter = new ConnectionAdapterImpl(channel, inetSockAddr, true);
- Assert.assertEquals("Wrong - diffrence between channel.isOpen() and ConnectionAdapterImpl.isAlive()", channel.isOpen(), connAddapter.isAlive());
-
+ final ConnectionAdapterImpl connAddapter = new ConnectionAdapterImpl(channel, inetSockAddr, true,
+ CHANNEL_OUTBOUND_QUEUE_SIZE);
+ Assert.assertEquals("Wrong - diffrence between channel.isOpen() and ConnectionAdapterImpl.isAlive()",
+ channel.isOpen(), connAddapter.isAlive());
connAddapter.disconnect();
Assert.assertFalse("Wrong - ConnectionAdapterImpl can not be alive after disconnet.", connAddapter.isAlive());
}
/**
- * Test throw exception if no listeners are present
+ * Test throw exception if no listeners are present.
*/
@Test(expected = java.lang.IllegalStateException.class)
- public void testMissingListeners(){
+ public void testMissingListeners() {
final int port = 9876;
- final String host ="localhost";
+ final String host = "localhost";
final InetSocketAddress inetSockAddr = InetSocketAddress.createUnresolved(host, port);
- final ConnectionAdapterImpl connAddapter = new ConnectionAdapterImpl(channel, inetSockAddr, true);
+ final ConnectionAdapterImpl connAddapter = new ConnectionAdapterImpl(channel, inetSockAddr, true,
+ CHANNEL_OUTBOUND_QUEUE_SIZE);
connAddapter.setSystemListener(null);
connAddapter.setMessageListener(null);
connAddapter.setConnectionReadyListener(null);
Code Review / openflowplugin.git / blobdiff