Modernize codebase

[openflowplugin.git] / openflowjava / openflow-protocol-impl / src / test / java / org / opendaylight / openflowjava / protocol / impl / serialization / SerializerRegistryImplTest.java

diff --git a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImplTest.java b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImplTest.java
index abed50d9e93dec66454bf1e85dc12d4d0a4376ad..e1de29da63dfb38cc70b8c1182e3a67795781114 100644 (file)
--- a/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImplTest.java
+++ b/openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/serialization/SerializerRegistryImplTest.java
@@ -7,55 +7,56 @@
  */
 package org.opendaylight.openflowjava.protocol.impl.serialization;
 
+import static org.opendaylight.openflowjava.protocol.api.util.EncodeConstants.OF_VERSION_1_0;
+import static org.opendaylight.openflowjava.protocol.api.util.EncodeConstants.OF_VERSION_1_3;
+
 import org.junit.Assert;
 import org.junit.Test;
 import org.opendaylight.openflowjava.protocol.api.keys.MessageTypeKey;
-import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants;
 import org.opendaylight.openflowjava.protocol.impl.util.OF13MatchSerializer;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev150225.match.grouping.Match;
 
 /**
+ * Unit tests for SerializerRegistryImpl.
  *
  * @author madamjak
- *
  */
 public class SerializerRegistryImplTest {
 
-    private static final short OF13 = EncodeConstants.OF13_VERSION_ID;
-    private static final short OF10 = EncodeConstants.OF10_VERSION_ID;
-
     /**
-     * Test - register serializer without arguments
+     * Test - register serializer without arguments.
      */
     @Test(expected = IllegalArgumentException.class)
-    public void testRegisterSerializerNoArgs(){
+    public void testRegisterSerializerNoArgs() {
 
         SerializerRegistryImpl serReg = new SerializerRegistryImpl();
         serReg.registerSerializer(null, null);
     }
 
     /**
-     * Test - unregister serializer without MessageTypeKye
+     * Test - unregister serializer without MessageTypeKey.
      */
     @Test(expected = IllegalArgumentException.class)
-    public void testUnRegisterSerializerNoMessageTypeKey(){
+    public void testUnRegisterSerializerNoMessageTypeKey() {
         SerializerRegistryImpl serReg = new SerializerRegistryImpl();
         serReg.init();
-        serReg.registerSerializer(new MessageTypeKey<>(OF13, Match.class), new OF13MatchSerializer());
+        serReg.registerSerializer(new MessageTypeKey<>(OF_VERSION_1_3, Match.class), new OF13MatchSerializer());
         serReg.unregisterSerializer(null);
     }
 
     /**
-     * Test - unregister serializer
+     * Test - unregister serializer.
      */
     @Test
-    public void testUnRegisterSerializer(){
+    public void testUnRegisterSerializer() {
         SerializerRegistryImpl serReg = new SerializerRegistryImpl();
         serReg.init();
-        serReg.registerSerializer(new MessageTypeKey<>(OF13, Match.class), new OF13MatchSerializer());
-        Assert.assertTrue("Wrong - unregister serializer",serReg.unregisterSerializer(new MessageTypeKey<>(OF13, Match.class)));
+        serReg.registerSerializer(new MessageTypeKey<>(OF_VERSION_1_3, Match.class), new OF13MatchSerializer());
+        Assert.assertTrue("Wrong - unregister serializer",
+                serReg.unregisterSerializer(new MessageTypeKey<>(OF_VERSION_1_3, Match.class)));
 
-        serReg.registerSerializer(new MessageTypeKey<>(OF13, Match.class), new OF13MatchSerializer());
-        Assert.assertFalse("Wrong - unregister serializer",serReg.unregisterSerializer(new MessageTypeKey<>(OF10, Match.class)));
+        serReg.registerSerializer(new MessageTypeKey<>(OF_VERSION_1_3, Match.class), new OF13MatchSerializer());
+        Assert.assertFalse("Wrong - unregister serializer",
+                serReg.unregisterSerializer(new MessageTypeKey<>(OF_VERSION_1_0, Match.class)));
     }
 }