-/**
+/*
* Copyright (c) 2015 Cisco Systems, Inc. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
import com.google.common.base.Preconditions;
import java.net.InetSocketAddress;
import java.util.Date;
+import java.util.Objects;
+import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future;
-import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import javax.annotation.Nonnull;
import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- *
- */
public class SystemNotificationsListenerImpl implements SystemNotificationsListener {
private static final Logger LOG = LoggerFactory.getLogger(SystemNotificationsListenerImpl.class);
- private static final long ECHO_XID = 0L;
+ private static final Logger OF_EVENT_LOG = LoggerFactory.getLogger("OfEventLog");
+ private static final Xid ECHO_XID = new Xid(0L);
private final ConnectionContext connectionContext;
@VisibleForTesting
static final long MAX_ECHO_REPLY_TIMEOUT = 2000;
private final long echoReplyTimeout;
- private final ThreadPoolExecutor threadPool;
+ private final ExecutorService executorService;
public SystemNotificationsListenerImpl(@Nonnull final ConnectionContext connectionContext,
long echoReplyTimeout,
- @Nonnull final ThreadPoolExecutor threadPool) {
- this.threadPool = threadPool;
+ @Nonnull final ExecutorService executorService) {
+ this.executorService = executorService;
this.connectionContext = Preconditions.checkNotNull(connectionContext);
this.echoReplyTimeout = echoReplyTimeout;
}
@Override
public void onDisconnectEvent(final DisconnectEvent notification) {
+ OF_EVENT_LOG.debug("Disconnect, Node: {}", connectionContext.getSafeNodeIdForLOG());
LOG.info("ConnectionEvent: Connection closed by device, Device:{}, NodeId:{}",
connectionContext.getConnectionAdapter().getRemoteAddress(), connectionContext.getSafeNodeIdForLOG());
connectionContext.onConnectionClosed();
@Override
public void onSwitchIdleEvent(final SwitchIdleEvent notification) {
- threadPool.execute(this::executeOnSwitchIdleEvent);
+ executorService.execute(this::executeOnSwitchIdleEvent);
}
+ @SuppressWarnings("checkstyle:IllegalCatch")
private void executeOnSwitchIdleEvent() {
boolean shouldBeDisconnected = true;
if (ConnectionContext.CONNECTION_STATE.WORKING.equals(connectionContext.getConnectionState())) {
FeaturesReply features = connectionContext.getFeatures();
- LOG.info("Switch Idle state occurred, node={}|auxId={}", remoteAddress, features.getAuxiliaryId());
+ LOG.debug("Switch Idle state occurred, node={}|auxId={}", remoteAddress, features.getAuxiliaryId());
+ OF_EVENT_LOG.debug("Switch idle state, Node: {}", features.getDatapathId());
connectionContext.changeStateToTimeouting();
EchoInputBuilder builder = new EchoInputBuilder();
builder.setVersion(features.getVersion());
- Xid xid = new Xid(ECHO_XID);
- builder.setXid(xid.getValue());
+ builder.setXid(ECHO_XID.getValue());
- Future<RpcResult<EchoOutput>> echoReplyFuture = connectionContext.getConnectionAdapter().echo(builder.build());
+ Future<RpcResult<EchoOutput>> echoReplyFuture =
+ connectionContext.getConnectionAdapter().echo(builder.build());
try {
RpcResult<EchoOutput> echoReplyValue = echoReplyFuture.get(echoReplyTimeout, TimeUnit.MILLISECONDS);
- if (echoReplyValue.isSuccessful() && echoReplyValue.getResult().getXid() == ECHO_XID) {
+ if (echoReplyValue.isSuccessful()
+ && Objects.equals(echoReplyValue.getResult().getXid(), ECHO_XID.getValue())) {
connectionContext.changeStateToWorking();
shouldBeDisconnected = false;
} else {
}
} catch (Exception e) {
if (LOG.isWarnEnabled()) {
- LOG.warn("Exception while waiting for echoReply from [{}] in TIMEOUTING state: {}", remoteAddress, e.getMessage());
+ LOG.warn("Exception while waiting for echoReply from [{}] in TIMEOUTING state: {}",
+ remoteAddress, e.getMessage());
}
if (LOG.isTraceEnabled()) {
- LOG.trace("Exception while waiting for echoReply from [{}] in TIMEOUTING state: {}", remoteAddress, e);
+ LOG.trace("Exception while waiting for echoReply from [{}] in TIMEOUTING state",
+ remoteAddress, e);
}
}
if (shouldBeDisconnected) {
if (LOG.isInfoEnabled()) {
LOG.info("ConnectionEvent:Closing connection as device is idle. Echo sent at {}. Device:{}, NodeId:{}",
- new Date(System.currentTimeMillis() - echoReplyTimeout), remoteAddress, connectionContext.getSafeNodeIdForLOG());
+ new Date(System.currentTimeMillis() - echoReplyTimeout),
+ remoteAddress, connectionContext.getSafeNodeIdForLOG());
}
connectionContext.closeConnection(true);
for (RpcError replyError : echoReplyValue.getErrors()) {
Throwable cause = replyError.getCause();
if (LOG.isWarnEnabled()) {
- LOG.warn("Received EchoReply from [{}] in TIMEOUTING state, Error:{}", remoteAddress, cause.getMessage());
+ LOG.warn("Received EchoReply from [{}] in TIMEOUTING state, Error:{}",
+ remoteAddress, cause.getMessage());
}
if (LOG.isTraceEnabled()) {
- LOG.trace("Received EchoReply from [{}] in TIMEOUTING state, Error:{}", remoteAddress, cause);
+ LOG.trace("Received EchoReply from [{}] in TIMEOUTING state", remoteAddress, cause);
}
-
}
}
}