Fix checkstyle warnings for services package

[openflowplugin.git] / openflowplugin-impl / src / main / java / org / opendaylight / openflowplugin / impl / services / AbstractMultipartRequestOnTheFlyCallback.java

diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractMultipartRequestOnTheFlyCallback.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractMultipartRequestOnTheFlyCallback.java
index 6150fa9d8048620430542963b3f957727e037ef3..43a3450d40e6eba648e4bb78e9eb920bf156f74d 100644 (file)
--- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractMultipartRequestOnTheFlyCallback.java
+++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractMultipartRequestOnTheFlyCallback.java
@@ -32,7 +32,8 @@ import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeader> extends AbstractMultipartRequestCallback<T> {
+public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeader>
+                                                        extends AbstractMultipartRequestCallback<T> {
     private static final Logger LOG = LoggerFactory.getLogger(AbstractMultipartRequestOnTheFlyCallback.class);
     private final DeviceInfo deviceInfo;
     private final EventIdentifier doneEventIdentifier;
@@ -49,7 +50,8 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
                                                     final ConvertorExecutor convertorExecutor) {
         super(context, requestType, deviceContext, eventIdentifier);
         deviceInfo = deviceContext.getDeviceInfo();
-        doneEventIdentifier = new EventIdentifier(getMultipartType().name(), deviceContext.getDeviceInfo().getNodeId().toString());
+        doneEventIdentifier =
+                new EventIdentifier(getMultipartType().name(), deviceContext.getDeviceInfo().getNodeId().toString());
         txFacade = deviceContext;
         deviceRegistry = deviceContext;
         this.statisticsWriterProvider = statisticsWriterProvider;
@@ -57,7 +59,7 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
     }
 
     @Override
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings({"unchecked", "checkstyle:IllegalCatch"})
     public void onSuccess(final OfHeader result) {
         if (Objects.isNull(result)) {
             LOG.warn("Response received was null.");
@@ -100,7 +102,9 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
             } catch (final Exception ex) {
                 LOG.warn("Unexpected exception occurred while translating response: {}.", result.getClass(), ex);
                 setResult(RpcResultBuilder.<List<T>>failed().withError(RpcError.ErrorType.APPLICATION,
-                        String.format("Unexpected exception occurred while translating response: %s. %s", result.getClass(), ex)).build());
+                        String.format("Unexpected exception occurred while translating response: %s. %s",
+                                      result.getClass(),
+                                      ex)).build());
                 endCollecting(false);
                 return;
             }
@@ -112,7 +116,7 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
     }
 
     /**
-     * Get tx facade
+     * Get tx facade.
      * @return tx facade
      */
     protected TxFacade getTxFacade() {
@@ -120,7 +124,7 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
     }
 
     /**
-     * Starts collecting of multipart data
+     * Starts collecting of multipart data.
      */
     private synchronized void startCollecting() {
         EventsTimeCounter.markStart(doneEventIdentifier);
@@ -149,11 +153,13 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
                         instanceIdentifier,
                         deviceRegistry.getDeviceGroupRegistry());
                 break;
+            default:
+                LOG.warn("Unsupported type {}", getMultipartType());
         }
     }
 
     /**
-     * Ends collecting of multipart data
+     * Ends collecting of multipart data.
      * @param setResult set empty success result
      */
     private void endCollecting(final boolean setResult) {
@@ -178,13 +184,14 @@ public abstract class AbstractMultipartRequestOnTheFlyCallback<T extends OfHeade
             case OFPMPGROUPDESC:
                 deviceRegistry.getDeviceGroupRegistry().processMarks();
                 break;
+            default:
+                LOG.warn("Unsupported type {}", getMultipartType());
         }
     }
 
     /**
-     * Get multipart type
+     * Get multipart type.
      * @return multipart type
      */
     protected abstract MultipartType getMultipartType();
-
 }