Cleanup RequestContextStack
[openflowplugin.git] / openflowplugin-impl / src / main / java / org / opendaylight / openflowplugin / impl / services / CommonService.java
index e90cb6a7a2c70b8c6fd34fcf0236d610ca335801..eff804bc09e2dfad4cdfa244e5e2cee8198adfc0 100644 (file)
@@ -10,17 +10,16 @@ package org.opendaylight.openflowplugin.impl.services;
 import com.google.common.base.Function;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.SettableFuture;
 import java.math.BigInteger;
-import java.util.concurrent.Future;
 import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter;
 import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
 import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack;
+import org.opendaylight.openflowplugin.api.openflow.device.Xid;
 import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.MessageSpy;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.FeaturesReply;
-import org.opendaylight.yangtools.yang.common.RpcError.ErrorType;
+import org.opendaylight.yangtools.yang.common.RpcError;
 import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
 import org.slf4j.Logger;
@@ -28,29 +27,18 @@ import org.slf4j.Logger;
 public abstract class CommonService {
     private static final Logger LOG = org.slf4j.LoggerFactory.getLogger(CommonService.class);
     private static final long WAIT_TIME = 2000;
-    protected final static Future<RpcResult<Void>> ERROR_RPC_RESULT = Futures.immediateFuture(RpcResultBuilder
-            .<Void>failed().withError(ErrorType.APPLICATION, "", "Request quota exceeded.").build());
-    protected static final BigInteger PRIMARY_CONNECTION = new BigInteger("0");
+    private static final BigInteger PRIMARY_CONNECTION = BigInteger.ZERO;
 
-    // protected OFRpcTaskContext rpcTaskContext;
-    public short version;
-    public BigInteger datapathId;
-    protected RequestContextStack requestContextStack;
-    protected DeviceContext deviceContext;
-    public ConnectionAdapter primaryConnectionAdapter;
-    public MessageSpy messageSpy;
+    private final short version;
+    private final BigInteger datapathId;
+    private final RequestContextStack requestContextStack;
+    private final DeviceContext deviceContext;
+    private final ConnectionAdapter primaryConnectionAdapter;
+    private final MessageSpy messageSpy;
 
 
-    /**
-     * @deprecated use {@link #CommonService(RequestContextStack, DeviceContext)}
-     */
-    @Deprecated
-    public CommonService() {
-    }
-
-    public CommonService(final RequestContextStack requestContextStack, DeviceContext deviceContext) {
+    public CommonService(final RequestContextStack requestContextStack, final DeviceContext deviceContext) {
         this.requestContextStack = requestContextStack;
-
         this.deviceContext = deviceContext;
         final FeaturesReply features = this.deviceContext.getPrimaryConnectionContext().getFeatures();
         this.datapathId = features.getDatapathId();
@@ -59,10 +47,39 @@ public abstract class CommonService {
         this.messageSpy = deviceContext.getMessageSpy();
     }
 
+    public static BigInteger getPrimaryConnection() {
+        return PRIMARY_CONNECTION;
+    }
+
+    public short getVersion() {
+        return version;
+    }
+
+    public BigInteger getDatapathId() {
+        return datapathId;
+    }
+
+    public RequestContextStack getRequestContextStack() {
+        return requestContextStack;
+    }
+
+    public DeviceContext getDeviceContext() {
+        return deviceContext;
+    }
+
+    public ConnectionAdapter getPrimaryConnectionAdapter() {
+        return primaryConnectionAdapter;
+    }
+
+    public MessageSpy getMessageSpy() {
+        return messageSpy;
+    }
+
     protected long provideWaitTime() {
         return WAIT_TIME;
     }
 
+
     protected ConnectionAdapter provideConnectionAdapter(final BigInteger connectionID) {
         if (connectionID == null) {
             return primaryConnectionAdapter;
@@ -90,42 +107,64 @@ public abstract class CommonService {
     public <T, F> ListenableFuture<RpcResult<T>> handleServiceCall(final BigInteger connectionID,
                                                                    final Function<DataCrate<T>, ListenableFuture<RpcResult<F>>> function) {
         DataCrateBuilder<T> dataCrateBuilder = DataCrateBuilder.<T>builder();
-        return handleServiceCall(connectionID, function, dataCrateBuilder);
+        return handleServiceCall(function, dataCrateBuilder);
+    }
+
+    public <T, F> ListenableFuture<RpcResult<T>> handleServiceCall(final Function<DataCrate<T>, ListenableFuture<RpcResult<F>>> function) {
+        DataCrateBuilder<T> dataCrateBuilder = DataCrateBuilder.<T>builder();
+        return handleServiceCall(function, dataCrateBuilder);
     }
 
     /**
      * @param <T>
      * @param <F>
-     * @param connectionID
      * @param function
      * @param dataCrateBuilder predefined data
      * @return
      */
-    public final <T, F> ListenableFuture<RpcResult<T>> handleServiceCall(final BigInteger connectionID,
-                                                                         final Function<DataCrate<T>, ListenableFuture<RpcResult<F>>> function,
+    public final <T, F> ListenableFuture<RpcResult<T>> handleServiceCall(final Function<DataCrate<T>, ListenableFuture<RpcResult<F>>> function,
                                                                          final DataCrateBuilder<T> dataCrateBuilder) {
 
-        synchronized (deviceContext) {
-            LOG.trace("Handling general service call");
-            final RequestContext<T> requestContext = requestContextStack.createRequestContext();
-            final SettableFuture<RpcResult<T>> result = requestContextStack.storeOrFail(requestContext);
-            if (!result.isDone()) {
-                DataCrate<T> dataCrate = dataCrateBuilder.setiDConnection(connectionID).setRequestContext(requestContext)
-                        .build();
-                requestContext.setXid(deviceContext.getNextXid());
-
-                LOG.trace("Hooking xid {} to device context - precaution.", requestContext.getXid().getValue());
-                deviceContext.hookRequestCtx(requestContext.getXid(), requestContext);
-
-                final ListenableFuture<RpcResult<F>> resultFromOFLib = function.apply(dataCrate);
+        LOG.trace("Handling general service call");
+        final RequestContext<T> requestContext = createRequestContext();
+        if (requestContext == null) {
+            LOG.trace("Request context refused.");
+            deviceContext.getMessageSpy().spyMessage(null, MessageSpy.STATISTIC_GROUP.TO_SWITCH_DISREGARDED);
+            return failedFuture();
+        }
 
-                final OFJResult2RequestCtxFuture<T> OFJResult2RequestCtxFuture = new OFJResult2RequestCtxFuture<>(requestContext, deviceContext);
-                OFJResult2RequestCtxFuture.processResultFromOfJava(resultFromOFLib);
-            } else {
-                messageSpy.spyMessage(requestContext.getClass(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMITTED_FAILURE);
+        Long reservedXid = deviceContext.getReservedXid();
+        if (null == reservedXid) {
+            //retry
+            reservedXid = deviceContext.getReservedXid();
+            if (null == reservedXid) {
+                deviceContext.getMessageSpy().spyMessage(requestContext.getClass(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_RESERVATION_REJECTED);
+                return RequestContextUtil.closeRequestContextWithRpcError(requestContext, "Outbound queue wasn't able to reserve XID.");
             }
-            return result;
         }
+        final Xid xid = new Xid(reservedXid);
+        requestContext.setXid(xid);
+        DataCrate<T> dataCrate = dataCrateBuilder.setRequestContext(requestContext)
+                .build();
+        final ListenableFuture<RpcResult<F>> resultFromOFLib;
+
+        LOG.trace("Hooking xid {} to device context - precaution.", requestContext.getXid().getValue());
+        deviceContext.hookRequestCtx(xid, requestContext);
+
+        messageSpy.spyMessage(requestContext.getClass(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_READY_FOR_SUBMIT);
+        function.apply(dataCrate);
+
+        return requestContext.getFuture();
+
+    }
+
+    protected final <T> RequestContext<T> createRequestContext() {
+        return requestContextStack.createRequestContext();
     }
 
+    protected static <T> ListenableFuture<RpcResult<T>> failedFuture() {
+        final RpcResult<T> rpcResult = RpcResultBuilder.<T>failed()
+                .withError(RpcError.ErrorType.APPLICATION, "", "Request quota exceeded").build();
+        return Futures.immediateFuture(rpcResult);
+    }
 }