re-activate FindBugs

[openflowplugin.git] / openflowplugin-impl / src / main / java / org / opendaylight / openflowplugin / impl / services / RoleService.java

diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/RoleService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/RoleService.java
index 164e6ce153cdd15dcaf813144c310387b1a75097..0bee9905e51e0eca5fe66938ae96cfb141c8f04a 100644 (file)
--- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/RoleService.java
+++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/RoleService.java
@@ -16,6 +16,7 @@ import java.math.BigInteger;
 import java.util.Collection;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
+import javax.annotation.Nonnull;
 import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack;
 import org.opendaylight.openflowplugin.api.openflow.device.Xid;
@@ -68,7 +69,7 @@ public class RoleService extends AbstractSimpleService<RoleRequestInputBuilder,
                 handleServiceCall(roleRequestInputBuilder);
         Futures.addCallback(genIdListenableFuture, new FutureCallback<RpcResult<RoleRequestOutput>>() {
             @Override
-            public void onSuccess(final RpcResult<RoleRequestOutput> roleRequestOutputRpcResult) {
+            public void onSuccess(@Nonnull final RpcResult<RoleRequestOutput> roleRequestOutputRpcResult) {
                 if (roleRequestOutputRpcResult.isSuccessful()) {
                     final RoleRequestOutput roleRequestOutput = roleRequestOutputRpcResult.getResult();
                     if (roleRequestOutput != null) {
@@ -81,8 +82,8 @@ public class RoleService extends AbstractSimpleService<RoleRequestInputBuilder,
                     }
 
                 } else {
-                    LOG.error("getGenerationIdFromDevice RPC error "
-                            + roleRequestOutputRpcResult.getErrors().iterator().next().getInfo());
+                    LOG.error("getGenerationIdFromDevice RPC error {}",
+                            roleRequestOutputRpcResult.getErrors().iterator().next().getInfo());
                     finalFuture.setException(new RoleChangeException(ErrorUtil
                             .errorsToString(roleRequestOutputRpcResult.getErrors())));
                 }
@@ -114,7 +115,7 @@ public class RoleService extends AbstractSimpleService<RoleRequestInputBuilder,
         final SettableFuture<RpcResult<SetRoleOutput>> finalFuture = SettableFuture.create();
         Futures.addCallback(roleListenableFuture, new FutureCallback<RpcResult<RoleRequestOutput>>() {
             @Override
-            public void onSuccess(final RpcResult<RoleRequestOutput> roleRequestOutputRpcResult) {
+            public void onSuccess(@Nonnull final RpcResult<RoleRequestOutput> roleRequestOutputRpcResult) {
                 LOG.info("submitRoleChange onSuccess for device:{}, role:{}",
                         getDeviceInfo().getNodeId(), ofpRole);
                 final RoleRequestOutput roleRequestOutput = roleRequestOutputRpcResult.getResult();