package org.opendaylight.openflowplugin.impl.statistics;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Function;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterators;
import javax.annotation.concurrent.GuardedBy;
import org.opendaylight.mdsal.common.api.TransactionChainClosedException;
import org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier;
+import org.opendaylight.openflowplugin.api.ConnectionException;
import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext;
import org.opendaylight.openflowplugin.api.openflow.device.DeviceInfo;
private final DeviceContext deviceContext;
private final DeviceState devState;
private final ListenableFuture<Boolean> emptyFuture;
- private final boolean shuttingDownStatisticsPolling;
- private final Object COLLECTION_STAT_TYPE_LOCK = new Object();
+ private final boolean isStatisticsPollingOn;
private final SinglePurposeMultipartReplyTranslator multipartReplyTranslator;
- @GuardedBy("COLLECTION_STAT_TYPE_LOCK")
+ private final Object collectionStatTypeLock = new Object();
+ @GuardedBy("collectionStatTypeLock")
private List<MultipartType> collectingStatType;
private StatisticsGatheringService statisticsGatheringService;
private ListenableFuture<Boolean> lastDataGathering;
StatisticsContextImpl(@Nonnull final DeviceInfo deviceInfo,
- final boolean shuttingDownStatisticsPolling,
+ final boolean isStatisticsPollingOn,
@Nonnull final LifecycleService lifecycleService,
@Nonnull final ConvertorExecutor convertorExecutor,
@Nonnull final StatisticsManager myManager) {
this.lifecycleService = lifecycleService;
this.deviceContext = lifecycleService.getDeviceContext();
this.devState = Preconditions.checkNotNull(deviceContext.getDeviceState());
- this.shuttingDownStatisticsPolling = shuttingDownStatisticsPolling;
+ this.isStatisticsPollingOn = isStatisticsPollingOn;
multipartReplyTranslator = new SinglePurposeMultipartReplyTranslator(convertorExecutor);
emptyFuture = Futures.immediateFuture(false);
statisticsGatheringService = new StatisticsGatheringService(this, deviceContext);
statisticsGatheringOnTheFlyService = new StatisticsGatheringOnTheFlyService(this, deviceContext, convertorExecutor);
itemLifeCycleListener = new ItemLifecycleListenerImpl(deviceContext);
statListForCollectingInitialization();
- setState(CONTEXT_STATE.INITIALIZATION);
+ this.state = CONTEXT_STATE.INITIALIZATION;
this.deviceInfo = deviceInfo;
this.myManager = myManager;
this.lastDataGathering = null;
@Override
public void statListForCollectingInitialization() {
- synchronized (COLLECTION_STAT_TYPE_LOCK) {
+ synchronized (collectionStatTypeLock) {
final List<MultipartType> statListForCollecting = new ArrayList<>();
if (devState.isTableStatisticsAvailable()) {
statListForCollecting.add(MultipartType.OFPMPTABLE);
private ListenableFuture<Boolean> gatherDynamicData(final boolean initial) {
this.lastDataGathering = null;
- if (shuttingDownStatisticsPolling) {
+ if (!isStatisticsPollingOn) {
LOG.debug("Statistics for device {} is not enabled.", getDeviceInfo().getNodeId().getValue());
return Futures.immediateFuture(Boolean.TRUE);
}
if (errorResultFuture != null) {
return errorResultFuture;
}
- synchronized (COLLECTION_STAT_TYPE_LOCK) {
+ synchronized (collectionStatTypeLock) {
final Iterator<MultipartType> statIterator = collectingStatType.iterator();
final SettableFuture<Boolean> settableStatResultFuture = SettableFuture.create();
}
private ListenableFuture<Boolean> chooseStat(final MultipartType multipartType, final boolean initial){
+ ListenableFuture<Boolean> result = Futures.immediateCheckedFuture(Boolean.TRUE);
+
switch (multipartType) {
case OFPMPFLOW:
- return collectFlowStatistics(multipartType, initial);
+ result = collectFlowStatistics(multipartType, initial);
+ break;
case OFPMPTABLE:
- return collectTableStatistics(multipartType);
+ result = collectTableStatistics(multipartType);
+ break;
case OFPMPPORTSTATS:
- return collectPortStatistics(multipartType);
+ result = collectPortStatistics(multipartType);
+ break;
case OFPMPQUEUE:
- return collectQueueStatistics(multipartType);
+ result = collectQueueStatistics(multipartType);
+ break;
case OFPMPGROUPDESC:
- return collectGroupDescStatistics(multipartType);
+ result = collectGroupDescStatistics(multipartType);
+ break;
case OFPMPGROUP:
- return collectGroupStatistics(multipartType);
+ result = collectGroupStatistics(multipartType);
+ break;
case OFPMPMETERCONFIG:
- return collectMeterConfigStatistics(multipartType);
+ result = collectMeterConfigStatistics(multipartType);
+ break;
case OFPMPMETER:
- return collectMeterStatistics(multipartType);
+ result = collectMeterStatistics(multipartType);
+ break;
default:
- LOG.warn("Unsuported Statistics type {}", multipartType);
- return Futures.immediateCheckedFuture(Boolean.TRUE);
+ LOG.warn("Unsupported Statistics type {}", multipartType);
}
+
+ return result;
}
public void close() {
if (CONTEXT_STATE.TERMINATION.equals(getState())) {
if (LOG.isDebugEnabled()) {
- LOG.debug("Statistics context is already in state TERMINATION.");
+ LOG.debug("StatisticsContext for node {} is already in TERMINATION state.", getDeviceInfo().getLOGValue());
}
} else {
- stopGatheringData();
- setState(CONTEXT_STATE.TERMINATION);
- schedulingEnabled = false;
+ try {
+ stopClusterServices().get();
+ } catch (Exception e) {
+ LOG.debug("Failed to close StatisticsContext for node {} with exception: ", getDeviceInfo().getLOGValue(), e);
+ }
+
+ this.state = CONTEXT_STATE.TERMINATION;
+
for (final Iterator<RequestContext<?>> iterator = Iterators.consumingIterator(requestContexts.iterator());
iterator.hasNext(); ) {
RequestContextUtil.closeRequestContextWithRpcError(iterator.next(), CONNECTION_CLOSED);
}
+
if (null != pollTimeout && !pollTimeout.isExpired()) {
pollTimeout.cancel();
}
final String errMsg = String.format("Device connection is closed for Node : %s.",
getDeviceInfo().getNodeId());
LOG.debug(errMsg);
- resultFuture.setException(new IllegalStateException(errMsg));
+ resultFuture.setException(new ConnectionException(errMsg));
return;
}
if ( ! iterator.hasNext()) {
return this.state;
}
- @Override
- public void setState(CONTEXT_STATE state) {
- this.state = state;
- }
-
@Override
public ServiceGroupIdentifier getServiceIdentifier() {
return this.deviceInfo.getServiceIdentifier();
}
@Override
- public ListenableFuture<Void> stopClusterServices(boolean deviceDisconnected) {
- stopGatheringData();
- myManager.stopScheduling(deviceInfo);
- return Futures.immediateFuture(null);
+ public ListenableFuture<Void> stopClusterServices() {
+ if (CONTEXT_STATE.TERMINATION.equals(getState())) {
+ return Futures.immediateCancelledFuture();
+ }
+
+ return Futures.transform(Futures.immediateFuture(null), new Function<Object, Void>() {
+ @Nullable
+ @Override
+ public Void apply(@Nullable Object input) {
+ schedulingEnabled = false;
+ stopGatheringData();
+ return null;
+ }
+ });
}
@Override
if (LOG.isDebugEnabled()) {
LOG.debug("Stop the running statistics gathering for node {}", this.deviceInfo.getLOGValue());
}
- this.lastDataGathering.cancel(true);
+
+ lastDataGathering.cancel(true);
}
}
@Override
public boolean onContextInstantiateService(final ConnectionContext connectionContext) {
-
if (connectionContext.getConnectionState().equals(ConnectionContext.CONNECTION_STATE.RIP)) {
LOG.warn("Connection on device {} was interrupted, will stop starting master services.", deviceInfo.getLOGValue());
return false;
}
- if (!this.shuttingDownStatisticsPolling) {
-
- LOG.info("Starting statistics context cluster services for node {}", deviceInfo.getLOGValue());
+ LOG.info("Starting statistics context cluster services for node {}", deviceInfo.getLOGValue());
- this.statListForCollectingInitialization();
- Futures.addCallback(this.initialGatherDynamicData(), new FutureCallback<Boolean>() {
+ this.statListForCollectingInitialization();
+ Futures.addCallback(this.initialGatherDynamicData(), new FutureCallback<Boolean>() {
- @Override
- public void onSuccess(@Nullable Boolean aBoolean) {
- initialSubmitHandler.initialSubmitTransaction();
- }
-
- @Override
- public void onFailure(Throwable throwable) {
- LOG.warn("Initial gathering statistics unsuccessful for node {}", deviceInfo.getLOGValue());
- lifecycleService.closeConnection();
- }
- });
+ @Override
+ public void onSuccess(@Nullable Boolean aBoolean) {
+ initialSubmitHandler.initialSubmitTransaction();
+ }
- myManager.startScheduling(deviceInfo);
+ @Override
+ public void onFailure(Throwable throwable) {
+ LOG.warn("Initial gathering statistics unsuccessful for node {}", deviceInfo.getLOGValue());
+ lifecycleService.closeConnection();
+ }
+ });
+ if (this.isStatisticsPollingOn) {
+ myManager.startScheduling(deviceInfo);
}
return this.clusterInitializationPhaseHandler.onContextInstantiateService(connectionContext);
public void setInitialSubmitHandler(final ClusterInitializationPhaseHandler initialSubmitHandler) {
this.initialSubmitHandler = initialSubmitHandler;
}
-}
+}
\ No newline at end of file
Code Review / openflowplugin.git / blobdiff