package org.opendaylight.openflowplugin.impl.statistics.services.compatibility;
+import com.google.common.collect.Lists;
import java.util.ArrayList;
+import java.util.HashSet;
import java.util.List;
import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
import org.opendaylight.openflowplugin.api.openflow.device.DeviceInfo;
import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor;
import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.data.VersionConvertorData;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.multipart.reply.multipart.reply.body.multipart.reply.group._case.MultipartReplyGroup;
/**
- * pulled out group stats to notification transformation
+ * Pulled out group stats to notification transformation.
*/
-public class GroupStatisticsToNotificationTransformer {
+public final class GroupStatisticsToNotificationTransformer {
+
private GroupStatisticsToNotificationTransformer() {
// Hide implicit constructor
}
+
/**
+ * Transform statistics to notification.
* @param mpReplyList raw multipart response from device
* @param deviceInfo device state
- * @param emulatedTxId
- * @param convertorExecutor
+ * @param emulatedTxId emulated transaction id
+ * @param convertorExecutor convertor executor
* @return notification containing flow stats
*/
public static GroupStatisticsUpdated transformToNotification(final List<MultipartReply> mpReplyList,
notification.setMoreReplies(Boolean.FALSE);
notification.setTransactionId(emulatedTxId);
- notification.setGroupStats(new ArrayList<GroupStats>());
+ notification.setGroupStats(new ArrayList<>());
for (MultipartReply mpReply : mpReplyList) {
MultipartReplyGroupCase caseBody = (MultipartReplyGroupCase) mpReply.getMultipartReplyBody();
final Optional<List<GroupStats>> groupStatsList = convertorExecutor.convert(
replyBody.getGroupStats(), data);
- if (groupStatsList.isPresent()) {
- notification.getGroupStats().addAll(groupStatsList.get());
- }
+ groupStatsList.ifPresent(groupStats -> {
+ if (notification.getGroupStats() == null) {
+ List<GroupStats> stats = Lists.newArrayList(groupStats);
+ notification.setGroupStats(stats);
+ } else {
+ Set<GroupStats> stats = new HashSet<>(notification.getGroupStats().values());
+ stats.addAll(groupStats);
+ notification.setGroupStats(stats.stream().collect(Collectors.toList()));
+ }
+ });
}
return notification.build();
}