package org.opendaylight.openflowplugin.impl.statistics.services.compatibility;
+import com.google.common.collect.Lists;
import java.util.ArrayList;
+import java.util.HashSet;
import java.util.List;
import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
import org.opendaylight.openflowplugin.api.openflow.device.DeviceInfo;
import org.opendaylight.openflowplugin.api.openflow.md.util.OpenflowVersion;
import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorExecutor;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.multipart.reply.multipart.reply.body.multipart.reply.meter._case.MultipartReplyMeter;
/**
- * pulled out meter stats to notification transformation
+ * Pulled out meter stats to notification transformation.
*/
-public class MeterStatisticsToNotificationTransformer {
+public final class MeterStatisticsToNotificationTransformer {
+
+ private MeterStatisticsToNotificationTransformer() {
+ // Hide implicit constructor
+ }
/**
+ * Transform statistics to notification.
+ *
* @param mpReplyList raw multipart response from device
- * @param deviceInfo device state
+ * @param deviceInfo device state
* @param ofVersion device version
- * @param emulatedTxId
- * @param convertorExecutor
+ * @param emulatedTxId emulated transaction Id
+ * @param convertorExecutor convertor executor
* @return notification containing flow stats
*/
public static MeterStatisticsUpdated transformToNotification(final List<MultipartReply> mpReplyList,
notification.setMoreReplies(Boolean.FALSE);
notification.setTransactionId(emulatedTxId);
- notification.setMeterStats(new ArrayList<MeterStats>());
+ notification.setMeterStats(new ArrayList<>());
for (MultipartReply mpReply : mpReplyList) {
MultipartReplyMeterCase caseBody = (MultipartReplyMeterCase) mpReply.getMultipartReplyBody();
MultipartReplyMeter replyBody = caseBody.getMultipartReplyMeter();
- final Optional<List<MeterStats>> meterStatsList = convertorExecutor.convert(replyBody.getMeterStats(), data);
+ final Optional<List<MeterStats>> meterStatsList =
+ convertorExecutor.convert(replyBody.getMeterStats(), data);
- if (meterStatsList.isPresent()) {
- notification.getMeterStats().addAll(meterStatsList.get());
- }
+ meterStatsList.ifPresent(meterStats -> {
+ if (notification.getMeterStats() == null) {
+ notification.setMeterStats(Lists.newArrayList(meterStats));
+ } else {
+ Set<MeterStats> stats = new HashSet<>(notification.getMeterStats().values());
+ stats.addAll(meterStats);
+ notification.setMeterStats(stats.stream().collect(Collectors.toList()));
+ }
+ });
}
return notification.build();