package org.opendaylight.openflowplugin.impl.device;
+import com.google.common.base.Optional;
+import com.google.common.util.concurrent.CheckedFuture;
import com.google.common.util.concurrent.Futures;
-import io.netty.util.HashedWheelTimer;
import org.junit.After;
import org.junit.Before;
-import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Matchers;
import org.mockito.runners.MockitoJUnitRunner;
import org.opendaylight.controller.md.sal.binding.api.BindingTransactionChain;
import org.opendaylight.controller.md.sal.binding.api.DataBroker;
-import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
+import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction;
+import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction;
import org.opendaylight.controller.md.sal.common.api.data.AsyncTransaction;
import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
+import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException;
import org.opendaylight.controller.md.sal.common.api.data.TransactionChain;
import org.opendaylight.controller.md.sal.common.api.data.TransactionChainListener;
import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
-import org.opendaylight.openflowplugin.api.openflow.device.DeviceState;
+import org.opendaylight.openflowplugin.api.openflow.device.DeviceInfo;
+import org.opendaylight.openflowplugin.common.txchain.TransactionChainManager;
+import org.opendaylight.openflowplugin.impl.util.DeviceStateUtil;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
+import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier;
-/**
- * Created by mirehak on 4/5/15.
- */
@RunWith(MockitoJUnitRunner.class)
public class TransactionChainManagerTest {
@Mock
private DataBroker dataBroker;
@Mock
- private DeviceState deviceState;
- @Mock
private BindingTransactionChain txChain;
@Mock
- private WriteTransaction writeTx;
+ private ReadWriteTransaction writeTx;
@Mock
private TransactionChain<?, ?> transactionChain;
@Mock
- HashedWheelTimer timer;
+ DeviceInfo deviceInfo;
+
+ @Mock
+ private KeyedInstanceIdentifier<Node, NodeKey> nodeKeyIdent;
private TransactionChainManager txChainManager;
private InstanceIdentifier<Node> path;
@Before
public void setUp() throws Exception {
+ final ReadOnlyTransaction readOnlyTx = Mockito.mock(ReadOnlyTransaction.class);
+ final CheckedFuture<Optional<Node>, ReadFailedException> noExistNodeFuture = Futures
+ .immediateCheckedFuture(Optional.<Node>absent());
+ Mockito.when(readOnlyTx.read(LogicalDatastoreType.OPERATIONAL, nodeKeyIdent)).thenReturn(noExistNodeFuture);
+ Mockito.when(dataBroker.newReadOnlyTransaction()).thenReturn(readOnlyTx);
Mockito.when(dataBroker.createTransactionChain(Matchers.any(TransactionChainListener.class)))
.thenReturn(txChain);
- Mockito.when(deviceState.isValid()).thenReturn(Boolean.TRUE);
- txChainManager = new TransactionChainManager(dataBroker, deviceState);
- Mockito.when(txChain.newWriteOnlyTransaction()).thenReturn(writeTx);
-
nodeId = new NodeId("h2g2:42");
- path = InstanceIdentifier.create(Nodes.class).child(Node.class, new NodeKey(nodeId));
+ nodeKeyIdent = DeviceStateUtil.createNodeInstanceIdentifier(nodeId);
+ Mockito.when(deviceInfo.getNodeInstanceIdentifier()).thenReturn(nodeKeyIdent);
+ Mockito.when(deviceInfo.getNodeId()).thenReturn(nodeId);
+ txChainManager = new TransactionChainManager(dataBroker, nodeId.getValue());
+ Mockito.when(txChain.newReadWriteTransaction()).thenReturn(writeTx);
- Mockito.when(writeTx.submit()).thenReturn(Futures.<Void, TransactionCommitFailedException>immediateCheckedFuture(null));
+ path = InstanceIdentifier.create(Nodes.class).child(Node.class, new NodeKey(nodeId));
+ Mockito.when(writeTx.submit())
+ .thenReturn(Futures.<Void, TransactionCommitFailedException>immediateCheckedFuture(null));
+ txChainManager.activateTransactionManager();
}
@After
@Test
public void testWriteToTransaction() throws Exception {
final Node data = new NodeBuilder().setId(nodeId).build();
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
- Mockito.verify(txChain).newWriteOnlyTransaction();
- Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data);
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
}
+ /**
+ * Tests transaction submit {@link TransactionChainManager#submitTransaction()}.
+ */
@Test
public void testSubmitTransaction() throws Exception {
final Node data = new NodeBuilder().setId(nodeId).build();
- txChainManager.enableSubmit();
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
- txChainManager.submitWriteTransaction();
+ txChainManager.initialSubmitWriteTransaction();
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ txChainManager.submitTransaction();
- Mockito.verify(txChain).newWriteOnlyTransaction();
- Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data);
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
Mockito.verify(writeTx).submit();
}
/**
- * test of {@link TransactionChainManager#enableSubmit()}: no submit - counter is not active
- * @throws Exception
+ * test of {@link TransactionChainManager#submitTransaction()}: no submit, never enabled.
*/
@Test
- public void testEnableCounter1() throws Exception {
+ public void testSubmitTransaction1() throws Exception {
final Node data = new NodeBuilder().setId(nodeId).build();
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ txChainManager.submitTransaction();
- Mockito.verify(txChain).newWriteOnlyTransaction();
- Mockito.verify(writeTx, Mockito.times(2)).put(LogicalDatastoreType.CONFIGURATION, path, data);
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ Mockito.verify(writeTx, Mockito.never()).submit();
}
- /**
- * test of {@link TransactionChainManager#enableSubmit()}: submit - after counter activated
- * @throws Exception
- */
@Test
- @Ignore // FIXME : think about test -> we don't use submit by time and nrOfOperations
- public void testEnableCounter2() throws Exception {
- txChainManager.enableSubmit();
-
+ public void testSubmitTransactionFailed() throws Exception {
+ Mockito.when(writeTx.submit()).thenReturn(
+ Futures.<Void, TransactionCommitFailedException>immediateFailedCheckedFuture(
+ new TransactionCommitFailedException("mock")));
final Node data = new NodeBuilder().setId(nodeId).build();
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
+ txChainManager.initialSubmitWriteTransaction();
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ txChainManager.submitTransaction();
- Mockito.verify(txChain).newWriteOnlyTransaction();
- Mockito.verify(writeTx, Mockito.times(2)).put(LogicalDatastoreType.CONFIGURATION, path, data);
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
Mockito.verify(writeTx).submit();
+ }
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
- txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data);
+ /**
+ * Test of {@link TransactionChainManager#enableSubmit()}: no submit - counter is not active.
+ */
+ @Test
+ public void testEnableCounter1() throws Exception {
+ final Node data = new NodeBuilder().setId(nodeId).build();
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
- Mockito.verify(txChain, Mockito.times(2)).newWriteOnlyTransaction();
- Mockito.verify(writeTx, Mockito.times(4)).put(LogicalDatastoreType.CONFIGURATION, path, data);
- Mockito.verify(writeTx, Mockito.times(2)).submit();
- Mockito.verify(writeTx, Mockito.times(2)).getIdentifier();
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx, Mockito.times(2)).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ Mockito.verify(writeTx, Mockito.never()).submit();
}
@Test
public void testOnTransactionChainFailed() throws Exception {
- txChainManager.onTransactionChainFailed(transactionChain, Mockito.mock(AsyncTransaction.class), Mockito.mock(Throwable.class));
-
+ txChainManager
+ .onTransactionChainFailed(txChain, Mockito.mock(AsyncTransaction.class), Mockito.mock(Throwable.class));
Mockito.verify(txChain).close();
Mockito.verify(dataBroker, Mockito.times(2)).createTransactionChain(txChainManager);
}
@Test
public void testAddDeleteOperationTotTxChain() throws Exception {
- txChainManager.addDeleteOperationTotTxChain(LogicalDatastoreType.CONFIGURATION, path);
+ txChainManager.addDeleteOperationToTxChain(LogicalDatastoreType.CONFIGURATION, path);
- Mockito.verify(txChain).newWriteOnlyTransaction();
+ Mockito.verify(txChain).newReadWriteTransaction();
Mockito.verify(writeTx).delete(LogicalDatastoreType.CONFIGURATION, path);
}
-}
\ No newline at end of file
+
+ @Test
+ public void testDeactivateTransactionChainManager() throws Exception {
+ txChainManager.deactivateTransactionManager();
+
+ Mockito.verify(txChain).close();
+ }
+
+ @Test
+ public void testDeactivateTransactionChainManagerFailed() throws Exception {
+ Mockito.when(writeTx.submit()).thenReturn(
+ Futures.<Void, TransactionCommitFailedException>immediateFailedCheckedFuture(
+ new TransactionCommitFailedException("mock")));
+ final Node data = new NodeBuilder().setId(nodeId).build();
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
+
+ txChainManager.deactivateTransactionManager();
+
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ Mockito.verify(writeTx, Mockito.never()).submit();
+ Mockito.verify(writeTx).cancel();
+ Mockito.verify(txChain).close();
+ }
+
+ @Test
+ public void testShuttingDown() throws Exception {
+ final Node data = new NodeBuilder().setId(nodeId).build();
+ txChainManager.initialSubmitWriteTransaction();
+ txChainManager.writeToTransaction(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ txChainManager.shuttingDown();
+
+ Mockito.verify(txChain).newReadWriteTransaction();
+ Mockito.verify(writeTx).put(LogicalDatastoreType.CONFIGURATION, path, data, false);
+ Mockito.verify(writeTx).submit();
+ }
+
+ @Test
+ public void testClose() {
+ txChainManager.shuttingDown();
+ txChainManager.close();
+ Mockito.verify(txChain).close();
+ }
+}
Code Review / openflowplugin.git / blobdiff