Decompose RPC implementation classes

[openflowplugin.git] / openflowplugin-impl / src / test / java / org / opendaylight / openflowplugin / impl / services / sal / TransmitPacketImplTest.java

diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/TransmitPacketImplTest.java
similarity index 64%
rename from openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java
rename to openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/TransmitPacketImplTest.java
index 5107449ce700ed31a32a780c3ddddae8d750f2c3..ba037b6811bc1ddbfaca413475fb9280c7f24af0 100644 (file)
--- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/PacketProcessingServiceImplTest.java
+++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/services/sal/TransmitPacketImplTest.java
@@ -16,7 +16,6 @@ import org.junit.Test;
 import org.opendaylight.openflowplugin.api.OFConstants;
 import org.opendaylight.openflowplugin.api.openflow.device.Xid;
 import org.opendaylight.openflowplugin.impl.services.ServiceMocking;
-import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorManager;
 import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorManagerFactory;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef;
@@ -28,7 +27,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.No
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.action.rev150203.action.grouping.action.choice.OutputActionCase;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.OfHeader;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.PacketOutInput;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInput;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInputBuilder;
@@ -36,56 +34,51 @@ import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier;
 import org.opendaylight.yangtools.yang.common.Uint32;
 
 /**
- * Test for {@link PacketProcessingServiceImpl}.
+ * Test for {@link TransmitPacketImpl}.
  */
-public class PacketProcessingServiceImplTest extends ServiceMocking {
-
+public class TransmitPacketImplTest extends ServiceMocking {
     private static final Uint32 DUMMY_XID_VALUE = Uint32.valueOf(100);
-    public static final String ULTIMATE_PAYLOAD = "What do you get when you multiply six by nine?";
+    private static final String ULTIMATE_PAYLOAD = "What do you get when you multiply six by nine?";
 
-    private PacketProcessingServiceImpl packetProcessingService;
+    private TransmitPacketImpl transmitPacket;
     private KeyedInstanceIdentifier<NodeConnector, NodeConnectorKey> pathToNodeconnector;
 
     @Override
     protected void setup() {
-        final ConvertorManager convertorManager = ConvertorManagerFactory.createDefaultManager();
-        packetProcessingService =
-                new PacketProcessingServiceImpl(mockedRequestContextStack, mockedDeviceContext, convertorManager);
+        final var convertorManager = ConvertorManagerFactory.createDefaultManager();
+        transmitPacket = new TransmitPacketImpl(mockedRequestContextStack, mockedDeviceContext, convertorManager);
         pathToNodeconnector = KeyedInstanceIdentifier.create(Nodes.class)
-                .child(Node.class, new NodeKey(new NodeId("ofp-ut:123")))
-                .child(NodeConnector.class, new NodeConnectorKey(new NodeConnectorId("ofp-ut:123:1")));
+            .child(Node.class, new NodeKey(new NodeId("ofp-ut:123")))
+            .child(NodeConnector.class, new NodeConnectorKey(new NodeConnectorId("ofp-ut:123:1")));
     }
 
     @Test
     public void testTransmitPacket() {
-        TransmitPacketInput transmitPacketInput = buildTransmitPacketInput();
-        packetProcessingService.transmitPacket(transmitPacketInput);
+        transmitPacket.invoke(buildTransmitPacketInput());
         verify(mockedRequestContextStack).createRequestContext();
     }
 
     @Test
     public void testBuildRequest() {
-        TransmitPacketInput transmitPacketInput = buildTransmitPacketInput();
-
-        final OfHeader request = packetProcessingService.buildRequest(new Xid(DUMMY_XID_VALUE), transmitPacketInput);
+        final var request = transmitPacket.buildRequest(new Xid(DUMMY_XID_VALUE), buildTransmitPacketInput());
         assertEquals(DUMMY_XID_VALUE, request.getXid());
         assertTrue(request instanceof PacketOutInput);
-        final PacketOutInput input = (PacketOutInput) request;
+        final var input = (PacketOutInput) request;
         assertEquals(OFConstants.OFP_NO_BUFFER, input.getBufferId());
         assertEquals(1, input.getAction().size());
         assertEquals(OutputActionCase.class, input.getAction().get(0).getActionChoice().implementedInterface());
 
-        final OutputActionCase actionChoice = (OutputActionCase) input.getAction().get(0).getActionChoice();
+        final var actionChoice = (OutputActionCase) input.getAction().get(0).getActionChoice();
         assertEquals(1, actionChoice.getOutputAction().getPort().getValue().intValue());
         assertEquals(ULTIMATE_PAYLOAD, new String(input.getData()));
     }
 
     private TransmitPacketInput buildTransmitPacketInput() {
-        TransmitPacketInputBuilder transmitPacketInputBld = new TransmitPacketInputBuilder()
-                .setBufferId(OFConstants.OFP_NO_BUFFER)
-                .setNode(new NodeRef(mockedDeviceInfo.getNodeInstanceIdentifier()))
-                .setPayload(ULTIMATE_PAYLOAD.getBytes())
-                .setEgress(new NodeConnectorRef(pathToNodeconnector));
-        return transmitPacketInputBld.build();
+        return new TransmitPacketInputBuilder()
+            .setBufferId(OFConstants.OFP_NO_BUFFER)
+            .setNode(new NodeRef(mockedDeviceInfo.getNodeInstanceIdentifier()))
+            .setPayload(ULTIMATE_PAYLOAD.getBytes())
+            .setEgress(new NodeConnectorRef(pathToNodeconnector))
+            .build();
     }
 }