Merge "Fix issues related to checkstyle enforcement on openflow-impl module"
[openflowplugin.git] / openflowplugin-impl / src / test / java / org / opendaylight / openflowplugin / impl / statistics / StatisticsContextImplTest.java
index 25a153592e731dc210d9b4443691afdc7c44f719..cebe9bfb2c0cbccbeaeab6b7c13a0b29c69ce0d6 100644 (file)
@@ -1,12 +1,9 @@
 /*
+ * Copyright (c) 2015 Cisco Systems, Inc. and others.  All rights reserved.
  *
- *  * Copyright (c) 2015 Cisco Systems, Inc. and others.  All rights reserved.
- *  *
- *  * This program and the accompanying materials are made available under the
- *  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- *  * and is available at http://www.eclipse.org/legal/epl-v10.html
- *
- *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
 
 package org.opendaylight.openflowplugin.impl.statistics;
@@ -18,9 +15,8 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.MoreExecutors;
 import java.util.Collections;
-import java.util.concurrent.ExecutionException;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -28,9 +24,11 @@ import org.junit.runner.RunWith;
 import org.mockito.Matchers;
 import org.mockito.Mockito;
 import org.mockito.runners.MockitoJUnitRunner;
-import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContext;
 import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.EventIdentifier;
+import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProviderFactory;
+import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorManager;
+import org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.ConvertorManagerFactory;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.MultipartType;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.MultipartReply;
 import org.opendaylight.yangtools.yang.common.RpcResult;
@@ -44,34 +42,52 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
     private static final Logger LOG = LoggerFactory.getLogger(StatisticsContextImplTest.class);
 
     private static final Long TEST_XID = 55L;
-    private StatisticsContextImpl statisticsContext;
+    private StatisticsContextImpl<MultipartReply> statisticsContext;
+    private ConvertorManager convertorManager;
 
     @Before
     public void setUp() throws Exception {
-        when(mockedDeviceContext.getReservedXid()).thenReturn(TEST_XID);
+        convertorManager = ConvertorManagerFactory.createDefaultManager();
+        when(mockedDeviceInfo.reserveXidForDeviceMessage()).thenReturn(TEST_XID);
+        Mockito.when(mockedDeviceContext.getDeviceState()).thenReturn(mockedDeviceState);
         initStatisticsContext();
     }
 
     private void initStatisticsContext() {
-        statisticsContext = new StatisticsContextImpl(mockedDeviceContext);
+        statisticsContext = new StatisticsContextImpl<>(mockedDeviceContext, convertorManager,
+                                                        MultipartWriterProviderFactory
+                                                                .createDefaultProvider(mockedDeviceContext),
+                                                        MoreExecutors.newDirectExecutorService(), true, false, 3000,
+                                                        50000);
+
         statisticsContext.setStatisticsGatheringService(mockedStatisticsGatheringService);
         statisticsContext.setStatisticsGatheringOnTheFlyService(mockedStatisticsOnFlyGatheringService);
     }
 
     @Test
     public void testCreateRequestContext() {
-        RequestContext<Object> requestContext = statisticsContext.createRequestContext();
+        final RequestContext<Object> requestContext = statisticsContext.createRequestContext();
         assertNotNull(requestContext);
         assertEquals(TEST_XID, requestContext.getXid().getValue());
         Assert.assertFalse(requestContext.getFuture().isDone());
     }
 
     /**
-     * There is nothing to check in close method
+     * There is nothing to check in close method.
      */
     @Test
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public void testClose() throws Exception {
-        StatisticsContextImpl statisticsContext = new StatisticsContextImpl(mockedDeviceContext);
+        final StatisticsContextImpl<MultipartReply> statisticsContext =
+                new StatisticsContextImpl<>(mockedDeviceContext,
+                                            convertorManager,
+                                            MultipartWriterProviderFactory
+                                                    .createDefaultProvider(mockedDeviceContext),
+                                            MoreExecutors.newDirectExecutorService(),
+                                            true,
+                                            false,
+                                            3000,50000);
+
         final RequestContext<Object> requestContext = statisticsContext.createRequestContext();
         statisticsContext.close();
         try {
@@ -79,7 +95,7 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
             final RpcResult<?> rpcResult = requestContext.getFuture().get();
             Assert.assertFalse(rpcResult.isSuccessful());
             Assert.assertFalse(rpcResult.isSuccessful());
-        } catch (Exception e) {
+        } catch (final Exception e) {
             LOG.error("request future value should be finished", e);
             Assert.fail("request context closing failed");
         }
@@ -87,76 +103,40 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
 
     @Test
     public void testGatherDynamicData_none() throws Exception {
-        final ListenableFuture<Boolean> gatheringResult = statisticsContext.gatherDynamicData();
-        Assert.assertTrue(gatheringResult.isDone());
-        Assert.assertTrue(gatheringResult.get());
+        statisticsContext.instantiateServiceInstance();
         Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService);
     }
 
     @Test
     public void testGatherDynamicData_all() throws Exception {
         Mockito.reset(mockedDeviceState);
-        when(mockedDeviceState.isTableStatisticsAvailable()).thenReturn(true);
-        when(mockedDeviceState.isFlowStatisticsAvailable()).thenReturn(true);
-        when(mockedDeviceState.isGroupAvailable()).thenReturn(true);
-        when(mockedDeviceState.isMetersAvailable()).thenReturn(true);
-        when(mockedDeviceState.isPortStatisticsAvailable()).thenReturn(true);
-        when(mockedDeviceState.isQueueStatisticsAvailable()).thenReturn(true);
+        when(mockedDeviceState.isTableStatisticsAvailable()).thenReturn(Boolean.TRUE);
+        when(mockedDeviceState.isFlowStatisticsAvailable()).thenReturn(Boolean.TRUE);
+        when(mockedDeviceState.isGroupAvailable()).thenReturn(Boolean.TRUE);
+        when(mockedDeviceState.isMetersAvailable()).thenReturn(Boolean.TRUE);
+        when(mockedDeviceState.isPortStatisticsAvailable()).thenReturn(Boolean.TRUE);
+        when(mockedDeviceState.isQueueStatisticsAvailable()).thenReturn(Boolean.TRUE);
+        when(mockedDeviceInfo.getNodeInstanceIdentifier()).thenReturn(DUMMY_NODE_ID);
         initStatisticsContext();
 
-        when(mockedStatisticsGatheringService.getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
-                .thenReturn(
-                        Futures.immediateFuture(RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build())
-                );
-        when(mockedStatisticsOnFlyGatheringService.getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
-                .thenReturn(
-                        Futures.immediateFuture(RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build())
-                );
-
-        final ListenableFuture<Boolean> gatheringResult = statisticsContext.gatherDynamicData();
-        Assert.assertTrue(gatheringResult.isDone());
-        Assert.assertTrue(gatheringResult.get());
+        when(mockedStatisticsGatheringService
+                     .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
+                .thenReturn(Futures.immediateFuture(
+                        RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build()));
+        when(mockedStatisticsOnFlyGatheringService
+                     .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
+                .thenReturn(Futures.immediateFuture(
+                        RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build()));
+
+        statisticsContext.registerMastershipWatcher(mockedMastershipWatcher);
+        statisticsContext.setStatisticsGatheringService(mockedStatisticsGatheringService);
+        statisticsContext.setStatisticsGatheringOnTheFlyService(mockedStatisticsOnFlyGatheringService);
+        statisticsContext.instantiateServiceInstance();
+
         verify(mockedStatisticsGatheringService, times(7))
                 .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class));
         verify(mockedStatisticsOnFlyGatheringService)
                 .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class));
         Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService);
     }
-
-    @Test
-    public void testDeviceConnectionCheck_WORKING() throws Exception {
-        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
-        Assert.assertNull(deviceConnectionCheckResult);
-    }
-
-    @Test
-    public void testDeviceConnectionCheck_RIP() throws Exception {
-        Mockito.reset(mockedConnectionContext);
-        when(mockedConnectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.RIP);
-        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
-        Assert.assertNotNull(deviceConnectionCheckResult);
-        Assert.assertTrue(deviceConnectionCheckResult.isDone());
-        try {
-            deviceConnectionCheckResult.get();
-            Assert.fail("connection in state RIP should have caused exception here");
-        } catch (Exception e) {
-            LOG.debug("expected behavior for RIP connection achieved");
-            Assert.assertTrue(e instanceof ExecutionException);
-        }
-    }
-
-    @Test
-    public void testDeviceConnectionCheck_HANSHAKING() throws Exception {
-        Mockito.reset(mockedConnectionContext);
-        when(mockedConnectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.HANDSHAKING);
-        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
-        Assert.assertNotNull(deviceConnectionCheckResult);
-        Assert.assertTrue(deviceConnectionCheckResult.isDone());
-        try {
-            final Boolean checkPositive = deviceConnectionCheckResult.get();
-            Assert.assertTrue(checkPositive);
-        } catch (Exception e) {
-            Assert.fail("connection in state HANDSHAKING should NOT have caused exception here");
-        }
-    }
 }