Merge "Fix issues related to checkstyle enforcement on openflow-impl module"

[openflowplugin.git] / openflowplugin-impl / src / test / java / org / opendaylight / openflowplugin / impl / statistics / StatisticsContextImplTest.java

diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java
index 30adeaf2f94bada7a0d81ccca38abbb65ee74ef4..cebe9bfb2c0cbccbeaeab6b7c13a0b29c69ce0d6 100644 (file)
--- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java
+++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java
@@ -15,9 +15,8 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.MoreExecutors;
 import java.util.Collections;
-import java.util.concurrent.ExecutionException;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -25,7 +24,6 @@ import org.junit.runner.RunWith;
 import org.mockito.Matchers;
 import org.mockito.Mockito;
 import org.mockito.runners.MockitoJUnitRunner;
-import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContext;
 import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.EventIdentifier;
 import org.opendaylight.openflowplugin.impl.datastore.MultipartWriterProviderFactory;
@@ -56,9 +54,11 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
     }
 
     private void initStatisticsContext() {
-        statisticsContext = new StatisticsContextImpl<MultipartReply>(
-                true, mockedDeviceContext, convertorManager, mockedStatisticsManager,
-                MultipartWriterProviderFactory.createDefaultProvider(mockedDeviceContext));
+        statisticsContext = new StatisticsContextImpl<>(mockedDeviceContext, convertorManager,
+                                                        MultipartWriterProviderFactory
+                                                                .createDefaultProvider(mockedDeviceContext),
+                                                        MoreExecutors.newDirectExecutorService(), true, false, 3000,
+                                                        50000);
 
         statisticsContext.setStatisticsGatheringService(mockedStatisticsGatheringService);
         statisticsContext.setStatisticsGatheringOnTheFlyService(mockedStatisticsOnFlyGatheringService);
@@ -73,13 +73,20 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
     }
 
     /**
-     * There is nothing to check in close method
+     * There is nothing to check in close method.
      */
     @Test
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public void testClose() throws Exception {
-        final StatisticsContextImpl<MultipartReply> statisticsContext = new StatisticsContextImpl<MultipartReply>(
-                true, mockedDeviceContext, convertorManager, mockedStatisticsManager,
-                MultipartWriterProviderFactory.createDefaultProvider(mockedDeviceContext));
+        final StatisticsContextImpl<MultipartReply> statisticsContext =
+                new StatisticsContextImpl<>(mockedDeviceContext,
+                                            convertorManager,
+                                            MultipartWriterProviderFactory
+                                                    .createDefaultProvider(mockedDeviceContext),
+                                            MoreExecutors.newDirectExecutorService(),
+                                            true,
+                                            false,
+                                            3000,50000);
 
         final RequestContext<Object> requestContext = statisticsContext.createRequestContext();
         statisticsContext.close();
@@ -96,9 +103,7 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
 
     @Test
     public void testGatherDynamicData_none() throws Exception {
-        final ListenableFuture<Boolean> gatheringResult = statisticsContext.gatherDynamicData();
-        Assert.assertTrue(gatheringResult.isDone());
-        Assert.assertTrue(gatheringResult.get());
+        statisticsContext.instantiateServiceInstance();
         Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService);
     }
 
@@ -111,62 +116,27 @@ public class StatisticsContextImplTest extends StatisticsContextImpMockInitiatio
         when(mockedDeviceState.isMetersAvailable()).thenReturn(Boolean.TRUE);
         when(mockedDeviceState.isPortStatisticsAvailable()).thenReturn(Boolean.TRUE);
         when(mockedDeviceState.isQueueStatisticsAvailable()).thenReturn(Boolean.TRUE);
-        when(mockedDeviceInfo.getNodeInstanceIdentifier()).thenReturn(dummyNodeII);
+        when(mockedDeviceInfo.getNodeInstanceIdentifier()).thenReturn(DUMMY_NODE_ID);
         initStatisticsContext();
 
-        when(mockedStatisticsGatheringService.getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
-                .thenReturn(
-                        Futures.immediateFuture(RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build())
-                );
-        when(mockedStatisticsOnFlyGatheringService.getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
-                .thenReturn(
-                        Futures.immediateFuture(RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build())
-                );
-
-        final ListenableFuture<Boolean> gatheringResult = statisticsContext.gatherDynamicData();
-        Assert.assertTrue(gatheringResult.isDone());
-        Assert.assertTrue(gatheringResult.get());
+        when(mockedStatisticsGatheringService
+                     .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
+                .thenReturn(Futures.immediateFuture(
+                        RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build()));
+        when(mockedStatisticsOnFlyGatheringService
+                     .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
+                .thenReturn(Futures.immediateFuture(
+                        RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build()));
+
+        statisticsContext.registerMastershipWatcher(mockedMastershipWatcher);
+        statisticsContext.setStatisticsGatheringService(mockedStatisticsGatheringService);
+        statisticsContext.setStatisticsGatheringOnTheFlyService(mockedStatisticsOnFlyGatheringService);
+        statisticsContext.instantiateServiceInstance();
+
         verify(mockedStatisticsGatheringService, times(7))
                 .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class));
         verify(mockedStatisticsOnFlyGatheringService)
                 .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class));
         Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService);
     }
-
-    @Test
-    public void testDeviceConnectionCheck_WORKING() throws Exception {
-        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
-        Assert.assertNull(deviceConnectionCheckResult);
-    }
-
-    @Test
-    public void testDeviceConnectionCheck_RIP() throws Exception {
-        Mockito.reset(mockedConnectionContext);
-        when(mockedConnectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.RIP);
-        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
-        Assert.assertNotNull(deviceConnectionCheckResult);
-        Assert.assertTrue(deviceConnectionCheckResult.isDone());
-        try {
-            deviceConnectionCheckResult.get();
-            Assert.fail("connection in state RIP should have caused exception here");
-        } catch (final Exception e) {
-            LOG.debug("expected behavior for RIP connection achieved");
-            Assert.assertTrue(e instanceof ExecutionException);
-        }
-    }
-
-    @Test
-    public void testDeviceConnectionCheck_HANSHAKING() throws Exception {
-        Mockito.reset(mockedConnectionContext);
-        when(mockedConnectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.HANDSHAKING);
-        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
-        Assert.assertNotNull(deviceConnectionCheckResult);
-        Assert.assertTrue(deviceConnectionCheckResult.isDone());
-        try {
-            final Boolean checkPositive = deviceConnectionCheckResult.get();
-            Assert.assertTrue(checkPositive);
-        } catch (final Exception e) {
-            Assert.fail("connection in state HANDSHAKING should NOT have caused exception here");
-        }
-    }
 }