/*
- * Copyright (C) 2014 SDN Hub, LLC.
+ * Copyright (c) 2014, 2015 SDN Hub, LLC. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
- *
- * Authors : Srini Seetharaman
*/
package org.opendaylight.ovsdb.openstack.netvirt;
-import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerAware;
-import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerPoolCRUD;
-import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerPoolMemberCRUD;
-import org.opendaylight.controller.networkconfig.neutron.INeutronPortCRUD;
-import org.opendaylight.controller.networkconfig.neutron.NeutronLoadBalancer;
-import org.opendaylight.controller.networkconfig.neutron.NeutronLoadBalancerPool;
-import org.opendaylight.controller.networkconfig.neutron.NeutronLoadBalancerPoolMember;
-import org.opendaylight.controller.networkconfig.neutron.NeutronPort;
-import org.opendaylight.controller.networkconfig.neutron.Neutron_IPs;
-import org.opendaylight.controller.sal.core.Node;
-import org.opendaylight.controller.switchmanager.ISwitchManager;
+import java.net.HttpURLConnection;
+import java.util.List;
+import java.util.Map;
+
+import org.opendaylight.neutron.spi.INeutronLoadBalancerAware;
+import org.opendaylight.neutron.spi.INeutronLoadBalancerCRUD;
+import org.opendaylight.neutron.spi.INeutronLoadBalancerPoolCRUD;
+import org.opendaylight.neutron.spi.INeutronNetworkCRUD;
+import org.opendaylight.neutron.spi.INeutronPortCRUD;
+import org.opendaylight.neutron.spi.INeutronSubnetCRUD;
+import org.opendaylight.neutron.spi.NeutronLoadBalancer;
+import org.opendaylight.neutron.spi.NeutronLoadBalancerPool;
+import org.opendaylight.neutron.spi.NeutronLoadBalancerPoolMember;
import org.opendaylight.ovsdb.openstack.netvirt.api.Action;
+import org.opendaylight.ovsdb.openstack.netvirt.api.EventDispatcher;
import org.opendaylight.ovsdb.openstack.netvirt.api.LoadBalancerConfiguration;
import org.opendaylight.ovsdb.openstack.netvirt.api.LoadBalancerProvider;
+import org.opendaylight.ovsdb.openstack.netvirt.api.NodeCacheListener;
+import org.opendaylight.ovsdb.openstack.netvirt.api.NodeCacheManager;
+import org.opendaylight.ovsdb.utils.servicehelper.ServiceHelper;
+import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.ServiceReference;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.google.common.base.Preconditions;
-import java.net.HttpURLConnection;
-import java.util.Iterator;
-import java.util.List;
-
/**
* Handle requests for OpenStack Neutron v2.0 LBaaS API calls for /v2.0/loadbalancers.
*/
//TODO: Implement INeutronLoadBalancerHealthMonitorAware, INeutronLoadBalancerListenerAware, INeutronLoadBalancerPoolMemberAware,
public class LBaaSHandler extends AbstractHandler
- implements INeutronLoadBalancerAware {
-
- private static final Logger logger = LoggerFactory.getLogger(LBaaSHandler.class);
+ implements INeutronLoadBalancerAware, ConfigInterface, NodeCacheListener {
+ private static final Logger LOG = LoggerFactory.getLogger(LBaaSHandler.class);
// The implementation for each of these services is resolved by the OSGi Service Manager
+ private volatile INeutronLoadBalancerCRUD neutronLBCache;
private volatile INeutronLoadBalancerPoolCRUD neutronLBPoolCache;
- private volatile INeutronLoadBalancerPoolMemberCRUD neutronLBPoolMemberCache;
- private volatile INeutronPortCRUD neutronPortsCache;
+ private volatile INeutronPortCRUD neutronPortCache;
+ private volatile INeutronNetworkCRUD neutronNetworkCache;
+ private volatile INeutronSubnetCRUD neutronSubnetCache;
private volatile LoadBalancerProvider loadBalancerProvider;
- private volatile ISwitchManager switchManager;
+ private volatile NodeCacheManager nodeCacheManager;
+
+ @Override
+ public int canCreateNeutronLoadBalancer(NeutronLoadBalancer neutronLB) {
+ //Always allowed and not wait for pool and members to be created
+ return HttpURLConnection.HTTP_OK;
+ }
@Override
- public int canCreateNeutronLoadBalancer(NeutronLoadBalancer neutronLoadBalancer) {
- LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLoadBalancer);
- if (!lbConfig.isValid())
- return HttpURLConnection.HTTP_NOT_ACCEPTABLE;
- else
- return HttpURLConnection.HTTP_OK;
+ public void neutronLoadBalancerCreated(NeutronLoadBalancer neutronLB) {
+ LOG.debug("Neutron LB Creation : {}", neutronLB.toString());
+ enqueueEvent(new NorthboundEvent(neutronLB, Action.ADD));
}
/**
* we go with creating the LoadBalancerConfiguration object for this call with
* all information that is necessary to insert flow_mods
*/
- @Override
- public void neutronLoadBalancerCreated(NeutronLoadBalancer neutronLoadBalancer) {
- logger.debug("Neutron LB Creation : {}", neutronLoadBalancer.toString());
- enqueueEvent(new NorthboundEvent(neutronLoadBalancer, Action.ADD));
- }
-
- private void doNeutronLoadBalancerCreate(NeutronLoadBalancer neutronLoadBalancer) {
- int result = canCreateNeutronLoadBalancer(neutronLoadBalancer);
- if (result != HttpURLConnection.HTTP_OK) {
- logger.debug("Neutron Load Balancer creation failed {} ", result);
- return;
- }
+ private void doNeutronLoadBalancerCreate(NeutronLoadBalancer neutronLB) {
Preconditions.checkNotNull(loadBalancerProvider);
- LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLoadBalancer);
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+ final List<Node> nodes = nodeCacheManager.getBridgeNodes();
if (!lbConfig.isValid()) {
- logger.trace("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
- return;
+ LOG.debug("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
+ } else if (nodes.isEmpty()) {
+ LOG.debug("Noop with LB {} creation because no nodes available.", lbConfig.getName());
} else {
- for (Node node: this.switchManager.getNodes())
+ for (Node node : nodes) {
loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.ADD);
+ }
}
}
@Override
public int canUpdateNeutronLoadBalancer(NeutronLoadBalancer delta, NeutronLoadBalancer original) {
+ //Update allowed anytime, even when the LB has no active pool yet
return HttpURLConnection.HTTP_OK;
}
@Override
- public void neutronLoadBalancerUpdated(NeutronLoadBalancer neutronLoadBalancer) {
- enqueueEvent(new NorthboundEvent(neutronLoadBalancer, Action.UPDATE));
- return;
+ public void neutronLoadBalancerUpdated(NeutronLoadBalancer neutronLB) {
+ LOG.debug("Neutron LB Update : {}", neutronLB.toString());
+ enqueueEvent(new NorthboundEvent(neutronLB, Action.UPDATE));
}
@Override
- public int canDeleteNeutronLoadBalancer(NeutronLoadBalancer neutronLoadBalancer) {
- LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLoadBalancer);
- if (!lbConfig.isValid())
- return HttpURLConnection.HTTP_NOT_ACCEPTABLE;
- else
- return HttpURLConnection.HTTP_OK;
+ public int canDeleteNeutronLoadBalancer(NeutronLoadBalancer neutronLB) {
+ //Always allowed and not wait for pool to stop using it
+ return HttpURLConnection.HTTP_OK;
}
@Override
- public void neutronLoadBalancerDeleted(NeutronLoadBalancer neutronLoadBalancer) {
- logger.debug("Neutron LB Deletion : {}", neutronLoadBalancer.toString());
- enqueueEvent(new NorthboundEvent(neutronLoadBalancer, Action.DELETE));
+ public void neutronLoadBalancerDeleted(NeutronLoadBalancer neutronLB) {
+ LOG.debug("Neutron LB Deletion : {}", neutronLB.toString());
+ enqueueEvent(new NorthboundEvent(neutronLB, Action.DELETE));
}
- private void doNeutronLoadBalancerDelete(NeutronLoadBalancer neutronLoadBalancer) {
- int result = canDeleteNeutronLoadBalancer(neutronLoadBalancer);
- if (result != HttpURLConnection.HTTP_OK) {
- logger.error(" delete Neutron NeutronLoadBalancer Pool validation failed for result - {} ", result);
- return;
- }
+ private void doNeutronLoadBalancerDelete(NeutronLoadBalancer neutronLB) {
Preconditions.checkNotNull(loadBalancerProvider);
- LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLoadBalancer);
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+ final List<Node> nodes = nodeCacheManager.getBridgeNodes();
if (!lbConfig.isValid()) {
- logger.trace("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
- return;
+ LOG.debug("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
+ } else if (nodes.isEmpty()) {
+ LOG.debug("Noop with LB {} deletion because no nodes available.", lbConfig.getName());
} else {
- for (Node node: this.switchManager.getNodes())
+ for (Node node : nodes) {
loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.DELETE);
+ }
}
}
*/
@Override
public void processEvent(AbstractEvent abstractEvent) {
+ LOG.debug("Processing Loadbalancer event {}", abstractEvent);
if (!(abstractEvent instanceof NorthboundEvent)) {
- logger.error("Unable to process abstract event " + abstractEvent);
+ LOG.error("Unable to process abstract event {}", abstractEvent);
return;
}
NorthboundEvent ev = (NorthboundEvent) abstractEvent;
switch (ev.getAction()) {
case ADD:
doNeutronLoadBalancerCreate(ev.getLoadBalancer());
+ break;
case DELETE:
doNeutronLoadBalancerDelete(ev.getLoadBalancer());
+ break;
case UPDATE:
/**
* Currently member update requires delete and re-adding
doNeutronLoadBalancerCreate(ev.getLoadBalancer());
break;
default:
- logger.warn("Unable to process event action " + ev.getAction());
+ LOG.warn("Unable to process event action {}", ev.getAction());
break;
}
}
* Useful utility for extracting the loadbalancer instance
* configuration from the neutron LB cache
*/
- public LoadBalancerConfiguration extractLBConfiguration(NeutronLoadBalancer neutronLoadBalancer) {
- String loadBalancerName = neutronLoadBalancer.getLoadBalancerName();
- String loadBalancerVip = neutronLoadBalancer.getLoadBalancerVipAddress();
- String loadBalancerSubnetID = neutronLoadBalancer.getLoadBalancerVipSubnetID();
- LoadBalancerConfiguration lbConfig = new LoadBalancerConfiguration(loadBalancerName, loadBalancerVip);
+ public LoadBalancerConfiguration extractLBConfiguration(NeutronLoadBalancer neutronLB) {
+ String loadBalancerName = neutronLB.getLoadBalancerName();
+ String loadBalancerVip = neutronLB.getLoadBalancerVipAddress();
+ String loadBalancerSubnetID = neutronLB.getLoadBalancerVipSubnetID();
- String memberID, memberIP, memberMAC, memberProtocol;
- Integer memberPort;
+ LoadBalancerConfiguration lbConfig = new LoadBalancerConfiguration(loadBalancerName, loadBalancerVip);
+ Map.Entry<String,String> providerInfo =
+ NeutronCacheUtils.getProviderInformation(neutronNetworkCache, neutronSubnetCache, loadBalancerSubnetID);
+ if (providerInfo != null) {
+ lbConfig.setProviderNetworkType(providerInfo.getKey());
+ lbConfig.setProviderSegmentationId(providerInfo.getValue());
+ }
+ lbConfig.setVmac(NeutronCacheUtils.getMacAddress(neutronPortCache, loadBalancerSubnetID, loadBalancerVip));
for (NeutronLoadBalancerPool neutronLBPool: neutronLBPoolCache.getAllNeutronLoadBalancerPools()) {
- List<? extends NeutronLoadBalancerPoolMember> members =
- (List<? extends NeutronLoadBalancerPoolMember>)neutronLBPool.getLoadBalancerPoolMembers();
- memberProtocol = neutronLBPool.getLoadBalancerPoolProtocol();
- /*
- * Only HTTP and HTTPS are supported as of this version
- * TODO: Support all TCP load-balancers
- */
- if (!(memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTP) ||
- memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTPS)))
+ List<NeutronLoadBalancerPoolMember> members = neutronLBPool.getLoadBalancerPoolMembers();
+ String memberProtocol = neutronLBPool.getLoadBalancerPoolProtocol();
+ if (memberProtocol == null) {
+ continue;
+ }
+
+ if (!(memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_TCP) ||
+ memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTP) ||
+ memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTPS))) {
continue;
+ }
for (NeutronLoadBalancerPoolMember neutronLBPoolMember: members) {
- if (neutronLBPoolMember.getPoolMemberSubnetID().equals(loadBalancerSubnetID)) {
- memberID = neutronLBPoolMember.getPoolMemberID();
- memberIP = neutronLBPoolMember.getPoolMemberAddress();
- memberPort = neutronLBPoolMember.getPoolMemberProtoPort();
- memberMAC = this.getMacAddress(memberIP);
- if (memberMAC == null)
+ Boolean memberAdminStateIsUp = neutronLBPoolMember.getPoolMemberAdminStateIsUp();
+ String memberSubnetID = neutronLBPoolMember.getPoolMemberSubnetID();
+ if (memberSubnetID != null && memberAdminStateIsUp != null &&
+ memberSubnetID.equals(loadBalancerSubnetID) && memberAdminStateIsUp) {
+ String memberID = neutronLBPoolMember.getID();
+ String memberIP = neutronLBPoolMember.getPoolMemberAddress();
+ Integer memberPort = neutronLBPoolMember.getPoolMemberProtoPort();
+ if (memberID == null || memberIP == null || memberPort == null) {
+ LOG.debug("Neutron LB pool member details incomplete: {}", neutronLBPoolMember);
continue;
+ }
+ String memberMAC = NeutronCacheUtils.getMacAddress(neutronPortCache, memberSubnetID, memberIP);
+ if (memberMAC == null) {
+ continue;
+ }
lbConfig.addMember(memberID, memberIP, memberMAC, memberProtocol, memberPort);
}
}
}
/**
- * Look up in the NeutronPortsCRUD cache and return the MAC address for a corresponding IP address
- * @param ipAddr IP address of a member or VM
- * @return MAC address registered with that IP address
+ * On the addition of a new node, we iterate through all existing loadbalancer
+ * instances and program the node for all of them. It is sufficient to do that only
+ * when a node is added, and only for the LB instances (and not individual members).
*/
- public String getMacAddress(String ipAddr) {
- List<Neutron_IPs> fixedIPs;
- Iterator<Neutron_IPs> fixedIPIterator;
- Neutron_IPs ip;
-
- List<NeutronPort> allPorts = neutronPortsCache.getAllPorts();
- Iterator<NeutronPort> i = allPorts.iterator();
- while (i.hasNext()) {
- NeutronPort port = i.next();
- fixedIPs = port.getFixedIPs();
- if (fixedIPs != null && fixedIPs.size() > 0) {
- fixedIPIterator = fixedIPs.iterator();
- while (fixedIPIterator.hasNext()) {
- ip = fixedIPIterator.next();
- if (ip.getIpAddress().equals(ipAddr))
- return port.getMacAddress();
- }
- }
- }
- return null;
+ @Override
+ public void notifyNode(Node node, Action type) {
+ LOG.debug("notifyNode: Node {} update {} from Controller's inventory Service", node, type);
+ Preconditions.checkNotNull(loadBalancerProvider);
+
+ for (NeutronLoadBalancer neutronLB: neutronLBCache.getAllNeutronLoadBalancers()) {
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+ if (!lbConfig.isValid()) {
+ LOG.debug("Neutron LB configuration invalid for {} ", lbConfig.getName());
+ } else {
+ if (type.equals(Action.ADD)) {
+ loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.ADD);
+
+ /* When node disappears, we do nothing for now. Making a call to
+ * loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.DELETE)
+ * can lead to TransactionCommitFailedException. Similarly when node is changed,
+ * because of remove followed by add, we do nothing.
+ */
+
+ //(type.equals(UpdateType.REMOVED) || type.equals(UpdateType.CHANGED))
+ }
+ }
+ }
+ }
+
+ @Override
+ public void setDependencies(BundleContext bundleContext, ServiceReference serviceReference) {
+ loadBalancerProvider =
+ (LoadBalancerProvider) ServiceHelper.getGlobalInstance(LoadBalancerProvider.class, this);
+ nodeCacheManager =
+ (NodeCacheManager) ServiceHelper.getGlobalInstance(NodeCacheManager.class, this);
+ nodeCacheManager.cacheListenerAdded(
+ bundleContext.getServiceReference(INeutronLoadBalancerAware.class.getName()), this);
+ eventDispatcher =
+ (EventDispatcher) ServiceHelper.getGlobalInstance(EventDispatcher.class, this);
+ eventDispatcher.eventHandlerAdded(
+ bundleContext.getServiceReference(INeutronLoadBalancerAware.class.getName()), this);
+ }
+
+ @Override
+ public void setDependencies(Object impl) {
+ if (impl instanceof INeutronNetworkCRUD) {
+ neutronNetworkCache = (INeutronNetworkCRUD)impl;
+ } else if (impl instanceof INeutronPortCRUD) {
+ neutronPortCache = (INeutronPortCRUD)impl;
+ } else if (impl instanceof INeutronSubnetCRUD) {
+ neutronSubnetCache = (INeutronSubnetCRUD)impl;
+ } else if (impl instanceof INeutronLoadBalancerCRUD) {
+ neutronLBCache = (INeutronLoadBalancerCRUD)impl;
+ } else if (impl instanceof INeutronLoadBalancerPoolCRUD) {
+ neutronLBPoolCache = (INeutronLoadBalancerPoolCRUD)impl;
+ } else if (impl instanceof LoadBalancerProvider) {
+ loadBalancerProvider = (LoadBalancerProvider)impl;
+ }
}
}
Code Review / netvirt.git / blobdiff