/*
- * Copyright (C) 2014 SDN Hub, LLC.
+ * Copyright (c) 2014, 2015 SDN Hub, LLC. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
- *
- * Authors : Srini Seetharaman
*/
package org.opendaylight.ovsdb.openstack.netvirt;
+import java.net.HttpURLConnection;
+import java.util.List;
+import java.util.Map;
+
import org.opendaylight.neutron.spi.INeutronLoadBalancerAware;
import org.opendaylight.neutron.spi.INeutronLoadBalancerCRUD;
import org.opendaylight.neutron.spi.INeutronLoadBalancerPoolCRUD;
import org.opendaylight.ovsdb.openstack.netvirt.api.EventDispatcher;
import org.opendaylight.ovsdb.openstack.netvirt.api.LoadBalancerConfiguration;
import org.opendaylight.ovsdb.openstack.netvirt.api.LoadBalancerProvider;
-import org.opendaylight.ovsdb.openstack.netvirt.api.NodeCacheManager;
import org.opendaylight.ovsdb.openstack.netvirt.api.NodeCacheListener;
+import org.opendaylight.ovsdb.openstack.netvirt.api.NodeCacheManager;
import org.opendaylight.ovsdb.utils.servicehelper.ServiceHelper;
import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node;
import org.osgi.framework.BundleContext;
import com.google.common.base.Preconditions;
-import java.net.HttpURLConnection;
-import java.util.List;
-import java.util.Map;
-
/**
* Handle requests for OpenStack Neutron v2.0 LBaaS API calls for /v2.0/loadbalancers.
*/
public class LBaaSHandler extends AbstractHandler
implements INeutronLoadBalancerAware, ConfigInterface, NodeCacheListener {
- private static final Logger logger = LoggerFactory.getLogger(LBaaSHandler.class);
+ private static final Logger LOG = LoggerFactory.getLogger(LBaaSHandler.class);
// The implementation for each of these services is resolved by the OSGi Service Manager
private volatile INeutronLoadBalancerCRUD neutronLBCache;
private volatile INeutronSubnetCRUD neutronSubnetCache;
private volatile LoadBalancerProvider loadBalancerProvider;
private volatile NodeCacheManager nodeCacheManager;
- private volatile EventDispatcher eventDispatcher;
@Override
public int canCreateNeutronLoadBalancer(NeutronLoadBalancer neutronLB) {
@Override
public void neutronLoadBalancerCreated(NeutronLoadBalancer neutronLB) {
- logger.debug("Neutron LB Creation : {}", neutronLB.toString());
+ LOG.debug("Neutron LB Creation : {}", neutronLB.toString());
enqueueEvent(new NorthboundEvent(neutronLB, Action.ADD));
}
final List<Node> nodes = nodeCacheManager.getBridgeNodes();
if (!lbConfig.isValid()) {
- logger.debug("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
+ LOG.debug("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
} else if (nodes.isEmpty()) {
- logger.debug("Noop with LB {} creation because no nodes available.", lbConfig.getName());
+ LOG.debug("Noop with LB {} creation because no nodes available.", lbConfig.getName());
} else {
for (Node node : nodes) {
loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.ADD);
@Override
public void neutronLoadBalancerUpdated(NeutronLoadBalancer neutronLB) {
- logger.debug("Neutron LB Update : {}", neutronLB.toString());
+ LOG.debug("Neutron LB Update : {}", neutronLB.toString());
enqueueEvent(new NorthboundEvent(neutronLB, Action.UPDATE));
}
@Override
public void neutronLoadBalancerDeleted(NeutronLoadBalancer neutronLB) {
- logger.debug("Neutron LB Deletion : {}", neutronLB.toString());
+ LOG.debug("Neutron LB Deletion : {}", neutronLB.toString());
enqueueEvent(new NorthboundEvent(neutronLB, Action.DELETE));
}
final List<Node> nodes = nodeCacheManager.getBridgeNodes();
if (!lbConfig.isValid()) {
- logger.debug("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
+ LOG.debug("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
} else if (nodes.isEmpty()) {
- logger.debug("Noop with LB {} deletion because no nodes available.", lbConfig.getName());
+ LOG.debug("Noop with LB {} deletion because no nodes available.", lbConfig.getName());
} else {
for (Node node : nodes) {
loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.DELETE);
*/
@Override
public void processEvent(AbstractEvent abstractEvent) {
- logger.debug("Processing Loadbalancer event " + abstractEvent);
+ LOG.debug("Processing Loadbalancer event {}", abstractEvent);
if (!(abstractEvent instanceof NorthboundEvent)) {
- logger.error("Unable to process abstract event " + abstractEvent);
+ LOG.error("Unable to process abstract event {}", abstractEvent);
return;
}
NorthboundEvent ev = (NorthboundEvent) abstractEvent;
doNeutronLoadBalancerCreate(ev.getLoadBalancer());
break;
default:
- logger.warn("Unable to process event action " + ev.getAction());
+ LOG.warn("Unable to process event action {}", ev.getAction());
break;
}
}
}
lbConfig.setVmac(NeutronCacheUtils.getMacAddress(neutronPortCache, loadBalancerSubnetID, loadBalancerVip));
- String memberID, memberIP, memberMAC, memberProtocol, memberSubnetID;
- Integer memberPort;
- Boolean memberAdminStateIsUp;
-
for (NeutronLoadBalancerPool neutronLBPool: neutronLBPoolCache.getAllNeutronLoadBalancerPools()) {
List<NeutronLoadBalancerPoolMember> members = neutronLBPool.getLoadBalancerPoolMembers();
- memberProtocol = neutronLBPool.getLoadBalancerPoolProtocol();
+ String memberProtocol = neutronLBPool.getLoadBalancerPoolProtocol();
if (memberProtocol == null) {
continue;
}
continue;
}
for (NeutronLoadBalancerPoolMember neutronLBPoolMember: members) {
- memberAdminStateIsUp = neutronLBPoolMember.getPoolMemberAdminStateIsUp();
- memberSubnetID = neutronLBPoolMember.getPoolMemberSubnetID();
- if (memberSubnetID == null || memberAdminStateIsUp == null) {
- continue;
- }
- else if (memberSubnetID.equals(loadBalancerSubnetID) && memberAdminStateIsUp.booleanValue()) {
- memberID = neutronLBPoolMember.getPoolMemberID();
- memberIP = neutronLBPoolMember.getPoolMemberAddress();
- memberPort = neutronLBPoolMember.getPoolMemberProtoPort();
- if (memberSubnetID == null || memberID == null || memberIP == null || memberPort == null) {
- logger.debug("Neutron LB pool member details incomplete: {}", neutronLBPoolMember);
+ Boolean memberAdminStateIsUp = neutronLBPoolMember.getPoolMemberAdminStateIsUp();
+ String memberSubnetID = neutronLBPoolMember.getPoolMemberSubnetID();
+ if (memberSubnetID != null && memberAdminStateIsUp != null &&
+ memberSubnetID.equals(loadBalancerSubnetID) && memberAdminStateIsUp) {
+ String memberID = neutronLBPoolMember.getID();
+ String memberIP = neutronLBPoolMember.getPoolMemberAddress();
+ Integer memberPort = neutronLBPoolMember.getPoolMemberProtoPort();
+ if (memberID == null || memberIP == null || memberPort == null) {
+ LOG.debug("Neutron LB pool member details incomplete: {}", neutronLBPoolMember);
continue;
}
- memberMAC = NeutronCacheUtils.getMacAddress(neutronPortCache, memberSubnetID, memberIP);
+ String memberMAC = NeutronCacheUtils.getMacAddress(neutronPortCache, memberSubnetID, memberIP);
if (memberMAC == null) {
continue;
}
*/
@Override
public void notifyNode(Node node, Action type) {
- logger.debug("notifyNode: Node {} update {} from Controller's inventory Service", node, type);
+ LOG.debug("notifyNode: Node {} update {} from Controller's inventory Service", node, type);
Preconditions.checkNotNull(loadBalancerProvider);
for (NeutronLoadBalancer neutronLB: neutronLBCache.getAllNeutronLoadBalancers()) {
LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
if (!lbConfig.isValid()) {
- logger.debug("Neutron LB configuration invalid for {} ", lbConfig.getName());
+ LOG.debug("Neutron LB configuration invalid for {} ", lbConfig.getName());
} else {
if (type.equals(Action.ADD)) {
loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.ADD);
*/
//(type.equals(UpdateType.REMOVED) || type.equals(UpdateType.CHANGED))
- } else {
- continue;
}
}
}
(EventDispatcher) ServiceHelper.getGlobalInstance(EventDispatcher.class, this);
eventDispatcher.eventHandlerAdded(
bundleContext.getServiceReference(INeutronLoadBalancerAware.class.getName()), this);
- super.setDispatcher(eventDispatcher);
}
@Override
Code Review / netvirt.git / blobdiff