package org.opendaylight.ovsdb.openstack.netvirt;
import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerAware;
+import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerCRUD;
import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerPoolCRUD;
import org.opendaylight.controller.networkconfig.neutron.INeutronLoadBalancerPoolMemberCRUD;
import org.opendaylight.controller.networkconfig.neutron.INeutronPortCRUD;
import org.opendaylight.controller.networkconfig.neutron.NeutronLoadBalancer;
import org.opendaylight.controller.networkconfig.neutron.NeutronLoadBalancerPool;
import org.opendaylight.controller.networkconfig.neutron.NeutronLoadBalancerPoolMember;
-import org.opendaylight.controller.networkconfig.neutron.NeutronPort;
-import org.opendaylight.controller.networkconfig.neutron.Neutron_IPs;
+import org.opendaylight.controller.sal.core.Node;
+import org.opendaylight.controller.sal.core.NodeConnector;
+import org.opendaylight.controller.sal.core.Property;
+import org.opendaylight.controller.sal.core.UpdateType;
+import org.opendaylight.controller.switchmanager.IInventoryListener;
+import org.opendaylight.controller.switchmanager.ISwitchManager;
import org.opendaylight.ovsdb.openstack.netvirt.api.Action;
import org.opendaylight.ovsdb.openstack.netvirt.api.LoadBalancerConfiguration;
+import org.opendaylight.ovsdb.openstack.netvirt.api.LoadBalancerProvider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.collect.Maps;
+import com.google.common.base.Preconditions;
import java.net.HttpURLConnection;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
//TODO: Implement INeutronLoadBalancerHealthMonitorAware, INeutronLoadBalancerListenerAware, INeutronLoadBalancerPoolMemberAware,
public class LBaaSHandler extends AbstractHandler
- implements INeutronLoadBalancerAware {
+ implements INeutronLoadBalancerAware, IInventoryListener {
private static final Logger logger = LoggerFactory.getLogger(LBaaSHandler.class);
// The implementation for each of these services is resolved by the OSGi Service Manager
+ private volatile INeutronLoadBalancerCRUD neutronLBCache;
private volatile INeutronLoadBalancerPoolCRUD neutronLBPoolCache;
private volatile INeutronLoadBalancerPoolMemberCRUD neutronLBPoolMemberCache;
private volatile INeutronPortCRUD neutronPortsCache;
- private Map<String, LoadBalancerConfiguration> loadbalancersCache = Maps.newHashMap();
+ private volatile LoadBalancerProvider loadBalancerProvider;
+ private volatile ISwitchManager switchManager;
@Override
- public int canCreateNeutronLoadBalancer(NeutronLoadBalancer neutronLoadBalancer) {
- if (loadbalancersCache.containsKey(neutronLoadBalancer.getLoadBalancerID()))
- return HttpURLConnection.HTTP_CONFLICT;
- return HttpURLConnection.HTTP_OK;
+ public int canCreateNeutronLoadBalancer(NeutronLoadBalancer neutronLB) {
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+ if (!lbConfig.isValid())
+ return HttpURLConnection.HTTP_NOT_ACCEPTABLE;
+ else
+ return HttpURLConnection.HTTP_OK;
+ }
+
+ @Override
+ public void neutronLoadBalancerCreated(NeutronLoadBalancer neutronLB) {
+ logger.debug("Neutron LB Creation : {}", neutronLB.toString());
+ enqueueEvent(new NorthboundEvent(neutronLB, Action.ADD));
}
/**
* we go with creating the LoadBalancerConfiguration object for this call with
* all information that is necessary to insert flow_mods
*/
- @Override
- public void neutronLoadBalancerCreated(NeutronLoadBalancer neutronLoadBalancer) {
- logger.debug("Neutron LB Creation : {}", neutronLoadBalancer.toString());
- enqueueEvent(new NorthboundEvent(neutronLoadBalancer, Action.ADD));
- }
-
- private void doNeutronLoadBalancerCreate(NeutronLoadBalancer neutronLoadBalancer) {
- int result = canCreateNeutronLoadBalancer(neutronLoadBalancer);
- if (result != HttpURLConnection.HTTP_OK) {
- logger.debug("Neutron Load Balancer creation failed {} ", result);
- return;
- }
-
- String loadBalancerID = neutronLoadBalancer.getLoadBalancerID();
- String loadBalancerName = neutronLoadBalancer.getLoadBalancerName();
- String loadBalancerVip = neutronLoadBalancer.getLoadBalancerVipAddress();
- String loadBalancerSubnetID = neutronLoadBalancer.getLoadBalancerVipSubnetID();
- LoadBalancerConfiguration newLB = new LoadBalancerConfiguration(loadBalancerName, loadBalancerVip);
-
- String memberID, memberIP, memberMAC, memberProtocol;
- Integer memberPort;
-
- for (NeutronLoadBalancerPool neutronLBPool: neutronLBPoolCache.getAllNeutronLoadBalancerPools()) {
- List<? extends NeutronLoadBalancerPoolMember> members =
- (List<? extends NeutronLoadBalancerPoolMember>)neutronLBPool.getLoadBalancerPoolMembers();
- memberProtocol = neutronLBPool.getLoadBalancerPoolProtocol();
- /*
- * Only HTTP and HTTPS are supported as of this version
- * TODO: Support all TCP load-balancers
- */
- if (!(memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTP) ||
- memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTPS)))
- continue;
- for (NeutronLoadBalancerPoolMember neutronLBPoolMember: members) {
- if (neutronLBPoolMember.getPoolMemberSubnetID().equals(loadBalancerSubnetID)) {
- memberID = neutronLBPoolMember.getPoolMemberID();
- memberIP = neutronLBPoolMember.getPoolMemberAddress();
- memberPort = neutronLBPoolMember.getPoolMemberProtoPort();
- memberMAC = this.getMacAddress(memberIP);
- if (memberMAC == null)
- continue;
- newLB.addMember(memberID, memberIP, memberMAC, memberProtocol, memberPort);
- }
- }
- }
- if (newLB.isValid()) {
- logger.trace("Neutron LB pool configuration invalid for {} ", loadBalancerName);
- return;
+ private void doNeutronLoadBalancerCreate(NeutronLoadBalancer neutronLB) {
+ Preconditions.checkNotNull(loadBalancerProvider);
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+
+ if (!lbConfig.isValid()) {
+ logger.trace("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
+ } else if (this.switchManager.getNodes().size() == 0) {
+ logger.trace("Noop with LB {} creation because no nodes available.", lbConfig.getName());
} else {
- loadbalancersCache.put(loadBalancerID, newLB);
- //TODO: Trigger flowmod addition
+ for (Node node: this.switchManager.getNodes())
+ loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.ADD);
}
}
@Override
public int canUpdateNeutronLoadBalancer(NeutronLoadBalancer delta, NeutronLoadBalancer original) {
- return HttpURLConnection.HTTP_OK;
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(delta);
+ if (!lbConfig.isValid())
+ return HttpURLConnection.HTTP_NOT_ACCEPTABLE;
+ else
+ return HttpURLConnection.HTTP_OK;
}
@Override
- public void neutronLoadBalancerUpdated(NeutronLoadBalancer neutronLoadBalancer) {
- enqueueEvent(new NorthboundEvent(neutronLoadBalancer, Action.UPDATE));
- return;
+ public void neutronLoadBalancerUpdated(NeutronLoadBalancer neutronLB) {
+ logger.debug("Neutron LB Update : {}", neutronLB.toString());
+ enqueueEvent(new NorthboundEvent(neutronLB, Action.UPDATE));
}
@Override
- public int canDeleteNeutronLoadBalancer(NeutronLoadBalancer neutronLoadBalancer) {
- if (!loadbalancersCache.containsKey(neutronLoadBalancer.getLoadBalancerID()))
+ public int canDeleteNeutronLoadBalancer(NeutronLoadBalancer neutronLB) {
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+ if (lbConfig == null)
return HttpURLConnection.HTTP_NOT_ACCEPTABLE;
- return HttpURLConnection.HTTP_OK;
+ else
+ return HttpURLConnection.HTTP_OK;
}
@Override
- public void neutronLoadBalancerDeleted(NeutronLoadBalancer neutronLoadBalancer) {
- logger.debug("Neutron LB Deletion : {}", neutronLoadBalancer.toString());
- enqueueEvent(new NorthboundEvent(neutronLoadBalancer, Action.DELETE));
+ public void neutronLoadBalancerDeleted(NeutronLoadBalancer neutronLB) {
+ logger.debug("Neutron LB Deletion : {}", neutronLB.toString());
+ enqueueEvent(new NorthboundEvent(neutronLB, Action.DELETE));
}
- private void doNeutronLoadBalancerDelete(NeutronLoadBalancer neutronLoadBalancer) {
- int result = canDeleteNeutronLoadBalancer(neutronLoadBalancer);
- if (result != HttpURLConnection.HTTP_OK) {
- logger.error(" delete Neutron NeutronLoadBalancer Pool validation failed for result - {} ", result);
- return;
+ private void doNeutronLoadBalancerDelete(NeutronLoadBalancer neutronLB) {
+ Preconditions.checkNotNull(loadBalancerProvider);
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+
+ if (!lbConfig.isValid()) {
+ logger.trace("Neutron LB pool configuration invalid for {} ", lbConfig.getName());
+ } else if (this.switchManager.getNodes().size() == 0) {
+ logger.trace("Noop with LB {} deletion because no nodes available.", lbConfig.getName());
+ } else {
+ for (Node node: this.switchManager.getNodes())
+ loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.DELETE);
}
- loadbalancersCache.remove(neutronLoadBalancer.getLoadBalancerID());
- //TODO: Trigger flowmod removals
}
/**
*/
@Override
public void processEvent(AbstractEvent abstractEvent) {
+ logger.debug("Processing Loadbalancer event " + abstractEvent);
if (!(abstractEvent instanceof NorthboundEvent)) {
logger.error("Unable to process abstract event " + abstractEvent);
return;
switch (ev.getAction()) {
case ADD:
doNeutronLoadBalancerCreate(ev.getLoadBalancer());
+ break;
case DELETE:
+ try {
doNeutronLoadBalancerDelete(ev.getLoadBalancer());
- // fall through
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
+ break;
case UPDATE:
+ /**
+ * Currently member update requires delete and re-adding
+ * Also, weights and weight updates are not supported
+ */
doNeutronLoadBalancerDelete(ev.getLoadBalancer());
doNeutronLoadBalancerCreate(ev.getLoadBalancer());
break;
}
/**
- * Look up in the NeutronPortsCRUD cache and return the MAC address for a corresponding IP address
- * @param ipAddr IP address of a member or VM
- * @return MAC address registered with that IP address
+ * Useful utility for extracting the loadbalancer instance
+ * configuration from the neutron LB cache
*/
- private String getMacAddress(String ipAddr) {
- List<Neutron_IPs> fixedIPs;
- Iterator<Neutron_IPs> fixedIPIterator;
- Neutron_IPs ip;
-
- List<NeutronPort> allPorts = neutronPortsCache.getAllPorts();
- Iterator<NeutronPort> i = allPorts.iterator();
- while (i.hasNext()) {
- NeutronPort port = i.next();
- fixedIPs = port.getFixedIPs();
- if (fixedIPs != null && fixedIPs.size() > 0) {
- fixedIPIterator = fixedIPs.iterator();
- while (fixedIPIterator.hasNext()) {
- ip = fixedIPIterator.next();
- if (ip.getIpAddress().equals(ipAddr))
- return port.getMacAddress();
- }
- }
- }
- return null;
+ public LoadBalancerConfiguration extractLBConfiguration(NeutronLoadBalancer neutronLB) {
+ String loadBalancerName = neutronLB.getLoadBalancerName();
+ String loadBalancerVip = neutronLB.getLoadBalancerVipAddress();
+ String loadBalancerSubnetID = neutronLB.getLoadBalancerVipSubnetID();
+ LoadBalancerConfiguration lbConfig = new LoadBalancerConfiguration(loadBalancerName, loadBalancerVip);
+
+ String memberID, memberIP, memberMAC, memberProtocol, memberSubnetID;
+ Integer memberPort;
+ Boolean memberAdminStateIsUp;
+
+ for (NeutronLoadBalancerPool neutronLBPool: neutronLBPoolCache.getAllNeutronLoadBalancerPools()) {
+ List<NeutronLoadBalancerPoolMember> members = neutronLBPool.getLoadBalancerPoolMembers();
+ memberProtocol = neutronLBPool.getLoadBalancerPoolProtocol();
+ if (memberProtocol == null)
+ continue;
+ /*
+ * Only HTTP and HTTPS are supported as of this version
+ * TODO: Support all TCP load-balancers
+ */
+ if (!(memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTP) ||
+ memberProtocol.equalsIgnoreCase(LoadBalancerConfiguration.PROTOCOL_HTTPS)))
+ continue;
+ for (NeutronLoadBalancerPoolMember neutronLBPoolMember: members) {
+ memberAdminStateIsUp = neutronLBPoolMember.getPoolMemberAdminStateIsUp();
+ memberSubnetID = neutronLBPoolMember.getPoolMemberSubnetID();
+ if (memberSubnetID == null || memberAdminStateIsUp == null)
+ continue;
+ else if (memberSubnetID.equals(loadBalancerSubnetID) && memberAdminStateIsUp.booleanValue()) {
+ memberID = neutronLBPoolMember.getPoolMemberID();
+ memberIP = neutronLBPoolMember.getPoolMemberAddress();
+ memberPort = neutronLBPoolMember.getPoolMemberProtoPort();
+ memberMAC = NeutronCacheUtils.getMacAddress(neutronPortsCache, memberIP);
+ if (memberMAC == null)
+ continue;
+ lbConfig.addMember(memberID, memberIP, memberMAC, memberProtocol, memberPort);
+ }
+ }
+ }
+ return lbConfig;
+ }
+
+ /**
+ * On the addition of a new node, we iterate through all existing loadbalancer
+ * instances and program the node for all of them. It is sufficient to do that only
+ * when a node is added, and only for the LB instances (and not individual members).
+ */
+ @Override
+ public void notifyNode(Node node, UpdateType type, Map<String, Property> propMap) {
+ logger.debug("notifyNode: Node {} update {} from Controller's inventory Service", node, type);
+ Preconditions.checkNotNull(loadBalancerProvider);
+
+ for (NeutronLoadBalancer neutronLB: neutronLBCache.getAllNeutronLoadBalancers()) {
+ LoadBalancerConfiguration lbConfig = extractLBConfiguration(neutronLB);
+ if (!lbConfig.isValid())
+ logger.trace("Neutron LB configuration invalid for {} ", lbConfig.getName());
+ else {
+ if (type.equals(UpdateType.ADDED))
+ loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.ADD);
+ else if (type.equals(UpdateType.REMOVED))
+ loadBalancerProvider.programLoadBalancerRules(node, lbConfig, Action.DELETE);
+ }
+ }
+ }
+
+ @Override
+ public void notifyNodeConnector(NodeConnector arg0, UpdateType arg1,
+ Map<String, Property> arg2) {
+ //NOOP
}
}
Code Review / netvirt.git / blobdiff