Remove unused views

[releng/builder.git] / packer / provision / baseline.sh

diff --git a/packer/provision/baseline.sh b/packer/provision/baseline.sh
index 8aca86314e02d110e5c5ab5fe05d19b1f77f942e..aae30d44b1e3be34881adf56e5646a8ef1fedde7 100644 (file)
--- a/packer/provision/baseline.sh
+++ b/packer/provision/baseline.sh
@@ -7,17 +7,19 @@ set -xeu -o pipefail
 
 enable_service() {
     # Enable services for Ubuntu instances
+    # We purposely want to allow globbing to build the package array
+    # shellcheck disable=SC2206
     services=($@)
 
     for service in "${services[@]}"; do
         echo "---> Enable service: $service"
-        FACTER_OS=$(/usr/bin/facter operatingsystem)
+        FACTER_OS=$(/usr/bin/facter operatingsystem | tr '[:upper:]' '[:lower:]')
         FACTER_OSVER=$(/usr/bin/facter operatingsystemrelease)
-        if [ "$FACTER_OS" == "CentOS" ]; then
+        if [ "$FACTER_OS" == "centos" ]; then
             systemctl enable "$service"
             systemctl start "$service"
             systemctl status "$service"
-        elif [ "$FACTER_OS" == "Ubuntu" ]; then
+        elif [ "$FACTER_OS" == "ubuntu" ]; then
             case "$FACTER_OSVER" in
                 14.04)
                     service "$service" start
@@ -72,6 +74,8 @@ ensure_ubuntu_install() {
     # On Ubuntu sometimes the mirrors fail to install a package. This wrapper
     # checks that a package is successfully installed before moving on.
 
+    # We purposely want to allow globbing to build the package array
+    # shellcheck disable=SC2206
     packages=($@)
 
     for pkg in "${packages[@]}"
@@ -79,6 +83,10 @@ ensure_ubuntu_install() {
         # Retry installing package 5 times if necessary
         for i in {0..5}
         do
+
+            # Wait for any background apt processes to finish before running apt
+            while pgrep apt > /dev/null; do sleep 1; done
+
             echo "$i: Installing $pkg"
             if [ "$(dpkg-query -W -f='${Status}' "$pkg" 2>/dev/null | grep -c "ok installed")" -eq 0 ]; then
                 apt-cache policy "$pkg"
@@ -172,10 +180,10 @@ EOF
     echo "---> Configuring OpenJDK"
     yum install -y 'java-*-openjdk-devel'
 
-    FACTER_OS=$(/usr/bin/facter operatingsystem)
+    FACTER_OS=$(/usr/bin/facter operatingsystem | tr '[:upper:]' '[:lower:]')
     FACTER_OSVER=$(/usr/bin/facter operatingsystemrelease)
     case "$FACTER_OS" in
-        Fedora)
+        fedora)
             if [ "$FACTER_OSVER" -ge "21" ]
             then
                 echo "---> not modifying java alternatives as OpenJDK 1.7.0 does not exist"
@@ -184,7 +192,7 @@ EOF
                 alternatives --set java_sdk_openjdk /usr/lib/jvm/java-1.7.0-openjdk.x86_64
             fi
         ;;
-        RedHat|CentOS)
+        redhat|centos)
             if [ "$(echo "$FACTER_OSVER" | cut -d'.' -f1)" -ge "7" ]
             then
                 echo "---> not modifying java alternatives as OpenJDK 1.7.0 does not exist"
@@ -227,9 +235,6 @@ EOF
     cabal install "Cabal<1.18"  # Pull Cabal version that is capable of building shellcheck
     cabal install --bindir=/usr/local/bin "shellcheck-0.4.6"  # Pin shellcheck version
 
-    # openldap dev headers are required for lftools
-    yum install -y openldap-devel
-
     # NLTK_DATA Cache: many jobs that use coala pull down nltk_data
     wget -nv -O /opt/nltk_data.zip https://github.com/nltk/nltk_data/archive/gh-pages.zip
 
@@ -280,26 +285,23 @@ Dpkg::Options {
 
 EOF
 
-    # Add hostname to /etc/hosts to fix 'unable to resolve host' issue with sudo
-    sed -i "/127.0.0.1/s/$/ $(hostname)/" /etc/hosts
-
     echo "---> Updating operating system"
 
     # add additional repositories
     sudo add-apt-repository "deb http://us.archive.ubuntu.com/ubuntu $(lsb_release -sc) main universe restricted multiverse"
 
-    # facter is not installed by default on the base image and facter package
-    # gets removed when puppet4 is updated. To fix this use version of facter
-    # shipped with puppet4.
-    ensure_ubuntu_install facter
-    # ensure facter is available in $PATH avoid failures in retry loop
-    export PATH="/opt/puppetlabs/bin/:$PATH"
-
     echo "---> Installing base packages"
     apt-get clean
     apt-get update -m
     apt-get upgrade -m
     apt-get dist-upgrade -m
+    apt-get install facter
+
+    # facter is not installed by default on the base image and facter package
+    # gets removed when puppet4 is updated. To fix this use version of facter
+    # shipped with puppet4.
+    # ensure facter is available in $PATH avoid failures in retry loop
+    export PATH="/opt/puppetlabs/bin/:$PATH"
 
     ensure_ubuntu_install unzip xz-utils git libxml-xpath-perl
 
@@ -390,9 +392,6 @@ EOF
     cabal update
     cabal install --bindir=/usr/local/bin "shellcheck-0.4.6"  # Pin shellcheck version
 
-    # openldap dev headers are required for lftools
-    ensure_ubuntu_install libldap2-dev libssl-dev libsasl2-dev
-
     # NLTK_DATA Cache: many jobs that use coala pull down nltk_data
     wget -nv -O /opt/nltk_data.zip https://github.com/nltk/nltk_data/archive/gh-pages.zip
 
@@ -427,9 +426,9 @@ all_systems() {
 
     # Do any Distro specific installations here
     echo "Checking distribution"
-    FACTER_OS=$(/usr/bin/facter operatingsystem)
+    FACTER_OS=$(/usr/bin/facter operatingsystem | tr '[:upper:]' '[:lower:]')
     case "$FACTER_OS" in
-        RedHat|CentOS)
+        redhat|centos)
             if [ "$(/usr/bin/facter operatingsystemrelease | /bin/cut -d '.' -f1)" = "7" ]; then
                 echo
                 echo "---> CentOS 7"
@@ -446,6 +445,11 @@ all_systems() {
             echo "No extra steps for $FACTER_OS"
         ;;
     esac
+
+    # Update /etc/nss-switch.conf to map hostname with IP instead of using `localhost`
+    # from /etc/hosts which is required by some of the Java API's to avoid
+    # Java UnknownHostException: "Name or service not known" error.
+    sed -i "/^hosts:/s/$/ myhostname/" /etc/nsswitch.conf
 }
 
 echo "---> Attempting to detect OS"