fix sonar clumsy issues

[transportpce.git] / pce / src / main / java / org / opendaylight / transportpce / pce / PceConstraintsCalc.java

diff --git a/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraintsCalc.java b/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraintsCalc.java
index 97beb039fe04bca57663aff48eaf90f1037b4046..700f91f06c06eda54b4c6ab965ae955ae114aacc 100644 (file)
--- a/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraintsCalc.java
+++ b/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraintsCalc.java
@@ -145,11 +145,9 @@ public class PceConstraintsCalc {
         }
 
         Diversity diversity = tmpGeneral.getDiversity();
-        if (diversity != null) {
-            if (diversity.getExistingServiceApplicability().isNode()) {
-                LOG.info("in readGeneralContrains {}", diversity.toString());
-                readDiversityNodes(diversity.getExistingService(), constraints);
-            }
+        if ((diversity != null) && (diversity.getExistingServiceApplicability().isNode())) {
+            LOG.info("in readGeneralContrains {}", diversity.toString());
+            readDiversityNodes(diversity.getExistingService(), constraints);
         }
 
     }