Migrate pce module to JUnit5

[transportpce.git] / pce / src / test / java / org / opendaylight / transportpce / pce / constraints / PceConstraintsCalcTest.java

diff --git a/pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsCalcTest.java b/pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsCalcTest.java
index 6ba36dfbee6bdd974099c5fa62ff50dc81cf8205..ac07c4eddc0caddcf3805c265515554975d5a522 100644 (file)
--- a/pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsCalcTest.java
+++ b/pce/src/test/java/org/opendaylight/transportpce/pce/constraints/PceConstraintsCalcTest.java
@@ -8,73 +8,76 @@
 
 package org.opendaylight.transportpce.pce.constraints;
 
-import org.junit.Before;
-import org.junit.Test;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.util.NoSuchElementException;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.opendaylight.mdsal.binding.api.DataBroker;
 import org.opendaylight.transportpce.common.network.NetworkTransactionImpl;
 import org.opendaylight.transportpce.common.network.NetworkTransactionService;
-import org.opendaylight.transportpce.common.network.RequestProcessor;
 import org.opendaylight.transportpce.pce.utils.PceTestData;
 import org.opendaylight.transportpce.pce.utils.PceTestUtils;
 import org.opendaylight.transportpce.pce.utils.TransactionUtils;
 import org.opendaylight.transportpce.test.AbstractTest;
 
 public class PceConstraintsCalcTest extends AbstractTest {
-    private static PceConstraintsCalc pceConstraintsCalc;
     private static NetworkTransactionService networkTransactionService = null;
     private DataBroker dataBroker = getDataBroker();
 
-    @Before
-    public void setup() throws Exception {
+    //TODO: review this test class. May be miss few assert.
+    @BeforeEach
+    void setup() throws Exception {
         // networkTransactionService = Mockito.mock(NetworkTransactionService.class);
         PceTestUtils.writeNetworkIntoDataStore(dataBroker, getDataStoreContextUtil(),
                 TransactionUtils.getNetworkForSpanLoss());
-        networkTransactionService = new NetworkTransactionImpl(new RequestProcessor(dataBroker));
-
-
+        networkTransactionService = new NetworkTransactionImpl(dataBroker);
     }
 
     @Test
-    public void testNoHardOrSoftConstrainsExists() {
+    void testNoHardOrSoftConstrainsExists() {
         PceTestData.getPCE_test2_request_54().getSoftConstraints();
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .getEmptyPCERequest(), networkTransactionService);
+        new PceConstraintsCalc(PceTestData.getEmptyPCERequest(), networkTransactionService);
     }
 
     @Test()
-    public void testHardConstrainsExists() {
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .getPCE_simpletopology_test1_requestSetHardAndSoftConstrains(), networkTransactionService);
+    void testHardConstrainsExists() {
+        new PceConstraintsCalc(
+            PceTestData.getPCE_simpletopology_test1_requestSetHardAndSoftConstrains(),
+            networkTransactionService);
     }
 
     @Test()
-    public void testHardConstrainsExists1() {
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .getPathComputationRequestInputWithCoRoutingOrGeneral(), networkTransactionService);
+    void testHardConstrainsExists1() {
+        new PceConstraintsCalc(
+            PceTestData.getPathComputationRequestInputWithCoRoutingOrGeneral(),
+            networkTransactionService);
     }
 
     @Test
-    public void testSoftConstrainsExists() {
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .getPCERequest(), networkTransactionService);
+    void testSoftConstrainsExists() {
+        new PceConstraintsCalc(PceTestData.getPCERequest(), networkTransactionService);
     }
 
-    @Test(expected = Exception.class)
-    public void testHardConstrainsExists2() {
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .build_diversity_from_request(PceTestData.getPCERequest()), networkTransactionService);
+    //TODO: See if this test is relevant.
+    @Test
+    void testHardConstrainsExists2() {
+        Exception exception = assertThrows(NoSuchElementException.class, () -> {
+            new PceConstraintsCalc(
+                    PceTestData.build_diversity_from_request(PceTestData.getPCERequest()),
+                    networkTransactionService);
+        });
+        assertTrue(exception.getMessage().contains("No value present"));
     }
 
     @Test()
-    public void testHardConstrainsExists3() {
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .getEmptyPCERequestServiceNameWithRequestId(), networkTransactionService);
+    void testHardConstrainsExists3() {
+        new PceConstraintsCalc(PceTestData.getEmptyPCERequestServiceNameWithRequestId(), networkTransactionService);
     }
 
-    @Test(expected = Exception.class)
-    public void testHardConstrainsExists4() {
-        pceConstraintsCalc = new PceConstraintsCalc(PceTestData
-                .getPCE_test2_request_54(), networkTransactionService);
+    @Test()
+    void testHardConstrainsExists4() {
+        new PceConstraintsCalc(PceTestData.getPCE_test2_request_54(), networkTransactionService);
     }
-
 }