Clean pcep/base-parser code

[bgpcep.git] / pcep / base-parser / src / main / java / org / opendaylight / protocol / pcep / parser / message / PCEPErrorMessageParser.java

diff --git a/pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/message/PCEPErrorMessageParser.java b/pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/message/PCEPErrorMessageParser.java
index ae2b972be7293388b31feaf7e8323ac51c77aaf5..b8edf3fff2fa489ddddfd6112a7b109a8f05a32b 100644 (file)
--- a/pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/message/PCEPErrorMessageParser.java
+++ b/pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/message/PCEPErrorMessageParser.java
@@ -39,7 +39,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.typ
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev181109.rp.object.Rp;
 
 /**
- * Parser for {@link PcerrMessage}
+ * Parser for {@link PcerrMessage}.
  */
 public class PCEPErrorMessageParser extends AbstractMessageParser {
 
@@ -51,9 +51,12 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
 
     @Override
     public void serializeMessage(final Message message, final ByteBuf out) {
-        Preconditions.checkArgument(message instanceof PcerrMessage, "Wrong instance of Message. Passed instance of %s. Need PcerrMessage.", message.getClass());
-        final org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev181109.pcerr.message.PcerrMessage err = ((PcerrMessage) message).getPcerrMessage();
-        Preconditions.checkArgument(err.getErrors() != null && !err.getErrors().isEmpty(), "Errors should not be empty.");
+        Preconditions.checkArgument(message instanceof PcerrMessage,
+                "Wrong instance of Message. Passed instance of %s. Need PcerrMessage.", message.getClass());
+        final org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev181109.pcerr.message
+            .PcerrMessage err = ((PcerrMessage) message).getPcerrMessage();
+        Preconditions.checkArgument(err.getErrors() != null && !err.getErrors().isEmpty(),
+                "Errors should not be empty.");
         final ByteBuf buffer = Unpooled.buffer();
         serializeCases(err, buffer);
         for (final Errors e : err.getErrors()) {
@@ -69,7 +72,9 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
     /**
      * If needed, subclasses can override this method.
      */
-    protected void serializeCases(final org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev181109.pcerr.message.PcerrMessage err, final ByteBuf buffer) {
+    protected void serializeCases(
+            final org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev181109.pcerr.message
+                .PcerrMessage err, final ByteBuf buffer) {
         if (err.getErrorType() instanceof RequestCase) {
             final List<Rps> rps = ((RequestCase) err.getErrorType()).getRequest().getRps();
             for (final Rps r : rps) {
@@ -79,14 +84,15 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
     }
 
     @Override
-    protected PcerrMessage validate(final List<Object> objects, final List<Message> errors) throws PCEPDeserializerException {
+    protected PcerrMessage validate(final List<Object> objects, final List<Message> errors)
+            throws PCEPDeserializerException {
         Preconditions.checkArgument(objects != null, "Passed list can't be null.");
         if (objects.isEmpty()) {
             throw new PCEPDeserializerException("Error message is empty.");
         }
         final List<Rps> requestParameters = new ArrayList<>();
         final List<Errors> errorObjects = new ArrayList<>();
-        final PcerrMessageBuilder b = new PcerrMessageBuilder();
+        final PcerrMessageBuilder msgBuilder = new PcerrMessageBuilder();
 
         Object obj = objects.get(0);
         State state = State.INIT;
@@ -111,9 +117,10 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
         while (!objects.isEmpty() && !state.equals(State.END)) {
             obj = objects.get(0);
             if (obj instanceof UnknownObject) {
-                return new PcerrBuilder().setPcerrMessage(b.setErrors(((UnknownObject) obj).getErrors()).build()).build();
+                return new PcerrBuilder()
+                        .setPcerrMessage(msgBuilder.setErrors(((UnknownObject) obj).getErrors()).build()).build();
             }
-            state = insertObject(state, errorObjects, obj, requestParameters, b);
+            state = insertObject(state, errorObjects, obj, requestParameters, msgBuilder);
             if (!state.equals(State.END)) {
                 objects.remove(0);
             }
@@ -125,43 +132,44 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
             throw new PCEPDeserializerException("Unprocessed Objects: " + objects);
         }
         if (!requestParameters.isEmpty()) {
-            b.setErrorType(new RequestCaseBuilder().setRequest(new RequestBuilder().setRps(requestParameters).build()).build());
+            msgBuilder.setErrorType(new RequestCaseBuilder()
+                    .setRequest(new RequestBuilder().setRps(requestParameters).build()).build());
         }
-        return new PcerrBuilder().setPcerrMessage(b.setErrors(errorObjects).build()).build();
+        return new PcerrBuilder().setPcerrMessage(msgBuilder.setErrors(errorObjects).build()).build();
     }
 
     private static State insertObject(final State state, final List<Errors> errorObjects, final Object obj,
-            final List<Rps> requestParameters, final PcerrMessageBuilder b) {
+            final List<Rps> requestParameters, final PcerrMessageBuilder msgBuilder) {
         switch (state) {
-           case RP_IN:
+            case RP_IN:
                 if (obj instanceof Rp) {
                     final Rp o = (Rp) obj;
                     requestParameters.add(new RpsBuilder().setRp(o).build());
                     return State.RP_IN;
                 }
-                // fall-through
+                // fallthrough
             case ERROR_IN:
                 if (obj instanceof ErrorObject) {
                     final ErrorObject o = (ErrorObject) obj;
                     errorObjects.add(new ErrorsBuilder().setErrorObject(o).build());
                     return State.ERROR_IN;
                 }
-                // fall-through
+                // fallthrough
             case OPEN:
                 if (obj instanceof Open) {
-                    b.setErrorType(new SessionCaseBuilder().setSession(new SessionBuilder().setOpen((Open) obj).build()).build());
+                    msgBuilder.setErrorType(
+                        new SessionCaseBuilder().setSession(new SessionBuilder().setOpen((Open) obj).build()).build());
                     return State.OPEN_IN;
                 }
-                // fall-through
+                // fallthrough
             case ERROR:
                 if (obj instanceof ErrorObject) {
                     final ErrorObject o = (ErrorObject) obj;
                     errorObjects.add(new ErrorsBuilder().setErrorObject(o).build());
                     return State.ERROR;
                 }
-                // fall-through
+                // fallthrough
             case OPEN_IN:
-                // fall-through
             case END:
                 return State.END;
             default: