Rework parser infrastructure to support partial message processing
[bgpcep.git] / pcep / impl / src / main / java / org / opendaylight / protocol / pcep / impl / message / PCEPErrorMessageParser.java
index efe4fb1d8b9813e5b4b3f05e1ee165674ab2621b..94f908815b7bccba41473ece48f6435c6af54b31 100644 (file)
@@ -9,23 +9,19 @@ package org.opendaylight.protocol.pcep.impl.message;
 
 import io.netty.buffer.ByteBuf;
 
-import java.util.Arrays;
 import java.util.List;
 
 import org.opendaylight.protocol.pcep.PCEPDeserializerException;
 import org.opendaylight.protocol.pcep.PCEPDocumentedException;
-import org.opendaylight.protocol.pcep.PCEPErrorMapping;
 import org.opendaylight.protocol.pcep.PCEPErrors;
 import org.opendaylight.protocol.pcep.UnknownObject;
-import org.opendaylight.protocol.pcep.impl.AbstractMessageParser;
 import org.opendaylight.protocol.pcep.spi.ObjectHandlerRegistry;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.message.rev131007.PcerrBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.Message;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.Object;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.OpenObject;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.PcepErrorObject;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.PcerrMessage;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.Open;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.pcep.error.object.ErrorObject;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.pcerr.message.PcerrMessageBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.pcerr.message.pcerr.message.Errors;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.pcerr.message.pcerr.message.ErrorsBuilder;
@@ -70,7 +66,7 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
                }
 
                for (final Errors e : err.getErrors()) {
-                       buffer.writeBytes(serializeObject(e));
+                       buffer.writeBytes(serializeObject(e.getErrorObject()));
                }
 
                if (err.getErrorType() instanceof Session) {
@@ -79,36 +75,38 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
        }
 
        @Override
-       public PcerrMessage parseMessage(final byte[] buffer) throws PCEPDeserializerException, PCEPDocumentedException {
-               if (buffer == null || buffer.length == 0) {
-                       throw new PCEPDeserializerException("Error message is empty.");
-               }
-               final List<Object> objs = parseObjects(buffer);
-               PcerrMessage m = null;
-               try {
-                       m = validate(objs);
-               } catch (final PCEPDocumentedException e) {
-                       final PCEPErrorMapping maping = PCEPErrorMapping.getInstance();
-                       return new PcerrBuilder().setPcerrMessage(
-                                       new PcerrMessageBuilder().setErrors(
-                                                       Arrays.asList(new ErrorsBuilder().setType(maping.getFromErrorsEnum(e.getError()).type).setValue(
-                                                                       maping.getFromErrorsEnum(e.getError()).value).build())).build()).build();
-               }
-               return m;
-       }
-
-       private PcerrMessage validate(final List<Object> objects) throws PCEPDeserializerException, PCEPDocumentedException {
+       protected PcerrMessage validate(final List<Object> objects, final List<Message> errors) throws PCEPDeserializerException, PCEPDocumentedException {
                if (objects == null) {
                        throw new IllegalArgumentException("Passed list can't be null.");
                }
 
-               Open openObj = null;
+               if (objects.isEmpty()) {
+                       throw new PCEPDeserializerException("Error message is empty.");
+               }
+
                final List<Rps> requestParameters = Lists.newArrayList();
                final List<Errors> errorObjects = Lists.newArrayList();
                final PcerrMessageBuilder b = new PcerrMessageBuilder();
 
                Object obj;
-               int state = 1;
+               State state = State.Init;
+               obj = objects.get(0);
+
+               if (obj instanceof ErrorObject) {
+                       final ErrorObject o = (ErrorObject) obj;
+                       errorObjects.add(new ErrorsBuilder().setErrorObject(o).build());
+                       state = State.ErrorIn;
+                       objects.remove(0);
+               } else if (obj instanceof Rp) {
+                       final Rp o = ((Rp) obj);
+                       if (o.isProcessingRule()) {
+                               throw new PCEPDocumentedException("Invalid setting of P flag.", PCEPErrors.P_FLAG_NOT_SET);
+                       }
+                       requestParameters.add(new RpsBuilder().setRp(o).build());
+                       state = State.RpIn;
+                       objects.remove(0);
+               }
+
                while (!objects.isEmpty()) {
                        obj = objects.get(0);
 
@@ -117,59 +115,50 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
                        }
 
                        switch (state) {
-                       case 1:
-                               if (obj instanceof PcepErrorObject) {
-                                       final PcepErrorObject o = (PcepErrorObject) obj;
-                                       errorObjects.add((Errors) o);
+                       case ErrorIn:
+                               state = State.Open;
+                               if (obj instanceof ErrorObject) {
+                                       final ErrorObject o = (ErrorObject) obj;
+                                       errorObjects.add(new ErrorsBuilder().setErrorObject(o).build());
+                                       state = State.ErrorIn;
                                        break;
                                }
-                               state = 2;
-                       case 2:
-                               state = 3;
-                               if (obj instanceof OpenObject) {
-                                       openObj = (Open) obj;
+                       case RpIn:
+                               state = State.Error;
+                               if (obj instanceof Rp) {
+                                       final Rp o = ((Rp) obj);
+                                       if (o.isProcessingRule()) {
+                                               throw new PCEPDocumentedException("Invalid setting of P flag.", PCEPErrors.P_FLAG_NOT_SET);
+                                       }
+                                       requestParameters.add(new RpsBuilder().setRp(o).build());
+                                       state = State.RpIn;
                                        break;
                                }
-                       case 3:
-                               while (!objects.isEmpty()) {
-                                       switch (state) {
-                                       case 1:
-                                               state = 2;
-                                               if (obj instanceof Rp) {
-                                                       final Rp o = ((Rp) obj);
-                                                       if (o.isProcessingRule()) {
-                                                               throw new PCEPDocumentedException("Invalid setting of P flag.", PCEPErrors.P_FLAG_NOT_SET);
-                                                       }
-                                                       requestParameters.add(new RpsBuilder().setRp(o).build());
-                                                       state = 1;
-                                                       break;
-                                               }
-                                       case 2:
-                                               if (obj instanceof PcepErrorObject) {
-                                                       final PcepErrorObject o = (PcepErrorObject) obj;
-                                                       errorObjects.add((Errors) o);
-                                                       state = 2;
-                                                       break;
-                                               }
-                                               state = 3;
-                                       }
-
-                                       if (state == 3) {
-                                               break;
-                                       }
-
-                                       objects.remove(0);
+                       case Open:
+                               state = State.OpenIn;
+                               if (obj instanceof Open) {
+                                       b.setErrorType(new SessionBuilder().setOpen((Open) obj).build());
+                                       break;
                                }
-
-                               state = 4;
+                       case Error:
+                               state = State.OpenIn;
+                               if (obj instanceof ErrorObject) {
+                                       final ErrorObject o = (ErrorObject) obj;
+                                       errorObjects.add(new ErrorsBuilder().setErrorObject(o).build());
+                                       state = State.Error;
+                                       break;
+                               }
+                       case OpenIn:
+                               state = State.End;
                                break;
-                       }
-
-                       if (state == 4) {
+                       case End:
+                               break;
+                       default:
                                break;
                        }
-
-                       objects.remove(0);
+                       if (!state.equals(State.End)) {
+                               objects.remove(0);
+                       }
                }
 
                if (errorObjects.isEmpty() && errorObjects.isEmpty()) {
@@ -179,16 +168,17 @@ public class PCEPErrorMessageParser extends AbstractMessageParser {
                if (!objects.isEmpty()) {
                        throw new PCEPDeserializerException("Unprocessed Objects: " + objects);
                }
-               if (requestParameters != null) {
+               if (requestParameters != null && !requestParameters.isEmpty()) {
                        b.setErrorType(new RequestBuilder().setRps(requestParameters).build());
                }
-               if (openObj != null) {
-                       b.setErrorType(new SessionBuilder().setOpen(openObj).build());
-               }
 
                return new PcerrBuilder().setPcerrMessage(b.setErrors(errorObjects).build()).build();
        }
 
+       private enum State {
+               Init, ErrorIn, RpIn, Open, Error, OpenIn, End
+       }
+
        @Override
        public int getMessageType() {
                return TYPE;