BUG 4181: Fix PCEP Parsers/Serializers

[bgpcep.git] / pcep / impl / src / main / java / org / opendaylight / protocol / pcep / impl / object / PCEPLoadBalancingObjectParser.java

diff --git a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/object/PCEPLoadBalancingObjectParser.java b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/object/PCEPLoadBalancingObjectParser.java
index bdec9e875a42ec8c3a231006cb8b9d86c95fae54..c035a56156cf379fc4a6159446999efd9a08f1fa 100644 (file)
--- a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/object/PCEPLoadBalancingObjectParser.java
+++ b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/object/PCEPLoadBalancingObjectParser.java
@@ -7,10 +7,16 @@
  */
 package org.opendaylight.protocol.pcep.impl.object;
 
-import org.opendaylight.protocol.pcep.spi.AbstractObjectWithTlvsParser;
+import static org.opendaylight.protocol.util.ByteBufWriteUtil.writeFloat32;
+import static org.opendaylight.protocol.util.ByteBufWriteUtil.writeUnsignedByte;
+
+import com.google.common.base.Preconditions;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import org.opendaylight.protocol.pcep.spi.ObjectParser;
+import org.opendaylight.protocol.pcep.spi.ObjectSerializer;
 import org.opendaylight.protocol.pcep.spi.ObjectUtil;
 import org.opendaylight.protocol.pcep.spi.PCEPDeserializerException;
-import org.opendaylight.protocol.pcep.spi.TlvRegistry;
 import org.opendaylight.protocol.util.ByteArray;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.network.concepts.rev131125.Bandwidth;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.Object;
@@ -18,57 +24,44 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.typ
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.load.balancing.object.LoadBalancing;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.load.balancing.object.LoadBalancingBuilder;
 
-import com.google.common.primitives.UnsignedBytes;
-
 /**
  * Parser for {@link LoadBalancing}
  */
-public class PCEPLoadBalancingObjectParser extends AbstractObjectWithTlvsParser<LoadBalancingBuilder> {
-
-       public static final int CLASS = 14;
-
-       public static final int TYPE = 1;
+public class PCEPLoadBalancingObjectParser implements ObjectParser, ObjectSerializer {
 
-       private static final int FLAGS_F_LENGTH = 1;
-       private static final int MAX_LSP_F_LENGTH = 1;
-       private static final int MIN_BAND_F_LENGTH = 4;
+    public static final int CLASS = 14;
 
-       private static final int FLAGS_F_OFFSET = 2;
-       private static final int MAX_LSP_F_OFFSET = FLAGS_F_OFFSET + FLAGS_F_LENGTH;
-       private static final int MIN_BAND_F_OFFSET = MAX_LSP_F_OFFSET + MAX_LSP_F_LENGTH;
+    public static final int TYPE = 1;
 
-       private static final int SIZE = MIN_BAND_F_OFFSET + MIN_BAND_F_LENGTH;
+    private static final int RESERVED = 2;
+    private static final int FLAGS_F_LENGTH = 1;
 
-       public PCEPLoadBalancingObjectParser(final TlvRegistry tlvReg) {
-               super(tlvReg);
-       }
+    private static final int SIZE = 8;
 
-       @Override
-       public LoadBalancing parseObject(final ObjectHeader header, final byte[] bytes) throws PCEPDeserializerException {
-               if (bytes == null || bytes.length == 0) {
-                       throw new IllegalArgumentException("Byte array is mandatory. Can't be null or empty.");
-               }
-               if (bytes.length != SIZE) {
-                       throw new PCEPDeserializerException("Wrong length of array of bytes. Passed: " + bytes.length + "; Expected: " + SIZE + ".");
-               }
-               final LoadBalancingBuilder builder = new LoadBalancingBuilder();
-               builder.setIgnore(header.isIgnore());
-               builder.setProcessingRule(header.isProcessingRule());
-               builder.setMaxLsp((short) UnsignedBytes.toInt(bytes[MAX_LSP_F_OFFSET]));
-               builder.setMinBandwidth(new Bandwidth(ByteArray.subByte(bytes, MIN_BAND_F_OFFSET, MIN_BAND_F_LENGTH)));
-               return builder.build();
-       }
+    @Override
+    public LoadBalancing parseObject(final ObjectHeader header, final ByteBuf bytes) throws PCEPDeserializerException {
+        Preconditions.checkArgument(bytes != null && bytes.isReadable(), "Array of bytes is mandatory. Can't be null or empty.");
+        if (bytes.readableBytes() != SIZE) {
+            throw new PCEPDeserializerException("Wrong length of array of bytes. Passed: " + bytes.readableBytes() + "; Expected: " + SIZE
+                    + ".");
+        }
+        final LoadBalancingBuilder builder = new LoadBalancingBuilder();
+        builder.setIgnore(header.isIgnore());
+        builder.setProcessingRule(header.isProcessingRule());
+        bytes.skipBytes(RESERVED + FLAGS_F_LENGTH);
+        builder.setMaxLsp(bytes.readUnsignedByte());
+        builder.setMinBandwidth(new Bandwidth(ByteArray.readAllBytes(bytes)));
+        return builder.build();
+    }
 
-       @Override
-       public byte[] serializeObject(final Object object) {
-               if (!(object instanceof LoadBalancing)) {
-                       throw new IllegalArgumentException("Wrong instance of PCEPObject. Passed " + object.getClass()
-                                       + ". Needed LoadBalancingObject.");
-               }
-               final LoadBalancing specObj = (LoadBalancing) object;
-               final byte[] retBytes = new byte[SIZE];
-               retBytes[MAX_LSP_F_OFFSET] = UnsignedBytes.checkedCast(specObj.getMaxLsp());
-               ByteArray.copyWhole(specObj.getMinBandwidth().getValue(), retBytes, MIN_BAND_F_OFFSET);
-               return ObjectUtil.formatSubobject(TYPE, CLASS, object.isProcessingRule(), object.isIgnore(), retBytes);
-       }
+    @Override
+    public void serializeObject(final Object object, final ByteBuf buffer) {
+        Preconditions.checkArgument(object instanceof LoadBalancing, "Wrong instance of PCEPObject. Passed %s. Needed LoadBalancingObject.", object.getClass());
+        final LoadBalancing specObj = (LoadBalancing) object;
+        final ByteBuf body = Unpooled.buffer(SIZE);
+        body.writeZero(RESERVED + FLAGS_F_LENGTH);
+        writeUnsignedByte(specObj.getMaxLsp(), body);
+        writeFloat32(specObj.getMinBandwidth(), body);
+        ObjectUtil.formatSubobject(TYPE, CLASS, object.isProcessingRule(), object.isIgnore(), body, buffer);
+    }
 }