BUG-64 : reformat TlvRegistry, to skip using getType method.
[bgpcep.git] / pcep / impl / src / main / java / org / opendaylight / protocol / pcep / impl / object / PCEPOpenObjectParser.java
index bac945ed63feee33884912a64825c3dde68ed1af..d27b341391d3effd88517bb69df5e3a63e83fc08 100644 (file)
@@ -8,31 +8,32 @@
 
 package org.opendaylight.protocol.pcep.impl.object;
 
-import org.opendaylight.protocol.pcep.PCEPDeserializerException;
-import org.opendaylight.protocol.pcep.PCEPDocumentedException;
-import org.opendaylight.protocol.pcep.PCEPErrors;
-import org.opendaylight.protocol.pcep.spi.TlvHandlerRegistry;
+import org.opendaylight.protocol.pcep.spi.AbstractObjectWithTlvsParser;
+import org.opendaylight.protocol.pcep.spi.ObjectUtil;
+import org.opendaylight.protocol.pcep.spi.PCEPDeserializerException;
+import org.opendaylight.protocol.pcep.spi.PCEPErrors;
+import org.opendaylight.protocol.pcep.spi.TlvRegistry;
+import org.opendaylight.protocol.pcep.spi.UnknownObject;
 import org.opendaylight.protocol.util.ByteArray;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.Object;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.ObjectHeader;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.OpenObject;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.ProtocolVersion;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.Tlv;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.lsp.db.version.tlv.LspDbVersion;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.of.list.tlv.OfList;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.message.open.message.OpenBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.Tlvs;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.TlvsBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.predundancy.group.id.tlv.PredundancyGroupId;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.stateful.capability.tlv.Stateful;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.Open;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.OpenBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.open.Tlvs;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.open.TlvsBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import com.google.common.primitives.UnsignedBytes;
 
 /**
- * Parser for {@link OpenObject}
+ * Parser for {@link Open}
  */
-
 public class PCEPOpenObjectParser extends AbstractObjectWithTlvsParser<TlvsBuilder> {
+       private static final Logger LOG = LoggerFactory.getLogger(PCEPOpenObjectParser.class);
 
        public static final int CLASS = 1;
 
@@ -67,20 +68,17 @@ public class PCEPOpenObjectParser extends AbstractObjectWithTlvsParser<TlvsBuild
 
        private static final int PCEP_VERSION = 1;
 
-       public PCEPOpenObjectParser(final TlvHandlerRegistry tlvReg) {
+       public PCEPOpenObjectParser(final TlvRegistry tlvReg) {
                super(tlvReg);
        }
 
        @Override
-       public OpenObject parseObject(final ObjectHeader header, final byte[] bytes) throws PCEPDeserializerException, PCEPDocumentedException {
+       public Object parseObject(final ObjectHeader header, final byte[] bytes) throws PCEPDeserializerException {
                if (bytes == null || bytes.length == 0) {
                        throw new IllegalArgumentException("Array of bytes is mandatory. Can't be null or empty.");
                }
                final int versionValue = ByteArray.copyBitsRange(bytes[VER_FLAGS_MF_OFFSET], VERSION_SF_OFFSET, VERSION_SF_LENGTH);
 
-               if (versionValue != PCEP_VERSION) {
-                       throw new PCEPDocumentedException("Unsupported PCEP version " + versionValue, PCEPErrors.PCEP_VERSION_NOT_SUPPORTED);
-               }
                final OpenBuilder builder = new OpenBuilder();
                builder.setVersion(new ProtocolVersion((short) versionValue));
                builder.setProcessingRule(header.isProcessingRule());
@@ -92,28 +90,30 @@ public class PCEPOpenObjectParser extends AbstractObjectWithTlvsParser<TlvsBuild
                final TlvsBuilder tbuilder = new TlvsBuilder();
                parseTlvs(tbuilder, ByteArray.cutBytes(bytes, TLVS_OFFSET));
                builder.setTlvs(tbuilder.build());
-               return builder.build();
+
+               final Open obj = builder.build();
+               if (versionValue != PCEP_VERSION) {
+                       // TODO: Should we move this check into the negotiator
+                       LOG.debug("Unsupported PCEP version {}", versionValue);
+                       return new UnknownObject(PCEPErrors.PCEP_VERSION_NOT_SUPPORTED, obj);
+               }
+
+               return obj;
        }
 
        @Override
        public void addTlv(final TlvsBuilder tbuilder, final Tlv tlv) {
                if (tlv instanceof OfList) {
                        tbuilder.setOfList((OfList) tlv);
-               } else if (tlv instanceof Stateful) {
-                       tbuilder.setStateful((Stateful) tlv);
-               } else if (tlv instanceof PredundancyGroupId) {
-                       tbuilder.setPredundancyGroupId((PredundancyGroupId) tlv);
-               } else if (tlv instanceof LspDbVersion) {
-                       tbuilder.setLspDbVersion((LspDbVersion) tlv);
                }
        }
 
        @Override
        public byte[] serializeObject(final Object object) {
-               if (!(object instanceof OpenObject)) {
+               if (!(object instanceof Open)) {
                        throw new IllegalArgumentException("Wrong instance of PCEPObject. Passed " + object.getClass() + ". Needed OpenObject.");
                }
-               final OpenObject open = (OpenObject) object;
+               final Open open = (Open) object;
 
                final byte versionFlagMF = (byte) (PCEP_VERSION << (Byte.SIZE - VERSION_SF_LENGTH));
 
@@ -128,62 +128,32 @@ public class PCEPOpenObjectParser extends AbstractObjectWithTlvsParser<TlvsBuild
                if (tlvs.length != 0) {
                        ByteArray.copyWhole(tlvs, bytes, TLVS_OFFSET);
                }
-               return bytes;
+               return ObjectUtil.formatSubobject(TYPE, CLASS, object.isProcessingRule(), object.isIgnore(), bytes);
        }
 
        public byte[] serializeTlvs(final Tlvs tlvs) {
                if (tlvs == null) {
                        return new byte[0];
                }
-               int finalLength = 0;
                byte[] ofListBytes = null;
-               byte[] statefulBytes = null;
-               byte[] predundancyBytes = null;
-               byte[] lspDbBytes = null;
                if (tlvs.getOfList() != null) {
                        ofListBytes = serializeTlv(tlvs.getOfList());
-                       finalLength += ofListBytes.length;
                }
-               if (tlvs.getStateful() != null) {
-                       statefulBytes = serializeTlv(tlvs.getStateful());
-                       finalLength += statefulBytes.length;
-               }
-               if (tlvs.getPredundancyGroupId() != null) {
-                       predundancyBytes = serializeTlv(tlvs.getPredundancyGroupId());
-                       finalLength += predundancyBytes.length;
-               }
-               if (tlvs.getLspDbVersion() != null) {
-                       lspDbBytes = serializeTlv(tlvs.getLspDbVersion());
-                       finalLength += lspDbBytes.length;
-               }
-               int offset = 0;
-               final byte[] result = new byte[finalLength];
+               byte[] result = new byte[0];
                if (ofListBytes != null) {
-                       ByteArray.copyWhole(ofListBytes, result, offset);
-                       offset += ofListBytes.length;
-               }
-               if (statefulBytes != null) {
-                       ByteArray.copyWhole(statefulBytes, result, offset);
-                       offset += statefulBytes.length;
-               }
-               if (lspDbBytes != null) {
-                       ByteArray.copyWhole(lspDbBytes, result, offset);
-                       offset += lspDbBytes.length;
-               }
-               if (predundancyBytes != null) {
-                       ByteArray.copyWhole(predundancyBytes, result, offset);
-                       offset += predundancyBytes.length;
+                       result = new byte[ofListBytes.length];
+                       ByteArray.copyWhole(ofListBytes, result, 0);
                }
                return result;
        }
 
        @Override
-       public int getObjectType() {
+       public final int getObjectType() {
                return TYPE;
        }
 
        @Override
-       public int getObjectClass() {
+       public final int getObjectClass() {
                return CLASS;
        }
 }