BUG-731 : fixed pcep sonar warnings

[bgpcep.git] / pcep / spi / src / main / java / org / opendaylight / protocol / pcep / spi / EROSubobjectRegistry.java

diff --git a/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/EROSubobjectRegistry.java b/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/EROSubobjectRegistry.java
index bc97b26954f9d33a8420c4ce77a3d4de4e266106..b9b4aa0d270c9e2e16cd81e2d57232aa1e3e22d7 100644 (file)
--- a/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/EROSubobjectRegistry.java
+++ b/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/EROSubobjectRegistry.java
@@ -7,23 +7,27 @@
  */
 package org.opendaylight.protocol.pcep.spi;
 
+import io.netty.buffer.ByteBuf;
+
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.explicit.route.object.ero.Subobject;
 
 public interface EROSubobjectRegistry {
-       /**
-        * Finds parser for given subobject type in the registry. Delegates parsing to found parser.
-        * @param type subobject type, key in parser registry
-        * @param buffer subobject raw binary value to be parsed
-        * @param loose ERO specific common field
-        * @return null if the parser for this subobject could not be found
-        * @throws PCEPDeserializerException if the parsing did not succeed
-        */
-       Subobject parseSubobject(final int subobjectType, final byte[] buffer, final boolean loose) throws PCEPDeserializerException;
+    /**
+     * Finds parser for given subobject type in the registry. Delegates parsing to found parser.
+     *
+     * @param type subobject type, key in parser registry
+     * @param buffer subobject wrapped in ByteBuf
+     * @param loose ERO specific common field
+     * @return null if the parser for this subobject could not be found
+     * @throws PCEPDeserializerException if the parsing did not succeed
+     */
+    Subobject parseSubobject(final int subobjectType, final ByteBuf buffer, final boolean loose) throws PCEPDeserializerException;
 
-       /**
-        * Find serializer for given subobject. Delegates parsing to found serializer.
-        * @param subobject to be parsed
-        * @return null if the serializer for this subobject could not be found
-        */
-       byte[] serializeSubobject(final Subobject subobject);
+    /**
+     * Find serializer for given subobject. Delegates parsing to found serializer.
+     *
+     * @param subobject to be parsed
+     * @param buffer buffer where the serialized subobject will be parsed
+     */
+    void serializeSubobject(final Subobject subobject, final ByteBuf buffer);
 }