Fixed some sonar warnings.

[bgpcep.git] / pcep / spi / src / main / java / org / opendaylight / protocol / pcep / spi / PCEPErrorMapping.java

diff --git a/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/PCEPErrorMapping.java b/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/PCEPErrorMapping.java
index 1abda2d13c1e8e49ca17f378ce3a359ead531ea5..47cc590655553a800ed4a489f9a295b0f6317414 100644 (file)
--- a/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/PCEPErrorMapping.java
+++ b/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/PCEPErrorMapping.java
@@ -20,14 +20,14 @@ import org.slf4j.LoggerFactory;
  */
 public final class PCEPErrorMapping {
 
-       private final static Logger logger = LoggerFactory.getLogger(PCEPErrorMapping.class);
+       private static final Logger LOG = LoggerFactory.getLogger(PCEPErrorMapping.class);
 
        /**
         * Caret for combination of Error-type and Error-value
         */
-       public static class PCEPErrorIdentifier {
-               public final short type;
-               public final short value;
+       public static final class PCEPErrorIdentifier {
+               public short type;
+               public short value;
 
                private PCEPErrorIdentifier(final short type, final short value) {
                        this.type = type;
@@ -70,7 +70,7 @@ public final class PCEPErrorMapping {
                }
        }
 
-       private static final PCEPErrorMapping instance = new PCEPErrorMapping();
+       private static final PCEPErrorMapping INSTANCE = new PCEPErrorMapping();
 
        private final Map<PCEPErrors, PCEPErrorIdentifier> errorsMap = new HashMap<PCEPErrors, PCEPErrorIdentifier>();
        private final Map<PCEPErrorIdentifier, PCEPErrors> errorIdsMap = new HashMap<PCEPErrorIdentifier, PCEPErrors>();
@@ -163,7 +163,7 @@ public final class PCEPErrorMapping {
        public PCEPErrorIdentifier getFromErrorsEnum(final PCEPErrors error) {
                final PCEPErrorIdentifier ei = this.errorsMap.get(error);
                if (ei == null) {
-                       logger.debug("Unknown PCEPErrors type: {}.", error);
+                       LOG.debug("Unknown PCEPErrors type: {}.", error);
                        throw new NoSuchElementException("Unknown PCEPErrors type: " + error);
                }
                return ei;
@@ -172,13 +172,13 @@ public final class PCEPErrorMapping {
        public PCEPErrors getFromErrorIdentifier(final PCEPErrorIdentifier identifier) {
                final PCEPErrors e = this.errorIdsMap.get(identifier);
                if (e == null) {
-                       logger.debug("Unknown error type/value combination: {}.", identifier);
+                       LOG.debug("Unknown error type/value combination: {}.", identifier);
                        throw new NoSuchElementException("Unknown error type/value combination: " + identifier);
                }
                return e;
        }
 
        public static PCEPErrorMapping getInstance() {
-               return instance;
+               return INSTANCE;
        }
 }