Code Review / groupbasedpolicy.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | inline | side by side
Increasing coverage on faas-renderer
[groupbasedpolicy.git] / renderers / faas / src / test / java / org / opendaylight / groupbasedpolicy / renderer / faas / FaasEndpointManagerListenerCovrgTest.java
diff --git a/renderers/faas/src/test/java/org/opendaylight/groupbasedpolicy/renderer/faas/FaasEndpointManagerListenerCovrgTest.java b/renderers/faas/src/test/java/org/opendaylight/groupbasedpolicy/renderer/faas/FaasEndpointManagerListenerCovrgTest.java
index 5139ebb28c71cb93a8c22a3e3ec69742334f198f..5177668021327337665768137d9682705dc4d88e 100644 (file)
--- a/renderers/faas/src/test/java/org/opendaylight/groupbasedpolicy/renderer/faas/FaasEndpointManagerListenerCovrgTest.java
+++ b/renderers/faas/src/test/java/org/opendaylight/groupbasedpolicy/renderer/faas/FaasEndpointManagerListenerCovrgTest.java
@@ -7,6 +7,9 @@
  */
 package org.opendaylight.groupbasedpolicy.renderer.faas;
 
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
 import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.mock;
@@ -17,10 +20,12 @@ import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
 
 import com.google.common.base.Optional;
+import com.google.common.collect.ImmutableList;
 import com.google.common.util.concurrent.CheckedFuture;
 import org.junit.Before;
 import org.junit.Test;
 import org.opendaylight.controller.md.sal.binding.api.DataBroker;
+import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction;
 import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction;
 import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
 import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
@@ -28,10 +33,15 @@ import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException;
 import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
 import org.opendaylight.groupbasedpolicy.renderer.faas.test.DataChangeListenerTester;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.MacAddress;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.faas.faas.endpoint.rev151009.FaasEndpointContext;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.faas.faas.endpoint.rev151009.FaasEndpointContextBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.faas.logical.faas.common.rev151013.Uuid;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.common.rev140421.EndpointGroupId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.common.rev140421.L2BridgeDomainId;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.common.rev140421.NetworkDomainId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.common.rev140421.SubnetId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.common.rev140421.TenantId;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.rev140421.endpoint.fields.L3AddressBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.rev140421.endpoints.Endpoint;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.rev140421.endpoints.EndpointBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.rev140421.endpoints.EndpointL3;
@@ -40,6 +50,8 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.r
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.rev140421.endpoints.EndpointL3PrefixBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.faas.rev151009.mapped.tenants.entities.mapped.entity.MappedEndpoint;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.faas.rev151009.mapped.tenants.entities.mapped.entity.MappedEndpointKey;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.faas.rev151009.mapped.tenants.entities.mapped.entity.MappedSubnet;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.resolved.policy.rev150828.ResolvedPolicies;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
@@ -51,9 +63,7 @@ public class FaasEndpointManagerListenerCovrgTest {
     private InstanceIdentifier<Endpoint> epIid;
     private FaasEndpointManagerListener listener;
     private TenantId gbpTenantId = new TenantId("gbpTenantId");
-    private SubnetId subnetId = new SubnetId("subnetId");
     private Uuid faasTenantId = new Uuid("b4511aac-ae43-11e5-bf7f-feff819cdc9f");
-    private Uuid faasSubnetId = new Uuid("c4511aac-ae43-11e5-bf7f-feff819cdc9f");
     private final ScheduledExecutorService executor = Executors.newScheduledThreadPool(1);
     private DataChangeListenerTester tester;
     private DataBroker dataProvider;
@@ -104,6 +114,142 @@ public class FaasEndpointManagerListenerCovrgTest {
         listener.executeEvent(tester.getChangeMock());
     }
 
+    @Test
+    public void testValidate() {
+        EndpointGroupId endpointGroupId = new EndpointGroupId("epg-1");
+        FaasEndpointContext faasEndpointContext1 = new FaasEndpointContextBuilder().build();
+        FaasEndpointContext faasEndpointContext2 = new FaasEndpointContextBuilder()
+                .setFaasPortRefId(new Uuid("c4511aac-ae43-11e5-bf7f-feff819cdc9f")).build();
+
+        Endpoint ep = new EndpointBuilder()
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .setEndpointGroup(endpointGroupId)
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .setEndpointGroup(endpointGroupId)
+                .addAugmentation(FaasEndpointContext.class, faasEndpointContext1)
+                .build();
+        assertFalse(listener.validate(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .setEndpointGroup(endpointGroupId)
+                .addAugmentation(FaasEndpointContext.class, faasEndpointContext2)
+                .build();
+        assertTrue(listener.validate(ep));
+    }
+
+    @Test
+    public void testProcessEndpoint(){
+        EndpointGroupId endpointGroupId = new EndpointGroupId("epg-1");
+        FaasEndpointContext faasEndpointContext2 = new FaasEndpointContextBuilder()
+                .setFaasPortRefId(new Uuid("c4511aac-ae43-11e5-bf7f-feff819cdc9f")).build();
+
+        Endpoint ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .setEndpointGroup(endpointGroupId)
+                .addAugmentation(FaasEndpointContext.class, faasEndpointContext2)
+                .build();
+
+        listener.processEndpoint(ep);
+    }
+
+    @SuppressWarnings("unchecked")
+    @Test
+    public void testGetFaasSubnetId() throws ReadFailedException{
+        EndpointGroupId endpointGroupId = new EndpointGroupId("epg-1");
+        NetworkDomainId networkDomainId = new NetworkDomainId("network-domain-1");
+        FaasEndpointContext faasEndpointContext2 = new FaasEndpointContextBuilder()
+                .setFaasPortRefId(new Uuid("c4511aac-ae43-11e5-bf7f-feff819cdc9f")).build();
+        SubnetId subnetId = new SubnetId(networkDomainId);
+        ReadOnlyTransaction roTx1 = mock(ReadOnlyTransaction.class);
+        ReadWriteTransaction rwTx2 = mock(ReadWriteTransaction.class);
+
+        CheckedFuture<Optional<ResolvedPolicies>, ReadFailedException> futureResolvedPolicies = mock(CheckedFuture.class);
+        Optional<ResolvedPolicies> optResolvedPolicies = mock(Optional.class);
+        when(optResolvedPolicies.isPresent()).thenReturn(false);
+        when(futureResolvedPolicies.checkedGet()).thenReturn(optResolvedPolicies);
+        when(roTx1.read(LogicalDatastoreType.OPERATIONAL,
+                InstanceIdentifier.builder(ResolvedPolicies.class).build())).thenReturn(futureResolvedPolicies);
+
+        CheckedFuture<Optional<MappedSubnet>, ReadFailedException> futureMappedSubnet = mock(CheckedFuture.class);
+        Optional<MappedSubnet> optMappedSubnet = mock(Optional.class);
+        when(optMappedSubnet.isPresent()).thenReturn(false);
+        when(futureMappedSubnet.checkedGet()).thenReturn(optMappedSubnet);
+        when(rwTx2.read(LogicalDatastoreType.OPERATIONAL,
+                FaasIidFactory.mappedSubnetIid(gbpTenantId, subnetId))).thenReturn(futureMappedSubnet);
+
+        when(dataProvider.newReadOnlyTransaction()).thenReturn(roTx1);
+        when(dataProvider.newReadWriteTransaction()).thenReturn(rwTx2);
+
+        Endpoint ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .addAugmentation(FaasEndpointContext.class, faasEndpointContext2)
+                .build();
+
+        assertNull(listener.getFaasSubnetId(ep));
+
+        ep = new EndpointBuilder()
+                .setL2Context(L_2_BRIDGE_DOMAIN_ID)
+                .setL3Address(ImmutableList.of(new L3AddressBuilder().build()))
+                .setMacAddress(MAC_ADDRESS)
+                .setTenant(gbpTenantId)
+                .setEndpointGroup(endpointGroupId)
+                .setNetworkContainment(networkDomainId)
+                .addAugmentation(FaasEndpointContext.class, faasEndpointContext2)
+                .build();
+
+        assertNull(listener.getFaasSubnetId(ep));
+    }
+
     @Test
     public void testOnDataChanged_EndpointL3() {
         EndpointL3 ep = new EndpointL3Builder().setTenant(gbpTenantId)
OpenDaylight Group Based Policy Plugin