package org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.actionList;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.createBucketPath;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.createGroupPath;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.createNodePath;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.getOfPortNum;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.nxLoadTunIPv4Action;
-import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.outputAction;
-
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Map;
-
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Optional;
import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction;
-import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
+import org.opendaylight.groupbasedpolicy.dto.EgKey;
import org.opendaylight.groupbasedpolicy.renderer.ofoverlay.OfContext;
-import org.opendaylight.groupbasedpolicy.renderer.ofoverlay.PolicyManager.FlowMap;
+import org.opendaylight.groupbasedpolicy.renderer.ofoverlay.OfWriter;
+import org.opendaylight.groupbasedpolicy.renderer.ofoverlay.endpoint.EndpointManager;
import org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.OrdinalFactory.EndpointFwdCtxOrdinals;
-import org.opendaylight.groupbasedpolicy.resolver.EgKey;
-import org.opendaylight.groupbasedpolicy.resolver.PolicyInfo;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpAddress;
import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.ActionBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNode;
import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.BucketId;
import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupId;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupTypes;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.group.Buckets;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.group.BucketsBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.group.buckets.Bucket;
import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.group.buckets.BucketBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.groups.Group;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.groups.GroupBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.endpoint.rev140421.endpoints.Endpoint;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.ofoverlay.rev140528.EndpointLocation.LocationType;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.ofoverlay.rev140528.OfOverlayContext;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.ofoverlay.rev140528.Segmentation;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.policy.rev140421.tenants.tenant.forwarding.context.L2FloodDomain;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId;
import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.overlay.rev150105.TunnelTypeVxlan;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.base.Objects;
-import com.google.common.base.Optional;
-import com.google.common.collect.Ordering;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.concurrent.ExecutionException;
+
+import static org.opendaylight.groupbasedpolicy.renderer.ofoverlay.flow.FlowUtils.*;
/**
* Manage the group tables for handling broadcast/multicast
- *
*/
public class GroupTable extends OfTable {
- private static final Logger LOG =
- LoggerFactory.getLogger(GroupTable.class);
+
+ private static final Logger LOG = LoggerFactory.getLogger(GroupTable.class);
public GroupTable(OfContext ctx) {
super(ctx);
}
- // @Override
@Override
- public void update(NodeId nodeId, PolicyInfo policyInfo, FlowMap flowMap)
- throws Exception {
+ public void sync(Endpoint endpoint, OfWriter ofWriter) throws Exception {
+ NodeId endpointNodeId = ctx.getEndpointManager().getEndpointNodeId(endpoint);
+ if (endpointNodeId == null) {
+ LOG.warn("Endpoint {} has no location specified, skipped", endpoint);
+ return;
+ }
+
// there appears to be no way of getting only the existing group
- // tables unfortunately, so we have to get the whole goddamned node.
+ // tables unfortunately, so we have to get the whole node.
// Since this is happening concurrently with other things that are
// working in subtrees of nodes, we have to do two transactions
- ReadOnlyTransaction t = ctx.getDataBroker().newReadOnlyTransaction();
- InstanceIdentifier<Node> niid = createNodePath(nodeId);
- Optional<Node> r =
- t.read(LogicalDatastoreType.OPERATIONAL, niid).get();
- if (!r.isPresent())
- return;
- FlowCapableNode fcn = r.get().getAugmentation(FlowCapableNode.class);
+ FlowCapableNode fcn = getFCNodeFromDatastore(endpointNodeId);
if (fcn == null)
return;
-
- HashMap<GroupId, GroupCtx> groupMap = new HashMap<>();
-
- if (fcn.getGroup() != null) {
- for (Group g : fcn.getGroup()) {
- GroupCtx gctx = new GroupCtx(g.getGroupId());
- groupMap.put(g.getGroupId(), gctx);
-
- Buckets bs = g.getBuckets();
- if (bs != null && bs.getBucket() != null)
- for (Bucket b : bs.getBucket()) {
- gctx.bucketMap.put(b.getBucketId(), new BucketCtx(b));
- }
- }
+ EndpointFwdCtxOrdinals ordinals = OrdinalFactory.getEndpointFwdCtxOrdinals(ctx, endpoint);
+ if (ordinals == null) {
+ LOG.info("getEndpointFwdCtxOrdinals is null for EP {}", endpoint);
+ return;
}
-
- // sync(nodeId, policyInfo, dirty, groupMap);
- sync(nodeId, policyInfo, groupMap);
-
- WriteTransaction wt = ctx.getDataBroker().newWriteOnlyTransaction();
- boolean wrote = syncGroupToStore(wt, nodeId, groupMap);
- if (wrote)
- wt.submit().get();
+ GroupId groupId = new GroupId(Long.valueOf(ordinals.getFdId()));
+ if (!ofWriter.groupExists(endpointNodeId, groupId.getValue())) {
+ LOG.info("createGroup {} {}", endpointNodeId, groupId);
+ ofWriter.writeGroup(endpointNodeId, groupId);
+ }
+ syncGroups(endpointNodeId, ordinals, endpoint, groupId, ofWriter);
}
- protected boolean syncGroupToStore(WriteTransaction wt,
- NodeId nodeId,
- HashMap<GroupId, GroupCtx> groupMap) {
- boolean wrote = false;
- for (GroupCtx gctx : groupMap.values()) {
- InstanceIdentifier<Group> giid =
- createGroupPath(nodeId, gctx.groupId);
- if (!gctx.visited) {
- // Remove group table
- wrote = true;
- wt.delete(LogicalDatastoreType.CONFIGURATION, giid);
- } else {
- ArrayList<Bucket> buckets = new ArrayList<>();
-
- // update group table
- for (BucketCtx bctx : gctx.bucketMap.values()) {
- BucketId bid;
- if (bctx.b != null)
- bid = bctx.b.getBucketId();
- else
- bid = bctx.newb.getBucketId();
- InstanceIdentifier<Bucket> biid =
- createBucketPath(nodeId,
- gctx.groupId,
- bid);
- if (!bctx.visited) {
- // remove bucket
- wrote = true;
- wt.delete(LogicalDatastoreType.CONFIGURATION, biid);
- } else if (bctx.b == null) {
- // new bucket
- buckets.add(bctx.newb);
- } else if (!Objects.equal(bctx.newb.getAction(),
- Ordering.from(ActionComparator.INSTANCE)
- .sortedCopy(bctx.b.getAction()))) {
- // update bucket
- buckets.add(bctx.newb);
+ @VisibleForTesting
+ void syncGroups(NodeId nodeId, EndpointFwdCtxOrdinals ordinals, Endpoint endpoint, GroupId groupId,
+ OfWriter ofWriter) throws Exception {
+ for (EgKey endpointGroupKey : ctx.getEndpointManager().getGroupsForNode(nodeId)) {
+ // we'll use the fdId with the high bit set for remote bucket
+ // and just the local port number for local bucket
+ for (NodeId destinationNode : findPeerNodesForGroup(endpointGroupKey)) {
+ if (nodeId.equals(destinationNode))
+ continue;
+ if (isFloodDomainOnNode(ordinals.getFdId(), destinationNode)) {
+ Long bucketId;
+ try {
+ bucketId = (long) OrdinalFactory.getContextOrdinal(destinationNode);
+ } catch (Exception e) {
+ LOG.error("Error during getting of context ordinal, node: {}", destinationNode);
+ continue;
}
- }
- if (buckets.size() > 0) {
- GroupBuilder gb = new GroupBuilder()
- .setGroupId(gctx.groupId)
- .setGroupType(GroupTypes.GroupAll)
- .setBuckets(new BucketsBuilder()
- .setBucket(buckets)
- .build());
- wrote = true;
- wt.merge(LogicalDatastoreType.CONFIGURATION,
- giid, gb.build(), true);
+ bucketId |= 1L << 31;
+ IpAddress tunDst = ctx.getSwitchManager().getTunnelIP(destinationNode, TunnelTypeVxlan.class);
+ NodeConnectorId tunPort = ctx.getSwitchManager().getTunnelPort(nodeId, TunnelTypeVxlan.class);
+ if (tunDst == null || tunPort == null)
+ continue;
+ Action tunDstAction;
+ if (tunDst.getIpv4Address() != null) {
+ String nextHop = tunDst.getIpv4Address().getValue();
+ tunDstAction = nxLoadTunIPv4Action(nextHop, true);
+ } else {
+ LOG.error("IPv6 tunnel destination {} for {} not supported", tunDst.getIpv6Address().getValue(),
+ destinationNode);
+ continue;
+ }
+ BucketBuilder bucketBuilder = new BucketBuilder().setBucketId(new BucketId(bucketId))
+ .setAction(actionList(tunDstAction, outputAction(tunPort)));
+ ofWriter.writeBucket(nodeId, groupId, bucketBuilder.build());
}
}
- }
- return wrote;
- }
-
- protected void sync(NodeId nodeId, PolicyInfo policyInfo, HashMap<GroupId, GroupCtx> groupMap) throws Exception {
-
-
- for (Endpoint localEp : ctx.getEndpointManager().getEndpointsForNode(nodeId)) {
- EndpointFwdCtxOrdinals localEpFwdCtxOrds = OrdinalFactory.getEndpointFwdCtxOrdinals(ctx, policyInfo, localEp);
- GroupId gid = new GroupId(Long.valueOf(localEpFwdCtxOrds.getFdId()));
- GroupCtx gctx = groupMap.get(gid);
- if (gctx == null) {
- groupMap.put(gid, gctx = new GroupCtx(gid));
- }
- gctx.visited = true;
-
- for (EgKey epg : ctx.getEndpointManager().getGroupsForNode(nodeId)) {
-
-
- // we'll use the fdId with the high bit set for remote bucket
- // and just the local port number for local bucket
- for (NodeId destNode : ctx.getEndpointManager().getNodesForGroup(epg)) {
- if (nodeId.equals(destNode))
- continue;
-
- long bucketId = OrdinalFactory.getContextOrdinal(destNode);
- bucketId |= 1L << 31;
-
- IpAddress tunDst =
- ctx.getSwitchManager().getTunnelIP(destNode, TunnelTypeVxlan.class);
- NodeConnectorId tunPort =
- ctx.getSwitchManager().getTunnelPort(nodeId, TunnelTypeVxlan.class);
- if (tunDst == null || tunPort == null)
- continue;
- Action tundstAction = null;
- if (tunDst.getIpv4Address() != null) {
- String nextHop = tunDst.getIpv4Address().getValue();
- tundstAction = nxLoadTunIPv4Action(nextHop, true);
- } else {
- LOG.error("IPv6 tunnel destination {} for {} not supported",
- tunDst.getIpv6Address().getValue(),
- destNode);
- continue;
+ // TODO broadcasts are not separated by EPG between endpoints on the same node
+ OfOverlayContext ofc = endpoint.getAugmentation(OfOverlayContext.class);
+ if (EndpointManager.isExternal(endpoint, ctx.getTenant(endpoint.getTenant()).getExternalImplicitGroups()))
+ continue;
+ long bucketId;
+ try {
+ bucketId = getOfPortNum(ofc.getNodeConnectorId());
+ } catch (NumberFormatException e) {
+ LOG.warn("Could not parse port number {}", ofc.getNodeConnectorId(), e);
+ continue;
+ }
+ Action output = outputAction(ofc.getNodeConnectorId());
+ BucketBuilder bb = new BucketBuilder().setBucketId(new BucketId(bucketId)).setAction(
+ FlowUtils.actionList(output));
+ ofWriter.writeBucket(nodeId, groupId, bb.build());
+ // if broadcast exceeds internal domain
+ for (Endpoint extEp : ctx.getEndpointManager().getExtEpsNoLocForGroup(endpointGroupKey)) {
+ if (extEp.getNetworkContainment() != null
+ && extEp.getNetworkContainment().equals(endpoint.getNetworkContainment())) {
+ L2FloodDomain l2Fd = ctx.getTenant(extEp.getTenant())
+ .resolveL2FloodDomain(extEp.getNetworkContainment());
+ if (l2Fd != null) {
+ Segmentation segmentation = l2Fd.getAugmentation(Segmentation.class);
+ // external endpoints do not have location augmentation
+ // however they are beyond external ports
+ for (NodeConnectorId extNcId : ctx.getSwitchManager().getExternalPorts(nodeId)) {
+ try {
+ bucketId = getOfPortNum(extNcId);
+ } catch (NumberFormatException e) {
+ LOG.warn("Could not parse external port number {}", extNcId, e);
+ continue;
+ }
+ ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.ActionBuilder>
+ actionList = new ArrayList<>();
+ if (segmentation != null) {
+ Integer vlanId = segmentation.getSegmentationId();
+ actionList.addAll(FlowUtils.pushVlanActions(vlanId));
+ actionList.add(new ActionBuilder().setOrder(2).setAction(outputAction(extNcId)));
+ } else {
+ actionList.add(new ActionBuilder().setOrder(0).setAction(outputAction(extNcId)));
+ }
+ bb.setBucketId(new BucketId(bucketId)).setAction(
+ FlowUtils.actionList(actionList));
+ ofWriter.writeBucket(nodeId, groupId, bb.build());
}
- BucketBuilder bb = new BucketBuilder().setBucketId(new BucketId(Long.valueOf(bucketId))).setAction(actionList(tundstAction, outputAction(tunPort)));
-
-
-
- updateBucket(gctx, bb);
}
- OfOverlayContext ofc =
- localEp.getAugmentation(OfOverlayContext.class);
- if (ofc == null || ofc.getNodeConnectorId() == null ||
- (LocationType.External.equals(ofc.getLocationType())))
- continue;
-
- long bucketId;
- try {
- bucketId = getOfPortNum(ofc.getNodeConnectorId());
- } catch (NumberFormatException e) {
- LOG.warn("Could not parse port number {}",
- ofc.getNodeConnectorId(), e);
- continue;
}
-
- Action output = outputAction(ofc.getNodeConnectorId());
- BucketBuilder bb = new BucketBuilder()
- .setBucketId(new BucketId(Long.valueOf(bucketId)))
- .setAction(actionList(output));
- updateBucket(gctx, bb);
}
}
+
}
- private static void updateBucket(GroupCtx gctx, BucketBuilder bb) {
- BucketCtx bctx = gctx.bucketMap.get(bb.getBucketId());
- if (bctx == null) {
- gctx.bucketMap.put(bb.getBucketId(),
- bctx = new BucketCtx(null));
+ /**
+ * @param sourceEpgKey a key of source group
+ * @return all the nodes on which endpoints are either in groups that have policy with source
+ * group, or are in the source group
+ */
+ private Set<NodeId> findPeerNodesForGroup(EgKey sourceEpgKey) {
+ Set<NodeId> nodes = new HashSet<>();
+ nodes.addAll(ctx.getEndpointManager().getNodesForGroup(sourceEpgKey));
+ for (EgKey dstEpGroups : ctx.getCurrentPolicy().getPeers(sourceEpgKey)) {
+ nodes.addAll(ctx.getEndpointManager().getNodesForGroup(dstEpGroups));
}
- bctx.visited = true;
- bctx.newb = bb.build();
+ return nodes;
}
- protected static class BucketCtx {
- Bucket b;
- Bucket newb;
- boolean visited = false;
-
- public BucketCtx(Bucket b) {
- super();
- this.b = b;
+ private boolean isFloodDomainOnNode(int fdId, NodeId node) throws Exception {
+ for (Endpoint endpoint : ctx.getEndpointManager().getEndpointsForNode(node)) {
+ EndpointFwdCtxOrdinals endpointFwdCtxOrdinals = OrdinalFactory.getEndpointFwdCtxOrdinals(ctx, endpoint);
+ if (endpointFwdCtxOrdinals == null) {
+ continue;
+ }
+ int epFdId = endpointFwdCtxOrdinals.getFdId();
+ if (fdId == epFdId) {
+ return true;
+ }
}
+ return false;
}
- protected static class GroupCtx {
- GroupId groupId;
- Map<BucketId, BucketCtx> bucketMap = new HashMap<>();
- boolean visited = false;
+ private FlowCapableNode getFCNodeFromDatastore(NodeId nodeId)
+ throws ExecutionException, InterruptedException {
+ ReadOnlyTransaction t = ctx.getDataBroker().newReadOnlyTransaction();
+ InstanceIdentifier<FlowCapableNode> fcnIid = createNodePath(nodeId).builder()
+ .augmentation(FlowCapableNode.class).build();
- public GroupCtx(GroupId groupId) {
- super();
- this.groupId = groupId;
+ Optional<FlowCapableNode> r = t.read(LogicalDatastoreType.OPERATIONAL, fcnIid).get();
+ if (!r.isPresent()) {
+ LOG.warn("Node {} is not present", fcnIid);
+ return null;
}
+ FlowCapableNode fcn = r.get();
+ t.close();
+ return fcn;
}
}