package org.opendaylight.groupbasedpolicy.renderer.vpp.iface;
+import java.util.List;
+import java.util.Set;
import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ExecutorService;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import org.opendaylight.controller.md.sal.binding.api.DataBroker;
-import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction;
+import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction;
import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
-import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException;
-import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.ConfigCommand;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.AbstractInterfaceCommand;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.LoopbackCommand;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.TapPortCommand;
import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.VhostUserCommand;
import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.VhostUserCommand.VhostUserCommandBuilder;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.commands.interfaces.ConfigCommand;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.config.ConfigUtil;
import org.opendaylight.groupbasedpolicy.renderer.vpp.event.NodeOperEvent;
import org.opendaylight.groupbasedpolicy.renderer.vpp.event.VppEndpointConfEvent;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.lisp.flat.overlay.FlatOverlayManager;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.policy.acl.AccessListWrapper;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.util.GbpNetconfTransaction;
import org.opendaylight.groupbasedpolicy.renderer.vpp.util.General.Operations;
import org.opendaylight.groupbasedpolicy.renderer.vpp.util.MountedDataBrokerProvider;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.util.VppIidFactory;
+import org.opendaylight.groupbasedpolicy.renderer.vpp.util.VppRendererProcessingException;
import org.opendaylight.groupbasedpolicy.util.DataStoreHelper;
+import org.opendaylight.vbd.impl.transaction.VbdNetconfTransaction;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.Interface;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.InterfaceKey;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.base_endpoint.rev160427.has.absolute.location.absolute.location.LocationType;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.base_endpoint.rev160427.has.absolute.location.absolute.location.location.type.ExternalLocationCase;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.base_endpoint.rev160427.has.absolute.location.absolute.location.location.type.ExternalLocationCaseBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.renderer.rev151103.renderers.renderer.renderer.policy.configuration.endpoints.AddressEndpointWithLocation;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425.ExcludeFromPolicy;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425._interface.attributes.InterfaceTypeChoice;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425._interface.attributes._interface.type.choice.LoopbackCase;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425._interface.attributes._interface.type.choice.TapCase;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425._interface.attributes._interface.type.choice.VhostUserCase;
import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425.config.VppEndpoint;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425.config.vpp.endpoint.InterfaceTypeChoice;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.groupbasedpolicy.vpp_renderer.rev160425.config.vpp.endpoint._interface.type.choice.VhostUserCase;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VhostUserRole;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VppInterfaceAugmentation;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces._interface.L2;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces._interface.L2Builder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.l2.base.attributes.Interconnection;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.l2.base.attributes.interconnection.BridgeBased;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.l2.base.attributes.interconnection.BridgeBasedBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.VhostUserRole;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.VppInterfaceAugmentation;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.interfaces._interface.L2;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.interfaces._interface.L2Builder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.l2.config.attributes.Interconnection;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.l2.config.attributes.interconnection.BridgeBased;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev170607.l2.config.attributes.interconnection.BridgeBasedBuilder;
+import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NodeId;
+import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
+import com.google.common.collect.HashMultimap;
+import com.google.common.collect.SetMultimap;
import com.google.common.eventbus.Subscribe;
-import com.google.common.util.concurrent.AsyncFunction;
-import com.google.common.util.concurrent.CheckedFuture;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.MoreExecutors;
public class InterfaceManager implements AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(InterfaceManager.class);
private final MountedDataBrokerProvider mountDataProvider;
private final VppEndpointLocationProvider vppEndpointLocationProvider;
- private final ExecutorService netconfWorker;
+ private final SetMultimap<NodeId, String> excludedFromPolicy = HashMultimap.create();
+ private final FlatOverlayManager flatOverlayManager;
- public InterfaceManager(@Nonnull MountedDataBrokerProvider mountDataProvider, @Nonnull DataBroker dataProvider, @Nonnull ExecutorService netconfWorker) {
+ public InterfaceManager(@Nonnull MountedDataBrokerProvider mountDataProvider, @Nonnull DataBroker dataProvider,
+ FlatOverlayManager flatOverlayManager) {
this.mountDataProvider = Preconditions.checkNotNull(mountDataProvider);
- this.netconfWorker = Preconditions.checkNotNull(netconfWorker);
this.vppEndpointLocationProvider = new VppEndpointLocationProvider(dataProvider);
+ this.flatOverlayManager = flatOverlayManager;
}
@Subscribe
+ @SuppressWarnings("OptionalGetWithoutIsPresent")
public synchronized void vppEndpointChanged(VppEndpointConfEvent event) {
+ String message;
+ final VppEndpoint oldVppEndpoint = event.getBefore().orNull();
+ final VppEndpoint newVppEndpoint = event.getAfter().orNull();
try {
- switch (event.getDtoModificationType()) {
- case CREATED:
- vppEndpointCreated(event.getAfter().get()).get();
- break;
- case UPDATED:
- vppEndpointDeleted(event.getBefore().get()).get();
- vppEndpointCreated(event.getAfter().get()).get();
- break;
- case DELETED:
- vppEndpointDeleted(event.getBefore().get()).get();
- break;
+ switch (event.getDtoModificationType()) {
+ case CREATED: {
+ Preconditions.checkNotNull(newVppEndpoint);
+ vppEndpointCreated(newVppEndpoint).get();
+ message = String.format("Vpp endpoint %s on node %s and interface %s created",
+ newVppEndpoint.getAddress(), newVppEndpoint.getVppNodeId().getValue(),
+ newVppEndpoint.getVppInterfaceName());
+ updatePolicyExcludedEndpoints(newVppEndpoint, true).get();
+ }
+ break;
+ case UPDATED: {
+ Preconditions.checkNotNull(oldVppEndpoint);
+ Preconditions.checkNotNull(newVppEndpoint);
+ vppEndpointUpdated(oldVppEndpoint, newVppEndpoint).get();
+ message = String.format("Vpp endpoint %s on node %s and interface %s updated",
+ newVppEndpoint.getAddress(), newVppEndpoint.getVppNodeId().getValue(),
+ newVppEndpoint.getVppInterfaceName());
+ updatePolicyExcludedEndpoints(oldVppEndpoint, true).get();
}
+ break;
+ case DELETED: {
+ Preconditions.checkNotNull(oldVppEndpoint);
+ vppEndpointDeleted(oldVppEndpoint).get();
+ message = String.format("Vpp endpoint %s on node %s and interface %s removed",
+ oldVppEndpoint.getAddress(), oldVppEndpoint.getVppNodeId().getValue(),
+ oldVppEndpoint.getVppInterfaceName());
+ updatePolicyExcludedEndpoints(event.getBefore().get(), false).get();
+ }
+ break;
+ default: {
+ message = "Unknown event modification type: " + event.getDtoModificationType();
+ LOG.error("Failed to process VPP endpoint {}. {}",
+ (oldVppEndpoint != null) ? oldVppEndpoint.getKey() : newVppEndpoint.getKey(),
+ event.getAfter(), new VppRendererProcessingException(message));
+ }
+ }
+ LOG.info(message);
} catch (InterruptedException | ExecutionException e) {
- LOG.error("Failed to update Vpp Endpoint. {}", e);
- e.printStackTrace();
+ LOG.error("Failed to process changed vpp endpoint. before: {}, after: {}.Exception: {} ", event.getBefore(),
+ event.getAfter(), e);
}
}
+ private ListenableFuture<Boolean> updatePolicyExcludedEndpoints(VppEndpoint vppEndpoint, boolean created) {
+ if (vppEndpoint == null || vppEndpoint.getAugmentation(ExcludeFromPolicy.class) == null) {
+ return Futures.immediateFuture(true);
+ }
+ if (created) {
+ LOG.trace("Interface excluded from policy: node:{} interface:{}", vppEndpoint.getVppNodeId(),
+ vppEndpoint.getVppInterfaceName());
+ excludedFromPolicy.put(vppEndpoint.getVppNodeId(), vppEndpoint.getVppInterfaceName());
+ return Futures.immediateFuture(true);
+ }
+ return Futures.immediateFuture(excludedFromPolicy.remove(vppEndpoint.getVppNodeId(),
+ vppEndpoint.getVppInterfaceName()));
+ }
+
private ListenableFuture<Void> vppEndpointCreated(VppEndpoint vppEndpoint) {
- Optional<ConfigCommand> potentialIfaceCommand = createInterfaceWithoutBdCommand(vppEndpoint, Operations.PUT);
+ InterfaceTypeChoice interfaceTypeChoice = vppEndpoint.getInterfaceTypeChoice();
+ LOG.trace("Creating VPP endpoint {}, type of {}", vppEndpoint, interfaceTypeChoice);
+ Optional<AbstractInterfaceCommand> potentialIfaceCommand = Optional.absent();
+ if (interfaceTypeChoice instanceof VhostUserCase) {
+ potentialIfaceCommand = createVhostInterfaceWithoutBdCommand(vppEndpoint, Operations.PUT);
+ } else if (interfaceTypeChoice instanceof TapCase) {
+ potentialIfaceCommand = createTapInterfaceWithoutBdCommand(vppEndpoint, Operations.PUT);
+ } else if (interfaceTypeChoice instanceof LoopbackCase){
+ if (!ConfigUtil.getInstance().isL3FlatEnabled()) {
+ potentialIfaceCommand = createLoopbackWithoutBdCommand(vppEndpoint, Operations.PUT);
+ }
+ else {
+ LOG.trace("L3 flat enabled: Creating of Loopback BVI disabled in InterfaceManager. LISP in VPP renderer will take care of this.");
+ }
+ }
if (!potentialIfaceCommand.isPresent()) {
+ LOG.debug("Interface/PUT command was not created for VppEndpoint point {}", vppEndpoint);
return Futures.immediateFuture(null);
}
ConfigCommand ifaceWithoutBdCommand = potentialIfaceCommand.get();
- InstanceIdentifier<?> vppNodeIid = vppEndpoint.getVppNodePath();
- Optional<DataBroker> potentialVppDataProvider = mountDataProvider.getDataBrokerForMountPoint(vppNodeIid);
+ InstanceIdentifier<Node> vppNodeIid = VppIidFactory.getNetconfNodeIid(vppEndpoint.getVppNodeId());
+ Optional<DataBroker> potentialVppDataProvider = mountDataProvider.resolveDataBrokerForMountPoint(vppNodeIid);
if (!potentialVppDataProvider.isPresent()) {
- LOG.debug("Cannot get data broker for mount point {}", vppNodeIid);
- Futures.immediateFuture(null);
+ final String message = "Cannot get data broker for mount point " + vppNodeIid;
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
}
- DataBroker vppDataBroker = potentialVppDataProvider.get();
- return createIfaceOnVpp(ifaceWithoutBdCommand, vppDataBroker, vppEndpoint, vppNodeIid);
+ return createInterfaceWithEndpointLocation(ifaceWithoutBdCommand, vppNodeIid, vppEndpoint);
}
- private ListenableFuture<Void> createIfaceOnVpp(ConfigCommand createIfaceWithoutBdCommand,
- DataBroker vppDataBroker, VppEndpoint vppEndpoint, InstanceIdentifier<?> vppNodeIid) {
- ReadWriteTransaction rwTx = vppDataBroker.newReadWriteTransaction();
- createIfaceWithoutBdCommand.execute(rwTx);
- return Futures.transform(rwTx.submit(), new AsyncFunction<Void, Void>() {
-
- @Override
- public ListenableFuture<Void> apply(Void input) {
- LOG.debug("Create interface on VPP command was successful:\nVPP: {}\nCommand: {}", vppNodeIid,
- createIfaceWithoutBdCommand);
- return vppEndpointLocationProvider.createLocationForVppEndpoint(vppEndpoint);
- }
- }, netconfWorker);
+ public ListenableFuture<Void> createInterfaceOnVpp(final ConfigCommand createIfaceWithoutBdCommand,
+ final InstanceIdentifier<Node> vppIid) {
+ final boolean transactionState = GbpNetconfTransaction.netconfSyncedWrite(vppIid, createIfaceWithoutBdCommand,
+ GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ LOG.trace("Creating Interface on VPP: {}", createIfaceWithoutBdCommand);
+ return Futures.immediateFuture(null);
+ } else {
+ final String message = "Failed to create Interface on VPP: " + createIfaceWithoutBdCommand;
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
+ }
+
+ private ListenableFuture<Void> createInterfaceWithEndpointLocation(final ConfigCommand createIfaceWithoutBdCommand,
+ final InstanceIdentifier<Node> vppIid,
+ final VppEndpoint vppEndpoint) {
+ final boolean transactionState = GbpNetconfTransaction.netconfSyncedWrite(vppIid, createIfaceWithoutBdCommand,
+ GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ LOG.debug("Create interface on VPP command was successful. VPP: {} Command: {}", vppIid,
+ createIfaceWithoutBdCommand);
+ return vppEndpointLocationProvider.createLocationForVppEndpoint(vppEndpoint);
+ } else {
+ final String message = "Create interface on VPP command was not successful. VPP: " + vppIid
+ + " Command: " + createIfaceWithoutBdCommand;
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
+ }
+
+ private ListenableFuture<Void> vppEndpointUpdated(@Nonnull final VppEndpoint oldVppEndpoint,
+ @Nonnull final VppEndpoint newVppEndpoint) {
+ if(!oldVppEndpoint.equals(newVppEndpoint)) {
+ LOG.debug("Updating vpp endpoint, old EP: {} new EP: {}", oldVppEndpoint, newVppEndpoint);
+ return Futures.transformAsync(vppEndpointDeleted(oldVppEndpoint),
+ input -> vppEndpointCreated(newVppEndpoint), MoreExecutors.directExecutor());
+ }
+ LOG.debug("Update skipped, provided before/after vpp endpoints are equal");
+ return Futures.immediateFuture(null);
}
- private ListenableFuture<Void> vppEndpointDeleted(VppEndpoint vppEndpoint) {
- Optional<ConfigCommand> potentialIfaceCommand = createInterfaceWithoutBdCommand(vppEndpoint, Operations.DELETE);
+ private ListenableFuture<Void> vppEndpointDeleted(@Nonnull VppEndpoint vppEndpoint) {
+ InterfaceTypeChoice interfaceTypeChoice = vppEndpoint.getInterfaceTypeChoice();
+ LOG.trace("Deleting VPP endpoint {}, type of {}", vppEndpoint, interfaceTypeChoice.toString());
+ Optional<AbstractInterfaceCommand> potentialIfaceCommand = Optional.absent();
+ if (interfaceTypeChoice instanceof VhostUserCase) {
+ potentialIfaceCommand = createVhostInterfaceWithoutBdCommand(vppEndpoint, Operations.DELETE);
+ } else if (interfaceTypeChoice instanceof TapCase) {
+ potentialIfaceCommand = createTapInterfaceWithoutBdCommand(vppEndpoint, Operations.DELETE);
+ } else if (interfaceTypeChoice instanceof LoopbackCase){
+ if (!ConfigUtil.getInstance().isL3FlatEnabled()) {
+ potentialIfaceCommand = createLoopbackWithoutBdCommand(vppEndpoint, Operations.DELETE);
+ }
+ else {
+ LOG.trace("L3 flat enabled: Deleting of Loopback BVI disabled in InterfaceManager. LISP in VPP renderer will take care of this.");
+ }
+ }
+
+
if (!potentialIfaceCommand.isPresent()) {
+ LOG.debug("Interface/DELETE command was not created for VppEndpoint point {}", vppEndpoint);
return Futures.immediateFuture(null);
}
- ConfigCommand ifaceWithoutBdCommand = potentialIfaceCommand.get();
- InstanceIdentifier<?> vppNodeIid = vppEndpoint.getVppNodePath();
- Optional<DataBroker> potentialVppDataProvider = mountDataProvider.getDataBrokerForMountPoint(vppNodeIid);
+ AbstractInterfaceCommand ifaceWithoutBdCommand = potentialIfaceCommand.get();
+ InstanceIdentifier<Node> vppNodeIid = VppIidFactory.getNetconfNodeIid(vppEndpoint.getVppNodeId());
+ Optional<DataBroker> potentialVppDataProvider = mountDataProvider.resolveDataBrokerForMountPoint(vppNodeIid);
if (!potentialVppDataProvider.isPresent()) {
- LOG.debug("Cannot get data broker for mount point {}", vppNodeIid);
- return Futures.immediateFuture(null);
+ final String message = "Cannot get data broker for mount point " + vppNodeIid;
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
}
DataBroker vppDataBroker = potentialVppDataProvider.get();
- return deleteIfaceOnVpp(ifaceWithoutBdCommand, vppDataBroker, vppEndpoint, vppNodeIid);
- }
-
- private ListenableFuture<Void> deleteIfaceOnVpp(ConfigCommand deleteIfaceWithoutBdCommand,
- DataBroker vppDataBroker, VppEndpoint vppEndpoint, InstanceIdentifier<?> vppNodeIid) {
- ReadWriteTransaction rwTx = vppDataBroker.newReadWriteTransaction();
- deleteIfaceWithoutBdCommand.execute(rwTx);
- return Futures.transform(rwTx.submit(), new AsyncFunction<Void, Void>() {
+ if (ConfigUtil.getInstance().isL3FlatEnabled()) {
+ flatOverlayManager.handleInterfaceDeleteForFlatOverlay(vppDataBroker, vppEndpoint);
+ }
+ return deleteIfaceOnVpp(ifaceWithoutBdCommand, vppNodeIid, vppEndpoint);
+ }
- @Override
- public ListenableFuture<Void> apply(Void input) {
- LOG.debug("Delete interface on VPP command was successful:\nVPP: {}\nCommand: {}", vppNodeIid,
- deleteIfaceWithoutBdCommand);
- return vppEndpointLocationProvider.deleteLocationForVppEndpoint(vppEndpoint);
- }
- }, netconfWorker);
+ private ListenableFuture<Void> deleteIfaceOnVpp(AbstractInterfaceCommand interfaceCommand,
+ InstanceIdentifier<Node> vppIid, VppEndpoint vppEndpoint) {
+ final boolean transactionState = GbpNetconfTransaction.netconfSyncedDelete(vppIid, interfaceCommand,
+ GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ LOG.debug("Delete interface on VPP command was successful: VPP: {} Command: {}", vppIid, interfaceCommand);
+ AccessListWrapper.removeAclsForInterface(vppIid, new InterfaceKey(interfaceCommand.getName()));
+ return vppEndpointLocationProvider.deleteLocationForVppEndpoint(vppEndpoint);
+ } else {
+ final String message = "Delete interface on VPP command was not successful: VPP: " + vppIid
+ + " Command: " + interfaceCommand;
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
}
@Subscribe
break;
case DELETED:
if (event.isBeforeConnected()) {
- // TODO we could do snapshot of VppEndpoints
+ // TODO we could do snapshot of VppEndpoints
// which can be used for reconciliation
}
break;
}
}
- private static Optional<ConfigCommand> createInterfaceWithoutBdCommand(@Nonnull VppEndpoint vppEp,
- @Nonnull Operations operations) {
+ private Optional<AbstractInterfaceCommand> createVhostInterfaceWithoutBdCommand(@Nonnull VppEndpoint vppEp,
+ @Nonnull Operations operations) {
if (!hasNodeAndInterface(vppEp)) {
LOG.debug("Interface command is not created for {}", vppEp);
return Optional.absent();
builder.setSocket(socket);
builder.setRole(VhostUserRole.Client);
}
+ if (ConfigUtil.getInstance().isL3FlatEnabled()) {
+ builder.setEnableProxyArp(true);
+ builder.setSnatEnabled(true);
+ }
VhostUserCommand vhostUserCommand =
builder.setOperation(operations).setDescription(vppEp.getDescription()).build();
return Optional.of(vhostUserCommand);
}
+ private Optional<AbstractInterfaceCommand> createTapInterfaceWithoutBdCommand(@Nonnull VppEndpoint vppEp,
+ @Nonnull Operations operation) {
+ if (!hasNodeAndInterface(vppEp)) {
+ LOG.debug("Interface command is not created for {}", vppEp);
+ return Optional.absent();
+ }
+ TapPortCommand.TapPortCommandBuilder builder = TapPortCommand.builder();
+ InterfaceTypeChoice interfaceTypeChoice = vppEp.getInterfaceTypeChoice();
+ if (interfaceTypeChoice instanceof TapCase) {
+ TapCase tapIface = (TapCase) interfaceTypeChoice;
+ String name = tapIface.getName();
+ if (Strings.isNullOrEmpty(name)) {
+ LOG.debug("Tap interface command is not created because name is missing. {}", vppEp);
+ return Optional.absent();
+ }
+ builder.setTapName(name);
+ }
+
+ if (ConfigUtil.getInstance().isL3FlatEnabled()) {
+ builder.setEnableProxyArp(true);
+ }
+
+ TapPortCommand tapPortCommand = builder
+ .setOperation(operation)
+ .setDescription(vppEp.getDescription())
+ .setInterfaceName(vppEp.getVppInterfaceName())
+ .build();
+ return Optional.of(tapPortCommand);
+ }
+
+ private Optional<AbstractInterfaceCommand> createLoopbackWithoutBdCommand(@Nonnull VppEndpoint vppEp,
+ @Nonnull Operations operation) {
+ if (!hasNodeAndInterface(vppEp)) {
+ LOG.debug("Interface command is not created for {}", vppEp);
+ return Optional.absent();
+ }
+ LoopbackCommand.LoopbackCommandBuilder builder = LoopbackCommand.builder();
+ LoopbackCase loopIface = (LoopbackCase) vppEp.getInterfaceTypeChoice();
+
+ builder.setPhysAddress(loopIface.getPhysAddress());
+ builder.setBvi(loopIface.isBvi());
+ builder.setIpAddress(loopIface.getIpAddress());
+ builder.setIpPrefix(loopIface.getIpPrefix());
+
+ LoopbackCommand loopbackCommand = builder
+ .setOperation(operation)
+ .setDescription(vppEp.getDescription())
+ .setInterfaceName(vppEp.getVppInterfaceName())
+ .build();
+
+ return Optional.of(loopbackCommand);
+ }
+
/**
* Adds bridge domain to an interface if the interface exist.<br>
* It rewrites bridge domain in case it already exist.<br>
* If the interface does not exist or other problems occur {@link ListenableFuture} will fail
* as {@link Futures#immediateFailedFuture(Throwable)} with {@link Exception}
* containing message in {@link Exception#getMessage()}
- *
+ *
* @param bridgeDomainName bridge domain
- * @param addrEpWithLoc {@link AddressEndpointWithLocation} containing
- * {@link ExternalLocationCase} where
- * {@link ExternalLocationCase#getExternalNodeMountPoint()} MUST NOT be {@code null}
- * and {@link ExternalLocationCase#getExternalNodeConnector()} MUST NOT be {@code null}
+ * @param addrEpWithLoc {@link AddressEndpointWithLocation} containing
+ * {@link ExternalLocationCase} where
+ * {@link ExternalLocationCase#getExternalNodeMountPoint()} MUST NOT be {@code null}
+ * and {@link ExternalLocationCase#getExternalNodeConnector()} MUST NOT be {@code null}
+ * @param aclWrappers wrappers for ACLs
+ * @param enableBvi BVI enabled/disabled
* @return {@link ListenableFuture}
*/
- public synchronized @Nonnull ListenableFuture<Void> addBridgeDomainToInterface(@Nonnull String bridgeDomainName,
- @Nonnull AddressEndpointWithLocation addrEpWithLoc) {
+ public synchronized ListenableFuture<Void> addBridgeDomainToInterface(@Nonnull String bridgeDomainName,
+ @Nonnull AddressEndpointWithLocation addrEpWithLoc,
+ @Nonnull List<AccessListWrapper> aclWrappers,
+ boolean enableBvi) {
ExternalLocationCase epLoc = resolveAndValidateLocation(addrEpWithLoc);
- InstanceIdentifier<?> vppNodeIid = epLoc.getExternalNodeMountPoint();
+ InstanceIdentifier<Node> vppNodeIid = (InstanceIdentifier<Node>) epLoc.getExternalNodeMountPoint();
String interfacePath = epLoc.getExternalNodeConnector();
Optional<InstanceIdentifier<Interface>> optInterfaceIid =
new Exception("Cannot resolve interface instance-identifier for interface path" + interfacePath));
}
InstanceIdentifier<Interface> interfaceIid = optInterfaceIid.get();
-
- Optional<DataBroker> potentialVppDataProvider = mountDataProvider.getDataBrokerForMountPoint(vppNodeIid);
+ Optional<DataBroker> potentialVppDataProvider = mountDataProvider.resolveDataBrokerForMountPoint(vppNodeIid);
if (!potentialVppDataProvider.isPresent()) {
return Futures.immediateFailedFuture(new Exception("Cannot get data broker for mount point " + vppNodeIid));
}
+ Optional<Interface> optInterface = GbpNetconfTransaction.read(vppNodeIid, LogicalDatastoreType.CONFIGURATION,
+ interfaceIid, GbpNetconfTransaction.RETRY_COUNT);
- ReadWriteTransaction rwTx = potentialVppDataProvider.get().newReadWriteTransaction();
- CheckedFuture<Optional<Interface>, ReadFailedException> futureIface =
- rwTx.read(LogicalDatastoreType.CONFIGURATION, interfaceIid);
- return Futures.transform(futureIface, new AsyncFunction<Optional<Interface>, Void>() {
+ if (!optInterface.isPresent()) {
+ return Futures.immediateFailedFuture(new Exception("Interface "
+ + interfaceIid.firstKeyOf(Interface.class) + " does not exist on node " + vppNodeIid));
+ }
+ String existingBridgeDomain = resolveBridgeDomain(optInterface.get());
+ if (bridgeDomainName.equals(existingBridgeDomain)) {
+ LOG.debug("Bridge domain {} already exists on interface {}", bridgeDomainName, interfacePath);
+ String bridgeDomainPath = VppPathMapper.bridgeDomainToRestPath(bridgeDomainName);
+ if (!bridgeDomainPath.equals(epLoc.getExternalNode())) {
+ return vppEndpointLocationProvider.replaceLocationForEndpoint(new ExternalLocationCaseBuilder()
+ .setExternalNode(bridgeDomainPath)
+ .setExternalNodeMountPoint(vppNodeIid)
+ .setExternalNodeConnector(interfacePath)
+ .build(), addrEpWithLoc.getKey());
+ }
+ return Futures.immediateFuture(null);
+ }
+ InstanceIdentifier<L2> l2Iid =
+ interfaceIid.builder().augmentation(VppInterfaceAugmentation.class).child(L2.class).build();
+ Optional<L2> optL2 = GbpNetconfTransaction.read(vppNodeIid, LogicalDatastoreType.CONFIGURATION,
+ l2Iid, GbpNetconfTransaction.RETRY_COUNT);
+ L2Builder l2Builder = (optL2.isPresent()) ? new L2Builder(optL2.get()) : new L2Builder();
+ L2 l2 = l2Builder.setInterconnection(new BridgeBasedBuilder()
+ .setBridgeDomain(bridgeDomainName)
+ .setBridgedVirtualInterface(enableBvi)
+ .build()).build();
+ LOG.debug("Adding bridge domain {} to interface {}", bridgeDomainName, interfacePath);
+ LOG.info("Debugging L2: iid={}, data={}", l2Iid, l2);
+ final boolean transactionState = GbpNetconfTransaction.netconfSyncedWrite(vppNodeIid, l2Iid, l2,
+ GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ LOG.debug("Adding bridge domain {} to interface {} successful", bridgeDomainName, interfacePath);
+ Set<String> excludedIfaces = excludedFromPolicy.get(vppNodeIid.firstKeyOf(Node.class).getNodeId());
+ if (!isExcludedFromPolicy(vppNodeIid.firstKeyOf(Node.class).getNodeId(),
+ interfaceIid.firstKeyOf(Interface.class).getName())) {
+ // can apply ACLs on interfaces in bridge domains
+ aclWrappers.forEach(aclWrapper -> {
+ LOG.debug("Writing access list for interface {} on a node {}.", interfaceIid, vppNodeIid);
+ aclWrapper.writeAcl(vppNodeIid, interfaceIid.firstKeyOf(Interface.class));
+ aclWrapper.writeAclRefOnIface(vppNodeIid, interfaceIid);
+ });
+ }
+ String bridgeDomainPath = VppPathMapper.bridgeDomainToRestPath(bridgeDomainName);
+ return vppEndpointLocationProvider.replaceLocationForEndpoint(new ExternalLocationCaseBuilder()
+ .setExternalNode(bridgeDomainPath)
+ .setExternalNodeMountPoint(vppNodeIid)
+ .setExternalNodeConnector(interfacePath)
+ .build(), addrEpWithLoc.getKey());
+ } else {
+ final String message = "Adding bridge domain " + bridgeDomainName + " to interface " + interfacePath + " failed";
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
+ }
- @Override
- public ListenableFuture<Void> apply(Optional<Interface> optIface) throws Exception {
- if (!optIface.isPresent()) {
- return Futures.immediateFailedFuture(new Exception("Iterface "
- + interfaceIid.firstKeyOf(Interface.class) + " does not exist on node " + vppNodeIid));
- }
+ public boolean isExcludedFromPolicy(@Nonnull NodeId nodeId,@Nonnull String interfaceName) {
+ Set<String> excludedIfaces = excludedFromPolicy.get(nodeId);
+ if(excludedIfaces != null && excludedIfaces.contains(interfaceName)) {
+ return true;
+ }
+ return false;
+ }
- String existingBridgeDomain = resolveBridgeDomain(optIface.get());
- if (bridgeDomainName.equals(existingBridgeDomain)) {
- LOG.debug("Bridge domain {} already exists on interface {}", bridgeDomainName, interfacePath);
- String bridgeDomainPath = VppPathMapper.bridgeDomainToRestPath(bridgeDomainName);
- if (!bridgeDomainPath.equals(epLoc.getExternalNode())) {
- return vppEndpointLocationProvider.replaceLocationForEndpoint(new ExternalLocationCaseBuilder()
- .setExternalNode(bridgeDomainPath)
- .setExternalNodeMountPoint(vppNodeIid)
- .setExternalNodeConnector(interfacePath)
- .build(), addrEpWithLoc.getKey());
- }
- return Futures.immediateFuture(null);
- }
+ public ListenableFuture<Void> configureInterface(InstanceIdentifier<Node> vppIid, InterfaceKey ifaceKey, @Nullable String bridgeDomainName,
+ @Nullable Boolean enableBvi) {
+ L2Builder l2Builder = readL2ForInterface(vppIid, ifaceKey);
+ L2 l2 = l2Builder.setInterconnection(new BridgeBasedBuilder()
+ .setBridgeDomain(bridgeDomainName)
+ .setBridgedVirtualInterface(enableBvi)
+ .build()).build();
+ final boolean transactionState = GbpNetconfTransaction.netconfSyncedWrite(vppIid,
+ VppIidFactory.getL2ForInterfaceIid(ifaceKey), l2, GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ LOG.debug("Adding bridge domain {} to interface {}", bridgeDomainName, VppIidFactory.getInterfaceIID(ifaceKey));
+ return Futures.immediateFuture(null);
+ } else {
+ final String message = "Failed to add bridge domain " + bridgeDomainName + " to interface "
+ + VppIidFactory.getInterfaceIID(ifaceKey);
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
+ }
- InstanceIdentifier<L2> l2Iid =
- interfaceIid.builder().augmentation(VppInterfaceAugmentation.class).child(L2.class).build();
- Optional<L2> optL2 = DataStoreHelper.readFromDs(LogicalDatastoreType.CONFIGURATION, l2Iid, rwTx);
- L2Builder l2Builder = (optL2.isPresent()) ? new L2Builder(optL2.get()) : new L2Builder();
- L2 l2 = l2Builder.setInterconnection(new BridgeBasedBuilder().setBridgeDomain(bridgeDomainName).build()).build();
- rwTx.put(LogicalDatastoreType.CONFIGURATION, l2Iid, l2);
- LOG.debug("Adding bridge domain {} to interface {}", bridgeDomainName, interfacePath);
- return Futures.transform(rwTx.submit(), new AsyncFunction<Void, Void>() {
-
- @Override
- public ListenableFuture<Void> apply(Void input) {
- String bridgeDomainPath = VppPathMapper.bridgeDomainToRestPath(bridgeDomainName);
- return vppEndpointLocationProvider.replaceLocationForEndpoint(new ExternalLocationCaseBuilder()
- .setExternalNode(bridgeDomainPath)
- .setExternalNodeMountPoint(vppNodeIid)
- .setExternalNodeConnector(interfacePath)
- .build(), addrEpWithLoc.getKey());
- }
- }, netconfWorker);
- }
- }, netconfWorker);
+ public ListenableFuture<Void> removeInterfaceFromBridgeDomain(InstanceIdentifier<Node> vppIid, InterfaceKey ifaceKey) {
+ L2Builder l2Builder = readL2ForInterface(vppIid, ifaceKey);
+ if (l2Builder.getInterconnection() == null || !(l2Builder.getInterconnection() instanceof BridgeBased)) {
+ LOG.warn("Interface already not in bridge domain {} ", ifaceKey);
+ return Futures.immediateFuture(null);
+ }
+ final boolean transactionState = GbpNetconfTransaction.netconfSyncedDelete(vppIid,
+ VppIidFactory.getL2ForInterfaceIid(ifaceKey), GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ LOG.debug("Removing bridge domain from interface {}", VppIidFactory.getInterfaceIID(ifaceKey));
+ return Futures.immediateFuture(null);
+ } else {
+ final String message = "Failed to remove bridge domain from interface "
+ + VppIidFactory.getInterfaceIID(ifaceKey);
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
+ }
+
+ private L2Builder readL2ForInterface(InstanceIdentifier<Node> vppIid, InterfaceKey ifaceKey) {
+ InstanceIdentifier<L2> l2Iid = VppIidFactory.getL2ForInterfaceIid(ifaceKey);
+ final ReadOnlyTransaction rwTxRead = VbdNetconfTransaction.NODE_DATA_BROKER_MAP.get(vppIid).getKey().newReadOnlyTransaction();
+ Optional<L2> optL2 = DataStoreHelper.readFromDs(LogicalDatastoreType.CONFIGURATION, l2Iid, rwTxRead);
+ rwTxRead.close();
+ return (optL2.isPresent()) ? new L2Builder(optL2.get()) : new L2Builder();
}
/**
- * <p>
* Removes bridge domain (if exist) from an interface (if exist).<br>
* {@link VppEndpointLocationProvider#VPP_ENDPOINT_LOCATION_PROVIDER} will update endpoint
* location.
* If the interface does not exist or other problems occur {@link ListenableFuture} will fail
* as {@link Futures#immediateFailedFuture(Throwable)} with {@link Exception}
* containing message in {@link Exception#getMessage()}
- *
+ *
* @param addrEpWithLoc {@link AddressEndpointWithLocation} containing
- * {@link ExternalLocationCase} where
- * {@link ExternalLocationCase#getExternalNodeMountPoint()} MUST NOT be {@code null}
- * and {@link ExternalLocationCase#getExternalNodeConnector()} MUST NOT be {@code null}
+ * {@link ExternalLocationCase} where
+ * {@link ExternalLocationCase#getExternalNodeMountPoint()} MUST NOT be {@code null}
+ * and {@link ExternalLocationCase#getExternalNodeConnector()} MUST NOT be {@code null}
* @return {@link ListenableFuture}
*/
public synchronized @Nonnull ListenableFuture<Void> deleteBridgeDomainFromInterface(
@Nonnull AddressEndpointWithLocation addrEpWithLoc) {
+ // TODO update ACLs for peers
ExternalLocationCase epLoc = resolveAndValidateLocation(addrEpWithLoc);
- InstanceIdentifier<?> vppNodeIid = epLoc.getExternalNodeMountPoint();
+ InstanceIdentifier<Node> vppNodeIid = (InstanceIdentifier<Node>) epLoc.getExternalNodeMountPoint();
String interfacePath = epLoc.getExternalNodeConnector();
Optional<InstanceIdentifier<Interface>> optInterfaceIid =
new Exception("Cannot resolve interface instance-identifier for interface path" + interfacePath));
}
InstanceIdentifier<Interface> interfaceIid = optInterfaceIid.get();
-
- Optional<DataBroker> potentialVppDataProvider = mountDataProvider.getDataBrokerForMountPoint(vppNodeIid);
+ Optional<DataBroker> potentialVppDataProvider = mountDataProvider.resolveDataBrokerForMountPoint(vppNodeIid);
if (!potentialVppDataProvider.isPresent()) {
return Futures.immediateFailedFuture(new Exception("Cannot get data broker for mount point " + vppNodeIid));
}
-
- ReadWriteTransaction rwTx = potentialVppDataProvider.get().newReadWriteTransaction();
- CheckedFuture<Optional<Interface>, ReadFailedException> futureIface =
- rwTx.read(LogicalDatastoreType.CONFIGURATION, interfaceIid);
- return Futures.transform(futureIface, new AsyncFunction<Optional<Interface>, Void>() {
-
- @Override
- public ListenableFuture<Void> apply(Optional<Interface> optIface) throws Exception {
- if (!optIface.isPresent()) {
- // interface does not exist so we consider job done
- return Futures.immediateFuture(null);
- }
-
- String existingBridgeDomain = resolveBridgeDomain(optIface.get());
- if (Strings.isNullOrEmpty(existingBridgeDomain)) {
- LOG.debug("Bridge domain does not exist therefore it is cosidered as"
- + "deleted for interface {}", interfacePath);
- // bridge domain does not exist on interface so we consider job done
- return vppEndpointLocationProvider.replaceLocationForEndpoint(new ExternalLocationCaseBuilder()
- .setExternalNode(null)
- .setExternalNodeMountPoint(vppNodeIid)
- .setExternalNodeConnector(interfacePath)
- .build(), addrEpWithLoc.getKey());
- }
-
- InstanceIdentifier<L2> l2Iid =
- interfaceIid.builder().augmentation(VppInterfaceAugmentation.class).child(L2.class).build();
- rwTx.delete(LogicalDatastoreType.CONFIGURATION, l2Iid);
- LOG.debug("Deleting bridge domain from interface {}", interfacePath);
- return Futures.transform(rwTx.submit(), new AsyncFunction<Void, Void>() {
-
- @Override
- public ListenableFuture<Void> apply(Void input) {
- return vppEndpointLocationProvider.replaceLocationForEndpoint(new ExternalLocationCaseBuilder()
- .setExternalNode(null)
- .setExternalNodeMountPoint(vppNodeIid)
- .setExternalNodeConnector(interfacePath)
- .build(), addrEpWithLoc.getKey());
- }
- }, netconfWorker);
- }
- }, netconfWorker);
+ final Optional<Interface> optInterface = GbpNetconfTransaction.read(vppNodeIid,
+ LogicalDatastoreType.CONFIGURATION, interfaceIid, GbpNetconfTransaction.RETRY_COUNT);
+ if (!optInterface.isPresent()) {
+ // interface does not exist so we consider job done
+ return Futures.immediateFuture(null);
+ }
+ String existingBridgeDomain = resolveBridgeDomain(optInterface.get());
+ if (Strings.isNullOrEmpty(existingBridgeDomain)) {
+ LOG.debug("Bridge domain does not exist therefore it is considered as deleted for interface {}",
+ interfacePath);
+ // bridge domain does not exist on interface so we consider job done
+ return vppEndpointLocationProvider.replaceLocationForEndpoint(
+ new ExternalLocationCaseBuilder().setExternalNode(null)
+ .setExternalNodeMountPoint(vppNodeIid)
+ .setExternalNodeConnector(interfacePath)
+ .build(),
+ addrEpWithLoc.getKey());
+ }
+ InstanceIdentifier<L2> l2Iid =
+ interfaceIid.builder().augmentation(VppInterfaceAugmentation.class).child(L2.class).build();
+ LOG.debug("Deleting bridge domain from interface {}", interfacePath);
+ final boolean transactionState =
+ GbpNetconfTransaction.netconfSyncedDelete(vppNodeIid, l2Iid, GbpNetconfTransaction.RETRY_COUNT);
+ if (transactionState) {
+ AccessListWrapper.removeAclRefFromIface(vppNodeIid, interfaceIid.firstKeyOf(Interface.class));
+ AccessListWrapper.removeAclsForInterface(vppNodeIid, interfaceIid.firstKeyOf(Interface.class));
+ return vppEndpointLocationProvider.replaceLocationForEndpoint(
+ new ExternalLocationCaseBuilder().setExternalNode(null)
+ .setExternalNodeMountPoint(vppNodeIid)
+ .setExternalNodeConnector(interfacePath)
+ .build(),
+ addrEpWithLoc.getKey());
+ } else {
+ final String message = "Failed to delete bridge domain from interface " + interfacePath;
+ LOG.warn(message);
+ return Futures.immediateFailedFuture(new VppRendererProcessingException(message));
+ }
}
- private static ExternalLocationCase resolveAndValidateLocation(AddressEndpointWithLocation addrEpWithLoc) {
+ public static ExternalLocationCase resolveAndValidateLocation(AddressEndpointWithLocation addrEpWithLoc) {
LocationType locationType = addrEpWithLoc.getAbsoluteLocation().getLocationType();
if (!(locationType instanceof ExternalLocationCase)) {
throw new IllegalArgumentException("Endpoint does not have external location " + addrEpWithLoc);
}
private static boolean hasNodeAndInterface(VppEndpoint vppEp) {
- if (vppEp.getVppNodePath() == null) {
+ if (vppEp.getVppNodeId() == null) {
LOG.debug("vpp-node is missing. {}", vppEp);
return false;
}
public void close() throws Exception {
vppEndpointLocationProvider.close();
}
-
}