*/
package org.opendaylight.restconf.nb.rfc8040.rests.utils;
-import com.google.common.util.concurrent.CheckedFuture;
+import com.google.common.util.concurrent.FluentFuture;
import javax.ws.rs.core.Response;
import javax.ws.rs.core.Response.Status;
-import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
-import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
-import org.opendaylight.controller.md.sal.dom.api.DOMDataReadWriteTransaction;
-import org.opendaylight.restconf.nb.rfc8040.handlers.TransactionChainHandler;
-import org.opendaylight.restconf.nb.rfc8040.rests.transactions.TransactionVarsWrapper;
+import org.opendaylight.mdsal.common.api.CommitInfo;
+import org.opendaylight.restconf.common.errors.RestconfDocumentedException;
+import org.opendaylight.restconf.common.errors.RestconfError.ErrorTag;
+import org.opendaylight.restconf.nb.rfc8040.rests.transactions.RestconfStrategy;
+import org.opendaylight.restconf.nb.rfc8040.rests.transactions.RestconfTransaction;
+import org.opendaylight.yangtools.yang.common.ErrorType;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Util class for delete specific data in config DS.
- *
*/
public final class DeleteDataTransactionUtil {
+ private static final Logger LOG = LoggerFactory.getLogger(DeleteDataTransactionUtil.class);
+ public static final String DELETE_TX_TYPE = "DELETE";
private DeleteDataTransactionUtil() {
throw new UnsupportedOperationException("Util class.");
/**
* Delete data from DS via transaction.
*
- * @param transactionNode
- * Wrapper for data of transaction
+ * @param strategy object that perform the actual DS operations
* @return {@link Response}
*/
- public static Response deleteData(final TransactionVarsWrapper transactionNode) {
- final CheckedFuture<Void, TransactionCommitFailedException> future = submitData(
- transactionNode.getTransactionChainHandler(),
- transactionNode.getInstanceIdentifier().getInstanceIdentifier());
+ public static Response deleteData(final RestconfStrategy strategy, final YangInstanceIdentifier path) {
+ final RestconfTransaction transaction = strategy.prepareWriteExecution();
+ try {
+ transaction.delete(path);
+ } catch (RestconfDocumentedException e) {
+ // close transaction if any and pass exception further
+ transaction.cancel();
+ throw e;
+ }
+ final FluentFuture<? extends CommitInfo> future = transaction.commit();
final ResponseFactory response = new ResponseFactory(Status.NO_CONTENT);
- FutureCallbackTx.addCallback(future, RestconfDataServiceConstant.DeleteData.DELETE_TX_TYPE, response);
+ //This method will close transactionChain if any
+ FutureCallbackTx.addCallback(future, DELETE_TX_TYPE, response, strategy, path);
return response.build();
}
/**
- * Delete data via transaction. Return error if data to delete does not exist.
+ * Check if items already exists at specified {@code path}. Throws {@link RestconfDocumentedException} if
+ * data does NOT already exists.
*
- * @param transactionChainHandler
- * transaction chain handler
- * @param readWriteTx
- * read and write transaction
- * @param path
- * path of data to delete
- * @return {@link CheckedFuture}
+ * @param isExistsFuture if checked data exists
+ * @param path Path to be checked
+ * @param operationType Type of operation (READ, POST, PUT, DELETE...)
*/
- private static CheckedFuture<Void, TransactionCommitFailedException> submitData(
- final TransactionChainHandler transactionChainHandler, final YangInstanceIdentifier path) {
- final DOMDataReadWriteTransaction readWriteTx = transactionChainHandler.get().newReadWriteTransaction();
- TransactionUtil.checkItemExists(transactionChainHandler, readWriteTx, LogicalDatastoreType.CONFIGURATION, path,
- RestconfDataServiceConstant.DeleteData.DELETE_TX_TYPE);
- readWriteTx.delete(LogicalDatastoreType.CONFIGURATION, path);
- return readWriteTx.submit();
+ public static void checkItemExists(final FluentFuture<Boolean> isExistsFuture,
+ final YangInstanceIdentifier path,
+ final String operationType) {
+ final FutureDataFactory<Boolean> response = new FutureDataFactory<>();
+ FutureCallbackTx.addCallback(isExistsFuture, operationType, response);
+
+ if (!response.result) {
+ LOG.trace("Operation via Restconf was not executed because data at {} does not exist", path);
+ throw new RestconfDocumentedException(
+ "Data does not exist", ErrorType.PROTOCOL, ErrorTag.DATA_MISSING, path);
+ }
}
}