Make ListenerAdapter serialize JSON directly
[netconf.git] / restconf / restconf-nb-rfc8040 / src / main / java / org / opendaylight / restconf / nb / rfc8040 / streams / listeners / ListenerAdapter.java
index 655e48bc39c1c15436c5d43a79ce8249e146f746..a237f17f73ad584ce0ef3cfe5487e093689e55da 100644 (file)
@@ -8,42 +8,26 @@
 package org.opendaylight.restconf.nb.rfc8040.streams.listeners;
 
 import static com.google.common.base.Preconditions.checkArgument;
-import static com.google.common.base.Preconditions.checkState;
 import static java.util.Objects.requireNonNull;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.MoreObjects;
-import java.io.IOException;
 import java.time.Instant;
 import java.util.Collection;
-import java.util.Map.Entry;
 import java.util.Optional;
-import javax.xml.stream.XMLStreamException;
-import javax.xml.transform.dom.DOMResult;
-import org.json.XML;
+import java.util.stream.Collectors;
+import javax.xml.xpath.XPathExpressionException;
 import org.opendaylight.mdsal.dom.api.ClusteredDOMDataTreeChangeListener;
+import org.opendaylight.restconf.common.formatters.DataTreeCandidateFormatter;
+import org.opendaylight.restconf.common.formatters.DataTreeCandidateFormatterFactory;
+import org.opendaylight.restconf.common.formatters.JSONDataTreeCandidateFormatter;
+import org.opendaylight.restconf.common.formatters.XMLDataTreeCandidateFormatter;
 import org.opendaylight.yang.gen.v1.urn.sal.restconf.event.subscription.rev140708.NotificationOutputTypeGrouping.NotificationOutputType;
-import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifierWithPredicates;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeWithValue;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument;
-import org.opendaylight.yangtools.yang.data.api.schema.LeafNode;
-import org.opendaylight.yangtools.yang.data.api.schema.MapEntryNode;
-import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
-import org.opendaylight.yangtools.yang.data.api.schema.UnkeyedListEntryNode;
 import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate;
-import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidateNode;
-import org.opendaylight.yangtools.yang.data.util.DataSchemaContextNode;
-import org.opendaylight.yangtools.yang.data.util.DataSchemaContextTree;
-import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
-import org.opendaylight.yangtools.yang.model.api.Module;
-import org.opendaylight.yangtools.yang.model.api.SchemaContext;
-import org.opendaylight.yangtools.yang.model.api.SchemaPath;
+import org.opendaylight.yangtools.yang.data.codec.gson.JSONCodecFactorySupplier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.w3c.dom.Document;
-import org.w3c.dom.Element;
-import org.w3c.dom.Node;
 
 /**
  * {@link ListenerAdapter} is responsible to track events, which occurred by changing data in data source.
@@ -51,14 +35,18 @@ import org.w3c.dom.Node;
 public class ListenerAdapter extends AbstractCommonSubscriber implements ClusteredDOMDataTreeChangeListener {
 
     private static final Logger LOG = LoggerFactory.getLogger(ListenerAdapter.class);
-    private static final String DATA_CHANGE_EVENT = "data-change-event";
+//    private static final String DATA_CHANGE_EVENT = "data-change-event";
     private static final String PATH = "path";
-    private static final String OPERATION = "operation";
+//    private static final String OPERATION = "operation";
+    private static final DataTreeCandidateFormatterFactory JSON_FORMATTER_FACTORY =
+            JSONDataTreeCandidateFormatter.createFactory(JSONCodecFactorySupplier.RFC7951);
 
     private final YangInstanceIdentifier path;
     private final String streamName;
     private final NotificationOutputType outputType;
 
+    @VisibleForTesting DataTreeCandidateFormatter formatter;
+
     /**
      * Creates new {@link ListenerAdapter} listener specified by path and stream name and register for subscribing.
      *
@@ -74,18 +62,57 @@ public class ListenerAdapter extends AbstractCommonSubscriber implements Cluster
         this.path = requireNonNull(path);
         this.streamName = requireNonNull(streamName);
         checkArgument(!streamName.isEmpty());
+
+        formatter = getFormatterFactory().getFormatter();
+    }
+
+    private DataTreeCandidateFormatterFactory getFormatterFactory() {
+        switch (outputType) {
+            case JSON:
+                return JSON_FORMATTER_FACTORY;
+            case XML:
+                return XMLDataTreeCandidateFormatter.FACTORY;
+            default:
+                throw new IllegalArgumentException(("Unsupported outputType" + outputType));
+        }
+    }
+
+    private DataTreeCandidateFormatter getFormatter(final String filter) throws XPathExpressionException {
+        final DataTreeCandidateFormatterFactory factory = getFormatterFactory();
+        return filter == null || filter.isEmpty() ? factory.getFormatter() : factory.getFormatter(filter);
     }
 
     @Override
+    public void setQueryParams(final Instant start, final Instant stop, final String filter,
+                               final boolean leafNodesOnly, final boolean skipNotificationData) {
+        super.setQueryParams(start, stop, filter, leafNodesOnly, skipNotificationData);
+        try {
+            this.formatter = getFormatter(filter);
+        } catch (final XPathExpressionException e) {
+            throw new IllegalArgumentException("Failed to get filter", e);
+        }
+    }
+
+    @Override
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public void onDataTreeChanged(final Collection<DataTreeCandidate> dataTreeCandidates) {
         final Instant now = Instant.now();
         if (!checkStartStop(now, this)) {
             return;
         }
 
-        final String xml = prepareXml(dataTreeCandidates);
-        if (checkFilter(xml)) {
-            prepareAndPostData(xml);
+        final Optional<String> maybeData;
+        try {
+            maybeData = formatter.eventData(schemaHandler.get(), dataTreeCandidates, now, getLeafNodesOnly(),
+                    isSkipNotificationData());
+        } catch (final Exception e) {
+            LOG.error("Failed to process notification {}",
+                    dataTreeCandidates.stream().map(Object::toString).collect(Collectors.joining(",")), e);
+            return;
+        }
+
+        if (maybeData.isPresent()) {
+            post(maybeData.get());
         }
     }
 
@@ -113,285 +140,6 @@ public class ListenerAdapter extends AbstractCommonSubscriber implements Cluster
         return this.path;
     }
 
-    /**
-     * Prepare data of notification and data to client.
-     *
-     * @param xml XML-formatted data.
-     */
-    private void prepareAndPostData(final String xml) {
-        if (this.outputType.equals(NotificationOutputType.JSON)) {
-            post(XML.toJSONObject(xml).toString());
-        } else {
-            post(xml);
-        }
-    }
-
-    /**
-     * Prepare data in printable form and transform it to String.
-     *
-     * @param dataTreeCandidates Data-tree candidates to be transformed.
-     * @return Data in printable form.
-     */
-    private String prepareXml(final Collection<DataTreeCandidate> dataTreeCandidates) {
-        final EffectiveModelContext schemaContext = schemaHandler.get();
-        final DataSchemaContextTree dataContextTree = DataSchemaContextTree.from(schemaContext);
-        final Document doc = createDocument();
-        final Element notificationElement = basePartDoc(doc);
-
-        final Element dataChangedNotificationEventElement = doc.createElementNS(
-                "urn:opendaylight:params:xml:ns:yang:controller:md:sal:remote", "data-changed-notification");
-
-        addValuesToDataChangedNotificationEventElement(doc, dataChangedNotificationEventElement, dataTreeCandidates,
-                schemaContext, dataContextTree);
-        notificationElement.appendChild(dataChangedNotificationEventElement);
-        return transformDoc(doc);
-    }
-
-    /**
-     * Adds values to data changed notification event element.
-     */
-    private void addValuesToDataChangedNotificationEventElement(final Document doc,
-            final Element dataChangedNotificationEventElement, final Collection<DataTreeCandidate> dataTreeCandidates,
-            final EffectiveModelContext schemaContext, final DataSchemaContextTree dataSchemaContextTree) {
-
-        for (DataTreeCandidate dataTreeCandidate : dataTreeCandidates) {
-            DataTreeCandidateNode candidateNode = dataTreeCandidate.getRootNode();
-            if (candidateNode == null) {
-                continue;
-            }
-            YangInstanceIdentifier yiid = dataTreeCandidate.getRootPath();
-            boolean isSkipNotificationData = this.isSkipNotificationData();
-            if (isSkipNotificationData) {
-                createCreatedChangedDataChangeEventElementWithoutData(doc, dataChangedNotificationEventElement,
-                        dataTreeCandidate.getRootNode(), schemaContext);
-            } else {
-                addNodeToDataChangeNotificationEventElement(doc, dataChangedNotificationEventElement, candidateNode,
-                        yiid.getParent(), schemaContext, dataSchemaContextTree);
-            }
-        }
-    }
-
-    private void addNodeToDataChangeNotificationEventElement(final Document doc,
-            final Element dataChangedNotificationEventElement, final DataTreeCandidateNode candidateNode,
-            final YangInstanceIdentifier parentYiid, final EffectiveModelContext schemaContext,
-            final DataSchemaContextTree dataSchemaContextTree) {
-
-        Optional<NormalizedNode<?, ?>> optionalNormalizedNode = Optional.empty();
-        switch (candidateNode.getModificationType()) {
-            case APPEARED:
-            case SUBTREE_MODIFIED:
-            case WRITE:
-                optionalNormalizedNode = candidateNode.getDataAfter();
-                break;
-            case DELETE:
-            case DISAPPEARED:
-                optionalNormalizedNode = candidateNode.getDataBefore();
-                break;
-            case UNMODIFIED:
-            default:
-                break;
-        }
-
-        if (!optionalNormalizedNode.isPresent()) {
-            LOG.error("No node present in notification for {}", candidateNode);
-            return;
-        }
-
-        NormalizedNode<?, ?> normalizedNode = optionalNormalizedNode.get();
-        YangInstanceIdentifier yiid = YangInstanceIdentifier.builder(parentYiid)
-                .append(normalizedNode.getIdentifier()).build();
-
-        final Optional<DataSchemaContextNode<?>> childrenSchemaNode = dataSchemaContextTree.findChild(yiid);
-        checkState(childrenSchemaNode.isPresent());
-        boolean isNodeMixin = childrenSchemaNode.get().isMixin();
-        boolean isSkippedNonLeaf = getLeafNodesOnly() && !(normalizedNode instanceof LeafNode);
-        if (!isNodeMixin && !isSkippedNonLeaf) {
-            Node node = null;
-            switch (candidateNode.getModificationType()) {
-                case APPEARED:
-                case SUBTREE_MODIFIED:
-                case WRITE:
-                    Operation op = candidateNode.getDataBefore().isPresent() ? Operation.UPDATED : Operation.CREATED;
-                    node = createCreatedChangedDataChangeEventElement(doc, yiid, normalizedNode, op,
-                            schemaContext, dataSchemaContextTree);
-                    break;
-                case DELETE:
-                case DISAPPEARED:
-                    node = createDataChangeEventElement(doc, yiid, schemaContext, Operation.DELETED);
-                    break;
-                case UNMODIFIED:
-                default:
-                    break;
-            }
-            if (node != null) {
-                dataChangedNotificationEventElement.appendChild(node);
-            }
-        }
-
-        for (DataTreeCandidateNode childNode : candidateNode.getChildNodes()) {
-            addNodeToDataChangeNotificationEventElement(
-                    doc, dataChangedNotificationEventElement, childNode, yiid, schemaContext, dataSchemaContextTree);
-        }
-    }
-
-    /**
-     * Creates data-changed event element from data.
-     *
-     * @param doc           {@link Document}
-     * @param schemaContext Schema context.
-     * @param operation  Operation value
-     * @return {@link Node} represented by changed event element.
-     */
-    private static Node createDataChangeEventElement(final Document doc, final YangInstanceIdentifier eventPath,
-            final SchemaContext schemaContext, Operation operation) {
-        final Element dataChangeEventElement = doc.createElement(DATA_CHANGE_EVENT);
-        final Element pathElement = doc.createElement(PATH);
-        addPathAsValueToElement(eventPath, pathElement, schemaContext);
-        dataChangeEventElement.appendChild(pathElement);
-
-        final Element operationElement = doc.createElement(OPERATION);
-        operationElement.setTextContent(operation.value);
-        dataChangeEventElement.appendChild(operationElement);
-
-        return dataChangeEventElement;
-    }
-
-    /**
-     * Creates data change notification element without data element.
-     *
-     * @param doc
-     *       {@link Document}
-     * @param dataChangedNotificationEventElement
-     *       {@link Element}
-     * @param candidateNode
-     *       {@link DataTreeCandidateNode}
-     */
-    private void createCreatedChangedDataChangeEventElementWithoutData(final Document doc,
-            final Element dataChangedNotificationEventElement, final DataTreeCandidateNode candidateNode,
-            final SchemaContext schemaContext) {
-        final Operation operation;
-        switch (candidateNode.getModificationType()) {
-            case APPEARED:
-            case SUBTREE_MODIFIED:
-            case WRITE:
-                operation = candidateNode.getDataBefore().isPresent() ? Operation.UPDATED : Operation.CREATED;
-                break;
-            case DELETE:
-            case DISAPPEARED:
-                operation = Operation.DELETED;
-                break;
-            case UNMODIFIED:
-            default:
-                return;
-        }
-        Node dataChangeEventElement = createDataChangeEventElement(doc, getPath(), schemaContext, operation);
-        dataChangedNotificationEventElement.appendChild(dataChangeEventElement);
-    }
-
-    private Node createCreatedChangedDataChangeEventElement(final Document doc, final YangInstanceIdentifier eventPath,
-            final NormalizedNode<?, ?> normalized, final Operation operation, final EffectiveModelContext schemaContext,
-            final DataSchemaContextTree dataSchemaContextTree) {
-        final Element dataChangeEventElement = doc.createElement(DATA_CHANGE_EVENT);
-        final Element pathElement = doc.createElement(PATH);
-        addPathAsValueToElement(eventPath, pathElement, schemaContext);
-        dataChangeEventElement.appendChild(pathElement);
-
-        final Element operationElement = doc.createElement("operation");
-        operationElement.setTextContent(operation.value);
-        dataChangeEventElement.appendChild(operationElement);
-
-        try {
-            final SchemaPath nodePath;
-            final Optional<DataSchemaContextNode<?>> childrenSchemaNode = dataSchemaContextTree.findChild(eventPath);
-            checkState(childrenSchemaNode.isPresent());
-            if (normalized instanceof MapEntryNode || normalized instanceof UnkeyedListEntryNode) {
-                nodePath = childrenSchemaNode.get().getDataSchemaNode().getPath();
-            } else {
-                nodePath = childrenSchemaNode.get().getDataSchemaNode().getPath().getParent();
-            }
-            final DOMResult domResult = writeNormalizedNode(normalized, schemaContext, nodePath);
-            final Node result = doc.importNode(domResult.getNode().getFirstChild(), true);
-            final Element dataElement = doc.createElement("data");
-            dataElement.appendChild(result);
-            dataChangeEventElement.appendChild(dataElement);
-        } catch (final IOException e) {
-            LOG.error("Error in writer ", e);
-        } catch (final XMLStreamException e) {
-            LOG.error("Error processing stream", e);
-        }
-
-        return dataChangeEventElement;
-    }
-
-    /**
-     * Adds path as value to element.
-     *
-     * @param eventPath     Path to data in data store.
-     * @param element       {@link Element}
-     * @param schemaContext Schema context.
-     */
-    private static void addPathAsValueToElement(final YangInstanceIdentifier eventPath, final Element element,
-            final SchemaContext schemaContext) {
-        final StringBuilder textContent = new StringBuilder();
-
-        for (final PathArgument pathArgument : eventPath.getPathArguments()) {
-            if (pathArgument instanceof YangInstanceIdentifier.AugmentationIdentifier) {
-                continue;
-            }
-            textContent.append("/");
-            writeIdentifierWithNamespacePrefix(textContent, pathArgument.getNodeType(), schemaContext);
-            if (pathArgument instanceof NodeIdentifierWithPredicates) {
-                for (final Entry<QName, Object> entry : ((NodeIdentifierWithPredicates) pathArgument).entrySet()) {
-                    final QName keyValue = entry.getKey();
-                    final String predicateValue = String.valueOf(entry.getValue());
-                    textContent.append("[");
-                    writeIdentifierWithNamespacePrefix(textContent, keyValue, schemaContext);
-                    textContent.append("='").append(predicateValue).append("']");
-                }
-            } else if (pathArgument instanceof NodeWithValue) {
-                textContent.append("[.='").append(((NodeWithValue<?>) pathArgument).getValue()).append("']");
-            }
-        }
-        element.setTextContent(textContent.toString());
-    }
-
-    /**
-     * Writes identifier that consists of prefix and QName.
-     *
-     * @param textContent   Text builder that should be supplemented by QName and its modules name.
-     * @param qualifiedName QName of the element.
-     * @param schemaContext Schema context that holds modules which should contain module specified in QName.
-     */
-    private static void writeIdentifierWithNamespacePrefix(final StringBuilder textContent, final QName qualifiedName,
-            final SchemaContext schemaContext) {
-        final Optional<Module> module = schemaContext.findModule(qualifiedName.getModule());
-        if (module.isPresent()) {
-            textContent.append(module.get().getName());
-            textContent.append(":");
-            textContent.append(qualifiedName.getLocalName());
-        } else {
-            LOG.error("Cannot write identifier with namespace prefix in data-change listener adapter: "
-                    + "Cannot find module in schema context for input QName {}.", qualifiedName);
-            throw new IllegalStateException(String.format("Cannot find module in schema context for input QName %s.",
-                    qualifiedName));
-        }
-    }
-
-    /**
-     * Consists of three types {@link Operation#CREATED}, {@link Operation#UPDATED} and {@link Operation#DELETED}.
-     */
-    private enum Operation {
-        CREATED("created"),
-        UPDATED("updated"),
-        DELETED("deleted");
-
-        private final String value;
-
-        Operation(final String value) {
-            this.value = value;
-        }
-    }
-
     @Override
     public String toString() {
         return MoreObjects.toStringHelper(this)