Fix findbugs violations in restconf-nb-rfc8040

[netconf.git] / restconf / restconf-nb-rfc8040 / src / main / java / org / opendaylight / restconf / nb / rfc8040 / utils / validations / RestconfValidation.java

diff --git a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/validations/RestconfValidation.java b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/validations/RestconfValidation.java
index 74c5012e3ff9a9d6f60f1c445737d8a7eed90435..1db58e4473c0e088088143f800d1b7083d27acb8 100644 (file)
--- a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/validations/RestconfValidation.java
+++ b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/validations/RestconfValidation.java
@@ -7,15 +7,16 @@
  */
 package org.opendaylight.restconf.nb.rfc8040.utils.validations;
 
-import java.text.ParseException;
+import java.time.format.DateTimeParseException;
 import java.util.Date;
 import java.util.Iterator;
+import java.util.Locale;
 import org.opendaylight.restconf.common.errors.RestconfDocumentedException;
 import org.opendaylight.restconf.common.errors.RestconfError.ErrorTag;
 import org.opendaylight.restconf.common.errors.RestconfError.ErrorType;
 import org.opendaylight.restconf.common.validation.RestconfValidationUtils;
 import org.opendaylight.restconf.nb.rfc8040.utils.parser.builder.ParserBuilderConstants;
-import org.opendaylight.yangtools.yang.common.SimpleDateFormatUtil;
+import org.opendaylight.yangtools.yang.common.Revision;
 
 /**
  * Util class for validations.
@@ -34,12 +35,12 @@ public final class RestconfValidation {
      *             iterator
      * @return {@link Date}
      */
-    public static Date validateAndGetRevision(final Iterator<String> revisionDate) {
+    public static Revision validateAndGetRevision(final Iterator<String> revisionDate) {
         RestconfValidationUtils.checkDocumentedError(revisionDate.hasNext(), ErrorType.PROTOCOL,
                 ErrorTag.INVALID_VALUE, "Revision date must be supplied.");
         try {
-            return SimpleDateFormatUtil.getRevisionFormat().parse(revisionDate.next());
-        } catch (final ParseException e) {
+            return Revision.of(revisionDate.next());
+        } catch (final DateTimeParseException e) {
             throw new RestconfDocumentedException("Supplied revision is not in expected date format YYYY-mm-dd", e);
         }
     }
@@ -67,7 +68,7 @@ public final class RestconfValidation {
         );
 
         RestconfValidationUtils.checkDocumentedError(
-                !name.toUpperCase().startsWith("XML"),
+                !name.toUpperCase(Locale.ROOT).startsWith("XML"),
                 ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE,
                 "Identifier must NOT start with XML ignore case."
         );