Enforce SpotBugs in Service handler
[transportpce.git] / servicehandler / src / main / java / org / opendaylight / transportpce / servicehandler / ModelMappingUtils.java
index 8561321a75e4ab6cbe285a34c4a9ecfd97dba7f6..46d1ccacd57b4d8fdd267ed4d7d41ff0f2981f74 100644 (file)
@@ -63,14 +63,61 @@ import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service
 import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev171017.service.path.list.ServicePathsBuilder;
 import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 
 public final class ModelMappingUtils {
 
+    private static final Logger LOG = LoggerFactory.getLogger(ModelMappingUtils.class);
+
     private ModelMappingUtils() {
     }
 
     public static ServiceImplementationRequestInput createServiceImplementationRequest(ServiceInput input,
             PathDescription pathDescription) {
+
+        org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
+                .service.implementation.request.input.ServiceAEndBuilder serviceAEnd =
+            new org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
+                .service.implementation.request.input.ServiceAEndBuilder()
+                    .setServiceFormat(input.getServiceAEnd().getServiceFormat())
+                    .setServiceRate(input.getServiceAEnd().getServiceRate())
+                    .setClli(input.getServiceAEnd().getClli())
+                    .setNodeId(new NodeIdType(input.getServiceAEnd().getNodeId().getValue()).getValue())
+                    .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
+                        .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.TxDirectionBuilder()
+                            .setPort(input.getServiceAEnd().getTxDirection().getPort())
+                            .build())
+                    .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
+                        .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.RxDirectionBuilder()
+                            .setPort(input.getServiceAEnd().getRxDirection().getPort())
+                            .build());
+
+        org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
+                .service.implementation.request.input.ServiceZEndBuilder serviceZEnd =
+            new org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
+                .service.implementation.request.input.ServiceZEndBuilder()
+                    .setServiceFormat(input.getServiceZEnd().getServiceFormat())
+                    .setServiceRate(input.getServiceZEnd().getServiceRate())
+                    .setClli(input.getServiceZEnd().getClli())
+                    .setNodeId(new NodeIdType(input.getServiceZEnd().getNodeId().getValue()).getValue())
+                    .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
+                        .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.TxDirectionBuilder()
+                            .setPort(input.getServiceZEnd().getTxDirection().getPort())
+                            .build())
+                    .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
+                        .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.RxDirectionBuilder()
+                            .setPort(input.getServiceZEnd().getRxDirection().getPort())
+                        .build());
+
+        org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
+                .service.implementation.request.input.PathDescriptionBuilder pathDescBuilder =
+            new org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
+                .service.implementation.request.input.PathDescriptionBuilder()
+                    .setAToZDirection(pathDescription.getAToZDirection())
+                    .setZToADirection(pathDescription.getZToADirection());
+
         ServiceImplementationRequestInputBuilder serviceImplementationRequestInputBuilder =
                 new ServiceImplementationRequestInputBuilder();
         if (input.isServiceReconfigure()) {
@@ -78,182 +125,171 @@ public final class ModelMappingUtils {
         } else {
             serviceImplementationRequestInputBuilder.setServiceName(input.getServiceName());
         }
-        org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017.service.implementation
-            .request.input.ServiceAEndBuilder serviceAEnd = new org.opendaylight.yang.gen.v1.http.org.opendaylight
-                .transportpce.renderer.rev171017.service.implementation.request.input.ServiceAEndBuilder();
-        serviceAEnd.setServiceFormat(input.getServiceAEnd().getServiceFormat())
-            .setServiceRate(input.getServiceAEnd().getServiceRate()).setClli(input.getServiceAEnd().getClli())
-            .setNodeId(new NodeIdType(input.getServiceAEnd().getNodeId().getValue()).getValue())
-            .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
-                .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.TxDirectionBuilder()
-                .setPort(input.getServiceAEnd().getTxDirection().getPort()).build())
-            .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
-                .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.RxDirectionBuilder()
-                .setPort(input.getServiceAEnd().getRxDirection().getPort()).build());
-        org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017.service.implementation
-            .request.input.ServiceZEndBuilder serviceZEnd = new org.opendaylight.yang.gen.v1.http.org.opendaylight
-                .transportpce.renderer.rev171017.service.implementation.request.input.ServiceZEndBuilder();
-        serviceZEnd.setServiceFormat(input.getServiceZEnd().getServiceFormat())
-            .setServiceRate(input.getServiceZEnd().getServiceRate()).setClli(input.getServiceZEnd().getClli())
-            .setNodeId(new NodeIdType(input.getServiceZEnd().getNodeId().getValue()).getValue())
-            .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
-                .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.TxDirectionBuilder()
-                .setPort(input.getServiceZEnd().getTxDirection().getPort()).build())
-            .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
-                .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.RxDirectionBuilder()
-                .setPort(input.getServiceZEnd().getRxDirection().getPort()).build());
-        serviceImplementationRequestInputBuilder
-            .setServiceAEnd(serviceAEnd.build())
-            .setServiceZEnd(serviceZEnd.build())
-            .setServiceHandlerHeader(
-                new ServiceHandlerHeaderBuilder().setRequestId(input.getSdncRequestHeader().getRequestId()).build());
-        org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017.service.implementation
-            .request.input.PathDescriptionBuilder pathDescBuilder = new org.opendaylight.yang.gen.v1.http.org
-                .opendaylight.transportpce.renderer.rev171017.service.implementation.request.input
-                    .PathDescriptionBuilder();
-        pathDescBuilder
-            .setAToZDirection(pathDescription.getAToZDirection())
-            .setZToADirection(pathDescription.getZToADirection());
-        serviceImplementationRequestInputBuilder.setPathDescription(pathDescBuilder.build());
-        return serviceImplementationRequestInputBuilder.build();
+
+        return serviceImplementationRequestInputBuilder
+                .setServiceAEnd(serviceAEnd.build())
+                .setServiceZEnd(serviceZEnd.build())
+                .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
+                    .setRequestId(input.getSdncRequestHeader().getRequestId())
+                    .build())
+                .setPathDescription(pathDescBuilder.build())
+                .build();
     }
 
     public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
-        .ServiceDeleteInput createServiceDeleteInput(ServiceInput serviceInput) {
-        ServiceDeleteInputBuilder builder = new ServiceDeleteInputBuilder()
-            .setServiceName(serviceInput.getServiceName())
-            .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
-                .setRequestId(serviceInput.getSdncRequestHeader().getRequestId()).build());
-        return builder.build();
+            .ServiceDeleteInput createServiceDeleteInput(ServiceInput serviceInput) {
+        return new ServiceDeleteInputBuilder()
+                .setServiceName(serviceInput.getServiceName())
+                .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
+                    .setRequestId(serviceInput.getSdncRequestHeader().getRequestId())
+                    .build())
+                .build();
     }
 
     public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
-        .ServiceDeleteInput createServiceDeleteInput(ServiceRerouteInput serviceRerouteinput, Services services) {
-        ServiceDeleteInputBuilder builder = new ServiceDeleteInputBuilder()
-            .setServiceName(serviceRerouteinput.getServiceName())
-            .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder().setRequestId(
-                services.getSdncRequestHeader().getRequestId()).build());
-        return builder.build();
+            .ServiceDeleteInput createServiceDeleteInput(ServiceRerouteInput serviceRerouteinput, Services services) {
+        return new ServiceDeleteInputBuilder()
+                .setServiceName(serviceRerouteinput.getServiceName())
+                .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
+                    .setRequestId(services.getSdncRequestHeader().getRequestId())
+                    .build())
+                .build();
     }
 
     public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017
-        .ServiceDeleteInput createServiceDeleteInput(ServiceRestorationInput serviceRestorationInput,
+            .ServiceDeleteInput createServiceDeleteInput(ServiceRestorationInput serviceRestorationInput,
                 Services services) {
-        ServiceDeleteInputBuilder builder = new ServiceDeleteInputBuilder()
-            .setServiceName(serviceRestorationInput.getServiceName())
-            .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder().setRequestId(
-                services.getSdncRequestHeader().getRequestId()).build());
-        return builder.build();
+        return new ServiceDeleteInputBuilder()
+                .setServiceName(serviceRestorationInput.getServiceName())
+                .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
+                    .setRequestId(services.getSdncRequestHeader().getRequestId())
+                    .build())
+                .build();
     }
 
     public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.renderer.rev171017.ServiceDeleteInput
             createServiceDeleteInput(ServiceReconfigureInput serviceReconfigureInput) {
-        String serviceName = serviceReconfigureInput.getServiceName();
-        ServiceDeleteInputBuilder builder = new ServiceDeleteInputBuilder()
-            .setServiceName(serviceReconfigureInput.getServiceName())
-            .setServiceHandlerHeader(
-                new ServiceHandlerHeaderBuilder().setRequestId(serviceName + "-reconfigure").build());
-        return builder.build();
+        return new ServiceDeleteInputBuilder()
+                .setServiceName(serviceReconfigureInput.getServiceName())
+                .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
+                    .setRequestId(serviceReconfigureInput.getServiceName() + "-reconfigure")
+                    .build())
+                .build();
     }
 
-    public static ServiceAEnd createServiceAEnd(org.opendaylight.yang.gen.v1.http.org.openroadm.common.service.types
-            .rev190531.ServiceEndpoint serviceAEnd) {
-        ServiceAEndBuilder serviceAEndBuilder = new ServiceAEndBuilder()
-            .setClli(serviceAEnd.getClli())
-            .setNodeId(serviceAEnd.getNodeId().getValue())
-            .setRxDirection(createRxDirection(serviceAEnd.getRxDirection()))
-            .setServiceFormat(serviceAEnd.getServiceFormat())
-            .setServiceRate(serviceAEnd.getServiceRate())
-            .setTxDirection(createTxDirection(serviceAEnd.getTxDirection()));
-        return serviceAEndBuilder.build();
+    public static ServiceAEnd createServiceAEnd(org.opendaylight.yang.gen.v1.http
+            .org.openroadm.common.service.types.rev190531.ServiceEndpoint serviceAEnd) {
+        return new ServiceAEndBuilder()
+                .setClli(serviceAEnd.getClli())
+                .setNodeId(serviceAEnd.getNodeId().getValue())
+                .setRxDirection(createRxDirection(serviceAEnd.getRxDirection()))
+                .setServiceFormat(serviceAEnd.getServiceFormat())
+                .setServiceRate(serviceAEnd.getServiceRate())
+                .setTxDirection(createTxDirection(serviceAEnd.getTxDirection()))
+                .build();
     }
 
-    public static ServiceZEnd createServiceZEnd(org.opendaylight.yang.gen.v1.http.org.openroadm.common.service.types
-            .rev190531.ServiceEndpoint serviceZEnd) {
-        ServiceZEndBuilder serviceZEndBuilder = new ServiceZEndBuilder()
-            .setClli(serviceZEnd.getClli())
-            .setNodeId(serviceZEnd.getNodeId().getValue())
-            .setRxDirection(createRxDirection(serviceZEnd.getRxDirection()))
-            .setServiceFormat(serviceZEnd.getServiceFormat())
-            .setServiceRate(serviceZEnd.getServiceRate())
-            .setTxDirection(createTxDirection(serviceZEnd.getTxDirection()));
-        return serviceZEndBuilder.build();
+    public static ServiceZEnd createServiceZEnd(org.opendaylight.yang.gen.v1.http
+            .org.openroadm.common.service.types.rev190531.ServiceEndpoint serviceZEnd) {
+        return new ServiceZEndBuilder()
+                .setClli(serviceZEnd.getClli())
+                .setNodeId(serviceZEnd.getNodeId().getValue())
+                .setRxDirection(createRxDirection(serviceZEnd.getRxDirection()))
+                .setServiceFormat(serviceZEnd.getServiceFormat())
+                .setServiceRate(serviceZEnd.getServiceRate())
+                .setTxDirection(createTxDirection(serviceZEnd.getTxDirection()))
+                .build();
     }
 
     public static RxDirection createRxDirection(org.opendaylight.yang.gen.v1.http.org.openroadm.common.service.types
             .rev190531.service.endpoint.RxDirection rxDirection) {
-        RxDirectionBuilder rxDirectionBuilder = new RxDirectionBuilder().setPort(rxDirection.getPort());
-        return rxDirectionBuilder.build();
+        return new RxDirectionBuilder()
+                .setPort(rxDirection.getPort())
+                .build();
     }
 
     public static TxDirection createTxDirection(org.opendaylight.yang.gen.v1.http.org.openroadm.common.service
             .types.rev190531.service.endpoint.TxDirection txDirection) {
-        TxDirectionBuilder txDirectionBuilder = new TxDirectionBuilder().setPort(txDirection.getPort());
-        return txDirectionBuilder.build();
+        return new TxDirectionBuilder()
+                .setPort(txDirection.getPort())
+                .build();
     }
 
     public static ListenableFuture<RpcResult<ServiceDeleteOutput>> createDeleteServiceReply(ServiceDeleteInput input,
             String finalAck, String message, String responseCode) {
+        LOG.debug("createDeleteServiceReply : {}", message);
         ConfigurationResponseCommonBuilder builder = new ConfigurationResponseCommonBuilder()
-                .setAckFinalIndicator(finalAck).setResponseMessage(message).setResponseCode(responseCode);
+                .setAckFinalIndicator(finalAck)
+                .setResponseMessage(message)
+                .setResponseCode(responseCode);
         if (input.getSdncRequestHeader() != null) {
             builder.setRequestId(input.getSdncRequestHeader().getRequestId());
         } else {
             builder.setRequestId(null);
         }
         ConfigurationResponseCommon configurationResponseCommon = builder.build();
-        ServiceDeleteOutput output =
-                new ServiceDeleteOutputBuilder().setConfigurationResponseCommon(configurationResponseCommon).build();
+        ServiceDeleteOutput output = new ServiceDeleteOutputBuilder()
+                .setConfigurationResponseCommon(configurationResponseCommon)
+                .build();
         return RpcResultBuilder.success(output).buildFuture();
     }
 
     public static ListenableFuture<RpcResult<TempServiceDeleteOutput>> createDeleteServiceReply(
             TempServiceDeleteInput input, String finalAck, String message, String responseCode) {
-        ConfigurationResponseCommonBuilder builder = new ConfigurationResponseCommonBuilder()
+        LOG.debug("createDeleteServiceReply : {}", message);
+        ConfigurationResponseCommonBuilder configurationResponseCommon =
+            new ConfigurationResponseCommonBuilder()
                 .setAckFinalIndicator(finalAck)
                 .setResponseMessage(message)
                 .setResponseCode(responseCode)
                 .setRequestId(null);
-        ConfigurationResponseCommon configurationResponseCommon = builder.build();
         TempServiceDeleteOutput output = new TempServiceDeleteOutputBuilder()
-                .setConfigurationResponseCommon(configurationResponseCommon).build();
+                .setConfigurationResponseCommon(configurationResponseCommon.build())
+                .build();
         return RpcResultBuilder.success(output).buildFuture();
     }
 
     public static ListenableFuture<RpcResult<ServiceCreateOutput>> createCreateServiceReply(ServiceCreateInput input,
             String finalAck, String message, String responseCode) {
+        LOG.debug("createCreateServiceReply : {}", message);
         ResponseParametersBuilder responseParameters = new ResponseParametersBuilder();
         ConfigurationResponseCommonBuilder configurationResponseCommon = new ConfigurationResponseCommonBuilder()
-                .setAckFinalIndicator(finalAck).setResponseMessage(message).setResponseCode(responseCode);
+                .setAckFinalIndicator(finalAck)
+                .setResponseMessage(message)
+                .setResponseCode(responseCode);
         if (input.getSdncRequestHeader() != null) {
             configurationResponseCommon.setRequestId(input.getSdncRequestHeader().getRequestId());
         } else {
             configurationResponseCommon.setRequestId(null);
         }
-        ServiceCreateOutputBuilder output =
-                new ServiceCreateOutputBuilder().setConfigurationResponseCommon(configurationResponseCommon.build())
-                        .setResponseParameters(responseParameters.build());
+        ServiceCreateOutputBuilder output = new ServiceCreateOutputBuilder()
+                .setConfigurationResponseCommon(configurationResponseCommon.build())
+                .setResponseParameters(responseParameters.build());
         return RpcResultBuilder.success(output.build()).buildFuture();
     }
 
     public static ListenableFuture<RpcResult<TempServiceCreateOutput>> createCreateServiceReply(
             TempServiceCreateInput input, String finalAck, String message, String responseCode) {
-        ResponseParametersBuilder responseParameters = new ResponseParametersBuilder();
-        ConfigurationResponseCommonBuilder configurationResponseCommon = new ConfigurationResponseCommonBuilder()
-                .setAckFinalIndicator(finalAck).setResponseMessage(message).setResponseCode(responseCode);
+        LOG.debug("createCreateServiceReply : {}", message);
+        ConfigurationResponseCommonBuilder configurationResponseCommon =
+            new ConfigurationResponseCommonBuilder()
+                .setAckFinalIndicator(finalAck)
+                .setResponseMessage(message)
+                .setResponseCode(responseCode);
         if (input.getSdncRequestHeader() != null) {
             configurationResponseCommon.setRequestId(input.getSdncRequestHeader().getRequestId());
         } else {
             configurationResponseCommon.setRequestId(null);
         }
-        TempServiceCreateOutputBuilder output =
-                new TempServiceCreateOutputBuilder().setConfigurationResponseCommon(configurationResponseCommon.build())
-                        .setResponseParameters(responseParameters.build());
+        TempServiceCreateOutputBuilder output = new TempServiceCreateOutputBuilder()
+                .setConfigurationResponseCommon(configurationResponseCommon.build())
+                .setResponseParameters(new ResponseParametersBuilder().build());
         return RpcResultBuilder.success(output.build()).buildFuture();
     }
 
     public static ListenableFuture<RpcResult<ServiceFeasibilityCheckOutput>> createCreateServiceReply(
             ServiceFeasibilityCheckInput input, String finalAck, String message, String responseCode) {
+        LOG.debug("createCreateServiceReply : {}", message);
         ResponseParametersBuilder responseParameters = new ResponseParametersBuilder();
         ConfigurationResponseCommonBuilder configurationResponseCommon = new ConfigurationResponseCommonBuilder()
                 .setAckFinalIndicator(finalAck).setResponseMessage(message).setResponseCode(responseCode);
@@ -270,6 +306,7 @@ public final class ModelMappingUtils {
 
     public static ListenableFuture<RpcResult<ServiceReconfigureOutput>> createCreateServiceReply(
             ServiceReconfigureInput input, String message, RpcStatus rpcStatus) {
+        LOG.debug("createCreateServiceReply : {}", message);
         ServiceReconfigureOutputBuilder output = new ServiceReconfigureOutputBuilder()
                 .setStatus(rpcStatus)
                 .setStatusMessage(message);
@@ -278,6 +315,7 @@ public final class ModelMappingUtils {
 
     public static ListenableFuture<RpcResult<ServiceRerouteOutput>> createRerouteServiceReply(ServiceRerouteInput input,
             String finalAckYes, String message, RpcStatus status) {
+        LOG.debug("createRerouteServiceReply : {}", message);
         ServiceRerouteOutputBuilder output = new ServiceRerouteOutputBuilder()
                 .setHardConstraints(null)
                 .setSoftConstraints(null)
@@ -288,6 +326,7 @@ public final class ModelMappingUtils {
 
     public static ListenableFuture<RpcResult<ServiceRestorationOutput>> createRestoreServiceReply(String message,
             RpcStatus status) {
+        LOG.debug("createRestoreServiceReply : {}", message);
         ServiceRestorationOutputBuilder output = new ServiceRestorationOutputBuilder()
                 .setStatus(status)
                 .setStatusMessage(message);
@@ -355,61 +394,79 @@ public final class ModelMappingUtils {
     }
 
     public static ServicePaths mappingServicePaths(ServiceInput serviceInput, PathComputationRequestOutput output) {
-        ServicePathsBuilder servicePathBuilder = new ServicePathsBuilder();
-        if (serviceInput != null) {
-            org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
+        if (serviceInput == null) {
+            return new ServicePathsBuilder().build();
+        }
+
+        org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
                 .service.path.ServiceAEndBuilder serviceAEnd =
-                new org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
-                    .service.path.ServiceAEndBuilder();
-            serviceAEnd.setServiceFormat(serviceInput.getServiceAEnd().getServiceFormat())
-                .setServiceRate(serviceInput.getServiceAEnd().getServiceRate())
-                .setClli(serviceInput.getServiceAEnd().getClli())
-                .setNodeId(new NodeIdType(serviceInput.getServiceAEnd().getNodeId()).getValue())
-                .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
-                    .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.TxDirectionBuilder()
-                    .setPort(serviceInput.getServiceAEnd().getTxDirection().getPort()).build())
-                .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
-                    .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.RxDirectionBuilder()
-                    .setPort(serviceInput.getServiceAEnd().getRxDirection().getPort()).build());
-            org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
+            new org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
+                .service.path.ServiceAEndBuilder()
+                    .setServiceFormat(serviceInput.getServiceAEnd().getServiceFormat())
+                    .setServiceRate(serviceInput.getServiceAEnd().getServiceRate())
+                    .setClli(serviceInput.getServiceAEnd().getClli())
+                    .setNodeId(new NodeIdType(serviceInput.getServiceAEnd().getNodeId()).getValue())
+                    .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
+                            .transportpce.b.c._interface.service.types.rev200128
+                            .service.endpoint.sp.TxDirectionBuilder()
+                                .setPort(serviceInput.getServiceAEnd().getTxDirection().getPort())
+                                .build())
+                    .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
+                            .transportpce.b.c._interface.service.types.rev200128
+                            .service.endpoint.sp.RxDirectionBuilder()
+                                .setPort(serviceInput.getServiceAEnd().getRxDirection().getPort())
+                                .build());
+        org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
                 .service.path.ServiceZEndBuilder serviceZEnd =
-                    new org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
-                        .service.path.ServiceZEndBuilder();
-            serviceZEnd.setServiceFormat(serviceInput.getServiceZEnd().getServiceFormat())
-                .setServiceRate(serviceInput.getServiceZEnd().getServiceRate())
-                .setClli(serviceInput.getServiceZEnd().getClli())
-                .setNodeId(new NodeIdType(serviceInput.getServiceZEnd().getNodeId()).getValue())
-                .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
-                    .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.TxDirectionBuilder()
-                    .setPort(serviceInput.getServiceZEnd().getTxDirection().getPort()).build())
-                .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
-                    .transportpce.b.c._interface.service.types.rev200128.service.endpoint.sp.RxDirectionBuilder()
-                    .setPort(serviceInput.getServiceZEnd().getRxDirection().getPort()).build());
-            servicePathBuilder.setServiceAEnd(serviceAEnd.build());
-            servicePathBuilder.setServiceZEnd(serviceZEnd.build());
-            MappingConstraints mapConstraints = new MappingConstraints(serviceInput.getHardConstraints(),
-                    serviceInput.getSoftConstraints());
-            mapConstraints.serviceToServicePathConstarints();
-            if (mapConstraints.getServicePathHardConstraints() != null) {
-                HardConstraintsBuilder hardConstraintBuilder = new HardConstraintsBuilder()
+            new org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev200128
+                .service.path.ServiceZEndBuilder()
+                    .setServiceFormat(serviceInput.getServiceZEnd().getServiceFormat())
+                    .setServiceRate(serviceInput.getServiceZEnd().getServiceRate())
+                    .setClli(serviceInput.getServiceZEnd().getClli())
+                    .setNodeId(new NodeIdType(serviceInput.getServiceZEnd().getNodeId()).getValue())
+                    .setTxDirection(new org.opendaylight.yang.gen.v1.http.org
+                                .transportpce.b.c._interface.service.types.rev200128
+                                .service.endpoint.sp.TxDirectionBuilder()
+                                        .setPort(serviceInput.getServiceZEnd().getTxDirection().getPort())
+                                        .build())
+                    .setRxDirection(new org.opendaylight.yang.gen.v1.http.org
+                                .transportpce.b.c._interface.service.types.rev200128
+                                .service.endpoint.sp.RxDirectionBuilder()
+                                    .setPort(serviceInput.getServiceZEnd().getRxDirection().getPort())
+                                    .build());
+        ServicePathsBuilder servicePathBuilder = new ServicePathsBuilder()
+                .setServiceAEnd(serviceAEnd.build())
+                .setServiceZEnd(serviceZEnd.build());
+        MappingConstraints mapConstraints = new MappingConstraints(
+                serviceInput.getHardConstraints(),
+                serviceInput.getSoftConstraints()
+            );
+        mapConstraints.serviceToServicePathConstarints();
+        if (mapConstraints.getServicePathHardConstraints() != null) {
+            servicePathBuilder.setHardConstraints(
+                new HardConstraintsBuilder()
                     .setCustomerCode(serviceInput.getHardConstraints().getCustomerCode())
-                    .setCoRoutingOrGeneral(mapConstraints.getServicePathHardConstraints().getCoRoutingOrGeneral());
-                servicePathBuilder.setHardConstraints(hardConstraintBuilder.build());
-            }
-            if (mapConstraints.getServicePathSoftConstraints() != null) {
-                SoftConstraintsBuilder softConstraintBuilder = new SoftConstraintsBuilder()
+                    .setCoRoutingOrGeneral(mapConstraints.getServicePathHardConstraints().getCoRoutingOrGeneral())
+                    .build()
+            );
+        }
+        if (mapConstraints.getServicePathSoftConstraints() != null) {
+            servicePathBuilder.setSoftConstraints(
+                new SoftConstraintsBuilder()
                     .setCustomerCode(mapConstraints.getServicePathSoftConstraints().getCustomerCode())
-                    .setCoRoutingOrGeneral(mapConstraints.getServicePathSoftConstraints().getCoRoutingOrGeneral());
-                servicePathBuilder.setSoftConstraints(softConstraintBuilder.build());
-            }
-            servicePathBuilder.setServicePathName(serviceInput.getServiceName());
-            servicePathBuilder.setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
-                    .setRequestId(serviceInput.getSdncRequestHeader().getRequestId()).build());
-            if (output.getResponseParameters().getPathDescription() != null) {
-                PathDescriptionBuilder pathDescBuilder =
-                        new PathDescriptionBuilder(output.getResponseParameters().getPathDescription());
-                servicePathBuilder.setPathDescription(pathDescBuilder.build());
-            }
+                    .setCoRoutingOrGeneral(mapConstraints.getServicePathSoftConstraints().getCoRoutingOrGeneral())
+                    .build()
+            );
+        }
+        servicePathBuilder
+            .setServicePathName(serviceInput.getServiceName())
+            .setServiceHandlerHeader(new ServiceHandlerHeaderBuilder()
+                    .setRequestId(serviceInput.getSdncRequestHeader().getRequestId())
+                    .build());
+        if (output.getResponseParameters().getPathDescription() != null) {
+            servicePathBuilder.setPathDescription(
+                    new PathDescriptionBuilder(output.getResponseParameters().getPathDescription()).build()
+            );
         }
 
         return servicePathBuilder.build();