fix some sonar issues

[transportpce.git] / servicehandler / src / main / java / org / opendaylight / transportpce / servicehandler / listeners / PceListenerImpl.java

diff --git a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/PceListenerImpl.java b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/PceListenerImpl.java
index 842a84404ef5edec049fa7a65f65440b56027f06..2a4b5a43ccb0c54ea592ef7e59212ccaa345c684 100644 (file)
--- a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/PceListenerImpl.java
+++ b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/PceListenerImpl.java
@@ -59,7 +59,8 @@ public class PceListenerImpl implements TransportpcePceListener {
             servicePathRpcResult = notification;
             PathDescription pathDescription = null;
             switch (servicePathRpcResult.getNotificationType().getIntValue()) {
-                case 1: /** path-computation-request. */
+                /* path-computation-request. */
+                case 1:
                     LOG.info("PCE '{}' Notification received : {}",servicePathRpcResult.getNotificationType().getName(),
                             notification);
                     if (servicePathRpcResult.getStatus() == RpcStatusEx.Successful) {
@@ -116,7 +117,8 @@ public class PceListenerImpl implements TransportpcePceListener {
                         return;
                     }
                     break;
-                case 2: /** cancel-resource-reserve. */
+                /* cancel-resource-reserve. */
+                case 2:
                     if (servicePathRpcResult.getStatus() == RpcStatusEx.Successful) {
                         LOG.info("PCE cancel resource done OK !");
                         OperationResult deleteServicePathOperationResult =
@@ -166,13 +168,13 @@ public class PceListenerImpl implements TransportpcePceListener {
             if (servicePathRpcResult.getNotificationType() != notification.getNotificationType()) {
                 result = false;
             }
-            if (servicePathRpcResult.getServiceName() != notification.getServiceName()) {
+            if (!servicePathRpcResult.getServiceName().equals(notification.getServiceName())) {
                 result = false;
             }
             if (servicePathRpcResult.getStatus() != notification.getStatus()) {
                 result = false;
             }
-            if (servicePathRpcResult.getStatusMessage() != notification.getStatusMessage()) {
+            if (!servicePathRpcResult.getStatusMessage().equals(notification.getStatusMessage())) {
                 result = false;
             }
         }