Refactor few TAPI rpcs

[transportpce.git] / tapi / src / main / java / org / opendaylight / transportpce / tapi / impl / rpc / InitRoadmRoadmTapiLinkImpl.java

diff --git a/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitRoadmRoadmTapiLinkImpl.java b/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitRoadmRoadmTapiLinkImpl.java
index 16c2f02374fb98141de1d494271e68d44b9369ca..d46075ef496e686c69df0eb3540d930ebf40b5de 100644 (file)
--- a/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitRoadmRoadmTapiLinkImpl.java
+++ b/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitRoadmRoadmTapiLinkImpl.java
@@ -50,16 +50,15 @@ public class InitRoadmRoadmTapiLinkImpl implements InitRoadmRoadmTapiLink {
             this.tapiLink.getOperState(sourceNode, sourceTp, destNode, destTp),
             Set.of(LayerProtocolName.PHOTONICMEDIA), Set.of(LayerProtocolName.PHOTONICMEDIA.getName()),
             tapiNetworkUtilsImpl.getTapiTopoUuid());
-        InitRoadmRoadmTapiLinkOutputBuilder output = new InitRoadmRoadmTapiLinkOutputBuilder();
         if (link == null) {
             LOG.error("Error creating link object");
             return RpcResultBuilder.<InitRoadmRoadmTapiLinkOutput>failed()
                 .withError(ErrorType.RPC, "Failed to create link in topology")
                 .buildFuture();
         }
+        InitRoadmRoadmTapiLinkOutputBuilder output = new InitRoadmRoadmTapiLinkOutputBuilder();
         if (tapiNetworkUtilsImpl.putLinkInTopology(link)) {
-            output = new InitRoadmRoadmTapiLinkOutputBuilder()
-                .setResult("Link created in tapi topology. Link-uuid = " + link.getUuid());
+            output.setResult("Link created in tapi topology. Link-uuid = " + link.getUuid());
         }
         return RpcResultBuilder.success(output.build()).buildFuture();
     }