Refactor few TAPI rpcs

[transportpce.git] / tapi / src / main / java / org / opendaylight / transportpce / tapi / impl / rpc / InitXpdrRdmTapiLinkImpl.java

diff --git a/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitXpdrRdmTapiLinkImpl.java b/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitXpdrRdmTapiLinkImpl.java
index e2ab0c3279865415d414705081d0140f7f663341..90c3d61f1d9df391aa87d0eb574c20b4af4adcde 100644 (file)
--- a/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitXpdrRdmTapiLinkImpl.java
+++ b/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/rpc/InitXpdrRdmTapiLinkImpl.java
@@ -50,16 +50,15 @@ public class InitXpdrRdmTapiLinkImpl implements InitXpdrRdmTapiLink {
             this.tapiLink.getOperState(sourceNode, sourceTp, destNode, destTp),
             Set.of(LayerProtocolName.PHOTONICMEDIA), Set.of(LayerProtocolName.PHOTONICMEDIA.getName()),
             tapiNetworkUtilsImpl.getTapiTopoUuid());
-        InitXpdrRdmTapiLinkOutputBuilder output = new InitXpdrRdmTapiLinkOutputBuilder();
         if (link == null) {
             LOG.error("Error creating link object");
             return RpcResultBuilder.<InitXpdrRdmTapiLinkOutput>failed()
                 .withError(ErrorType.RPC, "Failed to create link in topology")
                 .buildFuture();
         }
+        InitXpdrRdmTapiLinkOutputBuilder output = new InitXpdrRdmTapiLinkOutputBuilder();
         if (tapiNetworkUtilsImpl.putLinkInTopology(link)) {
-            output = new InitXpdrRdmTapiLinkOutputBuilder()
-                .setResult("Link created in tapi topology. Link-uuid = " + link.getUuid());
+            output.setResult("Link created in tapi topology. Link-uuid = " + link.getUuid());
         }
         return RpcResultBuilder.success(output.build()).buildFuture();
     }