import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
import org.opendaylight.transportpce.test.DataStoreContext;
import org.opendaylight.transportpce.test.converter.XMLDataObjectConverter;
-import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev210310.Network;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220114.Network;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.Networks;
import org.opendaylight.yangtools.yang.binding.DataObject;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
private static final Logger LOG = LoggerFactory.getLogger(TopologyDataUtils.class);
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public static <T> void writeTopologyFromFileToDatastore(DataStoreContext dataStoreContextUtil, String file,
InstanceIdentifier ii) throws InterruptedException, ExecutionException {
Networks networks = null;
if (topoFile.exists()) {
String fileName = topoFile.getName();
try (InputStream targetStream = new FileInputStream(topoFile)) {
- Optional<NormalizedNode<?, ?>> transformIntoNormalizedNode = XMLDataObjectConverter
+ Optional<NormalizedNode> transformIntoNormalizedNode = XMLDataObjectConverter
.createWithDataStoreUtil(dataStoreContextUtil).transformIntoNormalizedNode(targetStream);
if (!transformIntoNormalizedNode.isPresent()) {
throw new IllegalStateException(String.format(
LOG.info("extraction from {} stored with success in datastore", topoFile.getName());
}
- @SuppressWarnings("unchecked")
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
private static FluentFuture<? extends CommitInfo> writeTransaction(DataBroker dataBroker,
InstanceIdentifier instanceIdentifier, DataObject object) {
WriteTransaction transaction = dataBroker.newWriteOnlyTransaction();
if (portmappingFile.exists()) {
String fileName = portmappingFile.getName();
try (InputStream targetStream = new FileInputStream(portmappingFile)) {
- Optional<NormalizedNode<?, ?>> transformIntoNormalizedNode = null;
+ Optional<NormalizedNode> transformIntoNormalizedNode = null;
transformIntoNormalizedNode = XMLDataObjectConverter.createWithDataStoreUtil(dataStoreContextUtil)
.transformIntoNormalizedNode(targetStream);
if (!transformIntoNormalizedNode.isPresent()) {