clean some compilation warnings
[transportpce.git] / tests / stubpce / src / main / java / org / opendaylight / transportpce / stubpce / impl / StubpceImpl.java
index 89d3404f7d2a20b31fd44e87aed4b0a901d4555d..6240693e29e18d0e2a060422ef2defe3ae2ddd22 100644 (file)
@@ -14,13 +14,11 @@ import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.ListeningExecutorService;
 import com.google.common.util.concurrent.MoreExecutors;
-
 import java.util.Iterator;
 import java.util.SortedSet;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
-
 import org.opendaylight.controller.md.sal.binding.api.DataBroker;
 import org.opendaylight.controller.md.sal.binding.api.NotificationPublishService;
 import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction;
@@ -33,6 +31,26 @@ import org.opendaylight.transportpce.stubpce.StubpceTxRxCheck;
 import org.opendaylight.transportpce.stubpce.topology.PathDescriptionsOrdered;
 import org.opendaylight.transportpce.stubpce.topology.SuperNodePath;
 import org.opendaylight.transportpce.stubpce.topology.Topology;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.CancelResourceReserveInput;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.CancelResourceReserveOutput;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.CancelResourceReserveOutputBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.PathComputationRequestInput;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.PathComputationRequestOutput;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.PathComputationRequestOutputBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.PathDescriptionList;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.PathDescriptionListBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.ServicePathList;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.ServicePathListBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.ServicePathRpcResult;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.ServicePathRpcResultBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.StubpceService;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.path.description.list.PathDescriptions;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.path.description.list.PathDescriptionsBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.path.description.list.PathDescriptionsKey;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.service.path.list.ServicePaths;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.service.path.list.ServicePathsBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.service.path.list.ServicePathsKey;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubpce.rev170426.service.path.rpc.result.PathDescriptionBuilder;
 import org.opendaylight.yang.gen.v1.http.org.openroadm.common.service.types.rev161014.configuration.response.common.ConfigurationResponseCommonBuilder;
 import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.ServiceList;
 import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.service.list.Services;
@@ -40,30 +58,6 @@ import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.service
 import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.service.list.ServicesKey;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev170426.RpcStatusEx;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev170426.ServicePathNotificationTypes;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev170426.response.parameters.sp.response.parameters.PathDescriptionBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.CancelResourceReserveInput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.CancelResourceReserveOutput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.CancelResourceReserveOutputBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.PathComputationRequestInput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.PathComputationRequestOutput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.PathComputationRequestOutputBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.PathDescriptionList;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.PathDescriptionListBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServiceDeleteInput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServiceDeleteOutput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServiceImplementationRequestInput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServiceImplementationRequestOutput;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServicePathList;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServicePathListBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServicePathRpcResult;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.ServicePathRpcResultBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.TransportpceServicepathService;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.path.description.list.PathDescriptions;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.path.description.list.PathDescriptionsBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.path.description.list.PathDescriptionsKey;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.service.path.list.ServicePaths;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.service.path.list.ServicePathsBuilder;
-import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.service.path.list.ServicePathsKey;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.service.path.rpc.result.PathDescription;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.opendaylight.yangtools.yang.common.RpcResult;
@@ -77,7 +71,7 @@ import org.slf4j.LoggerFactory;
  *         behalf of Orange
  */
 
-public class StubpceImpl implements TransportpceServicepathService {
+public class StubpceImpl implements StubpceService {
     /** Logging. */
     private static final Logger LOG = LoggerFactory.getLogger(StubpceImpl.class);
     /** Permit to access database. */
@@ -98,7 +92,7 @@ public class StubpceImpl implements TransportpceServicepathService {
     public StubpceImpl(NotificationPublishService notificationPublishService, DataBroker databroker) {
         this.notificationPublishService = notificationPublishService;
         this.db = databroker;
-        pathDescriptionBuilder = null;
+        this.pathDescriptionBuilder = null;
         if (initializePathDescriptionList(databroker)) {
             fillPathDesciptionList();
         }
@@ -109,64 +103,64 @@ public class StubpceImpl implements TransportpceServicepathService {
     }
 
     @Override
-    public Future<RpcResult<CancelResourceReserveOutput>> cancelResourceReserve(CancelResourceReserveInput input) {
+    public ListenableFuture<RpcResult<CancelResourceReserveOutput>>
+            cancelResourceReserve(CancelResourceReserveInput input) {
         LOG.info("RPC cancelResourceReserve  request received");
         String message = "";
         String responseCode = "";
         ConfigurationResponseCommonBuilder configurationResponseCommon = null;
         String serviceName = input.getServiceName();
-        LOG.info("serviceName : " + serviceName);
+        LOG.info("serviceName : {}", serviceName);
         if (serviceName != null) {
-            sendingPCE = new SendingPceRPCs(input,db,executor);
+            this.sendingPCE = new SendingPceRPCs(input,this.db,this.executor);
             FutureCallback<Boolean> pceCallback = new FutureCallback<Boolean>() {
                 String message = "";
                 ServicePathRpcResult notification = null;
 
                 @Override
                 public void onFailure(Throwable arg0) {
-                    LOG.error(arg0.toString());
-                    LOG.error("Cancel resource failed !");
-                    notification = new ServicePathRpcResultBuilder()
+                    LOG.error("Cancel resource failed : {}", arg0);
+                    this.notification = new ServicePathRpcResultBuilder()
                             .setNotificationType(ServicePathNotificationTypes.CancelResourceReserve)
                             .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Failed)
                             .setStatusMessage("Cancel resource request failed  : " + arg0.getMessage()).build();
                     try {
-                        notificationPublishService.putNotification(notification);
+                        StubpceImpl.this.notificationPublishService.putNotification(this.notification);
                     } catch (InterruptedException e) {
-                        LOG.info("notification offer rejected : " + e);
+                        LOG.info("notification offer rejected : {}", e);
                     }
                 }
 
                 @Override
                 public void onSuccess(Boolean response) {
-                    LOG.info("response : " + response);
+                    LOG.info("response : {}", response);
                     if (response) {
-                        message = "Resource cancelled !";
-                        notification = new ServicePathRpcResultBuilder()
+                        this.message = "Resource cancelled !";
+                        this.notification = new ServicePathRpcResultBuilder()
                                 .setNotificationType(ServicePathNotificationTypes.CancelResourceReserve)
                                 .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Successful)
-                                .setStatusMessage(message)
+                                .setStatusMessage(this.message)
                                 .build();
                     } else {
-                        message = sendingPCE.getError();
-                        notification = new ServicePathRpcResultBuilder()
+                        this.message = StubpceImpl.this.sendingPCE.getError();
+                        this.notification = new ServicePathRpcResultBuilder()
                                 .setNotificationType(ServicePathNotificationTypes.CancelResourceReserve)
                                 .setServiceName("")
-                                .setStatus(RpcStatusEx.Failed).setStatusMessage(message)
+                                .setStatus(RpcStatusEx.Failed).setStatusMessage(this.message)
                                 .build();
-                        message = "Cancel request failed !";
+                        this.message = "Cancel request failed !";
                     }
-                    LOG.info(notification.toString());
+                    LOG.info(this.notification.toString());
                     try {
-                        notificationPublishService.putNotification(notification);
+                        StubpceImpl.this.notificationPublishService.putNotification(this.notification);
                     } catch (InterruptedException e) {
-                        LOG.info("notification offer rejected : " + e);
+                        LOG.info("notification offer rejected : {}", e);
                     }
-                    LOG.info(message);
+                    LOG.info(this.message);
                 }
             };
-            ListenableFuture<Boolean> pce = sendingPCE.cancelResourceReserve();
-            Futures.addCallback(pce, pceCallback, executor);
+            ListenableFuture<Boolean> pce = this.sendingPCE.cancelResourceReserve();
+            Futures.addCallback(pce, pceCallback, this.executor);
             LOG.info("Cancel Resource Request in progress ...");
             configurationResponseCommon = new ConfigurationResponseCommonBuilder()
                     .setAckFinalIndicator("No")
@@ -176,19 +170,18 @@ public class StubpceImpl implements TransportpceServicepathService {
 
             CancelResourceReserveOutputBuilder output = new CancelResourceReserveOutputBuilder()
                     .setConfigurationResponseCommon(configurationResponseCommon.build());
-
             return RpcResultBuilder.success(output.build()).buildFuture();
         } else {
             message = "serviceName / requestId is not correct !";
             responseCode = "500";
-            notification = new ServicePathRpcResultBuilder()
+            this.notification = new ServicePathRpcResultBuilder()
                     .setNotificationType(ServicePathNotificationTypes.CancelResourceReserve)
                     .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Failed)
                     .setStatusMessage(message).build();
             try {
-                notificationPublishService.putNotification(notification);
+                this.notificationPublishService.putNotification(this.notification);
             } catch (InterruptedException e) {
-                LOG.info("notification offer rejected : " + e);
+                LOG.info("notification offer rejected : {}", e);
             }
         }
         configurationResponseCommon = new ConfigurationResponseCommonBuilder();
@@ -202,15 +195,16 @@ public class StubpceImpl implements TransportpceServicepathService {
     }
 
     @Override
-    public Future<RpcResult<PathComputationRequestOutput>> pathComputationRequest(PathComputationRequestInput input) {
+    public ListenableFuture<RpcResult<PathComputationRequestOutput>>
+            pathComputationRequest(PathComputationRequestInput input) {
         LOG.info("RPC pathcomputation request received");
         String message = "";
         String responseCode = "";
         boolean coherencyHardSoft = false;
         boolean commonId = true;
         ConfigurationResponseCommonBuilder configurationResponseCommon = null;
-        compliancyCheck = new StubpceCompliancyCheck(input.getServiceName(), input.getServiceHandlerHeader());
-        if (compliancyCheck.check(false, true)) {
+        this.compliancyCheck = new StubpceCompliancyCheck(input.getServiceName(), input.getServiceHandlerHeader());
+        if (this.compliancyCheck.check(false, true)) {
             LOG.info("Service compliant !");
             /**
              * If compliant, service-request parameters are verified in order to
@@ -218,12 +212,12 @@ public class StubpceImpl implements TransportpceServicepathService {
              * a path and implement a service.
              */
             LOG.info("checking Tx/Rx Info for AEnd ...");
-            txrxCheck = new StubpceTxRxCheck(input.getServiceAEnd(), 1);
-            if (txrxCheck.check()) {
+            this.txrxCheck = new StubpceTxRxCheck(input.getServiceAEnd(), 1);
+            if (this.txrxCheck.check()) {
                 LOG.info("Tx/Rx Info for AEnd checked !");
                 LOG.info("checking Tx/Rx Info for ZEnd ...");
-                txrxCheck = new StubpceTxRxCheck(input.getServiceZEnd(), 2);
-                if (txrxCheck.check()) {
+                this.txrxCheck = new StubpceTxRxCheck(input.getServiceZEnd(), 2);
+                if (this.txrxCheck.check()) {
                     LOG.info("Tx/Rx Info for ZEnd checked !");
                     /**
                      * If OK, common-id is verified in order to see if there is
@@ -232,11 +226,11 @@ public class StubpceImpl implements TransportpceServicepathService {
                      * with hard/soft constraints provided in the input of the
                      * RPC.
                      */
-                    if (input.getHardConstraints() != null || input.getSoftConstraints() != null) {
+                    if ((input.getHardConstraints() != null) || (input.getSoftConstraints() != null)) {
                         LOG.info("Constraints specified !");
-                        checkCoherencyHardSoft = new CheckCoherencyHardSoft(input.getHardConstraints(),
+                        this.checkCoherencyHardSoft = new CheckCoherencyHardSoft(input.getHardConstraints(),
                                 input.getSoftConstraints());
-                        if (checkCoherencyHardSoft.check()) {
+                        if (this.checkCoherencyHardSoft.check()) {
                             LOG.info("hard/soft constraints coherent !");
                             coherencyHardSoft = true;
                         } else {
@@ -248,73 +242,79 @@ public class StubpceImpl implements TransportpceServicepathService {
                         commonId = false;
                     }
                     if (!commonId || (commonId && coherencyHardSoft)) {
-                        notification = new ServicePathRpcResultBuilder()
+                        this.notification = new ServicePathRpcResultBuilder()
                                 .setNotificationType(ServicePathNotificationTypes.PathComputationRequest)
                                 .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Pending)
                                 .setStatusMessage("Service compliant, submitting pathComputation Request ...").build();
                         try {
-                            notificationPublishService.putNotification(notification);
+                            this.notificationPublishService.putNotification(this.notification);
                         } catch (InterruptedException e) {
-                            LOG.info("notification offer rejected : " + e);
+                            LOG.info("notification offer rejected : {}", e);
                         }
-                        sendingPCE = new SendingPceRPCs(input,db,executor);
+                        this.sendingPCE = new SendingPceRPCs(input,this.db,this.executor);
                         FutureCallback<Boolean> pceCallback = new FutureCallback<Boolean>() {
                             String message = "";
                             ServicePathRpcResult notification = null;
 
                             @Override
                             public void onFailure(Throwable arg0) {
-                                LOG.error("Failure message : " + arg0.toString());
+                                LOG.error("Failure message : {}", arg0.toString());
                                 LOG.error("Path calculation failed !");
-                                notification = new ServicePathRpcResultBuilder()
+                                this.notification = new ServicePathRpcResultBuilder()
                                         .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Failed)
                                         .setStatusMessage("PCR Request failed  : " + arg0.getMessage()).build();
                                 try {
-                                    notificationPublishService.putNotification(notification);
+                                    StubpceImpl.this.notificationPublishService.putNotification(this.notification);
                                 } catch (InterruptedException e) {
-                                    LOG.info("notification offer rejected : " + e);
+                                    LOG.info("notification offer rejected : {}", e);
                                 }
                             }
 
                             @Override
                             public void onSuccess(Boolean response) {
-                                LOG.info("response : " + response);
+                                LOG.info("response : {}", response);
                                 if (response) {
-                                    message = "Path Computated !";
+                                    this.message = "Path Computated !";
                                     ServicePathRpcResultBuilder tmp = new ServicePathRpcResultBuilder()
                                             .setNotificationType(ServicePathNotificationTypes.PathComputationRequest)
                                             .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Successful)
-                                            .setStatusMessage(message);
-                                    pathDescriptionBuilder = sendingPCE.getPathDescription();
-                                    if (pathDescriptionBuilder != null) {
+                                            .setStatusMessage(this.message);
+                                    StubpceImpl.this.pathDescriptionBuilder =
+                                        StubpceImpl.this.sendingPCE.getPathDescription();
+                                    if (StubpceImpl.this.pathDescriptionBuilder != null) {
                                         PathDescription pathDescription = new org.opendaylight.yang.gen.v1.http.org
-                                                .transportpce.b.c._interface.servicepath.rev170426.service.path
-                                                .rpc.result.PathDescriptionBuilder()
-                                                .setAToZDirection(pathDescriptionBuilder.getAToZDirection())
-                                                .setZToADirection(pathDescriptionBuilder.getZToADirection())
-                                                .build();
-                                        tmp.setPathDescription(pathDescription);
+                                            .transportpce.b.c._interface.servicepath.rev170426.service.path
+                                            .rpc.result.PathDescriptionBuilder()
+                                            .setAToZDirection(
+                                                StubpceImpl.this.pathDescriptionBuilder.getAToZDirection())
+                                            .setZToADirection(
+                                                StubpceImpl.this.pathDescriptionBuilder.getZToADirection())
+                                            .build();
+                                        tmp.setPathDescription(new PathDescriptionBuilder()
+                                                .setAToZDirection(pathDescription.getAToZDirection())
+                                                .setZToADirection(pathDescription.getZToADirection())
+                                                .build());
                                     }
-                                    notification = tmp.build();
+                                    this.notification = tmp.build();
                                 } else {
-                                    message = sendingPCE.getError();
-                                    notification = new ServicePathRpcResultBuilder()
+                                    this.message = StubpceImpl.this.sendingPCE.getError();
+                                    this.notification = new ServicePathRpcResultBuilder()
                                             .setNotificationType(ServicePathNotificationTypes.PathComputationRequest)
                                             .setServiceName("")
-                                            .setStatus(RpcStatusEx.Failed).setStatusMessage(message)
+                                            .setStatus(RpcStatusEx.Failed).setStatusMessage(this.message)
                                             .build();
-                                    message = "Path not calculated!";
+                                    this.message = "Path not calculated!";
                                 }
                                 try {
-                                    notificationPublishService.putNotification(notification);
+                                    StubpceImpl.this.notificationPublishService.putNotification(this.notification);
                                 } catch (InterruptedException e) {
-                                    LOG.info("notification offer rejected : " + e);
+                                    LOG.info("notification offer rejected : {}", e);
                                 }
-                                LOG.info(message);
+                                LOG.info(this.message);
                             }
                         };
-                        ListenableFuture<Boolean> pce = sendingPCE.pathComputation();
-                        Futures.addCallback(pce, pceCallback, executor);
+                        ListenableFuture<Boolean> pce = this.sendingPCE.pathComputation();
+                        Futures.addCallback(pce, pceCallback, this.executor);
                         LOG.info("PathComputation Request in progress ...");
                         configurationResponseCommon = new ConfigurationResponseCommonBuilder()
                                 .setAckFinalIndicator("No")
@@ -328,24 +328,24 @@ public class StubpceImpl implements TransportpceServicepathService {
                     }
 
                 } else {
-                    message = txrxCheck.getMessage();
+                    message = this.txrxCheck.getMessage();
                     responseCode = "500";
                 }
             } else {
-                message = txrxCheck.getMessage();
+                message = this.txrxCheck.getMessage();
                 responseCode = "500";
             }
         } else {
-            message = compliancyCheck.getMessage();
+            message = this.compliancyCheck.getMessage();
             responseCode = "500";
-            notification = new ServicePathRpcResultBuilder()
+            this.notification = new ServicePathRpcResultBuilder()
                     .setNotificationType(ServicePathNotificationTypes.PathComputationRequest)
                     .setServiceName(input.getServiceName()).setStatus(RpcStatusEx.Failed)
                     .setStatusMessage("Service not compliant : " + message).build();
             try {
-                notificationPublishService.putNotification(notification);
+                this.notificationPublishService.putNotification(this.notification);
             } catch (InterruptedException e) {
-                LOG.info("notification offer rejected : " + e);
+                LOG.info("notification offer rejected : {}", e);
             }
         }
         configurationResponseCommon = new ConfigurationResponseCommonBuilder();
@@ -365,10 +365,10 @@ public class StubpceImpl implements TransportpceServicepathService {
      * @param DataBroker
      *            Access DataStore
      */
-    private boolean initializePathDescriptionList(DataBroker db) {
+    private boolean initializePathDescriptionList(DataBroker dataBroker) {
         Boolean result = true;
         LOG.info("Preparing to initialize the PathDescription List");
-        WriteTransaction transaction = db.newWriteOnlyTransaction();
+        WriteTransaction transaction = dataBroker.newWriteOnlyTransaction();
         InstanceIdentifier<PathDescriptionList> iid = InstanceIdentifier.create(PathDescriptionList.class);
         PathDescriptionList pathDescriptionList = new PathDescriptionListBuilder().build();
         transaction.put(LogicalDatastoreType.OPERATIONAL, iid, pathDescriptionList);
@@ -389,10 +389,10 @@ public class StubpceImpl implements TransportpceServicepathService {
      *            Access DataStore
      * @return <code>true</code> if ok, <code>false</code> else
      */
-    private boolean initializeServicePathList(DataBroker db) {
+    private boolean initializeServicePathList(DataBroker dataBroker) {
         Boolean result = true;
         LOG.info("Preparing to initialize the ServicePathList registry");
-        WriteTransaction transaction = db.newWriteOnlyTransaction();
+        WriteTransaction transaction = dataBroker.newWriteOnlyTransaction();
         InstanceIdentifier<ServicePathList> iid = InstanceIdentifier.create(ServicePathList.class);
         ServicePathList servicePathList = new ServicePathListBuilder().build();
         transaction.put(LogicalDatastoreType.OPERATIONAL, iid, servicePathList);
@@ -400,7 +400,7 @@ public class StubpceImpl implements TransportpceServicepathService {
         try {
             Futures.getChecked(future, ExecutionException.class);
         } catch (ExecutionException e) {
-            LOG.error("Failed to create ServicePathList List : " + e.toString());
+            LOG.error("Failed to create ServicePathList List : {}", e.toString());
             result = false;
         }
         return result;
@@ -415,7 +415,7 @@ public class StubpceImpl implements TransportpceServicepathService {
         LOG.info("filling PathDescription List...");
         Topology topo = new Topology();
         topo.start();
-        LOG.info("Network : " + topo.getNetwork());
+        LOG.info("Network : {}", topo.getNetwork());
         SuperNodePath superNodePath = new SuperNodePath(topo.getNetwork());
         String aend = "NodeA";
         String zend = "NodeZ";
@@ -441,13 +441,13 @@ public class StubpceImpl implements TransportpceServicepathService {
                 if (pathDesc != null) {
                     iid = InstanceIdentifier.create(PathDescriptionList.class)
                             .child(PathDescriptions.class, new PathDescriptionsKey(pathDesc.getPathName()));
-                    writeTx = db.newWriteOnlyTransaction();
+                    writeTx = this.db.newWriteOnlyTransaction();
                     writeTx.put(LogicalDatastoreType.OPERATIONAL, iid, pathDesc);
                     future = writeTx.submit();
                     try {
                         Futures.getChecked(future, ExecutionException.class);
                     } catch (ExecutionException e) {
-                        LOG.error("Failed to write PathDescriptions to PathDescriptionsList : " + e.toString());
+                        LOG.error("Failed to write PathDescriptions to PathDescriptionsList : {}", e.toString());
                     }
                 } else {
                     LOG.error("PathDescriptions gets is null !");
@@ -469,7 +469,7 @@ public class StubpceImpl implements TransportpceServicepathService {
     @SuppressWarnings("unused")
     private Services readServiceList(String serviceName) {
         Services result = null;
-        ReadOnlyTransaction readTx = db.newReadOnlyTransaction();
+        ReadOnlyTransaction readTx = this.db.newReadOnlyTransaction();
         InstanceIdentifier<Services> iid = InstanceIdentifier.create(ServiceList.class).child(Services.class,
                 new ServicesKey(serviceName));
         Future<Optional<Services>> future = readTx.read(LogicalDatastoreType.OPERATIONAL,iid);
@@ -480,7 +480,7 @@ public class StubpceImpl implements TransportpceServicepathService {
             LOG.error("Reading service failed:", e);
         }
         if (optional.isPresent()) {
-            LOG.debug("Service '" + serviceName + "' present !");
+            LOG.debug("Service '{}' present !", serviceName);
             result = new ServicesBuilder(optional.get()).build();
         }
         return result;
@@ -497,7 +497,7 @@ public class StubpceImpl implements TransportpceServicepathService {
     @SuppressWarnings("unused")
     private ServicePaths readServicePathList(String serviceName) {
         ServicePaths result = null;
-        ReadOnlyTransaction readTx = db.newReadOnlyTransaction();
+        ReadOnlyTransaction readTx = this.db.newReadOnlyTransaction();
         InstanceIdentifier<ServicePaths> iid = InstanceIdentifier.create(ServicePathList.class)
                 .child(ServicePaths.class, new ServicePathsKey(serviceName));
         Future<Optional<ServicePaths>> future = readTx.read(LogicalDatastoreType.OPERATIONAL,iid);
@@ -508,7 +508,7 @@ public class StubpceImpl implements TransportpceServicepathService {
             LOG.error("Reading service failed:", e);
         }
         if (optional.isPresent()) {
-            LOG.debug("Service '" + serviceName + "' present !");
+            LOG.debug("Service '{}' present !", serviceName);
             result = new ServicePathsBuilder(optional.get()).build();
         }
         return result;
@@ -525,7 +525,7 @@ public class StubpceImpl implements TransportpceServicepathService {
     @SuppressWarnings("unused")
     private PathDescriptions readPathDescriptionList(String pathName) {
         PathDescriptions result = null;
-        ReadOnlyTransaction readTx = db.newReadOnlyTransaction();
+        ReadOnlyTransaction readTx = this.db.newReadOnlyTransaction();
         InstanceIdentifier<PathDescriptions> iid = InstanceIdentifier.create(PathDescriptionList.class)
                 .child(PathDescriptions.class, new PathDescriptionsKey(pathName));
         Future<Optional<PathDescriptions>> future = readTx.read(LogicalDatastoreType.OPERATIONAL,iid);
@@ -536,7 +536,7 @@ public class StubpceImpl implements TransportpceServicepathService {
             LOG.error("Reading service failed:", e);
         }
         if (optional.isPresent()) {
-            LOG.debug("PathDescritions '" + pathName + "' present !");
+            LOG.debug("PathDescritions '{}' present !", pathName);
             result = new PathDescriptionsBuilder(optional.get()).build();
         }
         return result;
@@ -553,21 +553,21 @@ public class StubpceImpl implements TransportpceServicepathService {
     @SuppressWarnings("unused")
     private String writeServicePathList(PathComputationRequestInput input) {
         String serviceName = input.getServiceName();
-        LOG.debug("Write ServicePath '" + serviceName + "' Service");
+        LOG.debug("Write ServicePath '{}' Service", serviceName);
         String result = null;
-        LOG.debug("Writing '" + serviceName + "' ServicePath");
+        LOG.debug("Writing '{}' ServicePath", serviceName);
         InstanceIdentifier<ServicePaths> iid = InstanceIdentifier.create(ServicePathList.class)
                 .child(ServicePaths.class, new ServicePathsKey(serviceName));
 
         org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev170426.service
             .path.PathDescriptionBuilder path = new org.opendaylight.yang.gen.v1.http.org.transportpce
             .b.c._interface.service.types.rev170426.service.path.PathDescriptionBuilder();
-        path.setAToZDirection(pathDescriptionBuilder.getAToZDirection());
-        path.setZToADirection(pathDescriptionBuilder.getZToADirection());
+        path.setAToZDirection(this.pathDescriptionBuilder.getAToZDirection());
+        path.setZToADirection(this.pathDescriptionBuilder.getZToADirection());
         ServicePaths service = new ServicePathsBuilder().setServicePathName(input.getServiceName())
                 .setSoftConstraints(input.getSoftConstraints()).setHardConstraints(input.getHardConstraints())
                 .setPathDescription(path.build()).build();
-        WriteTransaction writeTx = db.newWriteOnlyTransaction();
+        WriteTransaction writeTx = this.db.newWriteOnlyTransaction();
         writeTx.put(LogicalDatastoreType.OPERATIONAL, iid, service);
         Future<Void> future = writeTx.submit();
         try {
@@ -581,23 +581,10 @@ public class StubpceImpl implements TransportpceServicepathService {
     }
 
     public PathDescriptionBuilder getPathDescriptionBuilder() {
-        return pathDescriptionBuilder;
+        return this.pathDescriptionBuilder;
     }
 
     public void setPathDescriptionBuilder(PathDescriptionBuilder pathDescriptionBuilder) {
         this.pathDescriptionBuilder = pathDescriptionBuilder;
     }
-
-    @Override
-    public Future<RpcResult<ServiceImplementationRequestOutput>> serviceImplementationRequest(
-            ServiceImplementationRequestInput input) {
-        // TODO Auto-generated method stub
-        return null;
-    }
-
-    @Override
-    public Future<RpcResult<ServiceDeleteOutput>> serviceDelete(ServiceDeleteInput input) {
-        // TODO Auto-generated method stub
-        return null;
-    }
 }