Refactor func. tests RFC8040 yang mount utils

[transportpce.git] / tests / transportpce_tests / common / test_utils_rfc8040.py

diff --git a/tests/transportpce_tests/common/test_utils_rfc8040.py b/tests/transportpce_tests/common/test_utils_rfc8040.py
index b2cfc4c4c75599fb626f9699dd289ca9a4ce7feb..bf4fb6d66ff44ec5194a2fee5943cc7d215e0432 100644 (file)
--- a/tests/transportpce_tests/common/test_utils_rfc8040.py
+++ b/tests/transportpce_tests/common/test_utils_rfc8040.py
@@ -318,79 +318,27 @@ def check_device_connection(node: str):
             'connection-status': connection_status}
 
 
-def check_interface_request(node: str, interface: str):
+def check_node_attribute_request(node: str, attribute: str, attribute_value: str):
     # pylint: disable=line-too-long
-    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/interface={}',  # nopep8
-           'draft-bierman02': '{}/operational/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/interface/{}'}  # nopep8
-    response = get_request(url[RESTCONF_VERSION].format('{}', node, interface))
+    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/{}={}',  # nopep8
+           'draft-bierman02': '{}/config/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/{}/{}'}  # nopep8
+    response = get_request(url[RESTCONF_VERSION].format('{}', node, attribute, attribute_value))
     res = response.json()
-    return_key = {'rfc8040': 'org-openroadm-device:interface',
-                  'draft-bierman02': 'interface'}
+    return_key = {'rfc8040': 'org-openroadm-device:' + attribute,
+                  'draft-bierman02': attribute}
     if return_key[RESTCONF_VERSION] in res.keys():
-        interface = res[return_key[RESTCONF_VERSION]]
+        response_attribute = res[return_key[RESTCONF_VERSION]]
     else:
-        interface = res['errors']['error'][0]
+        response_attribute = res['errors']['error'][0]
     return {'status_code': response.status_code,
-            'interface': interface}
+            attribute: response_attribute}
 
 
-def del_interface_request(node: str, interface: str):
+def del_node_attribute_request(node: str, attribute: str, attribute_value: str):
     # pylint: disable=line-too-long
-    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/interface={}',  # nopep8
-           'draft-bierman02': '{}/config/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/interface/{}'}  # nopep8
-    # draft-bierman02: note this is config here and not operational as previously in check_interface_request
-    response = delete_request(url[RESTCONF_VERSION].format('{}', node, interface))
-    return response
-
-
-def check_roadm_connections_request(node: str, connections: str):
-    # pylint: disable=line-too-long
-    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/roadm-connections={}',  # nopep8
-           'draft-bierman02': '{}/operational/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/roadm-connections/{}'}  # nopep8
-    response = get_request(url[RESTCONF_VERSION].format('{}', node, connections))
-    res = response.json()
-    return_key = {'rfc8040': 'org-openroadm-device:roadm-connections',
-                  'draft-bierman02': 'roadm-connections'}
-    if return_key[RESTCONF_VERSION] in res.keys():
-        roadm_connections = res[return_key[RESTCONF_VERSION]]
-    else:
-        roadm_connections = res['errors']['error'][0]
-    return {'status_code': response.status_code,
-            'roadm-connections': roadm_connections}
-
-
-def del_roadm_connections_request(node: str, connections: str):
-    # pylint: disable=line-too-long
-    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/roadm-connections={}',  # nopep8
-           'draft-bierman02': '{}/config/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/roadm-connections/{}'}  # nopep8
-    # draft-bierman02: note this is config here and not operational as previously in check_interface_request
-    response = delete_request(url[RESTCONF_VERSION].format('{}', node, connections))
-    return response
-
-
-def check_circuit_packs_request(node: str, circuit_packs: str):
-    # pylint: disable=line-too-long
-    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/circuit-packs={}',  # nopep8
-           'draft-bierman02': '{}/config/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/circuit-packs/{}'}  # nopep8
-    # draft-bierman02: note this is config here and not operational as previously in check_interface_request
-    # FIXME: https://jira.opendaylight.org/browse/TRNSPRTPCE-591
-    response = get_request(url[RESTCONF_VERSION].format('{}', node, circuit_packs))
-    res = response.json()
-    return_key = {'rfc8040': 'org-openroadm-device:circuit-packs',
-                  'draft-bierman02': 'circuit-packs'}
-    if return_key[RESTCONF_VERSION] in res.keys():
-        cp = res[return_key[RESTCONF_VERSION]]
-    else:
-        cp = res['errors']['error'][0]
-    return {'status_code': response.status_code,
-            'circuit-packs': cp}
-
-
-def del_circuit_packs_request(node: str, circuit_packs: str):
-    # pylint: disable=line-too-long
-    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/circuit-packs={}',  # nopep8
-           'draft-bierman02': '{}/config/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/circuit-packs/{}'}  # nopep8
-    response = delete_request(url[RESTCONF_VERSION].format('{}', node, circuit_packs))
+    url = {'rfc8040': '{}/data/network-topology:network-topology/topology=topology-netconf/node={}/yang-ext:mount/org-openroadm-device:org-openroadm-device/{}={}',  # nopep8
+           'draft-bierman02': '{}/config/network-topology:network-topology/topology/topology-netconf/node/{}/yang-ext:mount/org-openroadm-device:org-openroadm-device/{}/{}'}  # nopep8
+    response = delete_request(url[RESTCONF_VERSION].format('{}', node, attribute, attribute_value))
     return response
 
 #