import static org.opendaylight.yangtools.triemap.PresencePredicate.ABSENT;
import static org.opendaylight.yangtools.triemap.PresencePredicate.PRESENT;
+import com.google.common.base.VerifyException;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
return GCAS_Complete(m, ct);
}
- private MainNode<K, V> GCAS_Complete(MainNode<K, V> m, final TrieMap<?, ?> ct) {
- while (true) {
- if (m == null) {
- return null;
- }
-
+ private MainNode<K, V> GCAS_Complete(final MainNode<K, V> oldmain, final TrieMap<?, ?> ct) {
+ MainNode<K, V> m = oldmain;
+ while (m != null) {
// complete the GCAS
final MainNode<K, V> prev = /* READ */ m.READ_PREV();
- final Gen rdgen = ct.readRoot(true).gen;
+ final INode<?, ?> ctr = ct.readRoot(true);
if (prev == null) {
return m;
}
return fn.READ_PREV();
}
- // Tail recursion: return GCAS_Complete (/* READ */ mainnode, ct);
+ // Tail recursion: return GCAS_Complete(/* READ */ mainnode, ct);
m = /* READ */ mainnode;
continue;
}
// ==> if `ctr.gen` = `gen` then they are both equal to G.
// ==> otherwise, we know that either `ctr.gen` > G, `gen` < G,
// or both
- if (rdgen == gen && !ct.isReadOnly()) {
+ if (ctr.gen == gen && !ct.isReadOnly()) {
// try to commit
if (m.CAS_PREV(prev, null)) {
return m;
}
- // Tail recursion: return GCAS_Complete (m, ct);
+ // Tail recursion: return GCAS_Complete(m, ct);
continue;
}
// Tail recursion: return GCAS_Complete(/* READ */ mainnode, ct);
m = /* READ */ mainnode;
}
+
+ return null;
}
private boolean GCAS(final MainNode<K, V> old, final MainNode<K, V> n, final TrieMap<?, ?> ct) {
*
* @return true if successful, false otherwise
*/
- boolean rec_insert(final K k, final V v, final int hc, final int lev, final INode<K, V> parent,
+ boolean rec_insert(final K key, final V value, final int hc, final int lev, final INode<K, V> parent,
final TrieMap<K, V> ct) {
- return rec_insert(k, v, hc, lev, parent, gen, ct);
+ return rec_insert(key, value, hc, lev, parent, gen, ct);
}
private boolean rec_insert(final K k, final V v, final int hc, final int lev, final INode<K, V> parent,
return in.rec_insert(k, v, hc, lev + LEVEL_BITS, this, startgen, ct);
}
if (GCAS(cn, cn.renewed(startgen, ct), ct)) {
- // Tail recursion: return rec_insert (k, v, hc, lev, parent, startgen, ct);
+ // Tail recursion: return rec_insert(k, v, hc, lev, parent, startgen, ct);
continue;
}
}
final CNode<K, V> rn = (cn.gen == gen) ? cn : cn.renewed(gen, ct);
- final MainNode<K, V> nn = rn.updatedAt(pos, inode(CNode.dual(sn, k, v, hc, lev + LEVEL_BITS, gen)), gen);
- return GCAS (cn, nn, ct);
+ final MainNode<K, V> nn = rn.updatedAt(pos, inode(
+ CNode.dual(sn, k, v, hc, lev + LEVEL_BITS, gen)), gen);
+ return GCAS(cn, nn, ct);
+ } else {
+ throw CNode.invalidElement(cnAtPos);
}
- } else {
- final CNode<K, V> rn = (cn.gen == gen) ? cn : cn.renewed(gen, ct);
- final MainNode<K, V> ncnode = rn.insertedAt(pos, flag, new SNode<>(k, v, hc), gen);
- return GCAS (cn, ncnode, ct);
}
+
+ final CNode<K, V> rn = (cn.gen == gen) ? cn : cn.renewed(gen, ct);
+ final MainNode<K, V> ncnode = rn.insertedAt(pos, flag, new SNode<>(k, v, hc), gen);
+ return GCAS(cn, ncnode, ct);
} else if (m instanceof TNode) {
clean(parent, ct, lev - LEVEL_BITS);
return false;
final LNodeEntry<K, V> entry = ln.get(ct.equiv(), k);
return entry != null ? replaceln(ln, entry, v, ct) : insertln(ln, k, v, ct);
} else {
- throw new IllegalStateException("Unhandled node " + m);
+ throw invalidElement(m);
}
-
- throw new RuntimeException ("Should not happen");
}
}
+ private static VerifyException invalidElement(final BasicNode elem) {
+ throw new VerifyException("An INode can host only a CNode, a TNode or an LNode, not " + elem);
+ }
+
+ @SuppressFBWarnings(value = "NP_OPTIONAL_RETURN_NULL",
+ justification = "Returning null Optional indicates the need to restart.")
+ private Optional<V> insertDual(final TrieMap<K, V> ct, final CNode<K, V> cn, final int pos, final SNode<K, V> sn,
+ final K k, final V v, final int hc, final int lev) {
+ final CNode<K, V> rn = (cn.gen == gen) ? cn : cn.renewed(gen, ct);
+ final MainNode<K, V> nn = rn.updatedAt(pos, inode(CNode.dual(sn, k, v, hc, lev + LEVEL_BITS, gen)), gen);
+ return GCAS(cn, nn, ct) ? Optional.empty() : null;
+ }
+
/**
* Inserts a new key value pair, given that a specific condition is met.
*
return rec_insertif(k, v, hc, cond, lev, parent, gen, ct);
}
- @SuppressFBWarnings(value = "NP_OPTIONAL_RETURN_NULL",
- justification = "Returning null Optional indicates the need to restart.")
- private Optional<V> insertDual(final TrieMap<K, V> ct, final CNode<K, V> cn, final int pos, final SNode<K, V> sn,
- final K k, final V v, final int hc, final int lev) {
- final CNode<K, V> rn = (cn.gen == gen) ? cn : cn.renewed(gen, ct);
- final MainNode<K, V> nn = rn.updatedAt(pos, inode(CNode.dual(sn, k, v, hc, lev + LEVEL_BITS, gen)), gen);
- return GCAS(cn, nn, ct) ? Optional.empty() : null;
- }
-
@SuppressFBWarnings(value = "NP_OPTIONAL_RETURN_NULL",
justification = "Returning null Optional indicates the need to restart.")
private Optional<V> rec_insertif(final K k, final V v, final int hc, final Object cond, final int lev,
}
if (GCAS(cn, cn.renewed(startgen, ct), ct)) {
- // Tail recursion: return rec_insertif (k, v, hc, cond, lev, parent, startgen, ct);
+ // Tail recursion: return rec_insertif(k, v, hc, cond, lev, parent, startgen, ct);
continue;
}
return Optional.empty();
}
+ } else {
+ throw CNode.invalidElement(cnAtPos);
}
} else if (cond == null || cond == ABSENT) {
final CNode<K, V> rn = (cn.gen == gen) ? cn : cn.renewed(gen, ct);
- final CNode<K, V> ncnode = rn.insertedAt (pos, flag, new SNode<>(k, v, hc), gen);
+ final CNode<K, V> ncnode = rn.insertedAt(pos, flag, new SNode<>(k, v, hc), gen);
if (GCAS(cn, ncnode, ct)) {
return Optional.empty();
}
return replaceln(ln, entry, v, ct) ? Optional.of(entry.getValue()) : null;
}
} else {
- throw new IllegalStateException("Unhandled node " + m);
+ throw invalidElement(m);
}
-
- throw new RuntimeException("Should never happen");
}
}
}
return null;
+ } else {
+ throw CNode.invalidElement(sub);
}
} else if (m instanceof TNode) {
// 3) non-live node
final LNodeEntry<K, V> entry = ((LNode<K, V>) m).get(ct.equiv(), k);
return entry != null ? entry.getValue() : null;
} else {
- throw new IllegalStateException("Unhandled node " + m);
+ throw invalidElement(m);
}
-
- throw new RuntimeException ("Should not happen");
}
}
final int pos = Integer.bitCount(bmp & (flag - 1));
final BasicNode sub = cn.array[pos];
- Optional<V> res = null;
+ final Optional<V> res;
if (sub instanceof INode) {
final INode<K, V> in = (INode<K, V>) sub;
if (startgen == in.gen) {
res = in.rec_remove(k, cond, hc, lev + LEVEL_BITS, this, startgen, ct);
} else {
- if (GCAS(cn, cn.renewed (startgen, ct), ct)) {
+ if (GCAS(cn, cn.renewed(startgen, ct), ct)) {
res = rec_remove(k, cond, hc, lev, parent, startgen, ct);
} else {
res = null;
}
}
-
} else if (sub instanceof SNode) {
final SNode<K, V> sn = (SNode<K, V>) sub;
if (sn.hc == hc && ct.equal(sn.k, k) && (cond == null || cond.equals(sn.v))) {
} else {
res = Optional.empty();
}
+ } else {
+ throw CNode.invalidElement(sub);
}
if (res == null || !res.isPresent()) {
return GCAS(ln, ln.removeChild(entry, hc), ct) ? Optional.of(value) : null;
} else {
- throw new IllegalStateException("Unhandled node " + m);
+ throw invalidElement(m);
}
}
}
}
- int cachedSize(final TrieMap<?, ?> ct) {
- return GCAS_READ(ct).cachedSize(ct);
+ int size(final ImmutableTrieMap<?, ?> ct) {
+ return GCAS_READ(ct).size(ct);
}
// /* this is a quiescent method! */
String string(final int lev) {
return "INode";
}
-}
\ No newline at end of file
+}
Code Review / yangtools.git / blobdiff