introduce INeutronCRUD.Result, instead of boolean

[neutron.git] / transcriber / src / main / java / org / opendaylight / neutron / transcriber / AbstractTranscriberInterface.java

diff --git a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/AbstractTranscriberInterface.java b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/AbstractTranscriberInterface.java
index 9caa30df7bfa252eac1c5fe3d651159d18524635..9f31fd81a35fcbd6f1e27ed8a5d37e052976e1c8 100644 (file)
--- a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/AbstractTranscriberInterface.java
+++ b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/AbstractTranscriberInterface.java
@@ -481,18 +481,18 @@ public abstract class AbstractTranscriberInterface<
         }
     }
 
-    private boolean add(S input, ReadWriteTransaction tx) throws InterruptedException, ExecutionException {
+    private Result add(S input, ReadWriteTransaction tx) throws InterruptedException, ExecutionException {
         Preconditions.checkNotNull(tx);
         if (exists(input.getID(), tx)) {
             tx.cancel();
-            return false;
+            return Result.AlreadyExists;
         }
         addMd(input, tx);
-        return true;
+        return Result.Success;
     }
 
     @Override
-    public boolean add(S input) {
+    public Result add(S input) {
         int retries = RETRY_MAX;
         while (retries-- >= 0) {
             final ReadWriteTransaction tx = getDataBroker().newReadWriteTransaction();
@@ -508,7 +508,8 @@ public abstract class AbstractTranscriberInterface<
             }
             break;
         }
-        return false;
+        // TODO remove when re-throwing, and remove Result.Exception completely
+        return Result.Exception;
     }
 
     private boolean remove(String uuid, ReadWriteTransaction tx) throws InterruptedException, ExecutionException {