remove unnecessary cast

[neutron.git] / transcriber / src / main / java / org / opendaylight / neutron / transcriber / NeutronFirewallInterface.java

diff --git a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallInterface.java b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallInterface.java
index 81061da1831ace378c434ee48a6e5c6f97c3b1c3..389a24bcd530591717d1231f0a84afbee15ec52d 100644 (file)
--- a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallInterface.java
+++ b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallInterface.java
@@ -8,45 +8,21 @@
 
 package org.opendaylight.neutron.transcriber;
 
-import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ProviderContext;
+import java.util.List;
+import org.opendaylight.controller.md.sal.binding.api.DataBroker;
 import org.opendaylight.neutron.spi.INeutronFirewallCRUD;
 import org.opendaylight.neutron.spi.NeutronFirewall;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.firewalls.attributes.Firewalls;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.firewalls.attributes.firewalls.Firewall;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.firewalls.attributes.firewalls.FirewallBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.firewalls.attributes.firewalls.FirewallKey;
 
-import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev141002.firewalls.attributes.Firewalls;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev141002.firewalls.attributes.firewalls.Firewall;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev141002.firewalls.attributes.firewalls.FirewallBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150325.Neutron;
-
-import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.ServiceRegistration;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map.Entry;
-import java.util.Set;
-
-public class NeutronFirewallInterface extends AbstractNeutronInterface<Firewall, Firewalls, NeutronFirewall> implements INeutronFirewallCRUD {
-
-    private static final Logger LOGGER = LoggerFactory.getLogger(NeutronFirewallInterface.class);
+public final class NeutronFirewallInterface
+        extends AbstractNeutronInterface<Firewall, Firewalls, FirewallKey, NeutronFirewall>
+        implements INeutronFirewallCRUD {
 
-    NeutronFirewallInterface(ProviderContext providerContext) {
-        super(providerContext);
-    }
-
-    @Override
-    public boolean neutronFirewallExists(String uuid) {
-        return exists(uuid);
-    }
-
-    @Override
-    public NeutronFirewall getNeutronFirewall(String uuid) {
-        return get(uuid);
+    NeutronFirewallInterface(DataBroker db) {
+        super(FirewallBuilder.class, db);
     }
 
     @Override
@@ -55,91 +31,26 @@ public class NeutronFirewallInterface extends AbstractNeutronInterface<Firewall,
     }
 
     @Override
-    public List<NeutronFirewall> getAllNeutronFirewalls() {
-        return getAll();
-    }
-
-    @Override
-    public boolean addNeutronFirewall(NeutronFirewall input) {
-        return add(input);
-    }
-
-    @Override
-    public boolean removeNeutronFirewall(String uuid) {
-        return remove(uuid);
-    }
-
-    @Override
-    public boolean updateNeutronFirewall(String uuid, NeutronFirewall delta) {
-        return update(uuid, delta);
-    }
-
-    @Override
-    public boolean neutronFirewallInUse(String firewallUUID) {
-        return !exists(firewallUUID);
-    }
-
-    @Override
-    protected InstanceIdentifier<Firewall> createInstanceIdentifier(Firewall item) {
-        return InstanceIdentifier.create(Neutron.class)
-                .child(Firewalls.class)
-                .child(Firewall.class, item.getKey());
-    }
-
-    @Override
-    protected InstanceIdentifier<Firewalls> createInstanceIdentifier() {
-        return InstanceIdentifier.create(Neutron.class)
-                .child(Firewalls.class);
-    }
-
     protected NeutronFirewall fromMd(Firewall firewall) {
-        NeutronFirewall answer = new NeutronFirewall();
-        if (firewall.getUuid() != null) {
-            answer.setID(firewall.getUuid().getValue());
-        }
-        if (firewall.getName() != null) {
-            answer.setFirewallName(firewall.getName());
-        }
-        if (firewall.getTenantId() != null) {
-            answer.setTenantID(firewall.getTenantId());
-        }
+        final NeutronFirewall answer = new NeutronFirewall();
+        fromMdBaseAttributes(firewall, answer);
         answer.setFirewallAdminStateIsUp(firewall.isAdminStateUp());
-        if (firewall.getStatus() != null) {
-            answer.setFirewallStatus(firewall.getStatus());
-        }
-        if (firewall.getDescr() != null) {
-            answer.setFirewallDescription(firewall.getDescr());
-        }
         if (firewall.isShared() != null) {
             answer.setFirewallIsShared(firewall.isShared());
         }
         if (firewall.getFirewallPolicyId() != null) {
-             answer.setFirewallPolicyID(firewall.getFirewallPolicyId().getValue());
+            answer.setFirewallPolicyID(firewall.getFirewallPolicyId().getValue());
         }
         return answer;
     }
 
     @Override
     protected Firewall toMd(NeutronFirewall firewall) {
-        FirewallBuilder firewallBuilder = new FirewallBuilder();
-        if (firewall.getID() != null) {
-            firewallBuilder.setUuid(toUuid(firewall.getID()));
-        }
-        if (firewall.getFirewallName() != null) {
-            firewallBuilder.setName(firewall.getFirewallName());
-        }
-        if (firewall.getTenantID() != null) {
-            firewallBuilder.setTenantId(toUuid(firewall.getTenantID()));
-        }
+        final FirewallBuilder firewallBuilder = new FirewallBuilder();
+        toMdBaseAttributes(firewall, firewallBuilder);
         if (firewall.getFirewallAdminStateIsUp() != null) {
             firewallBuilder.setAdminStateUp(firewall.getFirewallAdminStateIsUp());
         }
-        if (firewall.getFirewallStatus() != null) {
-            firewallBuilder.setStatus(firewall.getFirewallStatus());
-        }
-        if (firewall.getFirewallDescription() != null) {
-            firewallBuilder.setDescr(firewall.getFirewallDescription());
-        }
         if (firewall.getFirewallIsShared() != null) {
             firewallBuilder.setShared(firewall.getFirewallIsShared());
         }
@@ -148,21 +59,4 @@ public class NeutronFirewallInterface extends AbstractNeutronInterface<Firewall,
         }
         return firewallBuilder.build();
     }
-
-    @Override
-    protected Firewall toMd(String uuid) {
-        FirewallBuilder firewallBuilder = new FirewallBuilder();
-        firewallBuilder.setUuid(toUuid(uuid));
-        return firewallBuilder.build();
-    }
-
-    public static void registerNewInterface(BundleContext context,
-                                            ProviderContext providerContext,
-                                            List<ServiceRegistration<?>> registrations) {
-        NeutronFirewallInterface neutronFirewallInterface = new NeutronFirewallInterface(providerContext);
-        ServiceRegistration<INeutronFirewallCRUD> neutronFirewallInterfaceRegistration = context.registerService(INeutronFirewallCRUD.class, neutronFirewallInterface, null);
-        if(neutronFirewallInterfaceRegistration != null) {
-            registrations.add(neutronFirewallInterfaceRegistration);
-        }
-    }
 }