remove unnecessary cast

[neutron.git] / transcriber / src / main / java / org / opendaylight / neutron / transcriber / NeutronFirewallRuleInterface.java

diff --git a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallRuleInterface.java b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallRuleInterface.java
index e4c623e4393518885148016637e3cb04f650c518..8a2e4c674b9614d302657cf9d6e53b2ff7d59927 100644 (file)
--- a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallRuleInterface.java
+++ b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronFirewallRuleInterface.java
@@ -8,12 +8,12 @@
 
 package org.opendaylight.neutron.transcriber;
 
+import com.google.common.collect.ImmutableBiMap;
 import java.util.List;
-
-import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ProviderContext;
+import org.opendaylight.controller.md.sal.binding.api.DataBroker;
+import org.opendaylight.neutron.northbound.api.BadRequestException;
 import org.opendaylight.neutron.spi.INeutronFirewallRuleCRUD;
 import org.opendaylight.neutron.spi.NeutronFirewallRule;
-
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.constants.rev150712.IpVersionBase;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.constants.rev150712.IpVersionV4;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.constants.rev150712.IpVersionV6;
@@ -25,34 +25,22 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.Fir
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.rules.attributes.FirewallRules;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.rules.attributes.firewall.rules.FirewallRule;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.rules.attributes.firewall.rules.FirewallRuleBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.fwaas.rev150712.rules.attributes.firewall.rules.FirewallRuleKey;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.types.rev160517.IpPrefixOrAddress;
-import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
-
-
-import com.google.common.collect.ImmutableBiMap;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.ServiceRegistration;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-public class NeutronFirewallRuleInterface extends AbstractNeutronInterface<FirewallRule, FirewallRules, NeutronFirewallRule> implements INeutronFirewallRuleCRUD {
-    private static final Logger LOGGER = LoggerFactory.getLogger(NeutronFirewallRuleInterface.class);
 
-    private static final ImmutableBiMap<Class<? extends ActionBase>, String> ACTION_MAP
-            = new ImmutableBiMap.Builder<Class<? extends ActionBase>, String>()
-            .put(ActionAllow.class, "allow")
-            .put(ActionDeny.class, "deny")
-            .build();
+public final class NeutronFirewallRuleInterface
+        extends AbstractNeutronInterface<FirewallRule, FirewallRules, FirewallRuleKey, NeutronFirewallRule>
+        implements INeutronFirewallRuleCRUD {
+    private static final ImmutableBiMap<Class<? extends ActionBase>,
+            String> ACTION_MAP = new ImmutableBiMap.Builder<Class<? extends ActionBase>, String>()
+                    .put(ActionAllow.class, "allow").put(ActionDeny.class, "deny").build();
 
-    private static final ImmutableBiMap<Class<? extends IpVersionBase>, Integer> IP_VERSION_MAP
-            = new ImmutableBiMap.Builder<Class<? extends IpVersionBase>, Integer>()
-            .put(IpVersionV4.class, Integer.valueOf(4))
-            .put(IpVersionV6.class, Integer.valueOf(6))
-            .build();
+    private static final ImmutableBiMap<Class<? extends IpVersionBase>,
+            Integer> IP_VERSION_MAP = new ImmutableBiMap.Builder<Class<? extends IpVersionBase>, Integer>()
+                    .put(IpVersionV4.class, Integer.valueOf(4)).put(IpVersionV6.class, Integer.valueOf(6)).build();
 
-    NeutronFirewallRuleInterface(ProviderContext providerContext) {
-        super(providerContext);
+    NeutronFirewallRuleInterface(DataBroker db) {
+        super(FirewallRuleBuilder.class, db);
     }
 
     @Override
@@ -61,29 +49,9 @@ public class NeutronFirewallRuleInterface extends AbstractNeutronInterface<Firew
     }
 
     @Override
-    protected InstanceIdentifier<FirewallRule> createInstanceIdentifier(FirewallRule item) {
-        return InstanceIdentifier.create(Neutron.class)
-                .child(FirewallRules.class)
-                .child(FirewallRule.class, item.getKey());
-    }
-
-    @Override
-    protected InstanceIdentifier<FirewallRules> createInstanceIdentifier() {
-        return InstanceIdentifier.create(Neutron.class)
-                .child(FirewallRules.class);
-    }
-
     protected NeutronFirewallRule fromMd(FirewallRule rule) {
         final NeutronFirewallRule answer = new NeutronFirewallRule();
-        if (rule.getUuid() != null) {
-            answer.setID(rule.getUuid().getValue());
-        }
-        if (rule.getName() != null) {
-            answer.setFirewallRuleName(rule.getName());
-        }
-        if (rule.getTenantId() != null) {
-            answer.setTenantID(rule.getTenantId());
-        }
+        fromMdBaseAttributes(rule, answer);
         if (rule.isShared() != null) {
             answer.setFirewallRuleIsShared(rule.isShared());
         }
@@ -136,15 +104,7 @@ public class NeutronFirewallRuleInterface extends AbstractNeutronInterface<Firew
     @Override
     protected FirewallRule toMd(NeutronFirewallRule rule) {
         final FirewallRuleBuilder ruleBuilder = new FirewallRuleBuilder();
-        if (rule.getID() != null) {
-            ruleBuilder.setUuid(toUuid(rule.getID()));
-        }
-        if (rule.getFirewallRuleName() != null) {
-            ruleBuilder.setName(rule.getFirewallRuleName());
-        }
-        if (rule.getTenantID() != null) {
-            ruleBuilder.setTenantId(toUuid(rule.getTenantID()));
-        }
+        toMdBaseAttributes(rule, ruleBuilder);
         if (rule.getFirewallRuleIsShared() != null) {
             ruleBuilder.setShared(rule.getFirewallRuleIsShared());
         }
@@ -156,8 +116,13 @@ public class NeutronFirewallRuleInterface extends AbstractNeutronInterface<Firew
         }
         if (rule.getFirewallRuleProtocol() != null) {
             final String protocolString = rule.getFirewallRuleProtocol();
-            final Protocol protocol = new Protocol(protocolString.toCharArray());
-            ruleBuilder.setProtocol(protocol);
+            try {
+                final Protocol protocol = new Protocol(protocolString.toCharArray());
+                ruleBuilder.setProtocol(protocol);
+            } catch (NumberFormatException e) {
+                throw new BadRequestException("Protocol {" + rule.getFirewallRuleProtocol()
+                        + "} is not supported");
+            }
         }
         if (rule.getFirewallRuleIpVer() != null) {
             final ImmutableBiMap<Integer, Class<? extends IpVersionBase>> mapper = IP_VERSION_MAP.inverse();
@@ -192,21 +157,4 @@ public class NeutronFirewallRuleInterface extends AbstractNeutronInterface<Firew
         }
         return ruleBuilder.build();
     }
-
-    @Override
-    protected FirewallRule toMd(String uuid) {
-        final FirewallRuleBuilder ruleBuilder = new FirewallRuleBuilder();
-        ruleBuilder.setUuid(toUuid(uuid));
-        return ruleBuilder.build();
-    }
-
-    public static void registerNewInterface(BundleContext context,
-                                            ProviderContext providerContext,
-                                            List<ServiceRegistration<?>> registrations) {
-        final NeutronFirewallRuleInterface neutronFirewallRuleInterface = new NeutronFirewallRuleInterface(providerContext);
-        final ServiceRegistration<INeutronFirewallRuleCRUD> neutronFirewallRuleInterfaceRegistration = context.registerService(INeutronFirewallRuleCRUD.class, neutronFirewallRuleInterface, null);
-        if(neutronFirewallRuleInterfaceRegistration != null) {
-            registrations.add(neutronFirewallRuleInterfaceRegistration);
-        }
-    }
 }