add dependency check for security rule's group update(), not just add()

[neutron.git] / transcriber / src / main / java / org / opendaylight / neutron / transcriber / NeutronSecurityRuleInterface.java

diff --git a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronSecurityRuleInterface.java b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronSecurityRuleInterface.java
index 653e76ffeea8db0adeeb86bb5058aa2455a443e2..aa40541559b2d0b7a6b37d5486a974eecc6e5164 100644 (file)
--- a/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronSecurityRuleInterface.java
+++ b/transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronSecurityRuleInterface.java
@@ -136,8 +136,9 @@ public final class NeutronSecurityRuleInterface extends
 
     @Override
     protected boolean areAllDependenciesAvailable(ReadTransaction tx, NeutronSecurityRule securityRule) {
-        return securityGroupInterface.exists(securityRule.getSecurityRuleGroupID(), tx)
-                && ifNonNull(securityRule.getSecurityRemoteGroupID(),
-                    remoteGroupID -> securityGroupInterface.exists(remoteGroupID, tx));
+        return ifNonNull(securityRule.getSecurityRuleGroupID(),
+            groupID -> securityGroupInterface.exists(groupID, tx))
+            && ifNonNull(securityRule.getSecurityRemoteGroupID(),
+                remoteGroupID -> securityGroupInterface.exists(remoteGroupID, tx));
     }
 }