Enable checkstyle for neutronvpn

[netvirt.git] / vpnservice / neutronvpn / neutronvpn-impl / src / main / java / org / opendaylight / netvirt / neutronvpn / NeutronHostConfigChangeListener.java

diff --git a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java
index f218b7e4c97925cc6206bee4e555987ba71a64db..3569a05e4b61ae99c051ce82495333ed79860be6 100644 (file)
--- a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java
+++ b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java
@@ -44,7 +44,7 @@ public class NeutronHostConfigChangeListener extends AsyncDataTreeChangeListener
         DELETE
     }
 
-    public NeutronHostConfigChangeListener(final DataBroker dataBroker){
+    public NeutronHostConfigChangeListener(final DataBroker dataBroker) {
         super(Node.class,NeutronHostConfigChangeListener.class);
         this.dataBroker = dataBroker;
         this.mdsalUtils = new MdsalUtils(dataBroker);
@@ -57,7 +57,7 @@ public class NeutronHostConfigChangeListener extends AsyncDataTreeChangeListener
     }
 
     @Override
-    protected InstanceIdentifier<Node> getWildCardPath(){
+    protected InstanceIdentifier<Node> getWildCardPath() {
         return InstanceIdentifier
                 .create(NetworkTopology.class)
                 .child(Topology.class,new TopologyKey(SouthboundUtils.OVSDB_TOPOLOGY_ID))
@@ -71,30 +71,27 @@ public class NeutronHostConfigChangeListener extends AsyncDataTreeChangeListener
 
 
     @Override
-    protected void remove(InstanceIdentifier<Node>identifier, Node del){
-        LOG.trace("NeutronHostConfigChangeListener.remove {}",del);
+    protected void remove(InstanceIdentifier<Node> identifier, Node del) {
         updateHostConfig(del, Action.DELETE);
     }
 
     @Override
-    protected void update(InstanceIdentifier<Node>identifier, Node original, Node update){
-        LOG.trace("NeutronHostConfigChangeListener.update {}",update);
+    protected void update(InstanceIdentifier<Node> identifier, Node original, Node update) {
         updateHostConfig(update, Action.UPDATE);
     }
 
     @Override
-    protected void add(InstanceIdentifier<Node>identifier, Node add){
-        LOG.trace("NeutronHostConfigChangeListener.add {}",add);
+    protected void add(InstanceIdentifier<Node> identifier, Node add) {
         updateHostConfig(add, Action.ADD);
 
     }
 
     private void updateHostConfig(Node node, Action action) {
         String hostId = getExternalId(node, OS_HOST_CONFIG_HOST_ID_KEY);
-        if (hostId == null){
+        if (hostId == null) {
             return;
         }
-        for(Map.Entry<String,String> entry : extractHostConfig(node).entrySet()) {
+        for (Map.Entry<String,String> entry : extractHostConfig(node).entrySet()) {
             updateMdsal(buildHostConfigInfo(hostId, entry.getKey(), entry.getValue()), action);
         }
     }
@@ -114,8 +111,9 @@ public class NeutronHostConfigChangeListener extends AsyncDataTreeChangeListener
                             hostType = hostType.substring(0, HOST_TYPE_STR_LEN);
                         }
                         hostType = "ODL " + hostType.toUpperCase();
-                        if (null != openvswitchExternalIds.getExternalIdValue())
+                        if (null != openvswitchExternalIds.getExternalIdValue()) {
                             config.put(hostType, openvswitchExternalIds.getExternalIdValue());
+                        }
                     }
                 }
             }
@@ -141,6 +139,9 @@ public class NeutronHostConfigChangeListener extends AsyncDataTreeChangeListener
                 result = mdsalUtils.delete(LogicalDatastoreType.OPERATIONAL, hostConfigId);
                 LOG.trace("Delete Node: result: {}", result);
                 break;
+            default:
+                LOG.warn("Invalid action: %s", action);
+                break;
         }
     }
 
@@ -164,8 +165,7 @@ public class NeutronHostConfigChangeListener extends AsyncDataTreeChangeListener
         return null;
     }
 
-    private OvsdbNodeAugmentation getOvsdbNodeAugmentation(Node node)
-    {
+    private OvsdbNodeAugmentation getOvsdbNodeAugmentation(Node node) {
         OvsdbNodeAugmentation ovsdbNode = southboundUtils.extractOvsdbNode(node);
         if (ovsdbNode == null) {
             Node nodeFromReadOvsdbNode = southboundUtils.readOvsdbNode(node);