import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ThreadFactoryBuilder;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.Callable;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ThreadFactory;
import org.opendaylight.controller.md.sal.binding.api.DataBroker;
-import org.opendaylight.controller.md.sal.binding.api.DataChangeListener;
import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
-import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker;
import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
+import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException;
import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
+import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase;
import org.opendaylight.genius.datastoreutils.DataStoreJobCoordinator;
+import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker;
import org.opendaylight.netvirt.bgpmanager.api.IBgpManager;
import org.opendaylight.netvirt.fibmanager.api.IFibManager;
import org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.VpnAfConfig;
import org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.VpnInstances;
+import org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.af.config.VpnTargets;
import org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.af.config.vpntargets.VpnTarget;
import org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.instances.VpnInstance;
import org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdManagerService;
import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.id.to.vpn.instance.VpnIds;
import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.VpnInstanceOpDataEntry;
import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.VpnInstanceOpDataEntryBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn.instance.op.data.entry.VpnTargetsBuilder;
import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn.instance.op.data.entry.VpnToDpnList;
-import org.opendaylight.yangtools.concepts.ListenerRegistration;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn.instance.op.data.entry.vpntargets.VpnTargetBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn.instance.op.data.entry.vpntargets.VpnTargetKey;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.to.extraroute.Vpn;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class VpnInstanceListener extends AbstractDataChangeListener<VpnInstance> implements AutoCloseable {
+public class VpnInstanceListener extends AsyncDataTreeChangeListenerBase<VpnInstance, VpnInstanceListener>
+ implements AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(VpnInstanceListener.class);
- private ListenerRegistration<DataChangeListener> listenerRegistration;
private final DataBroker dataBroker;
private final IBgpManager bgpManager;
private final IdManagerService idManager;
private final VpnInterfaceManager vpnInterfaceManager;
private final IFibManager fibManager;
- private static final ThreadFactory threadFactory = new ThreadFactoryBuilder()
- .setNameFormat("NV-VpnMgr-%d").build();
- private ExecutorService executorService = Executors.newSingleThreadExecutor(threadFactory);
- private ConcurrentMap<String, Runnable> vpnOpMap = new ConcurrentHashMap<String, Runnable>();
+ private final VpnOpDataSyncer vpnOpDataNotifier;
public VpnInstanceListener(final DataBroker dataBroker, final IBgpManager bgpManager,
- final IdManagerService idManager,
- final VpnInterfaceManager vpnInterfaceManager,
- final IFibManager fibManager) {
- super(VpnInstance.class);
+ final IdManagerService idManager, final VpnInterfaceManager vpnInterfaceManager, final IFibManager fibManager,
+ final VpnOpDataSyncer vpnOpDataSyncer) {
+ super(VpnInstance.class, VpnInstanceListener.class);
this.dataBroker = dataBroker;
this.bgpManager = bgpManager;
this.idManager = idManager;
this.vpnInterfaceManager = vpnInterfaceManager;
this.fibManager = fibManager;
+ this.vpnOpDataNotifier = vpnOpDataSyncer;
}
public void start() {
LOG.info("{} start", getClass().getSimpleName());
- listenerRegistration = dataBroker.registerDataChangeListener(LogicalDatastoreType.CONFIGURATION,
- getWildCardPath(), this, AsyncDataBroker.DataChangeScope.SUBTREE);
+ registerListener(LogicalDatastoreType.CONFIGURATION, dataBroker);
}
- private InstanceIdentifier<VpnInstance> getWildCardPath() {
+ @Override
+ protected InstanceIdentifier<VpnInstance> getWildCardPath() {
return InstanceIdentifier.create(VpnInstances.class).child(VpnInstance.class);
}
@Override
- public void close() throws Exception {
- if (listenerRegistration != null) {
- listenerRegistration.close();
- listenerRegistration = null;
- }
- LOG.info("{} close", getClass().getSimpleName());
- }
-
- void notifyTaskIfRequired(String vpnName) {
- Runnable notifyTask = vpnOpMap.remove(vpnName);
- if (notifyTask == null) {
- LOG.trace("VpnInstanceListener update: No Notify Task queued for vpnName {}", vpnName);
- return;
- }
- executorService.execute(notifyTask);
+ protected VpnInstanceListener getDataTreeChangeListener() {
+ return VpnInstanceListener.this;
}
private void waitForOpRemoval(String rd, String vpnName) {
- //wait till DCN for update on VPN Instance Op Data signals that vpn interfaces linked to this vpn instance is zero
+ //wait till DCN for update on VPN Instance Op Data signals that vpn interfaces linked to this vpn instance is
+ // zero
//TODO(vpnteam): Entire code would need refactoring to listen only on the parent object - VPNInstance
VpnInstanceOpDataEntry vpnOpEntry = null;
Long intfCount = 0L;
Long currentIntfCount = 0L;
- Integer retryCount = 1;
+ Integer retryCount = 3;
long timeout = VpnConstants.MIN_WAIT_TIME_IN_MILLISECONDS;
Optional<VpnInstanceOpDataEntry> vpnOpValue = null;
vpnOpValue = VpnUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(rd));
+ VpnUtil.getVpnInstanceOpDataIdentifier(rd));
if ((vpnOpValue != null) && (vpnOpValue.isPresent())) {
vpnOpEntry = vpnOpValue.get();
timeout = VpnConstants.MAX_WAIT_TIME_IN_MILLISECONDS;
}
LOG.info("VPNInstance removal count of interface at {} for for rd {}, vpnname {}",
- intfCount, rd, vpnName);
+ intfCount, rd, vpnName);
}
LOG.info("VPNInstance removal thread waiting for {} seconds for rd {}, vpnname {}",
- (timeout / 1000), rd, vpnName);
+ (timeout / 1000), rd, vpnName);
try {
Thread.sleep(timeout);
} catch (InterruptedException e) {
+ // Ignored
}
// Check current interface count
vpnOpValue = VpnUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(rd));
+ VpnUtil.getVpnInstanceOpDataIdentifier(rd));
if ((vpnOpValue != null) && (vpnOpValue.isPresent())) {
vpnOpEntry = vpnOpValue.get();
dpnToVpns = vpnOpEntry.getVpnToDpnList();
} else {
if (retryCount > 0) {
retryCount--;
- LOG.info("Retrying clearing vpn with vpnname {} rd {} since current interface count {} ", vpnName, rd, currentIntfCount);
+ LOG.info(
+ "Retrying clearing vpn with vpnname {} rd {} since current interface count {} ",
+ vpnName, rd, currentIntfCount);
if (currentIntfCount > 0) {
intfCount = currentIntfCount;
} else {
- LOG.info("Current interface count is zero, but instance Op for vpn {} and rd {} not cleared yet. Waiting for 5 more seconds.", vpnName, rd);
+ LOG.info(
+ "Current interface count is zero, but instance Op for vpn {} and rd {} not "
+ + "cleared yet. Waiting for 5 more seconds.",
+ vpnName, rd);
intfCount = 1L;
}
} else {
- LOG.info("VPNInstance bailing out of wait loop as current interface count is {} and max retries exceeded for for vpnName {}, rd {}",
- currentIntfCount, vpnName, rd);
+ LOG.info(
+ "VPNInstance bailing out of wait loop as current interface count is {} and max "
+ + "retries exceeded for for vpnName {}, rd {}",
+ currentIntfCount, vpnName, rd);
break;
}
}
+ } else {
+ LOG.info("Retrying clearing because not all vpnInterfaces removed : current interface count {},"
+ + " initial count {} for rd {}, vpnname {}", currentIntfCount, intfCount, rd, vpnName);
+ intfCount = currentIntfCount;
}
} else {
// There is no VPNOPEntry. Something else happened on the system !
// So let us quit and take our chances.
//TODO(vpnteam): L3VPN refactoring to take care of this case.
+ LOG.error("VpnInstanceOpData is not present in the operational DS for rd {}, vpnname {}", rd,
+ vpnName);
break;
}
}
}
LOG.info("Returned out of waiting for Op Data removal for rd {}, vpnname {}", rd, vpnName);
}
+
@Override
protected void remove(InstanceIdentifier<VpnInstance> identifier, VpnInstance del) {
LOG.trace("Remove VPN event key: {}, value: {}", identifier, del);
final String vpnName = del.getVpnInstanceName();
final String rd = del.getIpv4Family().getRouteDistinguisher();
- final long vpnId = VpnUtil.getVpnId(dataBroker, vpnName);
Optional<VpnInstanceOpDataEntry> vpnOpValue = null;
//TODO(vpnteam): Entire code would need refactoring to listen only on the parent object - VPNInstance
try {
if ((rd != null) && (!rd.isEmpty())) {
- vpnOpValue = VpnUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(rd));
+ vpnOpValue = SingleTransactionDataBroker.syncReadOptional(dataBroker, LogicalDatastoreType.OPERATIONAL,
+ VpnUtil.getVpnInstanceOpDataIdentifier(rd));
} else {
- vpnOpValue = VpnUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(vpnName));
+ vpnOpValue = SingleTransactionDataBroker.syncReadOptional(dataBroker, LogicalDatastoreType.OPERATIONAL,
+ VpnUtil.getVpnInstanceOpDataIdentifier(vpnName));
}
- } catch (Exception e) {
+ } catch (ReadFailedException e) {
LOG.error("Exception when attempting to retrieve VpnInstanceOpDataEntry for VPN {}. ", vpnName, e);
return;
}
DataStoreJobCoordinator dataStoreCoordinator = DataStoreJobCoordinator.getInstance();
dataStoreCoordinator.enqueueJob("VPN-" + vpnName,
- new DeleteVpnInstanceWorker(idManager, dataBroker, del));
+ new DeleteVpnInstanceWorker(idManager, dataBroker, del));
}
private class DeleteVpnInstanceWorker implements Callable<List<ListenableFuture<Void>>> {
DataBroker broker;
VpnInstance vpnInstance;
- public DeleteVpnInstanceWorker(IdManagerService idManager,
- DataBroker broker,
- VpnInstance value) {
+ DeleteVpnInstanceWorker(IdManagerService idManager,
+ DataBroker broker,
+ VpnInstance value) {
this.idManager = idManager;
this.broker = broker;
this.vpnInstance = value;
}
+ // TODO Clean up the exception handling
+ @SuppressWarnings("checkstyle:IllegalCatch")
@Override
- public List<ListenableFuture<Void>> call() throws Exception {
+ public List<ListenableFuture<Void>> call() {
final String vpnName = vpnInstance.getVpnInstanceName();
final String rd = vpnInstance.getIpv4Family().getRouteDistinguisher();
final long vpnId = VpnUtil.getVpnId(broker, vpnName);
// Clean up VpnInstanceToVpnId from Config DS
VpnUtil.removeVpnIdToVpnInstance(broker, vpnId, writeTxn);
VpnUtil.removeVpnInstanceToVpnId(broker, vpnName, writeTxn);
-
- List<ListenableFuture<Void>> futures = new ArrayList<>();
- futures.add(writeTxn.submit());
LOG.trace("Removed vpnIdentifier for rd{} vpnname {}", rd, vpnName);
if (rd != null) {
synchronized (vpnName.intern()) {
}
// Clean up VPNExtraRoutes Operational DS
- VpnUtil.removeVpnExtraRouteForVpn(broker, rd, null);
+ InstanceIdentifier<Vpn> vpnToExtraroute = VpnUtil.getVpnToExtrarouteIdentifier(rd);
+ Optional<Vpn> optVpnToExtraroute =
+ VpnUtil.read(broker, LogicalDatastoreType.OPERATIONAL, vpnToExtraroute);
+ if (optVpnToExtraroute.isPresent()) {
+ VpnUtil.removeVpnExtraRouteForVpn(broker, rd, writeTxn);
+ }
// Clean up VPNInstanceOpDataEntry
- VpnUtil.removeVpnOpInstance(broker, rd, null);
+ VpnUtil.removeVpnOpInstance(broker, rd, writeTxn);
} else {
// Clean up FIB Entries Config DS
synchronized (vpnName.intern()) {
fibManager.removeVrfTable(broker, vpnName, null);
}
// Clean up VPNExtraRoutes Operational DS
- VpnUtil.removeVpnExtraRouteForVpn(broker, vpnName, null);
+ InstanceIdentifier<Vpn> vpnToExtraroute = VpnUtil.getVpnToExtrarouteIdentifier(vpnName);
+ Optional<Vpn> optVpnToExtraroute =
+ VpnUtil.read(broker, LogicalDatastoreType.OPERATIONAL, vpnToExtraroute);
+ if (optVpnToExtraroute.isPresent()) {
+ VpnUtil.removeVpnExtraRouteForVpn(broker, vpnName, writeTxn);
+ }
// Clean up VPNInstanceOpDataEntry
- VpnUtil.removeVpnOpInstance(broker, vpnName, null);
+ VpnUtil.removeVpnOpInstance(broker, vpnName, writeTxn);
}
// Clean up PrefixToInterface Operational DS
- VpnUtil.removePrefixToInterfaceForVpnId(broker, vpnId, null);
+ VpnUtil.removePrefixToInterfaceForVpnId(broker, vpnId, writeTxn);
// Clean up L3NextHop Operational DS
- VpnUtil.removeL3nexthopForVpnId(broker, vpnId, null);
+ VpnUtil.removeL3nexthopForVpnId(broker, vpnId, writeTxn);
// Release the ID used for this VPN back to IdManager
VpnUtil.releaseId(idManager, VpnConstants.VPN_IDPOOL_NAME, vpnName);
+ List<ListenableFuture<Void>> futures = new ArrayList<>();
+ futures.add(writeTxn.submit());
return futures;
}
}
@Override
protected void update(InstanceIdentifier<VpnInstance> identifier,
- VpnInstance original, VpnInstance update) {
+ VpnInstance original, VpnInstance update) {
LOG.trace("Update VPN event key: {}, value: {}", identifier, update);
}
@Override
protected void add(final InstanceIdentifier<VpnInstance> identifier, final VpnInstance value) {
LOG.trace("Add VPN event key: {}, value: {}", identifier, value);
- final VpnAfConfig config = value.getIpv4Family();
- final String rd = config.getRouteDistinguisher();
final String vpnName = value.getVpnInstanceName();
DataStoreJobCoordinator dataStoreCoordinator = DataStoreJobCoordinator.getInstance();
dataStoreCoordinator.enqueueJob("VPN-" + vpnName,
- new AddVpnInstanceWorker(idManager, vpnInterfaceManager, dataBroker, value));
+ new AddVpnInstanceWorker(idManager, vpnInterfaceManager, dataBroker, value));
}
private class AddVpnInstanceWorker implements Callable<List<ListenableFuture<Void>>> {
VpnInstance vpnInstance;
DataBroker broker;
- public AddVpnInstanceWorker(IdManagerService idManager,
- VpnInterfaceManager vpnInterfaceManager,
- DataBroker broker,
- VpnInstance value) {
+ AddVpnInstanceWorker(IdManagerService idManager,
+ VpnInterfaceManager vpnInterfaceManager,
+ DataBroker broker,
+ VpnInstance value) {
this.idManager = idManager;
this.vpnInterfaceManager = vpnInterfaceManager;
this.broker = broker;
// If another renderer(for eg : CSS) needs to be supported, check can be performed here
// to call the respective helpers.
final VpnAfConfig config = vpnInstance.getIpv4Family();
- final String rd = config.getRouteDistinguisher();
WriteTransaction writeConfigTxn = broker.newWriteOnlyTransaction();
WriteTransaction writeOperTxn = broker.newWriteOnlyTransaction();
addVpnInstance(vpnInstance, writeConfigTxn, writeOperTxn);
List<ListenableFuture<Void>> futures = new ArrayList<>();
futures.add(writeConfigTxn.submit());
ListenableFuture<List<Void>> listenableFuture = Futures.allAsList(futures);
- if (rd != null) {
- Futures.addCallback(listenableFuture,
- new AddBgpVrfWorker(config , vpnInstance.getVpnInstanceName()));
- }
+ Futures.addCallback(listenableFuture,
+ new PostAddVpnInstanceWorker(config, vpnInstance.getVpnInstanceName()));
return futures;
}
}
+ // TODO Clean up the exception handling
+ @SuppressWarnings("checkstyle:IllegalCatch")
private void addVpnInstance(VpnInstance value, WriteTransaction writeConfigTxn,
- WriteTransaction writeOperTxn) {
+ WriteTransaction writeOperTxn) {
VpnAfConfig config = value.getIpv4Family();
String rd = config.getRouteDistinguisher();
String vpnInstanceName = value.getVpnInstanceName();
long vpnId = VpnUtil.getUniqueId(idManager, VpnConstants.VPN_IDPOOL_NAME, vpnInstanceName);
- LOG.trace("VPN instance to ID generated.");
+ if (vpnId == 0) {
+ LOG.error(
+ "Unable to fetch label from Id Manager. Bailing out of adding operational data for Vpn Instance {}",
+ value.getVpnInstanceName());
+ LOG.error(
+ "Unable to fetch label from Id Manager. Bailing out of adding operational data for Vpn Instance {}",
+ value.getVpnInstanceName());
+ return;
+ }
+ LOG.info("VPN Id {} generated for VpnInstanceName {}", vpnId, vpnInstanceName);
org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstance
- vpnInstanceToVpnId = VpnUtil.getVpnInstanceToVpnId(vpnInstanceName, vpnId, (rd != null) ? rd
- : vpnInstanceName);
+ vpnInstanceToVpnId = VpnUtil.getVpnInstanceToVpnId(vpnInstanceName, vpnId, (rd != null) ? rd
+ : vpnInstanceName);
if (writeConfigTxn != null) {
writeConfigTxn.put(LogicalDatastoreType.CONFIGURATION,
- VpnUtil.getVpnInstanceToVpnIdIdentifier(vpnInstanceName),
- vpnInstanceToVpnId, true);
+ VpnUtil.getVpnInstanceToVpnIdIdentifier(vpnInstanceName),
+ vpnInstanceToVpnId, true);
} else {
- TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.CONFIGURATION,
- VpnUtil.getVpnInstanceToVpnIdIdentifier(vpnInstanceName),
- vpnInstanceToVpnId, TransactionUtil.DEFAULT_CALLBACK);
+ TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.CONFIGURATION,
+ VpnUtil.getVpnInstanceToVpnIdIdentifier(vpnInstanceName),
+ vpnInstanceToVpnId, TransactionUtil.DEFAULT_CALLBACK);
}
VpnIds vpnIdToVpnInstance = VpnUtil.getVpnIdToVpnInstance(vpnId, value.getVpnInstanceName(),
- (rd != null) ? rd : value.getVpnInstanceName(), (rd != null)/*isExternalVpn*/);
+ (rd != null) ? rd : value.getVpnInstanceName(), (rd != null)/*isExternalVpn*/);
if (writeConfigTxn != null) {
writeConfigTxn.put(LogicalDatastoreType.CONFIGURATION,
- VpnUtil.getVpnIdToVpnInstanceIdentifier(vpnId),
- vpnIdToVpnInstance, true);
+ VpnUtil.getVpnIdToVpnInstanceIdentifier(vpnId),
+ vpnIdToVpnInstance, true);
} else {
- TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.CONFIGURATION,
- VpnUtil.getVpnIdToVpnInstanceIdentifier(vpnId),
- vpnIdToVpnInstance, TransactionUtil.DEFAULT_CALLBACK);
+ TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.CONFIGURATION,
+ VpnUtil.getVpnIdToVpnInstanceIdentifier(vpnId),
+ vpnIdToVpnInstance, TransactionUtil.DEFAULT_CALLBACK);
}
try {
String cachedTransType = fibManager.getConfTransType();
- LOG.trace("Value for confTransportType is " + cachedTransType);
if (cachedTransType.equals("Invalid")) {
try {
fibManager.setConfTransType("L3VPN", "VXLAN");
} catch (Exception e) {
- LOG.trace("Exception caught setting the cached value for transportType");
- LOG.error(e.getMessage());
+ LOG.error("Exception caught setting the L3VPN tunnel transportType", e);
}
} else {
- LOG.trace(":cached val is neither unset/invalid. NO-op.");
+ LOG.trace("Configured tunnel transport type for L3VPN as {}", cachedTransType);
}
} catch (Exception e) {
- LOG.error(e.getMessage());
+ LOG.error("Error when trying to retrieve tunnel transport type for L3VPN ", e);
}
if (rd == null) {
VpnInstanceOpDataEntryBuilder builder =
- new VpnInstanceOpDataEntryBuilder().setVrfId(vpnInstanceName).setVpnId(vpnId)
- .setVpnInstanceName(vpnInstanceName)
- .setVpnInterfaceCount(0L);
+ new VpnInstanceOpDataEntryBuilder().setVrfId(vpnInstanceName).setVpnId(vpnId)
+ .setVpnInstanceName(vpnInstanceName);
if (writeOperTxn != null) {
writeOperTxn.merge(LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(vpnInstanceName),
- builder.build(), true);
+ VpnUtil.getVpnInstanceOpDataIdentifier(vpnInstanceName),
+ builder.build(), true);
} else {
- TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(vpnInstanceName),
- builder.build(), TransactionUtil.DEFAULT_CALLBACK);
- }
- synchronized (vpnInstanceName.intern()) {
- fibManager.addVrfTable(dataBroker, vpnInstanceName, null);
+ TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.OPERATIONAL,
+ VpnUtil.getVpnInstanceOpDataIdentifier(vpnInstanceName),
+ builder.build(), TransactionUtil.DEFAULT_CALLBACK);
}
} else {
VpnInstanceOpDataEntryBuilder builder = new VpnInstanceOpDataEntryBuilder()
- .setVrfId(rd).setVpnId(vpnId).setVpnInstanceName(vpnInstanceName).setVpnInterfaceCount(0L);
+ .setVrfId(rd).setVpnId(vpnId).setVpnInstanceName(vpnInstanceName);
+
+ List<org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn
+ .instance.op.data.entry.vpntargets.VpnTarget>
+ opVpnTargetList = new ArrayList<>();
+ VpnTargets vpnTargets = config.getVpnTargets();
+ if (vpnTargets != null) {
+ List<VpnTarget> vpnTargetList = vpnTargets.getVpnTarget();
+ if (vpnTargetList != null) {
+ for (VpnTarget vpnTarget : vpnTargetList) {
+ VpnTargetBuilder vpnTargetBuilder =
+ new VpnTargetBuilder().setKey(new VpnTargetKey(vpnTarget.getKey().getVrfRTValue()))
+ .setVrfRTType(org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn
+ .instance.op.data.vpn.instance.op.data.entry.vpntargets.VpnTarget.VrfRTType
+ .forValue(vpnTarget.getVrfRTType().getIntValue())).setVrfRTValue(
+ vpnTarget.getVrfRTValue());
+ opVpnTargetList.add(vpnTargetBuilder.build());
+ }
+ }
+ }
+ VpnTargetsBuilder vpnTargetsBuilder = new VpnTargetsBuilder().setVpnTarget(opVpnTargetList);
+ builder.setVpnTargets(vpnTargetsBuilder.build());
if (writeOperTxn != null) {
writeOperTxn.merge(LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(rd),
- builder.build(), true);
+ VpnUtil.getVpnInstanceOpDataIdentifier(rd),
+ builder.build(), true);
} else {
- TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.OPERATIONAL,
- VpnUtil.getVpnInstanceOpDataIdentifier(rd),
- builder.build(), TransactionUtil.DEFAULT_CALLBACK);
- }
- synchronized (vpnInstanceName.intern()) {
- fibManager.addVrfTable(dataBroker, rd, null);
+ TransactionUtil.syncWrite(dataBroker, LogicalDatastoreType.OPERATIONAL,
+ VpnUtil.getVpnInstanceOpDataIdentifier(rd),
+ builder.build(), TransactionUtil.DEFAULT_CALLBACK);
}
}
+ LOG.info("VpnInstanceOpData populated successfully for vpn {} rd {}", vpnInstanceName, rd);
}
- private class AddBgpVrfWorker implements FutureCallback<List<Void>> {
+ private class PostAddVpnInstanceWorker implements FutureCallback<List<Void>> {
VpnAfConfig config;
String vpnName;
- public AddBgpVrfWorker(VpnAfConfig config, String vpnName) {
+ PostAddVpnInstanceWorker(VpnAfConfig config, String vpnName) {
this.config = config;
this.vpnName = vpnName;
}
/**
- * @param voids
* This implies that all the future instances have returned success. -- TODO: Confirm this
*/
@Override
public void onSuccess(List<Void> voids) {
+ /*
+ if rd is null, then its either a router vpn instance (or) a vlan external network vpn instance.
+ if rd is non-null, then it is a bgpvpn instance
+ */
String rd = config.getRouteDistinguisher();
- if (rd != null) {
- List<VpnTarget> vpnTargetList = config.getVpnTargets().getVpnTarget();
+ if ((rd == null) || addBgpVrf(voids)) {
+ notifyTask();
+ vpnInterfaceManager.vpnInstanceIsReady(vpnName);
+ }
+ }
+
+ // TODO Clean up the exception handling
+ @SuppressWarnings("checkstyle:IllegalCatch")
+ private boolean addBgpVrf(List<Void> voids) {
+ String rd = config.getRouteDistinguisher();
+ List<VpnTarget> vpnTargetList = config.getVpnTargets().getVpnTarget();
- List<String> ertList = new ArrayList<String>();
- List<String> irtList = new ArrayList<String>();
+ List<String> ertList = new ArrayList<String>();
+ List<String> irtList = new ArrayList<String>();
+ if (vpnTargetList != null) {
for (VpnTarget vpnTarget : vpnTargetList) {
if (vpnTarget.getVrfRTType() == VpnTarget.VrfRTType.ExportExtcommunity) {
ertList.add(vpnTarget.getVrfRTValue());
irtList.add(vpnTarget.getVrfRTValue());
}
}
-
- try {
- bgpManager.addVrf(rd, irtList, ertList);
- } catch (Exception e) {
- LOG.error("Exception when adding VRF to BGP", e);
- return;
- }
- vpnInterfaceManager.handleVpnsExportingRoutes(this.vpnName, rd);
+ } else {
+ LOG.error("vpn target list is empty, cannot add BGP VPN {} VRF {}", this.vpnName, rd);
+ return false;
}
+ try {
+ bgpManager.addVrf(rd, irtList, ertList);
+ } catch (Exception e) {
+ LOG.error("Exception when adding VRF to BGP", e);
+ return false;
+ }
+ vpnInterfaceManager.handleVpnsExportingRoutes(this.vpnName, rd);
+ return true;
}
+
+ private void notifyTask() {
+ vpnOpDataNotifier.notifyVpnOpDataReady(VpnOpDataSyncer.VpnOpDataType.vpnInstanceToId, vpnName);
+ vpnOpDataNotifier.notifyVpnOpDataReady(VpnOpDataSyncer.VpnOpDataType.vpnOpData, vpnName);
+ }
+
/**
- *
- * @param throwable
* This method is used to handle failure callbacks.
* If more retry needed, the retrycount is decremented and mainworker is executed again.
* After retries completed, rollbackworker is executed.
@Override
public void onFailure(Throwable throwable) {
- LOG.warn("Job: failed with exception: {}", throwable.getStackTrace());
+ LOG.error("Job for vpnInstance: {} failed with exception: {}", vpnName ,throwable);
+ vpnInterfaceManager.vpnInstanceFailed(vpnName);
}
}
public boolean isVPNConfigured() {
- InstanceIdentifier<VpnInstances> vpnsIdentifier =
- InstanceIdentifier.builder(VpnInstances.class).build();
+ InstanceIdentifier<VpnInstances> vpnsIdentifier = InstanceIdentifier.builder(VpnInstances.class).build();
Optional<VpnInstances> optionalVpns = TransactionUtil.read(dataBroker, LogicalDatastoreType.CONFIGURATION,
- vpnsIdentifier);
- if (!optionalVpns.isPresent() ||
- optionalVpns.get().getVpnInstance() == null ||
- optionalVpns.get().getVpnInstance().isEmpty()) {
+ vpnsIdentifier);
+ if (!optionalVpns.isPresent()
+ || optionalVpns.get().getVpnInstance() == null
+ || optionalVpns.get().getVpnInstance().isEmpty()) {
LOG.trace("No VPNs configured.");
return false;
}
protected VpnInstanceOpDataEntry getVpnInstanceOpData(String rd) {
InstanceIdentifier<VpnInstanceOpDataEntry> id = VpnUtil.getVpnInstanceOpDataIdentifier(rd);
Optional<VpnInstanceOpDataEntry> vpnInstanceOpData =
- TransactionUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, id);
- if(vpnInstanceOpData.isPresent()) {
+ TransactionUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, id);
+ if (vpnInstanceOpData.isPresent()) {
return vpnInstanceOpData.get();
}
return null;
Code Review / netvirt.git / blobdiff