Fix eclipse/checkstyle warnings
[yangtools.git] / yang / yang-common / src / test / java / org / opendaylight / yangtools / yang / common / RpcResultBuilderTest.java
index 45991b2e285a871aefc0e06c46eb314f6543dadb..74166dfede8792046f199e77a5a8b8711409c5e2 100644 (file)
@@ -11,6 +11,7 @@ package org.opendaylight.yangtools.yang.common;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
+
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.ObjectInputStream;
@@ -30,85 +31,85 @@ public class RpcResultBuilderTest {
 
     @Test
     public void testSuccess() {
-        RpcResult<String> result = RpcResultBuilder.<String>success().withResult( "foo" ).build();
-        verifyRpcResult( result, true, "foo" );
-        assertNotNull( "getErrors returned null", result.getErrors() );
-        assertEquals( "getErrors size", 0, result.getErrors().size() );
+        RpcResult<String> result = RpcResultBuilder.<String>success().withResult("foo").build();
+        verifyRpcResult(result, true, "foo");
+        assertNotNull("getErrors returned null", result.getErrors());
+        assertEquals("getErrors size", 0, result.getErrors().size());
 
-        result = RpcResultBuilder.success( "bar" ).build();
-        verifyRpcResult( result, true, "bar" );
+        result = RpcResultBuilder.success("bar").build();
+        verifyRpcResult(result, true, "bar");
     }
 
     @Test
     public void testFailed() {
-        Throwable cause = new Throwable( "mock cause" );
-        Throwable cause2 = new Throwable( "mock cause2" );
+        Throwable cause = new Throwable("mock cause");
+        Throwable cause2 = new Throwable("mock cause2");
         RpcResult<String> result = RpcResultBuilder.<String>failed()
-                  .withError( ErrorType.PROTOCOL, "error message 1" )
-                  .withError( ErrorType.APPLICATION, "lock_denied", "error message 2" )
-                  .withError( ErrorType.RPC, "in-use", "error message 3", "my-app-tag", "my-info", cause )
-                  .withError( ErrorType.TRANSPORT, "error message 4", cause2 )
+                  .withError(ErrorType.PROTOCOL, "error message 1")
+                  .withError(ErrorType.APPLICATION, "lock_denied", "error message 2")
+                  .withError(ErrorType.RPC, "in-use", "error message 3", "my-app-tag", "my-info", cause)
+                  .withError(ErrorType.TRANSPORT, "error message 4", cause2)
                   .build();
-        verifyRpcResult( result, false, null );
-        verifyRpcError( result, 0, ErrorSeverity.ERROR, ErrorType.PROTOCOL, "operation-failed",
-                        "error message 1", null, null, null );
-        verifyRpcError( result, 1, ErrorSeverity.ERROR, ErrorType.APPLICATION, "lock_denied",
-                        "error message 2", null, null, null );
-        verifyRpcError( result, 2, ErrorSeverity.ERROR, ErrorType.RPC, "in-use",
-                        "error message 3", "my-app-tag", "my-info", cause );
-        verifyRpcError( result, 3, ErrorSeverity.ERROR, ErrorType.TRANSPORT, "operation-failed",
-                        "error message 4", null, null, cause2 );
-        assertEquals( "getErrors size", 4, result.getErrors().size() );
+        verifyRpcResult(result, false, null);
+        verifyRpcError(result, 0, ErrorSeverity.ERROR, ErrorType.PROTOCOL, "operation-failed",
+                        "error message 1", null, null, null);
+        verifyRpcError(result, 1, ErrorSeverity.ERROR, ErrorType.APPLICATION, "lock_denied",
+                        "error message 2", null, null, null);
+        verifyRpcError(result, 2, ErrorSeverity.ERROR, ErrorType.RPC, "in-use",
+                        "error message 3", "my-app-tag", "my-info", cause);
+        verifyRpcError(result, 3, ErrorSeverity.ERROR, ErrorType.TRANSPORT, "operation-failed",
+                        "error message 4", null, null, cause2);
+        assertEquals("getErrors size", 4, result.getErrors().size());
     }
 
     @Test
     public void testWithWarnings() {
-        Throwable cause = new Throwable( "mock cause" );
+        Throwable cause = new Throwable("mock cause");
         RpcResult<String> result = RpcResultBuilder.<String>success()
-                  .withWarning( ErrorType.APPLICATION, "lock_denied", "message 1" )
-                  .withWarning( ErrorType.RPC, "in-use", "message 2", "my-app-tag", "my-info", cause )
+                  .withWarning(ErrorType.APPLICATION, "lock_denied", "message 1")
+                  .withWarning(ErrorType.RPC, "in-use", "message 2", "my-app-tag", "my-info", cause)
                   .build();
-        verifyRpcResult( result, true, null );
-        verifyRpcError( result, 0, ErrorSeverity.WARNING, ErrorType.APPLICATION, "lock_denied",
-                        "message 1", null, null, null );
-        verifyRpcError( result, 1, ErrorSeverity.WARNING, ErrorType.RPC, "in-use",
-                        "message 2", "my-app-tag", "my-info", cause );
-        assertEquals( "getErrors size", 2, result.getErrors().size() );
+        verifyRpcResult(result, true, null);
+        verifyRpcError(result, 0, ErrorSeverity.WARNING, ErrorType.APPLICATION, "lock_denied",
+                        "message 1", null, null, null);
+        verifyRpcError(result, 1, ErrorSeverity.WARNING, ErrorType.RPC, "in-use",
+                        "message 2", "my-app-tag", "my-info", cause);
+        assertEquals("getErrors size", 2, result.getErrors().size());
     }
 
     @Test
     public void testFrom() {
-        Throwable cause = new Throwable( "mock cause" );
+        Throwable cause = new Throwable("mock cause");
         RpcResult<String> result = RpcResultBuilder.<String>success()
-                .withResult( "foo" )
-                .withWarning( ErrorType.RPC, "in-use", "message", "my-app-tag", "my-info", cause )
+                .withResult("foo")
+                .withWarning(ErrorType.RPC, "in-use", "message", "my-app-tag", "my-info", cause)
                 .build();
 
-        RpcResult<String> copy = RpcResultBuilder.from( result )
-                .withError( ErrorType.PROTOCOL, "error message" )
+        RpcResult<String> copy = RpcResultBuilder.from(result)
+                .withError(ErrorType.PROTOCOL, "error message")
                 .build();
-        verifyRpcResult( copy, true, "foo" );
-        verifyRpcError( copy, 0, ErrorSeverity.WARNING, ErrorType.RPC, "in-use",
-                        "message", "my-app-tag", "my-info", cause );
-        verifyRpcError( copy, 1, ErrorSeverity.ERROR, ErrorType.PROTOCOL, "operation-failed",
-                        "error message", null, null, null );
+        verifyRpcResult(copy, true, "foo");
+        verifyRpcError(copy, 0, ErrorSeverity.WARNING, ErrorType.RPC, "in-use",
+                        "message", "my-app-tag", "my-info", cause);
+        verifyRpcError(copy, 1, ErrorSeverity.ERROR, ErrorType.PROTOCOL, "operation-failed",
+                        "error message", null, null, null);
     }
 
     @Test
     public void testWithRpcErrors() {
-        Throwable cause = new Throwable( "mock cause" );
+        Throwable cause = new Throwable("mock cause");
         RpcResult<String> result = RpcResultBuilder.<String>failed()
-                .withWarning( ErrorType.RPC, "in-use", "message", "my-app-tag", "my-info", cause )
-                .withError( ErrorType.PROTOCOL, "error message" )
+                .withWarning(ErrorType.RPC, "in-use", "message", "my-app-tag", "my-info", cause)
+                .withError(ErrorType.PROTOCOL, "error message")
                 .build();
 
         RpcResult<String> result2 = RpcResultBuilder.<String>failed()
-                .withRpcErrors( result.getErrors() )
+                .withRpcErrors(result.getErrors())
                 .build();
-        verifyRpcError( result2, 0, ErrorSeverity.WARNING, ErrorType.RPC, "in-use",
-                        "message", "my-app-tag", "my-info", cause );
-        verifyRpcError( result2, 1, ErrorSeverity.ERROR, ErrorType.PROTOCOL, "operation-failed",
-                        "error message", null, null, null );
+        verifyRpcError(result2, 0, ErrorSeverity.WARNING, ErrorType.RPC, "in-use",
+                        "message", "my-app-tag", "my-info", cause);
+        verifyRpcError(result2, 1, ErrorSeverity.ERROR, ErrorType.PROTOCOL, "operation-failed",
+                        "error message", null, null, null);
     }
 
     @Test
@@ -123,23 +124,23 @@ public class RpcResultBuilderTest {
                 "info", null);
         rpcResultBuilder.withRpcError(rpcErrorShort);
         final RpcResult<Object> rpcResult = rpcResultBuilder.build();
-        final RpcResultBuilder<RpcResult<Object>> rpcResultRpcResultBuilder1 = RpcResultBuilder.success
-                (rpcResultBuilder);
-        final RpcResultBuilder<RpcResult<Object>> rpcResultRpcResultBuilder2 = rpcResultRpcResultBuilder1.withResult
-                (rpcResultBuilder);
+        final RpcResultBuilder<RpcResult<Object>> rpcResultRpcResultBuilder1 = RpcResultBuilder.success(
+                rpcResultBuilder);
+        final RpcResultBuilder<RpcResult<Object>> rpcResultRpcResultBuilder2 = rpcResultRpcResultBuilder1.withResult(
+                rpcResultBuilder);
 
         assertEquals(rpcErrorShort.getErrorType(), rpcErrorShortWarn.getErrorType());
         assertEquals(rpcErrorLong.getErrorType(), rpcErrorLongWarn.getErrorType());
         assertEquals(rpcResultRpcResultBuilder1, rpcResultRpcResultBuilder2);
         assertNotNull(rpcResultBuilder.buildFuture());
-        assertEquals("RpcResult [successful=true, result=null, errors=[RpcError [message=msg, severity=ERROR, " +
-                "errorType=RPC, tag=tag, applicationTag=null, info=null, cause=null]]]", rpcResult.toString());
+        assertEquals("RpcResult [successful=true, result=null, errors=[RpcError [message=msg, severity=ERROR, "
+                "errorType=RPC, tag=tag, applicationTag=null, info=null, cause=null]]]", rpcResult.toString());
     }
 
     @SuppressWarnings("unchecked")
     @Test
     public void testSerialization() throws Exception {
-        RpcResult<String> result = RpcResultBuilder.<String>success().withResult( "foo" ).build();
+        RpcResult<String> result = RpcResultBuilder.<String>success().withResult("foo").build();
 
         ByteArrayOutputStream bos = new ByteArrayOutputStream();
         ObjectOutputStream out = new ObjectOutputStream(bos);
@@ -150,9 +151,9 @@ public class RpcResultBuilderTest {
 
         verifyRpcResult(clone, true, "foo");
 
-        Throwable cause = new Throwable( "mock cause" );
+        Throwable cause = new Throwable("mock cause");
         result = RpcResultBuilder.<String>failed()
-                .withError( ErrorType.RPC, "in-use", "error message", "my-app-tag", "my-info", cause )
+                .withError(ErrorType.RPC, "in-use", "error message", "my-app-tag", "my-info", cause)
                 .build();
 
         bos = new ByteArrayOutputStream();
@@ -163,29 +164,29 @@ public class RpcResultBuilderTest {
         clone = (RpcResult<String>) in.readObject();
 
         verifyRpcResult(clone, false, null);
-        verifyRpcError( result, 0, ErrorSeverity.ERROR, ErrorType.RPC, "in-use",
-                "error message", "my-app-tag", "my-info", cause );
+        verifyRpcError(result, 0, ErrorSeverity.ERROR, ErrorType.RPC, "in-use",
+                "error message", "my-app-tag", "my-info", cause);
     }
 
-    void verifyRpcError( final RpcResult<?> result, final int errorIndex, final ErrorSeverity expSeverity,
+    void verifyRpcError(final RpcResult<?> result, final int errorIndex, final ErrorSeverity expSeverity,
             final ErrorType expErrorType, final String expTag, final String expMessage, final String expAppTag,
-            final String expInfo, final Throwable expCause ) {
-
-        List<RpcError> errors = new ArrayList<>( result.getErrors() );
-        assertTrue( "Expected error at index " + errorIndex + " not found",
-                    errorIndex < errors.size() );
-        RpcError error = errors.get( errorIndex );
-        assertEquals( "getSeverity", expSeverity, error.getSeverity() );
-        assertEquals( "getErrorType", expErrorType, error.getErrorType() );
-        assertEquals( "getTag", expTag, error.getTag() );
-        assertEquals( "getMessage", expMessage, error.getMessage() );
-        assertEquals( "getApplicationTag", expAppTag, error.getApplicationTag() );
-        assertEquals( "getInfo", expInfo, error.getInfo() );
-        assertEquals( "getCause", expCause, error.getCause() );
+            final String expInfo, final Throwable expCause) {
+
+        List<RpcError> errors = new ArrayList<>(result.getErrors());
+        assertTrue("Expected error at index " + errorIndex + " not found",
+                    errorIndex < errors.size());
+        RpcError error = errors.get(errorIndex);
+        assertEquals("getSeverity", expSeverity, error.getSeverity());
+        assertEquals("getErrorType", expErrorType, error.getErrorType());
+        assertEquals("getTag", expTag, error.getTag());
+        assertEquals("getMessage", expMessage, error.getMessage());
+        assertEquals("getApplicationTag", expAppTag, error.getApplicationTag());
+        assertEquals("getInfo", expInfo, error.getInfo());
+        assertEquals("getCause", expCause, error.getCause());
     }
 
-    void verifyRpcResult( final RpcResult<?> result, final boolean expSuccess, final Object expValue ) {
-        assertEquals( "isSuccessful", expSuccess, result.isSuccessful() );
-        assertEquals( "getResult", expValue, result.getResult() );
+    void verifyRpcResult(final RpcResult<?> result, final boolean expSuccess, final Object expValue) {
+        assertEquals("isSuccessful", expSuccess, result.isSuccessful());
+        assertEquals("getResult", expValue, result.getResult());
     }
-}
\ No newline at end of file
+}