import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
-import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterables;
-import com.google.common.collect.Lists;
-import java.io.IOException;
-import java.io.ObjectInputStream;
-import java.io.ObjectOutputStream;
import java.io.Serializable;
import java.lang.reflect.Array;
-import java.lang.reflect.Field;
-import java.util.ArrayList;
import java.util.Arrays;
-import java.util.Collections;
+import java.util.Collection;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
import org.opendaylight.yangtools.concepts.Builder;
import org.opendaylight.yangtools.concepts.Immutable;
import org.opendaylight.yangtools.concepts.Path;
*
* @see <a href="http://tools.ietf.org/html/rfc6020#section-9.13">RFC6020</a>
*/
-public final class YangInstanceIdentifier implements Path<YangInstanceIdentifier>, Immutable, Serializable {
- @SuppressWarnings("rawtypes")
- private static final AtomicReferenceFieldUpdater<YangInstanceIdentifier, ImmutableList> LEGACYPATH_UPDATER =
- AtomicReferenceFieldUpdater.newUpdater(YangInstanceIdentifier.class, ImmutableList.class, "legacyPath");
+public abstract class YangInstanceIdentifier extends IterablePathArguments implements Path<YangInstanceIdentifier>, Immutable, Serializable {
+ /**
+ * An empty {@link YangInstanceIdentifier}. It corresponds to the path of the conceptual
+ * root of the YANG namespace.
+ */
+ public static final YangInstanceIdentifier EMPTY = FixedYangInstanceIdentifier.EMPTY_INSTANCE;
+
private static final AtomicReferenceFieldUpdater<YangInstanceIdentifier, String> TOSTRINGCACHE_UPDATER =
AtomicReferenceFieldUpdater.newUpdater(YangInstanceIdentifier.class, String.class, "toStringCache");
- private static final YangInstanceIdentifier EMPTY = trustedCreate(Collections.<PathArgument>emptyList());
- private static final Field PATHARGUMENTS_FIELD;
+ private static final long serialVersionUID = 4L;
- private static final long serialVersionUID = 3L;
- private transient final Iterable<PathArgument> pathArguments;
private final int hash;
-
- private volatile ImmutableList<PathArgument> legacyPath = null;
private transient volatile String toStringCache = null;
- static {
- final Field f;
- try {
- f = YangInstanceIdentifier.class.getDeclaredField("pathArguments");
- } catch (NoSuchFieldException | SecurityException e) {
- throw new ExceptionInInitializerError(e);
- }
- f.setAccessible(true);
-
- PATHARGUMENTS_FIELD = f;
+ // Package-private to prevent outside subclassing
+ YangInstanceIdentifier(final int hash) {
+ this.hash = hash;
}
- private final ImmutableList<PathArgument> getLegacyPath() {
- // Temporary variable saves a volatile read
- ImmutableList<PathArgument> ret = legacyPath;
- if (ret == null) {
- // We could have used a synchronized block, but the window is quite
- // small and worst that can happen is duplicate object construction.
- ret = ImmutableList.copyOf(pathArguments);
- LEGACYPATH_UPDATER.lazySet(this, ret);
- }
+ @Nonnull abstract YangInstanceIdentifier createRelativeIdentifier(int skipFromRoot);
+ @Nonnull abstract Collection<PathArgument> tryPathArguments();
+ @Nonnull abstract Collection<PathArgument> tryReversePathArguments();
- return ret;
- }
+ /**
+ * Check if this instance identifier has empty path arguments, e.g. it is
+ * empty and corresponds to {@link #EMPTY}.
+ *
+ * @return True if this instance identifier is empty, false otherwise.
+ */
+ public abstract boolean isEmpty();
+
+ /**
+ * Return the conceptual parent {@link YangInstanceIdentifier}, which has
+ * one item less in {@link #getPathArguments()}.
+ *
+ * @return Parent {@link YangInstanceIdentifier}, or null if this is object is {@link #EMPTY}.
+ */
+ @Nullable public abstract YangInstanceIdentifier getParent();
/**
* Returns a list of path arguments.
* @return Immutable list of path arguments.
*/
@Deprecated
- public List<PathArgument> getPath() {
- return getLegacyPath();
- }
+ public abstract List<PathArgument> getPath();
/**
* Returns an ordered iteration of path arguments.
*
* @return Immutable iteration of path arguments.
*/
- public Iterable<PathArgument> getPathArguments() {
- return pathArguments;
- }
+ @Override
+ public abstract Collection<PathArgument> getPathArguments();
/**
* Returns an iterable of path arguments in reverse order. This is useful
*
* @return Immutable iterable of path arguments in reverse order.
*/
- public Iterable<PathArgument> getReversePathArguments() {
- return getLegacyPath().reverse();
- }
+ @Override
+ public abstract Collection<PathArgument> getReversePathArguments();
/**
* Returns the last PathArgument. This is equivalent of iterating
*
* @return The last past argument, or null if there are no PathArguments.
*/
- public PathArgument getLastPathArgument() {
- return Iterables.getFirst(getReversePathArguments(), null);
- }
+ public abstract PathArgument getLastPathArgument();
- private YangInstanceIdentifier(final Iterable<PathArgument> path, final int hash) {
- this.pathArguments = Preconditions.checkNotNull(path, "path must not be null.");
- this.hash = hash;
- }
+ public static YangInstanceIdentifier create(final Iterable<? extends PathArgument> path) {
+ if (Iterables.isEmpty(path)) {
+ return EMPTY;
+ }
- private static final YangInstanceIdentifier trustedCreate(final Iterable<PathArgument> path) {
final HashCodeBuilder<PathArgument> hash = new HashCodeBuilder<>();
for (PathArgument a : path) {
hash.addArgument(a);
}
- return new YangInstanceIdentifier(path, hash.build());
+ return FixedYangInstanceIdentifier.create(path, hash.build());
}
- public static final YangInstanceIdentifier create(final Iterable<? extends PathArgument> path) {
- if (Iterables.isEmpty(path)) {
- return EMPTY;
- }
-
- return trustedCreate(ImmutableList.copyOf(path));
- }
-
- public static final YangInstanceIdentifier create(final PathArgument... path) {
+ public static YangInstanceIdentifier create(final PathArgument... path) {
// We are forcing a copy, since we cannot trust the user
return create(Arrays.asList(path));
}
@Override
- public int hashCode() {
+ public final int hashCode() {
/*
* The caching is safe, since the object contract requires
* immutability of the object and all objects referenced from this
return hash;
}
+ boolean pathArgumentsEqual(final YangInstanceIdentifier other) {
+ return Iterables.elementsEqual(getPathArguments(), other.getPathArguments());
+ }
+
@Override
public boolean equals(final Object obj) {
if (this == obj) {
return true;
}
- if (obj == null) {
- return false;
- }
- if (getClass() != obj.getClass()) {
+ if (!(obj instanceof YangInstanceIdentifier)) {
return false;
}
YangInstanceIdentifier other = (YangInstanceIdentifier) obj;
if (this.hashCode() != obj.hashCode()) {
return false;
}
- return Iterables.elementsEqual(pathArguments, other.pathArguments);
+
+ return pathArgumentsEqual(other);
}
/**
* @param name QName of {@link NodeIdentifier}
* @return Instance Identifier with additional path argument added to the end.
*/
- public YangInstanceIdentifier node(final QName name) {
+ public final YangInstanceIdentifier node(final QName name) {
return node(new NodeIdentifier(name));
}
* @param arg Path argument which should be added to the end
* @return Instance Identifier with additional path argument added to the end.
*/
- public YangInstanceIdentifier node(final PathArgument arg) {
- return new YangInstanceIdentifier(Iterables.concat(pathArguments, Collections.singleton(arg)), HashCodeBuilder.nextHashCode(hash, arg));
+ public final YangInstanceIdentifier node(final PathArgument arg) {
+ return new StackedYangInstanceIdentifier(this, arg, HashCodeBuilder.nextHashCode(hash, arg));
}
/**
* the specified parent is not in fact an ancestor of this object.
*/
public Optional<YangInstanceIdentifier> relativeTo(final YangInstanceIdentifier ancestor) {
- final Iterator<?> lit = pathArguments.iterator();
- final Iterator<?> oit = ancestor.pathArguments.iterator();
+ final Iterator<?> lit = getPathArguments().iterator();
+ final Iterator<?> oit = ancestor.getPathArguments().iterator();
int common = 0;
while (oit.hasNext()) {
if (!lit.hasNext()) {
return Optional.of(EMPTY);
}
- return Optional.of(trustedCreate(Iterables.skip(pathArguments, common)));
+
+ return Optional.of(createRelativeIdentifier(common));
}
private static int hashCode(final Object value) {
*
* @return new builder for InstanceIdentifier with empty path arguments.
*/
- static public InstanceIdentifierBuilder builder() {
- return new BuilderImpl();
+ public static InstanceIdentifierBuilder builder() {
+ return new YangInstanceIdentifierBuilder();
}
/**
* @param origin Instace Identifier from which path arguments are copied.
* @return new builder for InstanceIdentifier with path arguments copied from original instance identifier.
*/
- static public InstanceIdentifierBuilder builder(final YangInstanceIdentifier origin) {
- return new BuilderImpl(origin.getPathArguments(), origin.hashCode());
+ public static InstanceIdentifierBuilder builder(final YangInstanceIdentifier origin) {
+ return new YangInstanceIdentifierBuilder(origin.getPathArguments(), origin.hashCode());
}
/**
}
private static abstract class AbstractPathArgument implements PathArgument {
- private static final AtomicReferenceFieldUpdater<AbstractPathArgument, Integer> HASH_UPDATER =
- AtomicReferenceFieldUpdater.newUpdater(AbstractPathArgument.class, Integer.class, "hash");
private static final long serialVersionUID = -4546547994250849340L;
private final QName nodeType;
- private volatile transient Integer hash = null;
+ private transient int hashValue;
+ private volatile transient boolean hashGuard = false;
protected AbstractPathArgument(final QName nodeType) {
this.nodeType = Preconditions.checkNotNull(nodeType);
@Override
public final int hashCode() {
- Integer ret = hash;
- if (ret == null) {
- ret = hashCodeImpl();
- HASH_UPDATER.lazySet(this, ret);
+ if (!hashGuard) {
+ hashValue = hashCodeImpl();
+ hashGuard = true;
}
- return ret;
+ return hashValue;
}
@Override
}
/**
- *
* Fluent Builder of Instance Identifier instances
- *
- * @
- *
*/
public interface InstanceIdentifierBuilder extends Builder<YangInstanceIdentifier> {
/**
*
* @return {@link YangInstanceIdentifier}
*/
+ @Override
YangInstanceIdentifier build();
/*
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer("AugmentationIdentifier{");
+ final StringBuilder sb = new StringBuilder("AugmentationIdentifier{");
sb.append("childNames=").append(childNames).append('}');
return sb.toString();
}
}
}
- private static class BuilderImpl implements InstanceIdentifierBuilder {
- private final HashCodeBuilder<PathArgument> hash;
- private final List<PathArgument> path;
-
- public BuilderImpl() {
- this.hash = new HashCodeBuilder<>();
- this.path = new ArrayList<>();
- }
-
- public BuilderImpl(final Iterable<PathArgument> prefix, final int hash) {
- this.path = Lists.newArrayList(prefix);
- this.hash = new HashCodeBuilder<>(hash);
- }
-
- @Override
- public InstanceIdentifierBuilder node(final QName nodeType) {
- final PathArgument arg = new NodeIdentifier(nodeType);
- path.add(arg);
- hash.addArgument(arg);
- return this;
- }
-
- @Override
- public InstanceIdentifierBuilder nodeWithKey(final QName nodeType, final QName key, final Object value) {
- final PathArgument arg = new NodeIdentifierWithPredicates(nodeType, key, value);
- path.add(arg);
- hash.addArgument(arg);
- return this;
- }
-
- @Override
- public InstanceIdentifierBuilder nodeWithKey(final QName nodeType, final Map<QName, Object> keyValues) {
- final PathArgument arg = new NodeIdentifierWithPredicates(nodeType, keyValues);
- path.add(arg);
- hash.addArgument(arg);
- return this;
- }
-
- @Deprecated
- public YangInstanceIdentifier toInstance() {
- return build();
- }
-
- @Override
- public YangInstanceIdentifier build() {
- return new YangInstanceIdentifier(ImmutableList.copyOf(path), hash.build());
- }
- }
-
@Override
- public boolean contains(final YangInstanceIdentifier other) {
+ public final boolean contains(final YangInstanceIdentifier other) {
Preconditions.checkArgument(other != null, "other should not be null");
- final Iterator<?> lit = pathArguments.iterator();
- final Iterator<?> oit = other.pathArguments.iterator();
+ final Iterator<?> lit = getPathArguments().iterator();
+ final Iterator<?> oit = other.getPathArguments().iterator();
while (lit.hasNext()) {
if (!oit.hasNext()) {
}
@Override
- public String toString() {
+ public final String toString() {
/*
* The toStringCache is safe, since the object contract requires
* immutability of the object and all objects referenced from this
}
return ret;
}
-
- private void readObject(final ObjectInputStream inputStream) throws IOException, ClassNotFoundException {
- inputStream.defaultReadObject();
-
- try {
- PATHARGUMENTS_FIELD.set(this, legacyPath);
- } catch (IllegalArgumentException | IllegalAccessException e) {
- throw new IOException(e);
- }
- }
-
- private void writeObject(final ObjectOutputStream outputStream) throws IOException {
- /*
- * This may look strange, but what we are doing here is side-stepping the fact
- * that pathArguments is not generally serializable. We are forcing instantiation
- * of the legacy path, which is an ImmutableList (thus Serializable) and write
- * it out. The read path does the opposite -- it reads the legacyPath and then
- * uses invocation API to set the field.
- */
- getLegacyPath();
- outputStream.defaultWriteObject();
- }
}
Code Review / yangtools.git / blobdiff