Push out NormalizedNode fixmes

[yangtools.git] / yang / yang-data-api / src / main / java / org / opendaylight / yangtools / yang / data / api / YangInstanceIdentifierBuilder.java

diff --git a/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/YangInstanceIdentifierBuilder.java b/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/YangInstanceIdentifierBuilder.java
index d0ea997f23942a56c8ea6f2b91ee6bc00df0147e..57a0a61e0f9b40e2d303f832b072189f6dd95c39 100644 (file)
--- a/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/YangInstanceIdentifierBuilder.java
+++ b/yang/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/YangInstanceIdentifierBuilder.java
@@ -1,16 +1,19 @@
 /*
  * Copyright (c) 2015 Cisco Systems, Inc. and others. All rights reserved.
+ *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
 package org.opendaylight.yangtools.yang.data.api;
 
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.Lists;
+import static java.util.Objects.requireNonNull;
+
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 import java.util.Map;
+import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.yangtools.util.HashCodeBuilder;
 import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.InstanceIdentifierBuilder;
@@ -22,48 +25,51 @@ final class YangInstanceIdentifierBuilder implements InstanceIdentifierBuilder {
     private final HashCodeBuilder<PathArgument> hash;
     private final List<PathArgument> path;
 
-    public YangInstanceIdentifierBuilder() {
+    YangInstanceIdentifierBuilder() {
         this.hash = new HashCodeBuilder<>();
         this.path = new ArrayList<>();
     }
 
-    public YangInstanceIdentifierBuilder(final Iterable<PathArgument> prefix, final int hash) {
-        this.path = Lists.newArrayList(prefix);
+    YangInstanceIdentifierBuilder(final List<PathArgument> prefix, final int hash) {
+        this.path = new ArrayList<>(prefix);
         this.hash = new HashCodeBuilder<>(hash);
     }
 
-    @Override
-    public InstanceIdentifierBuilder node(final QName nodeType) {
-        final PathArgument arg = new NodeIdentifier(nodeType);
+    private @NonNull InstanceIdentifierBuilder addArgument(final PathArgument arg) {
         path.add(arg);
         hash.addArgument(arg);
         return this;
     }
 
     @Override
-    public InstanceIdentifierBuilder nodeWithKey(final QName nodeType, final QName key, final Object value) {
-        final PathArgument arg = new NodeIdentifierWithPredicates(nodeType, key, value);
-        path.add(arg);
-        hash.addArgument(arg);
-        return this;
+    public InstanceIdentifierBuilder node(final PathArgument arg) {
+        return addArgument(requireNonNull(arg));
     }
 
     @Override
-    public InstanceIdentifierBuilder nodeWithKey(final QName nodeType, final Map<QName, Object> keyValues) {
-        final PathArgument arg = new NodeIdentifierWithPredicates(nodeType, keyValues);
-        path.add(arg);
-        hash.addArgument(arg);
+    public InstanceIdentifierBuilder node(final QName nodeType) {
+        return addArgument(new NodeIdentifier(nodeType));
+    }
+
+    @Override
+    public InstanceIdentifierBuilder append(final Collection<? extends PathArgument> args) {
+        path.addAll(args);
+        args.forEach(hash::addArgument);
         return this;
     }
 
     @Override
-    @Deprecated
-    public YangInstanceIdentifier toInstance() {
-        return build();
+    public InstanceIdentifierBuilder nodeWithKey(final QName nodeType, final QName key, final Object value) {
+        return addArgument(NodeIdentifierWithPredicates.of(nodeType, key, value));
+    }
+
+    @Override
+    public InstanceIdentifierBuilder nodeWithKey(final QName nodeType, final Map<QName, Object> keyValues) {
+        return addArgument(NodeIdentifierWithPredicates.of(nodeType, keyValues));
     }
 
     @Override
     public YangInstanceIdentifier build() {
-        return new YangInstanceIdentifier(ImmutableList.copyOf(path), hash.build());
+        return FixedYangInstanceIdentifier.create(path, hash.build());
     }
-}
\ No newline at end of file
+}